Max has posted comments on this change. ( https://gerrit.osmocom.org/12492 )
Change subject: LCLS: add string dump helpers
..
Patch Set 8:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12492
Max has abandoned this change. ( https://gerrit.osmocom.org/12491 )
Change subject: LCLS: add allocator function
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/12491
To unsubscribe, or for help writing mail filters
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12569
Change subject: Prevent GCR encoder/decoder functions from being used directly
..
Prevent GCR encoder/decoder functions from being used directly
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12568
Change subject: LCLS: make GCR into static member of osmo_lcls
..
LCLS: make GCR into static member of osmo_lcls
Most of the time we'll have GCR
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12564
Change subject: MNCC: move messages into public header and convert to enum
..
MNCC: move messages into public header and convert to enum
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12563
Change subject: MNCC: use explicit struct type in gsm_call
..
MNCC: use explicit struct type in gsm_call
There's no need to use 'void *' because we
-PatchSet: 3
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-CC: Vadim Yanitskiy
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I78dfb7cd35073a305cf668beda7d9d58d5a5a713
Gerrit-Change-Number: 12556
Gerrit-PatchSet: 11
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels
Max has posted comments on this change. ( https://gerrit.osmocom.org/12519 )
Change subject: Clarify transaction ID assignment
..
Patch Set 2:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org
Max has posted comments on this change. ( https://gerrit.osmocom.org/12556 )
Change subject: Add tests for transaction routines
..
Patch Set 10:
(1 comment)
https://gerrit.osmocom.org/#/c/12556/9/tests/trans/trans_test.c
File
Max has posted comments on this change. ( https://gerrit.osmocom.org/12556 )
Change subject: Add tests for transaction routines
..
Patch Set 10:
(1 comment)
https://gerrit.osmocom.org/#/c/12556/9/tests/trans/trans_test.c
File
-MessageType: newpatchset
Gerrit-Change-Id: I78dfb7cd35073a305cf668beda7d9d58d5a5a713
Gerrit-Change-Number: 12556
Gerrit-PatchSet: 10
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Vadim Yanitskiy
Max has posted comments on this change. ( https://gerrit.osmocom.org/12556 )
Change subject: Add tests for transaction routines
..
Patch Set 9:
(8 comments)
> you could set its level to DEBUG
Good point. I'll upd
Max has posted comments on this change. ( https://gerrit.osmocom.org/12493 )
Change subject: LCLS: add GCR comparison helper
..
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/12493/2//COMMIT_MSG
Commit Message
Max has posted comments on this change. ( https://gerrit.osmocom.org/12493 )
Change subject: LCLS: add GCR comparison helper
..
Patch Set 3:
(1 comment)
In fact, it's already used in this patch in the test.
https
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12558 )
Change subject: LCLS: expand enc/dec tests
..
LCLS: expand enc/dec tests
Change-Id: I8ed87f26216104d34c7bd11c1527b203843760a2
---
M tests
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12493 )
Change subject: LCLS: add GCR comparison helper
..
LCLS: add GCR comparison helper
Change-Id: I9e3b5560a058b976638d03cb819415d237ae9984
Max has posted comments on this change. ( https://gerrit.osmocom.org/12441 )
Change subject: layer23/sap_interface.c: reimplement (BT)SAP interface
..
Patch Set 8:
(4 comments)
https://gerrit.osmocom.org/#/c/12441/8
Max has posted comments on this change. ( https://gerrit.osmocom.org/12547 )
Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/12547/2
Max has posted comments on this change. ( https://gerrit.osmocom.org/12547 )
Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message
..
Patch Set 2:
> it might avoid confusion if we don't call it CTRL in Osmo
Max has posted comments on this change. ( https://gerrit.osmocom.org/12493 )
Change subject: LCLS: add GCR comparison helper
..
Patch Set 2:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12493
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12558
Change subject: LCLS: expand enc/dec tests
..
LCLS: expand enc/dec tests
Change-Id: I8ed87f26216104d34c7bd11c1527b203843760a2
---
M tests/gsm0808
://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I813024ac8eef73c65b49d6d1c6ea1647b97e2fab
Gerrit-Change-Number: 12379
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit
Max has abandoned this change. ( https://gerrit.osmocom.org/12557 )
Change subject: Fix optional libmsc linking with libsmpp
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/12557
To unsubscribe, or for help writing
Max has posted comments on this change. ( https://gerrit.osmocom.org/12556 )
Change subject: Add tests for transaction routines
..
Patch Set 9:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12557
Change subject: Fix optional libmsc linking with libsmpp
..
Fix optional libmsc linking with libsmpp
Link internal libmsc against libsmpp
Max has abandoned this change. ( https://gerrit.osmocom.org/12365 )
Change subject: Log MI type on request failure
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/12365
To unsubscribe, or for help writing mail filters
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12555 )
Change subject: Fix trans_has_conn() doxygen description
..
Fix trans_has_conn() doxygen description
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12556
Change subject: Add tests for transaction routines
..
Add tests for transaction routines
Change-Id: I78dfb7cd35073a305cf668beda7d9d58d5a5a713
---
M
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12555
Change subject: Fix trans_has_conn() doxygen description
..
Fix trans_has_conn() doxygen description
Change-Id
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12553 )
Change subject: Print BTS number on GPRS options error
..
Print BTS number on GPRS options error
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/12519 )
Change subject: transaction: drop unused ti_flag
..
Patch Set 1:
(1 comment)
> Patch Set 1: Code-Review-2
Could you please clarify why it's bet
Max has posted comments on this change. ( https://gerrit.osmocom.org/12491 )
Change subject: LCLS: add allocator function
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12491/1/src/gsm/gsm0808_utils.c
File src/gsm
Max has posted comments on this change. ( https://gerrit.osmocom.org/12495 )
Change subject: ignore output files
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12495
To unsubscribe, or for help
Max has abandoned this change. ( https://gerrit.osmocom.org/12517 )
Change subject: Add .gitignore file
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/12517
To unsubscribe, or for help writing mail filters, visit
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12518 )
Change subject: Add git-review config
..
Add git-review config
Change-Id: If28c2f4908f8df96b627fd42b7e122e559d9382a
---
A .gitreview
1 file
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12553
Change subject: Print BTS number on GPRS options error
..
Print BTS number on GPRS options error
Change-Id: Ia413bd1b375d874cd79a2bf06eb82477417ead1a
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12520 )
Change subject: Use explicit protocol discriminator for NC SS/USSD session
..
Use explicit protocol discriminator for NC SS/USSD session
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12520
Change subject: Use explicit protocol discriminator for NC SS/USSD session
..
Use explicit protocol discriminator for NC SS/USSD session
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12519
Change subject: transaction: drop unused ti_flag
..
transaction: drop unused ti_flag
The ti_flag parameter in trans_assign_trans_id() is undocumented
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12518
Change subject: Add git-review config
..
Add git-review config
Change-Id: If28c2f4908f8df96b627fd42b7e122e559d9382a
---
A .gitreview
1 file changed, 3
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12517
Change subject: Add .gitignore file
..
Add .gitignore file
Change-Id: I6d853bc48d904c2567edb2103d590259877bbf87
---
A .gitignore
1 file changed, 1
Max has posted comments on this change. ( https://gerrit.osmocom.org/11746 )
Change subject: Store subscriber's cell identity in ran_conn
..
Patch Set 6:
This change is ready for review.
--
To view, visit https
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12476 )
Change subject: Add initial version of asyncio trap2cgi script
..
Add initial version of asyncio trap2cgi script
It uses the same config
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12367 )
Change subject: LCLS: use proper types for value_string wrappers
..
LCLS: use proper types for value_string wrappers
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/12490 )
Change subject: Cosmetic: hlr.c: remove confusing indent below if
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12490
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12493
Change subject: LCLS: add GCR comparison helper
..
LCLS: add GCR comparison helper
Change-Id: I9e3b5560a058b976638d03cb819415d237ae9984
---
M include
-MessageType: newpatchset
Gerrit-Change-Id: Ic3609224c8f3282d667e75f68bc20327e36eb9e6
Gerrit-Change-Number: 12492
Gerrit-PatchSet: 7
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12492 )
Change subject: LCLS: add string dump helper
..
Patch Set 6:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12492
Max has posted comments on this change. ( https://gerrit.osmocom.org/12488 )
Change subject: Cosmetic: GSUP: note "on wire" for imei_result
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom
Max has posted comments on this change. ( https://gerrit.osmocom.org/12302 )
Change subject: msc_vty.c: make check-imei-rqd configurable
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12302
Max has posted comments on this change. ( https://gerrit.osmocom.org/12484 )
Change subject: msgb: fix debug print
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12484
To unsubscribe, or for help
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12484 )
Change subject: msgb: fix debug print
..
msgb: fix debug print
Since osmo_hexdump() use static buffers we can't re-use pointers to it
after
Max has posted comments on this change. ( https://gerrit.osmocom.org/12365 )
Change subject: Log MI type on request failure
..
Patch Set 5:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12365
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12492
Change subject: LCLS: add string dump helper
..
LCLS: add string dump helper
Change-Id: Ic3609224c8f3282d667e75f68bc20327e36eb9e6
---
M include
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12491
Change subject: LCLS: add allocator function
..
LCLS: add allocator function
Change-Id: If67cf93ae3dd449e96156485fe1baaf013df3f77
---
M include
Max has posted comments on this change. ( https://gerrit.osmocom.org/12489 )
Change subject: Cosmetic: msc_vty: remove redundant "0 =", "1 ="
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerr
Max has posted comments on this change. ( https://gerrit.osmocom.org/12484 )
Change subject: msgb: fix debug print
..
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/12484/1/src/msgb.c
File src/msgb.c:
https
Max has posted comments on this change. ( https://gerrit.osmocom.org/12365 )
Change subject: Log MI type on request failure
..
Patch Set 3:
This change is ready for review.
--
To view, visit https://gerrit.osmocom.org/12365
Max has posted comments on this change. ( https://gerrit.osmocom.org/12476 )
Change subject: Add initial version of asyncio trap2cgi script
..
Patch Set 4:
> Can you also change debian/rules so the new service f
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12487
Change subject: deb: fix wrong changelog date
..
deb: fix wrong changelog date
Issue was discovered with lintian - likely a copy-paste error.
Change
://gerrit.osmocom.org/settings
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7428cbfbc9f1b80ce42a70be555a38a3497d1cf9
Gerrit-Change-Number: 12476
Gerrit-PatchSet: 4
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12486
Change subject: LCLS: use libosmocore function to add status
..
LCLS: use libosmocore function to add status
* use gsm0808_create_ass_compl2() to add
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12485
Change subject: LCLS: constify helper parameters
..
LCLS: constify helper parameters
Related: OS#2487
Change-Id
Max has posted comments on this change. ( https://gerrit.osmocom.org/12483 )
Change subject: LCLS: add status parameter to Assignment Completed message
..
Patch Set 2:
This change is ready for review.
--
To view, visit https
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12483
Change subject: LCLS: add status parameter to Assignment Completed message
..
LCLS: add status parameter to Assignment Completed message
* add
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12484
Change subject: msgb: fix debug print
..
msgb: fix debug print
Since osmo_hexdump() use static buffers we can't re-use pointers to it
after subsequent
Max has posted comments on this change. ( https://gerrit.osmocom.org/12375 )
Change subject: LCLS: don't encode incorrect values
..
Patch Set 2:
(1 comment)
Addressed in latest revision.
https://gerrit.osmocom.org/#/c/12375
Max has posted comments on this change. ( https://gerrit.osmocom.org/11920 )
Change subject: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP
..
Patch Set 12:
> Is there any rule in Osmocom that we have to use 'co
Max has posted comments on this change. ( https://gerrit.osmocom.org/12470 )
Change subject: add LOG_RAN_CONN() to use the conn->fi->id for context
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/12470/1
Max has posted comments on this change. ( https://gerrit.osmocom.org/11920 )
Change subject: libmsc/gsm_04_11.c: accept MT SMS messages over GSUP
..
Patch Set 12: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c
Max has posted comments on this change. ( https://gerrit.osmocom.org/12481 )
Change subject: gsm_04_08: Fix nullpointer deref
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12481
To unsubscribe
Max has posted comments on this change. ( https://gerrit.osmocom.org/12479 )
Change subject: vlr_core.h: remove duplicate declarations
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12479
Max has posted comments on this change. ( https://gerrit.osmocom.org/12480 )
Change subject: VLR: vlr_subscr_{,msisdn_or_}name: const vsub arg
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/12480
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7428cbfbc9f1b80ce42a70be555a38a3497d1cf9
Gerrit-Change-Number: 12476
Gerrit-PatchSet: 3
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit
Max has posted comments on this change. ( https://gerrit.osmocom.org/11991 )
Change subject: libmsc/gsm_04_80.c: HACK: reimplement GSM 04.08 RELEASE COMPLETE
..
Patch Set 4: Code-Review-1
It's good that it's posted
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8544c30ea800ce8356a227b03a8b21bf3252be7e
Gerrit-Change-Number: 11746
Gerrit-PatchSet: 4
Gerrit-Owner: Max
Gerrit
Max has posted comments on this change. ( https://gerrit.osmocom.org/12468 )
Change subject: add osmo_mi_name(), for MI-to-string like "IMSI-123456"
..
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/12468
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12473 )
Change subject: ctrl2cgi: update shared helper
..
ctrl2cgi: update shared helper
* split hash generation into simpler functions
* move them
Max has abandoned this change. ( https://gerrit.osmocom.org/12298 )
Change subject: MSC: adjust gsup log level to error
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/12298
To unsubscribe, or for help writing mail
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12475 )
Change subject: Mark soap.py as deprecated
..
Mark soap.py as deprecated
It might be removed in one of the future releases as we move away
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12474 )
Change subject: ctrl2cgi: update default parameters in config
..
ctrl2cgi: update default parameters in config
Change-Id
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7428cbfbc9f1b80ce42a70be555a38a3497d1cf9
Gerrit-Change-Number: 12476
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12473
Change subject: ctrl2cgi: update shared helper
..
ctrl2cgi: update shared helper
* split hash generation into simpler functions
* move them
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12474
Change subject: ctrl2cgi: update default parameters in config
..
ctrl2cgi: update default parameters in config
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12475
Change subject: Mark soap.py as deprecated
..
Mark soap.py as deprecated
It might be removed in one of the future releases as we move away from
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12476
Change subject: Add initial version of asyncio trap2cgi script
..
Add initial version of asyncio trap2cgi script
It uses the same config file format
Max has posted comments on this change. ( https://gerrit.osmocom.org/12058 )
Change subject: MSC_Tests.ttcn: introduce TC_gsup_mt_multi_part_sms
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/12058
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12378 )
Change subject: LCLS: use enum values instead of magic numbers
..
LCLS: use enum values instead of magic numbers
Change-Id
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12447 )
Change subject: Constify transaction helpers parameters
..
Constify transaction helpers parameters
Change-Id
Max has submitted this change and it was merged. (
https://gerrit.osmocom.org/12448 )
Change subject: IPA: log OML/RSL link drop reason
..
IPA: log OML/RSL link drop reason
There could multiple reason for OML or RSL link
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12461
Change subject: Use reference array for reading ICCID
..
Use reference array for reading ICCID
Change-Id: Iad0a328c6f0c9a4ab678efe068801849be48d8fc
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12462
Change subject: Don't try to parse result if select_file() failed
..
Don't try to parse result if select_file() failed
Change-Id
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12460
Change subject: Add option to keep cards' ICCID when programming
..
Add option to keep cards' ICCID when programming
This makes it easier to change
Max has uploaded this change for review. ( https://gerrit.osmocom.org/12448
Change subject: IPA: log OML/RSL link drop reason
..
IPA: log OML/RSL link drop reason
There could multiple reason for OML or RSL link towards BTS
Max has posted comments on this change. ( https://gerrit.osmocom.org/12379 )
Change subject: LCLS: use Status for HO-COMPLETE message
..
Patch Set 1:
This change is ready for review.
--
To view, visit https
Gerrit-Change-Number: 12447
Gerrit-PatchSet: 2
Gerrit-Owner: Max
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: Stefan Sperling
Gerrit-Reviewer: Vadim Yanitskiy
Max has posted comments on this change. ( https://gerrit.osmocom.org/12447 )
Change subject: Constify trans_assign_trans_id() parameters
..
Patch Set 1:
> Why do we need this change? Which problems it would solve?
It ma
Max has posted comments on this change. ( https://gerrit.osmocom.org/12382 )
Change subject: tests/gsup_test.c: drop session IEs from MO-ForwardSM Error
..
Patch Set 2: Code-Review+1
--
To view, visit https
Max has posted comments on this change. ( https://gerrit.osmocom.org/11157 )
Change subject: trxcon/scheduler: fix RSSI -> RX level conversion
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/11
701 - 800 of 3542 matches
Mail list logo
