Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-07 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11656 Change subject: use enums consistently instead of falling back to int .. use enums consistently instead of falling back to int The two exi

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-08 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 1: (8 comments) I would have liked to just accept this,

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-08 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.osmoc

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-12 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 1: (4 comments) https://gerrit.osmocom.org/#/c/11656/

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-12 Thread Stefan Sperling
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11656 to look at the new patch set (#2). Change subject: use enums consistently instead of falling back to int ..

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 2: (4 comments) https://gerrit.osmocom.org/#/c/11656

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-13 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 2: I have confirmed that TTCN3 SGSN test results are u

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmoco

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-15 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/11656/2

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-15 Thread Stefan Sperling
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11656 to look at the new patch set (#3). Change subject: use enums consistently instead of falling back to int

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-15 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11656/

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-15 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11656/3

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-15 Thread Stefan Sperling
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11656 to look at the new patch set (#4). Change subject: use enums consistently instead of falling back to int

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-15 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.os

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-15 Thread Stefan Sperling
Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. use enums consistently instead of falling back to int Th