Harald Welte has submitted this change and it was merged.
Change subject: implement support for 3-digit MNC with leading zeros
..
implement support for 3-digit MNC with leading zeros
Enable representing three-digit MNC with
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6659
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2240f7f518494c9df6c8bda52c0d5092f90f221
Gerrit-PatchSet: 7
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6659
to look at the new patch set (#7).
implement support for 3-digit MNC with leading zeros
Enable representing three-digit MNC with leading zeros. The MNCs 23 and 023 are
Patch Set 6:
(1 comment)
https://gerrit.osmocom.org/#/c/6659/6/include/osmocom/gsm/gsm48.h
File include/osmocom/gsm/gsm48.h:
Line 37: void osmo_decode_lai(const struct gsm48_loc_area_id *lai, struct
osmo_location_area_id *decoded);
> now here we have functions specific to the
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/6659/6/include/osmocom/gsm/gsm48.h
File include/osmocom/gsm/gsm48.h:
Line 37: void osmo_decode_lai(const struct gsm48_loc_area_id *lai, struct
osmo_location_area_id *decoded);
now here we have functions specific to the
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6659
to look at the new patch set (#6).
implement support for 3-digit MNC with leading zeros
Enable representing three-digit MNC with leading zeros. The MNCs 23 and 023 are
actually
Patch Set 5:
I think all (new) functions not dealing with a ts 04.08 encoding should go to
the 23.003 source file
--
To view, visit https://gerrit.osmocom.org/6659
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6659
to look at the new patch set (#5).
implement support for 3-digit MNC with leading zeros
Enable representing three-digit MNC with leading zeros. The MNCs 23 and 023 are
actually
Patch Set 4:
> Ok, agreed. However, for new API functions introduced, like
> gsm0808_create_layer3_aoip2 in your patch, I would like to see them
> take an aggregate structure as input, rather than an endless list
> of function arguments. If we create a new function/symbol, we
> don't have
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/6659/4/include/osmocom/gsm/gsm0808.h
File include/osmocom/gsm/gsm0808.h:
Line 40: uint16_t mcc, int lac,
uint16_t _ci,
in this example, struct osmo_cell_global_id seems a good alternative. It
Patch Set 4:
Ok, agreed. However, for new API functions introduced, like
gsm0808_create_layer3_aoip2 in your patch, I would like to see them take an
aggregate structure as input, rather than an endless list of function
arguments. If we create a new function/symbol, we don't have to hand
Patch Set 4:
This is breaking ABI, but not API. In the commit log, I wrote:
- I decided against packing the mnc with the mnc_3_digits field into a
sub-struct because it would enlarge this patch; plus, with a separate flag,
current code can decide when to start heeding leading zeros.
Maybe
Patch Set 4:
I think it would make sense to introuce a new 'struct gsm_mcc' or the like to
encapsulate the uint16_t + bool flag and then use that as function argument
rather than always having a mnc _and_ a 'bool thre_digits' argument.
Or even start to treat the MNC as a string in the
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6659
to look at the new patch set (#4).
implement support for 3-digit MNC with leading zeros
Enable representing three-digit MNC with leading zeros. The MNCs 23 and 023 are
actually
Review at https://gerrit.osmocom.org/6659
implement support for 3-digit MNC with leading zeros
Enable representing three-digit MNC with leading zeros. The MNCs 23 and 023 are
actually different; so far we treated both as 23. Re-encode an incoming BCD or
string of 023 as it were, i.e. not
15 matches
Mail list logo
