Keith Whyte has submitted this change and it was merged.
Change subject: libmsc: Map SMPP command status to GSM 04.11 cause
..
libmsc: Map SMPP command status to GSM 04.11 cause
Send SMS RP ERROR with a failure cause that
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2589
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61fb2d9ef4f2d2eabdc49b53d9966ad328d15e51
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Hello Neels Hofmeyr, Jenkins Builder, Pablo Neira Ayuso,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2589
to look at the new patch set (#2).
libmsc: Map SMPP command status to GSM 04.11 cause
Send SMS RP ERROR with a failure cause that relates to
the
Patch Set 1:
(3 comments)
https://gerrit.osmocom.org/#/c/2589/1/openbsc/src/libmsc/smpp_openbsc.c
File openbsc/src/libmsc/smpp_openbsc.c:
Line 477: .smpp_status_code = ESME_RSYSERR,
> This is C99 structure initialization... which is actually a good idea since
So, everywhere else I see
Patch Set 1: Code-Review-1
(6 comments)
https://gerrit.osmocom.org/#/c/2589/1/openbsc/src/libmsc/smpp_openbsc.c
File openbsc/src/libmsc/smpp_openbsc.c:
Line 464: #define SMPP_TO_GSM411_MAX 4
> You're defining this value but not using it the array definition... (s.b.)
Right. Keith, if you use
Review at https://gerrit.osmocom.org/2589
libmsc: Map SMPP command status to GSM 04.11 cause
Send SMS RP ERROR with a failure cause that relates to
the status returned by the ESME in the deliver_sm_resp.
Actual mapping array is limited as most phones I tested
don't seem to care about the
