Neels Hofmeyr has submitted this change and it was merged.
Change subject: implement support for 3-digit MNC with leading zeros
..
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and L
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6668
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e722103344186fde118b26d8353db95a4581daa
Gerrit-PatchSet: 11
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerr
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6668
to look at the new patch set (#11).
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the
Patch Set 10:
(1 comment)
https://gerrit.osmocom.org/#/c/6668/10/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:
PS10, Line 1280: ;
:lai = (struct osmo_location_area_id)
> weird, makes me wonder "what was my motivation"
NOW I remember: the lai is stati
Patch Set 10:
(2 comments)
https://gerrit.osmocom.org/#/c/6668/10/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:
PS10, Line 1280: ;
:lai = (struct osmo_location_area_id)
> why not simply have the '=' one line above, no typecast and no need to rest
wei
Patch Set 10: Code-Review+2
(2 comments)
https://gerrit.osmocom.org/#/c/6668/10/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:
PS10, Line 1280: ;
:lai = (struct osmo_location_area_id)
why not simply have the '=' one line above, no typecast and no need
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6668
to look at the new patch set (#10).
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the
Patch Set 9:
> Build Successful
finally!
--
To view, visit https://gerrit.osmocom.org/6668
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e722103344186fde118b26d8353db95a4581daa
Gerrit-PatchSet: 9
Gerrit-Project: osmo-bsc
Gerrit-Branc
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6668
to look at the new patch set (#8).
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the c
Patch Set 7: -Code-Review
ok fixed it; but it won't build because of an added dependency on
I020a4f11791c61742a3d795f782805f7b7e8733e
--
To view, visit https://gerrit.osmocom.org/6668
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e72
Patch Set 7: Code-Review-2
ok can verify the failure now with address sanitizer on. Still need to fix
something apparently.
--
To view, visit https://gerrit.osmocom.org/6668
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e722103344186
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6668
to look at the new patch set (#7).
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the c
Patch Set 6:
meh, can't reproduce the ctrl test failure!
--
To view, visit https://gerrit.osmocom.org/6668
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e722103344186fde118b26d8353db95a4581daa
Gerrit-PatchSet: 6
Gerrit-Project: osmo-b
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6668
to look at the new patch set (#6).
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the c
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6668
to look at the new patch set (#5).
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the c
Patch Set 4: Code-Review+1
What wie need now is proper coverage in the ttcn3 testsuite: usw vty to changfe
config and verify the Encoded value in all messages containing MNC/lai/rai
--
To view, visit https://gerrit.osmocom.org/6668
To unsubscribe, visit https://gerrit.osmocom.org/settings
Ger
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6668
to look at the new patch set (#4).
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the c
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6668
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e722103344186fde118b26d8353db95a4581daa
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6668
to look at the new patch set (#3).
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the code base to be
Patch Set 2:
Are there any ttcn3 tests for this? Seems like an ideal opportunity
--
To view, visit https://gerrit.osmocom.org/6668
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e722103344186fde118b26d8353db95a4581daa
Gerrit-PatchSet:
Review at https://gerrit.osmocom.org/6668
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the code base to be able to handle an MNC < 100 that has three digits (leading
zeros).
Depends: Id2240f7f518494c9df6c8bda
21 matches
Mail list logo
