Harald Welte has submitted this change and it was merged.
Change subject: octphy: override firmware version check
..
octphy: override firmware version check
When osmo-bts detects a mismatch between the firmware of the DSP
and t
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4446
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5774fbb29da832786326afb991014b9bd8b04b59
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4446
to look at the new patch set (#4).
octphy: override firmware version check
When osmo-bts detects a mismatch between the firmware of the DSP
and the header version which it was compile w
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/4446/3/src/osmo-bts-octphy/main.c
File src/osmo-bts-octphy/main.c:
Line 58:return 0;
I think if you introduce bts-specific command line options, you should also
document them in the --help output.
--
To view, visit https://gerr
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4446
to look at the new patch set (#3).
octphy: override firmware version check
When osmo-bts detects a mismatch between the firmware of the DSP
and the header version which it was compile w
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4446
to look at the new patch set (#2).
octphy: override firmware version check
When osmo-bts detects a mismatch between the firmware of the DSP
and the header version which it was compile w
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/4446/1/src/osmo-bts-octphy/l1_oml.c
File src/osmo-bts-octphy/l1_oml.c:
Line 55: int no_fw_check = 0;
It it's used as boolean, than why not use "bool" type for it to make that
obvious?
Line 1170: "Invalid header-file-v
Review at https://gerrit.osmocom.org/4446
octphy: override firmware version check
When osmo-bts detects a mismatch between the firmware of the DSP
and the header version which it was compile with, a hard exit
is performed. In some cases this may hinder debugging/testing things.
Implement a com