Harald Welte has submitted this change and it was merged.
Change subject: sdp: refactoring sdp parser/generator
..
sdp: refactoring sdp parser/generator
move SDP generator function write_response_sdp() from mgcp_protocol.c
to m
Patch Set 16: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4006
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f88c93872ff913bc211f560b26901267f577324
Gerrit-PatchSet: 16
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerr
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4006
to look at the new patch set (#16).
sdp: refactoring sdp parser/generator
move SDP generator function write_response_sdp() from mgcp_protocol.c
to mgcp_sdp.
Patch Set 14: Code-Review-1
(5 comments)
(introducing new comment markings -- '-1:' are the blockers, '?:' aren't
important...)
https://gerrit.osmocom.org/#/c/4006/14/src/libosmo-mgcp/mgcp_sdp.c
File src/libosmo-mgcp/mgcp_sdp.c:
Line 147: static void codecs_update(void *ctx, struct sdp_rtp_ma
Patch Set 14: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4006
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f88c93872ff913bc211f560b26901267f577324
Gerrit-PatchSet: 14
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerr
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4006
to look at the new patch set (#14).
sdp: refactoring sdp parser/generator
move SDP generator function write_response_sdp() from mgcp_protocol.c
to mgcp_sdp.
Patch Set 13: Code-Review-1
(10 comments)
https://gerrit.osmocom.org/#/c/4006/13/src/libosmo-mgcp/mgcp_sdp.c
File src/libosmo-mgcp/mgcp_sdp.c:
Line 41: /*! set codec configuration depending on payload type and codec name.
Nice, ends in a full stop, now all you need is to start with a capital le
Patch Set 13: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/4006/13/src/libosmo-mgcp/mgcp_sdp.c
File src/libosmo-mgcp/mgcp_sdp.c:
Line 335: int mgcp_write_response_sdp(struct mgcp_endpoint *endp,
not sure if endp and/or conn could be 'const' (read-only), but this is not
really criti
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4006
to look at the new patch set (#13).
sdp: refactoring sdp parser/generator
move SDP generator function write_response_sdp() from mgcp_protocol.c
to mgcp_sdp.c
move prototy
Patch Set 12: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/4006/12/src/libosmo-mgcp/mgcp_sdp.c
File src/libosmo-mgcp/mgcp_sdp.c:
Line 260: &port, &codecs[0].payload_type,
I see tons of whitespace changes in this path that don't really seem
neccessa
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4006
to look at the new patch set (#6).
sdp: refactoring sdp parser/generator
move SDP generator function write_response_sdp() from mgcp_protocol.c
to mgcp_sdp.c
move prototyp
Patch Set 4:
> just to be clear: This just moves code between files and adjust
> whitepsace/formatting, but there are no API/implementation changes?
> if yes, +2. "refactoring" can mean many things, that's why I'm
> asking.
Yes, it just moves the code. However, the API is slightly changed.
I
Patch Set 4: Code-Review+2
just to be clear: This just moves code between files and adjust
whitepsace/formatting, but there are no API/implementation changes? if yes, +2.
"refactoring" can mean many things, that's why I'm asking.
--
To view, visit https://gerrit.osmocom.org/4006
To unsubscri
Review at https://gerrit.osmocom.org/4006
sdp: refactoring sdp parser/generator
fix sourcecode formatting
move SDP generator to mgcp_sdp.c
add doxygen comments
Change-Id: I9f88c93872ff913bc211f560b26901267f577324
---
M include/osmocom/mgcp/Makefile.am
M include/osmocom/mgcp/mgcp_internal.h
A
14 matches
Mail list logo
