osmocom-bb[master]: Import gprsdecode utility from SRLabs

Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5992 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12234d37c66b83b8abd60f7511fa1d7837db1856 Gerrit-PatchSet: 7 Gerrit-Project: osmocom-bb Gerrit-Branch: master

osmocom-bb[master]: Import gprsdecode utility from SRLabs

Patch Set 6: (3 comments) https://gerrit.osmocom.org/#/c/5992/6//COMMIT_MSG Commit Message: Line 2: Author: Max > I'm not sure if we should attribute max as author in git, if it's code orig Done https://gerrit.osmocom.org/#/c/5992/6/src/host/gprsdecode/gprs.c File

osmocom-bb[master]: Import gprsdecode utility from SRLabs

Patch Set 6: -Code-Review > Seems like 'authors' file was lost during update, as well as > 'copying' and 'news'. Unless it's intentional of course. The only (as I saw) project, known to use such files, is OsmoTRX. I am not sure they are really important here, moreover some of them are and will

osmocom-bb[master]: Import gprsdecode utility from SRLabs

Patch Set 6: (3 comments) let's fix the copyright statements and then get it merged. https://gerrit.osmocom.org/#/c/5992/6//COMMIT_MSG Commit Message: Line 2: Author: Max I'm not sure if we should attribute max as author in git, if it's code originally from

osmocom-bb[master]: Import gprsdecode utility from SRLabs

Patch Set 6: Seems like 'authors' file was lost during update, as well as 'copying' and 'news'. Unless it's intentional of course. -- To view, visit https://gerrit.osmocom.org/5992 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmocom-bb[master]: Import gprsdecode utility from SRLabs

Patch Set 6: Code-Review+1 At this state it looks much better for me ;) Changed the code to use libosmocoding and avoid the code duplication (e.g. CRC, convolutional codes). Regression tests are passing. -- To view, visit https://gerrit.osmocom.org/5992 To unsubscribe, visit

osmocom-bb[master]: Import gprsdecode utility

Patch Set 5: Code-Review-1 (1 comment) > I'll leave it up to vadim. Once vadim is happy, let me know for > some final review and hopefully +2 I'll rewrite the code to use libosmocoding, because I have some experience with it and don't want to see the code duplication. The main idea is to use

osmocom-bb[master]: Import gprsdecode utility

Patch Set 1: I'll leave it up to vadim. Once vadim is happy, let me know for some final review and hopefully +2 -- To view, visit https://gerrit.osmocom.org/5992 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmocom-bb[master]: Import gprsdecode utility

Patch Set 1: (5 comments) Thank you for detailed review, I've tried to address most of it, don't hesitate to remind if I've missed something. https://gerrit.osmocom.org/#/c/5992/1/src/host/gprsdecode/README File src/host/gprsdecode/README: Line 3: Based on the version from

osmocom-bb[master]: Import gprsdecode utility

Patch Set 1: Code-Review-1 (24 comments) Regarding to the gprs_* files, i.e. samples and decoding references, I would prefer to keep them in a separate directory, for example, called 'samples' or 'test', since they only used for testing. Regarding to the CRC code, may we use the code from