RE: GHC AST Annotations

2014-09-26 Thread p.k.f.holzenspies
Dear Alan, Nice going and thanks for undertaking yet another useful AST transformation! A few thoughts (do with them as you see fit): - Always called "ann"; doesn't this require OverloadedRecordFields? You're in danger of delaying your modification (scheduled to land in 7.10). Other than th

RE: GHC AST Annotations

2014-09-26 Thread Simon Peyton Jones
- In terms of presentation/comments; when I first started looking at (i.e. traversing, selectively printing etc.) the AST, I was always really annoyed that every child in the tree has one extra step of indirection, due to the location annotations being "L loc thing", as opposed to a loc-field as

Re: [GHC] #9628: Add Annotations to the AST to simplify source to source conversions

2014-09-26 Thread Alan & Kim Zimmerman
I am trying to avoid having a type parameter for DynFlags, and so far the only thing that needs it is the hooks. I am currently working it through without hooks in DynFlags, and when I have something concrete I will ask againfor suggestions. I just wanted an initial test of the waters to make sure

Linux failures

2014-09-26 Thread Simon Peyton Jones
I am getting one persistent failure on Linux: => user001(normal) 5 of 29 [0, 0, 0] cd . && '/5playpen/simonpj/HEAD-2/inplace/bin/ghc-stage2' -fforce-recomp -dcore-lint -dcmm-lint -dno-debug-output -no-user-package-db -rtsopts -fno-ghci-history -o user001 user001.hs -package unix >user001

RE: ExtraCommas

2014-09-26 Thread Simon Peyton Jones
| What I think you are proposing is to capture commas in a different way | altogether before this stage, and I do not understand how or where No. I'm proposing this. Insetad of data HsRecFields id = HsRecFields { rec_flds :: [HsRecField id arg], rec_dotdot :: Maybe Int

Re: ExtraCommas

2014-09-26 Thread Alan & Kim Zimmerman
Something else to throw into the mix, once the Located replacement by Genlocated is done for hsSyn I intend to capture the locations of all non-captured syntactic elements, such as commas. So this proposed mechanism would help, provided the location of each comma is also tracked. Alan On Fri, S

Re: Linux failures

2014-09-26 Thread Edward Z. Yang
The user001 is tracked by this bug: https://ghc.haskell.org/trac/ghc/ticket/1487 Edward Excerpts from Simon Peyton Jones's message of 2014-09-26 04:37:59 -0700: > I am getting one persistent failure on Linux: > > > => user001(normal) 5 of 29 [0, 0, 0] > > cd . && '/5playpen/simonpj/HEAD-2/

Re: Linux failures

2014-09-26 Thread Thomas Miedema
Hi, The user001 is tracked by this bug: > https://ghc.haskell.org/trac/ghc/ticket/1487 This is my fault. I made a patch that reenabled that test some time ago, but it fails under certain conditions. I just proposed a proper solution to the libraries mailinglist

RE: Linux failures

2014-09-26 Thread Simon Peyton Jones
Yes, please disable it. Otherwise everyone’s ‘validate’ fails Simon From: Thomas Miedema [mailto:thomasmied...@gmail.com] Sent: 26 September 2014 17:43 To: Edward Z. Yang Cc: Simon Peyton Jones; ghc-devs@haskell.org Subject: Re: Linux failures Hi, The user001 is tracked by this bug: https://ghc

Re: Linux failures

2014-09-26 Thread Austin Seipp
Yes, probably the best to disable it for now. On Fri, Sep 26, 2014 at 11:43 AM, Thomas Miedema wrote: > Hi, > >> The user001 is tracked by this bug: >> https://ghc.haskell.org/trac/ghc/ticket/1487 > > > This is my fault. I made a patch that reenabled that test some time ago, but > it fails under

Re: Permitting trailing commas for record syntax ADT declarations

2014-09-26 Thread Richard Eisenberg
A modest counter-proposal to this idea: What if we just stopped requiring commas in import/export lists? As far as I can tell, they're not necessary for proper parsing. This doesn't solve other problems, but I'm not convinced every problem in this domain needs the same solution. In particular,

REMINDER: Please review the HCAR entry for GHC!

2014-09-26 Thread Austin Seipp
Hi *, Just a regularly scheduled reminder: please double-check the latest HCAR entry so we can make sure it's great for the October edition: https://ghc.haskell.org/trac/ghc/wiki/Status/Oct14 The current page looks good, but we're missing some things like: - Backpack updates - Information on

Re: Permitting trailing commas for record syntax ADT declarations

2014-09-26 Thread Roman Cheplyaka
On 26/09/14 22:17, Richard Eisenberg wrote: > A modest counter-proposal to this idea: > > What if we just stopped requiring commas in import/export lists? As far as I > can tell, they're not necessary for proper parsing. Things can get somewhat ambiguous: module M (module A value B type C) G