Tooling-friendly ModSummary

2016-09-05 Thread Alan & Kim Zimmerman
At the moment the standard way to use the GHC API is something like _ <- load LoadAllTargets modSum <- getModSummary mn p <- parseModule modSum And likewise if renamed or typechecked ASTs are needed. But the `load` step alre

RdrName and decorations

2016-08-05 Thread Alan &amp; Kim Zimmerman
Hi all At the moment I am working through ghc-exactprint, adding a feature to add standard API annotations to any constructed AST so that it can be (pretty)-printed. One of the major headaches is the decorations on a RdrName. What I mean by this is that an item appearing in the AST as a RdrName

Re: Note [Api annotations]

2016-07-20 Thread Alan &amp; Kim Zimmerman
Hopefully at a future date they will be a part of the AST itself, so this will be clearer. In reality, looking at Parser.y is not enough, as there are some workings in RdrHsSyn.hs too, and the process of attachment in Parser.y is sometimes quite complex. Basically the best reference is indeed ghc

Re: Proposal process status

2016-07-20 Thread Alan &amp; Kim Zimmerman
I think the most important thing is to be able to point to a designated point where discussions must take place. This means if anything comes up elsewhere it can be routed there to be "official". Alan On Wed, Jul 20, 2016 at 1:42 PM, Yuras Shumovich wrote: > > Looks like reddit is a wrong place

Re: Why upper bound version numbers?

2016-06-09 Thread Alan &amp; Kim Zimmerman
I think "hard" upper bounds would come about in situations where a new version of a dependency is released that breaks things in a package, so until the breakage is fixed a hard upper bound is required. Likewise for hard lower bounds. And arguments about "it shouldn't happen with the PVP" don't h

Re: instances for closed type families

2016-05-25 Thread Alan &amp; Kim Zimmerman
it'd be a > different story. But I doubt that such a thing is possible in this > case (based on the definition of NameOrRdrName you gave), so I think > we'll just have to settle for turning on UndecidableInstances and > writing code that we know won't throw the typechecker

Re: instances for closed type families

2016-05-25 Thread Alan &amp; Kim Zimmerman
Ryan / Simon, thanks. I have been working it in the way the PostRn stuff was done, but then it struck me there may be an easier way. I recall there was some discussion when the PostRn/PostTc stuff went in around the closed type family solution being better, and I thought it was that the Data inst

Re: instances for closed type families

2016-05-25 Thread Alan &amp; Kim Zimmerman
se, if F is a type function. It’s like not allowing > > > > f (g x) = x > > > > in the term language. Only constructors in patterns! > > > S > > > > *From:* ghc-devs [mailto:ghc-devs-boun...@haskell.org] *On Behalf Of *Alan > & Kim Zimmerm

instances for closed type families

2016-05-25 Thread Alan &amp; Kim Zimmerman
I am working on https://ghc.haskell.org/trac/ghc/ticket/12105, and have a type to ensure that the `HsMatchContext` has either a `RdrName` or a `Name`, not an `Id`. type family NameOrRdrName id where NameOrRdrName Id = Name NameOrRdrName Name= Name NameOrRdrName RdrName = RdrName Is

Re: [GHC] #11140: add command-line option to GHC to dump raw parse trees of Haskell programs

2016-05-18 Thread Alan &amp; Kim Zimmerman
I'm with mpickering on this one. Each stage has a debug format that makes sense for the stage. For parsing it is the exact ast Alan On 18 May 2016 12:43 PM, "GHC" wrote: > #11140: add command-line option to GHC to dump raw parse trees of Haskell > programs > ---

Re: ORF and renamer

2016-02-23 Thread Alan &amp; Kim Zimmerman
Regards Alan On Tue, Feb 23, 2016 at 8:29 PM, Alan & Kim Zimmerman wrote: > Hi Adam > > Thanks for the response. My initial mail was more of a sanity check to > see if anything had in fact changed, as I saw that the ambiguous case > is pushed to the type checker. I wanted to conf

Re: ORF and renamer

2016-02-23 Thread Alan &amp; Kim Zimmerman
a single Unique. > > Unfortunately, I can't reproduce the behaviour you describe with: > > ghc-8.0.0.20160204 Field1.hs -ddump-rn-trace -dppr-debug > > Can you describe in more detail how to reproduce the problem? > > All the best, > > Adam > > > On 23/

ORF and renamer

2016-02-23 Thread Alan &amp; Kim Zimmerman
I am working on updating HaRe for GHC 8.0.1, and have hit an issue with the following file --- module Field1 where --Rename field name 'pointx' to 'pointx1' data Point = Pt {pointx, pointy :: Float} absPoint :: Point -> Float absPoint p = sqrt (pointx p * pointx p +

Re: Special treatment of family and role in the parser

2016-01-21 Thread Alan &amp; Kim Zimmerman
At the risk of stating the obvious, have you looked at https://github.com/ghc/ghc/blob/master/compiler/parser/Parser.y#L2993? Alan On 21 Jan 2016 4:50 PM, "Jan Stolarek" wrote: > I'll take a look at the parser, see if we can do better. > > > I also suggest that keywords introduced by GHC extensi

Re: Multiple GHC sessions

2016-01-18 Thread Alan &amp; Kim Zimmerman
>From a tool writer perspective I would be happy to have GHC/Linker sessions be completely separate from each other. But I guess in practical terms a shared address space needs to be managed, making this impossible. The external interpreter for GHCI effectively solves the actual loading problem, t

Re: Multiple GHC sessions

2016-01-17 Thread Alan &amp; Kim Zimmerman
trac/ghc/wiki/RemoteGHCi: > "We can have multiple instances of a GHC Session on the GHC API, each > running TH and/or interpreted code. Right now this is not possible because > the linker's state is global." > > Regards, > Bartosz > > 2016-01-17 14:49 GMT+00:00

Multiple GHC sessions

2016-01-17 Thread Alan &amp; Kim Zimmerman
At the moment there are issues with having multiple GHC API sessions in a single executable, which boil down to GHC having global variables. A quick grep over the GHC sources shows the following instances compiler/ghci/Linker.hs:90:GLOBAL_VAR_M(v_PersistentLinkerState, ... compiler/ghci/Linker.hs

Re: Change from 7.10.3 to current master

2015-12-28 Thread Alan &amp; Kim Zimmerman
ype, i.e. not decomposed > into which class it is. > > > So: my instinct is that the above would be Fine Thing. Make a ticket? Add > these comments to give context? Excecute? > > Thanks > > Simon > > | -Original Message- > | From: ghc-devs [mailto:g

Change from 7.10.3 to current master

2015-12-20 Thread Alan &amp; Kim Zimmerman
I am in the process of updating ghc-exactprint for current GHC master. One of the tests has the following in it - {-# LANGUAGE TypeOperators #-} type family (r1 :++: r2); infixr 5 :++: type instance r :++: Nil = r type instance r1 :++: r2 :> a = (r1 :++: r2) :> a

ExprWithTySigOut

2015-12-19 Thread Alan &amp; Kim Zimmerman
At the moment HsExpr includes the following two constructors | ExprWithTySig (LHsExpr id) (LHsSigWcType id) | ExprWithTySigOut -- Post typechecking (LHsExpr id) (LHsSigWcType Name) -- Retain the signature,

Re: arcanist-external-json-linter missing commits

2015-12-10 Thread Alan &amp; Kim Zimmerman
I was advised to git submodule update --init and it did solve the problem Alan On Thu, Dec 10, 2015 at 11:48 PM, Edward Z. Yang wrote: > On a git submodule update on HEAD, I get: > > fatal: reference is not a tree: 85ece0f8653e7b1e7de6024d372cfeaf36ab5fa9 > Unable to checkout '85ec

Re: [GHC] #11177: panic! tc_hs_type: record

2015-12-08 Thread Alan &amp; Kim Zimmerman
I am travelling until Thursday, will only be able to look on Friday. Alan On 08 Dec 2015 2:44 PM, "GHC" wrote: > #11177: panic! tc_hs_type: record > -+- > Reporter: apanagio |Owner: > Type:

Re: The GHC 8.0 feature freeze is coming

2015-12-04 Thread Alan &amp; Kim Zimmerman
Well, its a feature freeze, not a release, so I imagine bugs can still be fixed as they come up. Alan On Fri, Dec 4, 2015 at 4:04 PM, Luite Stegeman wrote: > Oh I don't want to block anything from being merged, if anything I'd like to > see it get added and actually use the new intrastructure. U

Re: The GHC 8.0 feature freeze is coming

2015-12-03 Thread Alan &amp; Kim Zimmerman
My 2c, I would love to see the remote GHCi patch land for 8.0. It is a big change though. Alan On Thu, Dec 3, 2015 at 4:31 PM, Austin Seipp wrote: > On Thu, Dec 3, 2015 at 7:50 AM, Ben Gamari wrote: >> Luite Stegeman writes: >> >>> Is Simon's remote GHCi patch planned to go in before the for

linker error in haddock, D1558

2015-12-01 Thread Alan &amp; Kim Zimmerman
Does anyone know why a build would be failing with utils/haddock/dist/build/Haddock/GhcUtils.dyn_o: In function `skOK_info': (.text+0x75c8): undefined reference to `stg_ap_0_upd_info' utils/haddock/dist/build/Haddock/GhcUtils.dyn_o: In function `skP5_info': (.text+0x7728): undefined reference to `

Re: [GHC] #11028: Refactor ConDecl

2015-11-25 Thread Alan &amp; Kim Zimmerman
As I wrote that I came to the same conclusion, but decided to leave the rest in case. On Thu, Nov 26, 2015 at 12:25 AM, GHC wrote: > #11028: Refactor ConDecl > -+- > Reporter: simonpj |Owne

Re: [GHC] #11028: Refactor ConDecl

2015-11-25 Thread Alan &amp; Kim Zimmerman
I just pushed to wip/T11028 It is very much a work in progress, working through to sort out the compiler errors, in the simplest way at the moment. On Wed, Nov 25, 2015 at 3:06 PM, GHC wrote: > #11028: Refactor ConDecl > -+

Re: Remote GHCi

2015-11-24 Thread Alan &amp; Kim Zimmerman
What kind of timescale can we expect on this, and will it be possible to backport it (via a ghci-ng or similar)? We are currently wrestling with ghci stdio issues in haskell-ide-engine. If this will be out soon we can wait for it. Alan On Tue, Nov 24, 2015 at 2:25 AM, Manuel M T Chakravarty < c.

Re: spj-wildcard-refactor

2015-11-20 Thread Alan &amp; Kim Zimmerman
I would imagine git pull # Get master up to date git checkout wip/spj-wildcard-refactor git rebase -i master The -i will let you flatten commits See https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history Alan On Fri, Nov 20, 2015 at 7:14 PM, Simon Peyton Jones wro

Re: Wildcard refactor

2015-11-18 Thread Alan &amp; Kim Zimmerman
alf Of *Simon > Peyton Jones > *Sent:* 18 November 2015 11:18 > *To:* Alan & Kim Zimmerman > *Cc:* ghc-devs@haskell.org > *Subject:* RE: Wildcard refactor > > > > It does, yes. It’s on 0d157fe, which is the head of > wip/spj-wildcard-refactor in the haddock

Re: Wildcard refactor

2015-11-18 Thread Alan &amp; Kim Zimmerman
ok. I have been waiting to jump in and help. Alan On Wed, Nov 18, 2015 at 12:02 PM, Simon Peyton Jones wrote: > Alan > > I’m really close on wip/spj-wildcard-refactor, that I really want to get > into HEAD asap. > > Could you possibly checkout wip/spj-wildcard-refactor, and validate? I > get

Re: Remote GHCi

2015-11-17 Thread Alan &amp; Kim Zimmerman
This fits in directly with what I am trying to do for the haskell-ide-engine, where the intention is to expose ghci via an asynchronous process with communication via message passing. A bonus would be to have two separate interfaces, one for REPL interaction for the user, the other to be able to q

Re: [GHC] #11018: ApiAnnotations: Add SourceText for unicode tokens

2015-11-12 Thread Alan &amp; Kim Zimmerman
agree, as we discussed on IRC On Thu, Nov 12, 2015 at 9:30 PM, GHC wrote: > #11018: ApiAnnotations: Add SourceText for unicode tokens > -+- > Reporter: alanz |Owner: alanz >

Re: Pre-Proposal: Introspective Template Haskell

2015-11-11 Thread Alan &amp; Kim Zimmerman
Well, as of 7.10.2 the GHC AST no longer has bottoms in it, so it can already be used quite easily On Wed, Nov 11, 2015 at 9:53 PM, Thomas Bereknyei wrote: > If I understand this correctly it would also subsume haskell-src-exts. If > so I would definitely support this. > On Nov 11, 2015 2:21 PM,

Re: Pre-Proposal: Introspective Template Haskell

2015-11-11 Thread Alan &amp; Kim Zimmerman
>From an ApiAnnotations point of view, they will change to match changes in the AST, they cannot be a brake on improvements. We do intend to nudge the AST toward being more ApiAnnotations friendly over time. If the AST is shared, then a scenario of generating TH and being able to pretty-print it i

Re: too many lines too long

2015-11-10 Thread Alan &amp; Kim Zimmerman
80 cols does work well with the side by side diff in Phabricator. Alan On Tue, Nov 10, 2015 at 1:31 PM, Tuncer Ayaz wrote: > On Mon, Nov 9, 2015 at 11:51 PM, Richard Eisenberg > wrote: > > At both school and at home I can fit 3 80-character buffers side by > > side, at a comfortable font size.

Re: GADT decls

2015-10-28 Thread Alan &amp; Kim Zimmerman
But why?! Here’s my reasoning, looking at Parser.y > > > > · The RHS of the GADT signature is a ‘ctype’ > > · That parses the “forall v a.” , and then goes to type, then > btype, then atype > > · Now we get to the production ‘(‘ ctype ‘)’ in aty

Re: dll-split

2015-10-27 Thread Alan &amp; Kim Zimmerman
I think you need to remove Ctype and Lexer from https://github.com/ghc/ghc/blob/master/compiler/ghc.mk#L498 On 27 Oct 2015 11:06 AM, "Simon Peyton Jones" wrote: > It’s just not my day. > > Now, on Linux, on my branch wip/spj-wildcard-refactor, I get a failure in > dll-split! Should dll-split be

Re: [GHC] #11019: ApiAnnotations: Make all RdrName occurences Located

2015-10-26 Thread Alan &amp; Kim Zimmerman
At the moment in HaRe we do use the wrapped location, but it results in code that is much more complex. This change is more about bringing predictability to the AST than anything else. If anyone feels strongly that it should not happen then we can live without it. On Mon, Oct 26, 2015 at 2:11 PM,

Re: Show instances for GHC internals

2015-10-19 Thread Alan &amp; Kim Zimmerman
This is a utility I would love to see inside the ghc source tree for examining the AST https://github.com/edsko/ghc-dump-tree Alan On Mon, Oct 19, 2015 at 11:18 PM, Ömer Sinan Ağacan wrote: > Currently the only way to debug and inspect GHC internals is by adding some > carefully placed print s

Re: Generic instances for GHC AST

2015-10-05 Thread Alan &amp; Kim Zimmerman
I did note this commit and intend revisiting the AST generic instances [1] in future. Alan [1] https://github.com/alanz/ghc-generic-instances On Mon, Oct 5, 2015 at 7:06 PM, Ryan Scott wrote: > > If the unboxed types are a problem for the automatic Generic derivation, > a > > manual instance

Re: Switching users guide to ReStructuredText

2015-10-02 Thread Alan &amp; Kim Zimmerman
But at least they are stable for the life of a release. On Fri, Oct 2, 2015 at 4:06 PM, Ryan Scott wrote: > To be honest, I'm not sure if referring to sections by numbers is a great > idea. New subsections get spliced into the users' guide quite frequently, > which can cause all subsequent subse

Re: Haskell Error Messages

2015-09-18 Thread Alan &amp; Kim Zimmerman
That's great. My interest is more around having it than doing it, so I would be delighted if it received some attention. Alan On Fri, Sep 18, 2015 at 5:21 PM, Ben Gamari wrote: > Simon Peyton Jones writes: > > > Is there currently any planned work around making the haskell error > > messages

Re: download all of Hackage?

2015-09-14 Thread Alan &amp; Kim Zimmerman
You will probably not be able to compile everything. If you want a compilable subset, you should probably look at stackage Alan On Mon, Sep 14, 2015 at 9:57 PM, Mike Izbicki wrote: > Does anyone know approximately how much disk space all of hackage > takes up when compiled? And about how long

Re: download all of Hackage?

2015-09-14 Thread Alan &amp; Kim Zimmerman
You could clone https://github.com/bitemyapp/hackage-packages Alan On Mon, Sep 14, 2015 at 5:17 PM, Herbert Valerio Riedel wrote: > On 2015-09-14 at 16:43:44 +0200, Richard Eisenberg wrote: > > Is there an easy way to download (but not compile) all of Hackage? I > > know of the hackager package

Re: Haskell Error Messages

2015-09-09 Thread Alan &amp; Kim Zimmerman
, 2015, at 2:49 PM, "Alan & Kim Zimmerman" > wrote: > > Is there currently any planned work around making the haskell error > messages able to support something like the ones in IDRIS, as shown in > David Christianson's talk "A Pretty printer that says wha

Haskell Error Messages

2015-09-08 Thread Alan &amp; Kim Zimmerman
Is there currently any planned work around making the haskell error messages able to support something like the ones in IDRIS, as shown in David Christianson's talk "A Pretty printer that says what it means" at HIW? https://www.youtube.com/watch?v=m7BBCcIDXSg&list=PLnqUlCo055hVfNkQHP7z43r10yNo-mc7

Re: Shared data type for extension flags

2015-09-02 Thread Alan &amp; Kim Zimmerman
Would this be a feasible approach for harmonising the AST between GHC and TH too? Alan On 2 Sep 2015 09:27, "Michael Smith" wrote: > The package description for that is "The GHC compiler's view of the GHC > package database format", and this doesn't really have to do with the > package database

Re: arc patch

2015-08-05 Thread Alan &amp; Kim Zimmerman
Is your arc fully up to date? Running "arc upgrade" will do it if not. Alan On Wed, Aug 5, 2015 at 6:02 PM, Simon Peyton Jones wrote: > Friends > > I wanted to build a Phab ticket, so I tried > > arc patch D1069 > > but it failed, as below. What do I do now? > > Thanks > > Simon >

Re: [GHC] #10250: API Annotations : add Locations in hsSyn were layout occurs

2015-07-31 Thread Alan &amp; Kim Zimmerman
Oops, my mistake, Sorry On Fri, Jul 31, 2015 at 12:59 PM, GHC wrote: > #10250: API Annotations : add Locations in hsSyn were layout occurs > -+- > Reporter: alanz | Owner: alanz >

Re: [GHC] #10416: GHC 7.10.1 User Guide profiling section 5.4 missing images

2015-07-21 Thread Alan &amp; Kim Zimmerman
Ok. But it may be worth manually fixing the version on the official web site once 7.10.2 comes out On Tue, Jul 21, 2015 at 9:19 PM, GHC wrote: > #10416: GHC 7.10.1 User Guide profiling section 5.4 missing images > -+- >

Re: NOTE: Going on a vacation for a while...

2015-07-03 Thread Alan &amp; Kim Zimmerman
Enjoy the break, I think you've earned it. Alan On Fri, Jul 3, 2015 at 10:09 AM, Austin Seipp wrote: > Hi *, > > A few weeks ago, as the close of the 7.10.2 release came closer, I > decided to take a vacation; one I've needed for a little while now. > Well, it's been a bit long in the tooth wit

Re: [GHC] #10537: Parser: commas_tup_tail returns spurious "Missing" value

2015-06-17 Thread Alan &amp; Kim Zimmerman
So it appears the `Missing` item is correct, but it has been given the wrong SrcSpan. Originally it was a `noLoc`. I think I will just advance the column by one, then it is actually correct, and the annotation lookup will only succeed for the first one, so it will all just work. On Wed, Jun 17, 2

Re: HEADS UP: Final call for 7.10.2 is soon

2015-06-05 Thread Alan &amp; Kim Zimmerman
> - If your bug is critical, please explain why! We really want to > kill showstoppers ASAP, because bugs are much cheaper to fix early. If > that's the case we can bump the priority if it's necessary to make > things clear. > #10443 is critical to me, it prevents the installation of ghc-mod, wh

Re: Travis builds failing

2015-06-01 Thread Alan &amp; Kim Zimmerman
And the tests are just too long for the 50 minute limit. But if I can guarantee the single thread case then I can speed up the api annotations tests, by building a single exe to use for most of the tests. On Mon, Jun 1, 2015 at 11:22 PM, Alan & Kim Zimmerman wrote: > Looks lik

Re: Travis builds failing

2015-06-01 Thread Alan &amp; Kim Zimmerman
Looks like https://github.com/ghc/ghc/tree/wip/high_memory_usage has passed. Interestingly it gathered all the tests marked that way for the end, and ran them one at a time. See https://api.travis-ci.org/jobs/64977719/log.txt?deansi=true On Mon, Jun 1, 2015 at 9:54 PM, Joachim Breitner wrote: >

Re: Travis builds failing

2015-06-01 Thread Alan &amp; Kim Zimmerman
And I am preparing a test branch on ghc-api/annotations to use this flag, will push it once I have checked its sanity locally On Mon, Jun 1, 2015 at 9:42 PM, Austin Seipp wrote: > On Mon, Jun 1, 2015 at 2:34 PM, Joachim Breitner > wrote: > > Hi, > > > > Am Montag, den 01.06.2015, 14:26 -0500 sc

Re: Travis builds failing

2015-06-01 Thread Alan &amp; Kim Zimmerman
> > On Mon, Jun 1, 2015 at 8:22 PM, Joachim Breitner < > m...@joachim-breitner.de> > > wrote: > >> > >> Hi, > >> > >> > >> Am Montag, den 01.06.2015, 13:44 +0200 schrieb Alan & Kim Zimmerman: > >> > On Mon, Jun 1, 2015 at

Re: Travis builds failing

2015-06-01 Thread Alan &amp; Kim Zimmerman
I suspect this is different, I am building a local master now, at current HEAD a27fb46ff1ea46a45e0084c3db92a24475e3bab5 to see what I find. Alan On Mon, Jun 1, 2015 at 8:22 PM, Joachim Breitner wrote: > Hi, > > > Am Montag, den 01.06.2015, 13:44 +0200 schrieb Alan & Kim Zimme

Re: Travis builds failing

2015-06-01 Thread Alan &amp; Kim Zimmerman
With a lot of help from @thomie .. On Mon, Jun 1, 2015 at 1:25 PM, Joachim Breitner wrote: > Hi, > > yay, travis is green again. Thanks to Alan for fixing this. > > Greetings, > Joachim > -- > Joachim “nomeata” Breitner > m...@joachim-breitner.de • http://www.joachim-breitner.de/ > Jabber: n

Re: Travis builds failing

2015-05-30 Thread Alan &amp; Kim Zimmerman
'\r'`" Test10396 If separate processes are used to execute "make T10396" and "make T10358", they will each independently try to build CheckAnnotations. This causes problems. Alan On Sat, May 30, 2015 at 12:00 PM, Alan & Kim Zimmer

Re: Travis builds failing

2015-05-30 Thread Alan &amp; Kim Zimmerman
Your mail seems to indicate that the processes were sent a SIGKILL during the link phase. To my knowledge this can happen in two ways: from the test runner for a timeout or from the kernel for an out of memory condition. I suspect the timeout is not the culprit. Is there any way to check for out

Re: Travis builds failing

2015-05-29 Thread Alan &amp; Kim Zimmerman
I am still trying to track this down, in the context of D913. I am hoping that the extra logging that will be availiable once @thomie has finalised D926 will help. There seems to be some shared resource when using the GHC API, and it cannot tolerate running multiple tests at the same time. Alan

Re: api annotations test failures

2015-05-18 Thread Alan &amp; Kim Zimmerman
It looks like it is related somehow to having PartialTypeSignatures enabled, having no other warnings/errors, and not going beyond parseSource. Then it sometimes outputs the typed hole warnings, and sometimes not. Alan On Fri, May 15, 2015 at 10:37 AM, Alan & Kim Zimmerman w

Re: GADT confusion

2015-05-18 Thread Alan &amp; Kim Zimmerman
Thanks, that makes sense. And the existing behaviour is in the compiler, so the surrounding parens are optional and can/should be stripped (except for Api Annotations) Alan On Mon, May 18, 2015 at 10:11 AM, Roman Cheplyaka wrote: > On 18/05/15 10:57, Alan & Kim Zimmerman wrote: >

GADT confusion

2015-05-18 Thread Alan &amp; Kim Zimmerman
Hi all I am working on D836 and have the following test case data MaybeDefault v where SetTo4 :: forall v a. (( Eq v, Show v ) => v -> MaybeDefault v -> a -> MaybeDefault [a]) GHC 7.10.1 regards the return type of SetTo4 as `MaybeDefault [a]` The question is, due to the parens, is t

Re: api annotations test failures

2015-05-15 Thread Alan &amp; Kim Zimmerman
Interesting. The t10358.hs test is a direct clone of a number of others with just the filename to be processed changed. I have a queued TODO to harmonise this into a single module. In other words the build process for this test is identical to say t10357.hs, which runs just before t10358. Alan

Re: api annotations test failures

2015-05-15 Thread Alan &amp; Kim Zimmerman
That would be me, I will look into it. Current master builds fine though on Phab? Alan On Fri, May 15, 2015 at 9:46 AM, Joachim Breitner wrote: > Hi, > > I observe this on travis: > > Wrong exit code (expected 0 , actual 2 ) > Stdout: > > Stderr: > collect2: ld t

Re: [Diffusion] [Build Failed] rGHCa8493e03b89f: Fix imports in HscMain (stage2)

2015-05-13 Thread Alan &amp; Kim Zimmerman
You need to add import RdrHsSyn (setRdrNameSpace) to the imports Alan On Wed, May 13, 2015 at 1:10 PM, Simon Peyton Jones wrote: > I'm very sorry but the build breaks if you build Haddock docs for > ghc-prim. The failure is a call to tyConStupidTheta, but I have no idea > why it is called o

Re: HCAR DUE SOON: Please help edit!

2015-05-07 Thread Alan &amp; Kim Zimmerman
Will do. I was just about to send a mail to ask if I should. Alan On Thu, May 7, 2015 at 5:40 PM, Simon Peyton Jones wrote: > Alan: could you add a bullet to the GHC 7.10 section about API > annotations? Link to the relevant wiki page! > > Thanks! > > Simon > > | -Original Message- > |

Re: RFC: "Native -XCPP" Proposal

2015-05-06 Thread Alan &amp; Kim Zimmerman
Perhaps it makes sense to scan hackage to find all the different CPP idioms that are actually used in Haskell code, if it is a small/well-defined set it may be worth writing a simple custom preprocessor. Alan On Wed, May 6, 2015 at 3:03 PM, Mikhail Glushenkov < the.dead.shall.r...@gmail.com> wrot

Re: release timing

2015-05-06 Thread Alan &amp; Kim Zimmerman
On the automated build front, there are now nightly builds for 7.10.1 on stackage [1]. Running a stackage instance with 7.10.2 could serve as a good confirmation test prior to release. Alan [1] https://www.stackage.org/nightly/2015-05-05 On Wed, May 6, 2015 at 11:58 AM, Simon Peyton Jones wrot

Re: release timing

2015-05-05 Thread Alan &amp; Kim Zimmerman
t is not in that > state, can you cause it to be in that state? > > Thanks > > Simon > > | -Original Message- > | From: ghc-devs [mailto:ghc-devs-boun...@haskell.org] On Behalf Of > | Matthew Pickering > | Sent: 05 May 2015 12:09 > | To: Alan &am

Re: release timing

2015-05-05 Thread Alan &amp; Kim Zimmerman
I'd love to see the various queued API Annotations diffs go in. Alan On Tue, May 5, 2015 at 12:16 PM, Roman Cheplyaka wrote: > I'd love to see GHC 7.10.2 once this haddock issue is fixed: > https://github.com/haskell/haddock/issues/385 > > On 05/05/15 13:08, Simon Peyton Jones wrote: > > This t

Re: API Annotations and 7.10.2

2015-04-28 Thread Alan &amp; Kim Zimmerman
ranch D834 (manual fixup) arc patch --nobranch D837 (manual fixup) arc patch --nobranch D846 (manual fixup) arc patch --nobranch D868 (manual fixup) arc patch --nobranch D869 arc patch --nobranch D873 (manual fixup) On Fri, Apr 17, 2015 at 7:22 PM, Alan & Kim Zimmerman wrote: > This is

Collapsing HsForAllTy, again

2015-04-09 Thread Alan &amp; Kim Zimmerman
With the help of Jan Stolarek I tracked down the HsForAllTy flattening to `HsTypes.mk_forall_ty`. This function takes any nested HsForAllTy's where the top one does not have a context defined, and collapses them into a single one. I do not know what the motivation for this is, and if it perhaps

Where are the HsTyVarBndrs collapsed in an explicit HsForAllTy?

2015-04-09 Thread Alan &amp; Kim Zimmerman
When parsing extremumNewton :: (Eq a, Fractional a) => (forall tag. forall tag1. Tower tag1 (Tower tag a) -> Tower tag1 (Tower tag a)) -> a -> [a] the nested `forall` declarations are parsed by

Flurry of late patches for 7.10.2

2015-04-08 Thread Alan &amp; Kim Zimmerman
You may have noticed that I have submitted a lot of patches for the 7.10.2 release at a very late stage. I apologise for this, but it has been triggered by an exciting test conducted by Matt Pickering using the new ghc-exactprint[1] based on the API Annotations in 7.10.1 He ran it in round-trip

Re: Generic instances for GHC AST

2015-02-06 Thread Alan &amp; Kim Zimmerman
; I have nothing against this. > > If the unboxed types are a problem for the automatic Generic derivation, a > manual instance could be written instead. > > > Cheers, > Pedro > > On Wed, Jan 14, 2015 at 9:03 PM, Alan & Kim Zimmerman > wrote: > >> At the mome

Re: [GHC] #9988: Remove fun_id, is_infix from FunBind, as they are now in Match

2015-01-27 Thread Alan &amp; Kim Zimmerman
No problem, I will work around it, I originally did not want to do it because of potential destabilisation, this still holds. On Tue, Jan 27, 2015 at 12:08 PM, GHC wrote: > #9988: Remove fun_id, is_infix from FunBind, as they are now in Match > -+-

Re: vectorisation code?

2015-01-22 Thread Alan &amp; Kim Zimmerman
I think there is significant infrastructure in the parser, not sure how that could be managed via a plugin. Alan On Thu, Jan 22, 2015 at 10:55 AM, Jan Stolarek wrote: > Would it be possible to turn vectorisation into a compiler plugin? This > would kill two birds with > one stone: vectorisation

Re: RC2 Cutoff at the end of this week

2015-01-19 Thread Alan &amp; Kim Zimmerman
Thanks Alan On Mon, Jan 19, 2015 at 3:53 PM, Austin Seipp wrote: > Hi *, > > I just wanted to let everyone know we plan on releasing RC2 at the end > of this week, on Friday. We're hoping this will be the final RC before > we do the actual release, so if you want to get your fixes in for > user

Re: Generic instances for GHC AST

2015-01-17 Thread Alan &amp; Kim Zimmerman
FYI I have created ghc-generic-instances on hackage as a cache of the derived instances. Name cannot have a Generic instance due to the unboxed type(s) in it. Alan On Wed, Jan 14, 2015 at 11:03 PM, Alan & Kim Zimmerman wrote: > At the moment every part of the GHC AST derives instances

Re: API Annotations question

2015-01-15 Thread Alan &amp; Kim Zimmerman
All of the hsSyn ones. and the Wiki page is https://ghc.haskell.org/trac/ghc/wiki/GhcAstAnnotations They need to be updated whenever the Parser.y changes in a way that one of the keywords that is not otherwise captured in the AST is introduced, or moved. Alan On Thu, Jan 15, 2015 at 3:48 PM, Jan

Re: API Annotations question

2015-01-15 Thread Alan &amp; Kim Zimmerman
This has come up in the review of D538 too. Once processed by haddock the online documentation links through to the hsSyn/ApiAnnotation module where more detail is given. I am not sure what the best way is to add an internal source code link to it too without disturbing the haddock. I am open for

Generic instances for GHC AST

2015-01-14 Thread Alan &amp; Kim Zimmerman
At the moment every part of the GHC AST derives instances of Data and Typeable. There are no instances of Generic. If I try to standalone derive these, the derivation eventually fails for deriving instance Generic (Name) because the constructors are not all in scope. So, does it make sense

Re: Ord instance for Data.Data.Constr

2015-01-13 Thread Alan &amp; Kim Zimmerman
Never mind, I can derive one for ConstrRep Alan On Tue, Jan 13, 2015 at 11:49 PM, Alan & Kim Zimmerman wrote: > Is there a reason there is no Ord instance for Data.Data.Constr? > > I want to use it as part of a key in a Map, and can't auto derive the > instance as all the

Ord instance for Data.Data.Constr

2015-01-13 Thread Alan &amp; Kim Zimmerman
Is there a reason there is no Ord instance for Data.Data.Constr? I want to use it as part of a key in a Map, and can't auto derive the instance as all the constructors are not in scope. Alan ___ ghc-devs mailing list ghc-devs@haskell.org http://www.hask

Re: Possible unpackFS problem

2015-01-10 Thread Alan &amp; Kim Zimmerman
On further digging I see that Pretty.ftext eventually uses unpackFS, but outputs it via hPutStr. So no problem in GHC. Alan On Sat, Jan 10, 2015 at 5:39 PM, Alan & Kim Zimmerman wrote: > While doing further round-trip testing, I cam across the following issue > > Or

Possible unpackFS problem

2015-01-10 Thread Alan &amp; Kim Zimmerman
While doing further round-trip testing, I cam across the following issue Original source module Deprecation {-# Deprecated ["This is a module \"deprecation\"", "multi-line"] #-} ( foo ) where Pretty-printed AST via ppr (L {examples/Deprecation.hs:(3,1)-(4

Re: warn-redundant-constraints present as errors

2015-01-09 Thread Alan &amp; Kim Zimmerman
or ‘SYB.Renamer’ > > > > Do you think you could open a ticket with a reproducible test case? That > would be helpful > > > Simon > > > > *From:* Alan & Kim Zimmerman [mailto:alan.z...@gmail.com] > *Sent:* 09 January 2015 11:54 > > *To:* Simon Peyton Jo

Re: warn-redundant-constraints present as errors

2015-01-09 Thread Alan &amp; Kim Zimmerman
ure for: > >definingSigsNames :: SYB.Data t => > > [GHC.Name] -> t -> [GHC.LSig GHC.Name] > > > > which is 100% correct: defininingSigssNames doesn’t use its SYB.Data t > constraint > > > > Simon > > > > *From:* Alan & Kim

Re: warn-redundant-constraints present as errors

2015-01-09 Thread Alan &amp; Kim Zimmerman
--- On Fri, Jan 9, 2015 at 1:08 PM, Simon Peyton Jones wrote: > I’ve fixed this > > > > *From:* Alan & Kim Zimmerman [mailto:alan.z...@gmail.com] > *Sent:* 08 January 2015 21:46 > *To:* ghc-devs@haskell.org; Simon Peyton Jones > *Subject:* warn-redund

warn-redundant-constraints present as errors

2015-01-08 Thread Alan &amp; Kim Zimmerman
This is a great feature, here is some feedback My syntax highlighter in emacs expects warnings to have the word "warning" in them. So for the two warnings reported below, the first is highlighted as an error, and the second as a warning Language/Haskell/Refact/Utils/TypeUtils.hs:3036:17: Re

Re: Clarification of HsBang and isBanged

2015-01-08 Thread Alan &amp; Kim Zimmerman
I know there was a bug in the parser related to setting the HsBang value, it could be that this whole area has just not received solid scrutiny before now. Alan On Thu, Jan 8, 2015 at 10:15 AM, Johan Tibell wrote: > I also note that the definition of isBanged is confusing: > > isBanged :: H

API Annotations status report

2015-01-06 Thread Alan &amp; Kim Zimmerman
A quick status report on API Annotations. I have managed to integrate the API Annotations into the ghc-7.10 branch of HaRe [1], with a test comand to simply roundtrip the source. So the command ghc-hare roundtrip filename.hs will produce a file 'filename.refactored.hs' which should be the s

Re: Cabal 1.22 RC ready to test

2015-01-03 Thread Alan &amp; Kim Zimmerman
I tried to build https://github.com/ghc/packages-Cabal earlier today and got the same error, but it went fine with the version at https://github.com/haskell/cabal On Sat, Jan 3, 2015 at 10:17 PM, Johan Tibell wrote: > It might be as simple as bumping the Cabal submodule in GHC to match the > u

Re: Possible issue with isBuiltInOcc_maybe

2015-01-01 Thread Alan &amp; Kim Zimmerman
Never mind, I see it gets the required RdrName, e.g.listTyCon_RDR Alan On Thu, Jan 1, 2015 at 1:03 PM, Alan & Kim Zimmerman wrote: > I am busy checking that I can exactprint all the RdrNames produced by the > parser, and came across this > > isBuiltInOcc_maybe occ > = cas

Possible issue with isBuiltInOcc_maybe

2015-01-01 Thread Alan &amp; Kim Zimmerman
I am busy checking that I can exactprint all the RdrNames produced by the parser, and came across this isBuiltInOcc_maybe occ = case occNameString occ of "[]" -> choose_ns listTyCon nilDataCon ":" -> Just consDataConName "[::]" -> Just p

Re: API Annotatons in a FunBind

2014-12-23 Thread Alan &amp; Kim Zimmerman
s Match stuff is not in the desperate category.) > > > > Anything big, pervasive, or destabilising is unlikely to get in for the > reasons above. > > > > Simon > > > > *From:* Alan & Kim Zimmerman [mailto:alan.z...@gmail.com] > *Sent:* 23 December 2014 1

<    1   2   3   >