Re: Review Request: GIRAPH-84: Simplify boolean expressions in BspRecordReader

2011-11-20 Thread Claudio Martella
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2885/#review3375 --- Ship it! Yep, looks good to me. Note to committers: how does it work

[jira] [Commented] (GIRAPH-84) Simplify boolean expressions in BspRecordReader

2011-11-20 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153870#comment-13153870 ] jirapos...@reviews.apache.org commented on GIRAPH-84: -

[jira] [Commented] (GIRAPH-84) Simplify boolean expressions in BspRecordReader

2011-11-20 Thread Claudio Martella (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153873#comment-13153873 ] Claudio Martella commented on GIRAPH-84: One more thing, the descriptions mentions

[jira] [Commented] (GIRAPH-84) Simplify boolean expressions in BspRecordReader

2011-11-20 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153927#comment-13153927 ] Avery Ching commented on GIRAPH-84: --- Claudio, once a committer +1's something they can

Re: [jira] [Commented] (GIRAPH-84) Simplify boolean expressions in BspRecordReader

2011-11-20 Thread Claudio Martella
Ok. What if the committer +1 (and commits it) to a submitter for a JIRA filed by another committer? I.e., is it politically incorrect to step into this JIRA opened by Jakob? :) I know this is mind-twisting, but I prefer to ask than to finish up with dibs! On Mon, Nov 21, 2011 at 1:55 AM,

[jira] [Commented] (GIRAPH-84) Simplify boolean expressions in BspRecordReader

2011-11-20 Thread Jakob Homan (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153951#comment-13153951 ] Jakob Homan commented on GIRAPH-84: --- The patch *must* be attached to the JIRA. We need