Re: [RFC/WIP PATCH 08/11] transport: connect_setup appends protocol version number

2015-05-26 Thread Jeff King
On Tue, May 26, 2015 at 10:09:45PM -0700, Junio C Hamano wrote: > Stefan Beller writes: > > > On Tue, May 26, 2015 at 3:21 PM, Junio C Hamano wrote: > > > >> > >> if (...->version < 2) { > >> ... append "-%d" ... > >> } > >> > >> involved. > > > > Oh! I see here

Re: [RFC/WIP PATCH 07/11] fetch-pack: use the configured transport protocol

2015-05-26 Thread Jeff King
On Tue, May 26, 2015 at 03:01:11PM -0700, Stefan Beller wrote: > diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c > index 4a6b340..32dc8b0 100644 > --- a/builtin/fetch-pack.c > +++ b/builtin/fetch-pack.c > @@ -127,6 +127,10 @@ int cmd_fetch_pack(int argc, const char **argv, const > char *

Re: [RFC/WIP PATCH 06/11] remote.h: add get_remote_capabilities, request_capabilities

2015-05-26 Thread Jeff King
On Tue, May 26, 2015 at 11:25:05PM -0400, Eric Sunshine wrote: > > + len = packet_read(in, &src_buf, &src_len, > > + packet_buffer, sizeof(packet_buffer), > > + PACKET_READ_GENTLE_ON_EOF | > > +

Re: [RFC/WIP PATCH 06/11] remote.h: add get_remote_capabilities, request_capabilities

2015-05-26 Thread Jeff King
On Tue, May 26, 2015 at 03:01:10PM -0700, Stefan Beller wrote: > +void get_remote_capabilities(int in, char *src_buf, size_t src_len) > +{ > + struct strbuf capabilities_string = STRBUF_INIT; > + for (;;) { > + int len; > + char *line = packet_buffer; > +

Re: [RFC/WIP PATCH 05/11] transport: add infrastructure to support a protocol version number

2015-05-26 Thread Jeff King
On Tue, May 26, 2015 at 03:01:09PM -0700, Stefan Beller wrote: > + OPT_STRING('y', "transport-version", &transport_version, > +N_("transport-version"), > +N_("specify transport version to be used")), Interesting choice for the short option ("-v" would be nice,

Re: [RFC/WIP PATCH 04/11] upload-pack-2: Implement the version 2 of upload-pack

2015-05-26 Thread Jeff King
On Tue, May 26, 2015 at 03:01:08PM -0700, Stefan Beller wrote: > --- a/upload-pack.c > +++ b/upload-pack.c > @@ -716,10 +716,47 @@ static void format_symref_info(struct strbuf *buf, > struct string_list *symref) > strbuf_addf(buf, " symref=%s:%s", item->string, (char > *)item->util

[PATCH v3 4/4] diff.c: --ws-error-highlight= option

2015-05-26 Thread Junio C Hamano
Traditionally, we only cared about whitespace breakages introduced in new lines. Some people want to paint whitespace breakages on old lines, too. When they see a whitespace breakage on a new line, they can spot the same kind of whitespace breakage on the corresponding old line and want to say "A

[PATCH v3 2/4] t4015: separate common setup and per-test expectation

2015-05-26 Thread Junio C Hamano
The last two tests in the script were to - set up color.diff.* slots - set up an expectation for a single test - run that test and check the result but split in a wrong way. It did the first two in the first test and the third one in the second test. The latter two belong to each other. Thi

[PATCH v3 0/4] showing existing ws breakage

2015-05-26 Thread Junio C Hamano
We paint whitespace breakages in new (i.e. added or updated) lines when showing the "git diff" output to help people avoid introducing them with their changes. The basic premise is that people would want to avoid touching existing lines only to fix whitespace errors in a patch that does other chan

[PATCH v3 3/4] diff.c: add emit_del_line() and emit_context_line()

2015-05-26 Thread Junio C Hamano
Traditionally, we only had emit_add_line() helper, which knows how to find and paint whitespace breakages on the given line, because we only care about whitespace breakages introduced in new lines. The context lines and old (i.e. deleted) lines are emitted with a simpler emit_line_0() that paints

[PATCH v3 1/4] t4015: modernise style

2015-05-26 Thread Junio C Hamano
Move the preparatory steps that create the expected output inside the test bodies, remove unnecessary blank lines before and after the test bodies, and drop SP between redirection operator and its target. Signed-off-by: Junio C Hamano --- t/t4015-diff-whitespace.sh | 411 +++-

Re: [PATCH/RFC 1/2] git-rebase -i: Add key word "drop" to remove a commit

2015-05-26 Thread Johannes Schindelin
Hi Rémi, On 2015-05-26 23:38, Galan Rémi wrote: > Instead of removing a line to remove the commit, you can use the key > word "drop" (just like "pick" or "edit"). It has the same effect as > deleting the line (removing the commit) except that you keep a visual > trace of your actions, allowing a b

Re: [RFC/WIP PATCH 00/11] Protocol version 2, again!

2015-05-26 Thread Jeff King
On Tue, May 26, 2015 at 03:01:04PM -0700, Stefan Beller wrote: > "Just give us something to play around with" - Peff at GitMerge 2015 Sounds like something I would say. > The new protocol works just like the old protocol, except for > the capabilities negotiation being before any exchange of

Re: [RFC/WIP PATCH 09/11] transport: get_refs_via_connect exchanges capabilities before refs.

2015-05-26 Thread Eric Sunshine
On Tue, May 26, 2015 at 6:01 PM, Stefan Beller wrote: > transport: get_refs_via_connect exchanges capabilities before refs. s/exchanges/exchange/ s/\.$// > Signed-off-by: Stefan Beller > --- > transport.c | 29 + > 1 file changed, 25 insertions(+), 4 deletions(-) >

Re: [RFC/WIP PATCH 10/11] t5544: add a test case for the new protocol

2015-05-26 Thread Eric Sunshine
On Tue, May 26, 2015 at 6:01 PM, Stefan Beller wrote: > Signed-off-by: Stefan Beller > --- > diff --git a/t/t5544-fetch-2.sh b/t/t5544-fetch-2.sh > new file mode 100755 > index 000..beee46c > --- /dev/null > +++ b/t/t5544-fetch-2.sh > @@ -0,0 +1,40 @@ > +#!/bin/sh > +# > +# Copyright (c) 2015

Re: [PATCH v3 00/56] Convert parts of refs.c to struct object_id

2015-05-26 Thread Junio C Hamano
"brian m. carlson" writes: > If Junio would like to add my sign-off to the end, he's welcome to do > so: > > Signed-off-by: brian m. carlson Heh, too late. Thanks for explaining the true flow of patches, though. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of

Re: [RFC/WIP PATCH 08/11] transport: connect_setup appends protocol version number

2015-05-26 Thread Junio C Hamano
Stefan Beller writes: > On Tue, May 26, 2015 at 3:21 PM, Junio C Hamano wrote: > >> >> if (...->version < 2) { >> ... append "-%d" ... >> } >> >> involved. > > Oh! I see here you would count the current one as 1, which has no > number extension, and any further wo

Re: [RFC/WIP PATCH 08/11] transport: connect_setup appends protocol version number

2015-05-26 Thread Eric Sunshine
On Tue, May 26, 2015 at 6:01 PM, Stefan Beller wrote: > Signed-off-by: Stefan Beller > --- > diff --git a/transport.c b/transport.c > index 3ef15f6..33644a6 100644 > --- a/transport.c > +++ b/transport.c > @@ -496,15 +496,29 @@ static int set_git_option(struct git_transport_options > *opts, > s

Re: [RFC/WIP PATCH 06/11] remote.h: add get_remote_capabilities, request_capabilities

2015-05-26 Thread Eric Sunshine
On Tue, May 26, 2015 at 6:01 PM, Stefan Beller wrote: > Instead of calling get_remote_heads as a first command during the > protocol exchange, we need to have fine grained control over the > capability negotiation in version 2 of the protocol. > > Introduce get_remote_capabilities, which will just

Re: [RFC/WIP PATCH 04/11] upload-pack-2: Implement the version 2 of upload-pack

2015-05-26 Thread Eric Sunshine
On Tue, May 26, 2015 at 6:01 PM, Stefan Beller wrote: > In upload-pack-2 we send each capability in its own packet. > By reusing the advertise_capabilities and eventually setting it to > NULL we will be able to reuse the methods for refs advertisement. > > Signed-off-by: Stefan Beller > --- > dif

Re: [PATCH v3 00/56] Convert parts of refs.c to struct object_id

2015-05-26 Thread brian m. carlson
On Tue, May 26, 2015 at 10:37:29AM -0700, Stefan Beller wrote: > On Mon, May 25, 2015 at 12:40 PM, brian m. carlson > wrote: > > On Mon, May 25, 2015 at 12:34:59PM -0700, Junio C Hamano wrote: > >> [PATCH 01/56] was authored by you but has Michael's sign-off, which > >> looked somewhat odd to me,

Re: [PATCH/RFC 2/2] git rebase -i: Warn removed or dupplicated commits

2015-05-26 Thread Eric Sunshine
On Tue, May 26, 2015 at 5:38 PM, Galan Rémi wrote: > git rebase -i: Warn removed or dupplicated commits s/dupplicated/duplicated/ Also, drop capitalization, and insert "about": git rebase -i: warn about removed or duplicated commits > Check if commits were removed (i.e. a line was deleted)

Re: [PATCH/RFC 1/2] git-rebase -i: Add key word "drop" to remove a commit

2015-05-26 Thread Eric Sunshine
On Tue, May 26, 2015 at 5:38 PM, Galan Rémi wrote: > git-rebase -i: Add key word "drop" to remove a commit "key word" is unusual. More typical is "keyword". However, perhaps "command" might be even better. Also, custom on this project is not to capitalize, so: git-rebase -i: add command "dro

Re: [RFC/WIP PATCH 08/11] transport: connect_setup appends protocol version number

2015-05-26 Thread Stefan Beller
On Tue, May 26, 2015 at 3:21 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> + if (transport->smart_options >> + && transport->smart_options->transport_version) { >> + buf = xmalloc(strlen(remote_program) + 12); >> + sprintf(buf, "%s-%d", remote_program,

Re: [RFC/WIP PATCH 07/11] fetch-pack: use the configured transport protocol

2015-05-26 Thread Stefan Beller
On Tue, May 26, 2015 at 3:19 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> @@ -175,7 +179,18 @@ int cmd_fetch_pack(int argc, const char **argv, const >> char *prefix) >> if (!conn) >> return args.diag_url ? 0 : 1; >> } >> - get_remote_heads(

Re: [RFC/WIP PATCH 08/11] transport: connect_setup appends protocol version number

2015-05-26 Thread Junio C Hamano
Stefan Beller writes: > + if (transport->smart_options > + && transport->smart_options->transport_version) { > + buf = xmalloc(strlen(remote_program) + 12); > + sprintf(buf, "%s-%d", remote_program, > + transport->smart_options->transport_ve

Re: [RFC/WIP PATCH 02/11] upload-pack: only accept capabilities on the first "want" line

2015-05-26 Thread Stefan Beller
On Tue, May 26, 2015 at 3:17 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> From: Nguyễn Thái Ngọc Duy >> >> pack-protocol.txt says so and fetch-pack also follows it even though >> upload-pack is a bit lax. Fix it. > > Hmm, I actually think the .txt file unsuccessfully tried to close > t

Re: [RFC/WIP PATCH 07/11] fetch-pack: use the configured transport protocol

2015-05-26 Thread Junio C Hamano
Stefan Beller writes: > @@ -175,7 +179,18 @@ int cmd_fetch_pack(int argc, const char **argv, const > char *prefix) > if (!conn) > return args.diag_url ? 0 : 1; > } > - get_remote_heads(fd[0], NULL, 0, &ref, 0, NULL, &shallow); > + > + switch (arg

Re: [RFC/WIP PATCH 02/11] upload-pack: only accept capabilities on the first "want" line

2015-05-26 Thread Junio C Hamano
Stefan Beller writes: > From: Nguyễn Thái Ngọc Duy > > pack-protocol.txt says so and fetch-pack also follows it even though > upload-pack is a bit lax. Fix it. Hmm, I actually think the .txt file unsuccessfully tried to close the barn door after horse has long left. The existing clients that r

Re: What's cooking in git.git (May 2015, #07; Tue, 26)

2015-05-26 Thread Stefan Beller
> * sb/submodule-doc-intro (2015-05-22) 1 commit > - submodule documentation: reorder introductory paragraphs > > What's the doneness of this one??? I'll try again without a "This command will do ..." introduction, I just did not look into it yet. That said, I was expecting more bike shedding tha

[RFC/WIP PATCH 09/11] transport: get_refs_via_connect exchanges capabilities before refs.

2015-05-26 Thread Stefan Beller
Signed-off-by: Stefan Beller --- transport.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/transport.c b/transport.c index 33644a6..1cd9b77 100644 --- a/transport.c +++ b/transport.c @@ -526,12 +526,33 @@ static struct ref *get_refs_via_connect

[RFC/WIP PATCH 11/11] Document protocol version 2

2015-05-26 Thread Stefan Beller
Signed-off-by: Stefan Beller --- Documentation/technical/pack-protocol.txt | 86 --- Documentation/technical/protocol-capabilities.txt | 15 2 files changed, 77 insertions(+), 24 deletions(-) diff --git a/Documentation/technical/pack-protocol.txt b/Documentation

[RFC/WIP PATCH 05/11] transport: add infrastructure to support a protocol version number

2015-05-26 Thread Stefan Beller
The transport version set via command line argument in git fetch takes precedence over the configured version. Signed-off-by: Stefan Beller --- builtin/fetch.c| 6 ++ remote.c | 2 ++ remote.h | 2 ++ transport-helper.c | 1 + transport.c| 13 +

[RFC/WIP PATCH 04/11] upload-pack-2: Implement the version 2 of upload-pack

2015-05-26 Thread Stefan Beller
In upload-pack-2 we send each capability in its own packet. By reusing the advertise_capabilities and eventually setting it to NULL we will be able to reuse the methods for refs advertisement. Signed-off-by: Stefan Beller --- .gitignore | 1 + Makefile| 2 ++ upload-pack-2.c | 1

[RFC/WIP PATCH 03/11] upload-pack: move capabilities out of send_ref

2015-05-26 Thread Stefan Beller
This will make it easier to reuse the capabilities in a later patch. Signed-off-by: Stefan Beller --- upload-pack.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/upload-pack.c b/upload-pack.c index 6734777..a5f75b7 100644 --- a/upload-pack.c +++ b/upload-pack

[RFC/WIP PATCH 07/11] fetch-pack: use the configured transport protocol

2015-05-26 Thread Stefan Beller
Signed-off-by: Stefan Beller --- builtin/fetch-pack.c | 17 - fetch-pack.h | 1 + 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c index 4a6b340..32dc8b0 100644 --- a/builtin/fetch-pack.c +++ b/builtin/fetch-pack.c

[RFC/WIP PATCH 02/11] upload-pack: only accept capabilities on the first "want" line

2015-05-26 Thread Stefan Beller
From: Nguyễn Thái Ngọc Duy pack-protocol.txt says so and fetch-pack also follows it even though upload-pack is a bit lax. Fix it. Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Stefan Beller --- upload-pack.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/upload

[RFC/WIP PATCH 01/11] upload-pack: make client capability parsing code a separate function

2015-05-26 Thread Stefan Beller
From: Nguyễn Thái Ngọc Duy Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Stefan Beller --- upload-pack.c | 44 +++- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/upload-pack.c b/upload-pack.c index 745fda8..5449ff7 100644 --- a/upl

[RFC/WIP PATCH 10/11] t5544: add a test case for the new protocol

2015-05-26 Thread Stefan Beller
Signed-off-by: Stefan Beller --- t/t5544-fetch-2.sh | 40 1 file changed, 40 insertions(+) create mode 100755 t/t5544-fetch-2.sh diff --git a/t/t5544-fetch-2.sh b/t/t5544-fetch-2.sh new file mode 100755 index 000..beee46c --- /dev/null +++ b/t/t5544-

[RFC/WIP PATCH 06/11] remote.h: add get_remote_capabilities, request_capabilities

2015-05-26 Thread Stefan Beller
Instead of calling get_remote_heads as a first command during the protocol exchange, we need to have fine grained control over the capability negotiation in version 2 of the protocol. Introduce get_remote_capabilities, which will just listen to capabilities of the remote and request_capabilities w

[RFC/WIP PATCH 08/11] transport: connect_setup appends protocol version number

2015-05-26 Thread Stefan Beller
Signed-off-by: Stefan Beller --- transport.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/transport.c b/transport.c index 3ef15f6..33644a6 100644 --- a/transport.c +++ b/transport.c @@ -496,15 +496,29 @@ static int set_git_option(struct git_transport_opt

[RFC/WIP PATCH 00/11] Protocol version 2, again!

2015-05-26 Thread Stefan Beller
"Just give us something to play around with" - Peff at GitMerge 2015 This is another approach for updating the pack protocol of Git. While in the previous attempts I tried to come up with the perfect specification of the new protocol I realized that such an approach doesn't lead anywhere. So t

Re: [PATCH] submodule documentation: Reorder introductory paragraphs

2015-05-26 Thread Heiko Voigt
On Tue, May 26, 2015 at 10:53:15AM -0700, Stefan Beller wrote: > On Mon, May 25, 2015 at 3:00 PM, Junio C Hamano wrote: > > Stefan Beller writes: > > On the other hand, I probably would not have felt such a strong > > "strangeness" if it were described like this: > > > > This command can help

What's cooking in git.git (May 2015, #07; Tue, 26)

2015-05-26 Thread Junio C Hamano
Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The "untracked cache" series is in 'master' now. I do not use it personally, but it is meant to make life easier for those with large amount of

[ANNOUNCE] Git v2.4.2

2015-05-26 Thread Junio C Hamano
The latest maintenance release Git v2.4.2 is now available at the usual places. The tarballs are found at: https://www.kernel.org/pub/software/scm/git/ The following public repositories all have a copy of the 'v2.4.2' tag and the 'maint' branch that the tag points at: url = https://kernel

[PATCH/RFC 1/2] git-rebase -i: Add key word "drop" to remove a commit

2015-05-26 Thread Galan Rémi
Instead of removing a line to remove the commit, you can use the key word "drop" (just like "pick" or "edit"). It has the same effect as deleting the line (removing the commit) except that you keep a visual trace of your actions, allowing a better control and reducing the possibility of removing a

[PATCH 2/3] t4150-am: refactor am -3 tests

2015-05-26 Thread Remi Lespinet
Move the creation of the file, commit and branch used in git am -3 tests in a setup test, to avoid creating this setup several time. Signed-off-by: Remi Lespinet --- t/t4150-am.sh | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/t/t4150-am.sh b/t/t4150-am.s

[PATCH 3/3] git-am: add am.threeWay config variable

2015-05-26 Thread Remi Lespinet
Add the am.threeWay configuration variable to use the -3 or --3way option of git am by default. When am.threeway is set and not desired for a specific git am command, the --no-3way option can be used to override it. Signed-off-by: Remi Lespinet --- Even if git am will be rewritten soon, the code

[PATCH/RFC 2/2] git rebase -i: Warn removed or dupplicated commits

2015-05-26 Thread Galan Rémi
Check if commits were removed (i.e. a line was deleted) or dupplicated (e.g. the same commit is picked twice), can print warnings or abort git rebase according to the value of the configuration variable rebase.checkLevel. Add the configuration variable rebase.checkLevel. - When unset or set to

[PATCH 1/3] t4150-am: refactor and clean common setup

2015-05-26 Thread Remi Lespinet
Add new functions to keep the setup cleaner: - setup_temporary_branch: creates a new branch, check it out and automatically delete it after the test is over - setup_fixed_branch: creates a fixed branch, which can be re-used in later tests Signed-off-by: Remi Lespinet --- t/t4150-am.sh |

[PATCH v6] send-email: Add sendmail email aliases format

2015-05-26 Thread Allen Hubbe
Add support for the sendmail email aliases format. Synopsis: : [, ...] Example: alice: Alice W Land bob: Robert Bobbyton # this is a comment # this is also a comment chloe: ch...@example.com abgroup: alice, bob bcgrp: bob, chl

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-26 Thread Allen Hubbe
On Tue, May 26, 2015 at 4:53 PM, Eric Sunshine wrote: > On Tue, May 26, 2015 at 3:41 PM, Allen Hubbe wrote: >> On Tue, May 26, 2015 at 3:10 PM, Eric Sunshine >> wrote: >>> On Saturday, May 23, 2015, Allen Hubbe wrote: + # recognize lines that look like an alias +

Staging commits with visual diff tools?

2015-05-26 Thread John Lee
Hi Does anybody have code to stage commits using a the visual diff/merge tools supported by git-difftool? Is there support in git itself somewhere, even? I'm looking for something functionally similar to git add -p Looking at the git-difftool source I can see how to write a command to do i

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-26 Thread Eric Sunshine
On Tue, May 26, 2015 at 3:41 PM, Allen Hubbe wrote: > On Tue, May 26, 2015 at 3:10 PM, Eric Sunshine > wrote: >> On Saturday, May 23, 2015, Allen Hubbe wrote: >>> diff --git a/git-send-email.perl b/git-send-email.perl >>> index e1e9b1460ced..ffea50094a48 100755 >>> --- a/git-send-email.perl >>>

Re: [PATCH 2/2] git-p4: fix handling of multi-word P4EDITOR

2015-05-26 Thread Junio C Hamano
Luke Diamand writes: > On 07/05/15 23:16, Junio C Hamano wrote: >> Luke Diamand writes: >> > > [Resurrecting old thread] > ... > > To me, that seems to imply that for GIT_WINDOWS_NATIVE, we take the > *second* branch and use "sh", so again, the the code as it stands will > be fine. msysgit uses

[PATCH v2 0/5] showing existing ws breakage

2015-05-26 Thread Junio C Hamano
We paint whitespace breakages in new (i.e. added or updated) lines when showing the "git diff" output to help people avoid introducing them with their changes. The basic premise is that people would want to avoid touching existing lines only to fix whitespace errors in a patch that does other chan

[PATCH v2 2/4] t4015: separate common setup and per-test expectation

2015-05-26 Thread Junio C Hamano
The last two tests in the script were to - set up color.diff.* slots - set up an expectation for a single test - run that test and check the result but split in a wrong way. It did the first two in the first test and the third one in the second test. The latter two belong to each other. Thi

[PATCH v2 1/4] t4015: modernise style

2015-05-26 Thread Junio C Hamano
Move the preparatory steps that create the expected output inside the test bodies, remove unnecessary blank lines before and after the test bodies, and drop SP between redirection operator and its target. Signed-off-by: Junio C Hamano --- t/t4015-diff-whitespace.sh | 411 +++-

[PATCH v2 4/4] diff.c: --ws-check-deleted option

2015-05-26 Thread Junio C Hamano
Traditionally, we only cared about whitespace breakages introduced in new lines. Some people want to paint whitespace breakages on old lines, too. When they see a whitespace breakage on a new line, they can spot the same kind of whitespace breakage on the corresponding old line and want to say "A

[PATCH v2 3/4] diff.c: add emit_del_line() and update callers of emit_line_0()

2015-05-26 Thread Junio C Hamano
Traditionally, we only had emit_add_line() helper, which knows how to find and paint whitespace breakages on the given line, because we only care about whitespace breakages introduced in new lines. The context lines and old (i.e. deleted) lines are emitted with a simpler emit_line_0() that paints

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-26 Thread Allen Hubbe
On Tue, May 26, 2015 at 3:10 PM, Eric Sunshine wrote: > On Saturday, May 23, 2015, Allen Hubbe wrote: >> Note that this only adds support for a limited subset of the sendmail >> format. The format is is as follows. >> >> : [, ...] >> >> Aliases are specified one per line, and must start

Re: [PATCH v11 2/5] command-list.txt: add the common groups block

2015-05-26 Thread Junio C Hamano
Eric Sunshine writes: +history grow, mark and tweak your common history +remote collaborate (see also: git help workflows) + +# List of known git commands. >>> >>> This is odd. The above line was removed in 1/5 but then re-appears >>> here in 2/5. I think the intent

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-26 Thread Eric Sunshine
On Saturday, May 23, 2015, Allen Hubbe wrote: > Note that this only adds support for a limited subset of the sendmail > format. The format is is as follows. > > : [, ...] > > Aliases are specified one per line, and must start on the first column of the > line. Blank lines are ignored. I

Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

2015-05-26 Thread Eric Sunshine
On Sat, May 23, 2015 at 1:45 PM, Junio C Hamano wrote: > Allen Hubbe writes: >> Note that this only adds support for a limited subset of the sendmail >> format. The format is is as follows. >> >> : [, ...] >> >> Aliases are specified one per line, and must start on the first column of the

Re: [PATCH v11 2/5] command-list.txt: add the common groups block

2015-05-26 Thread Eric Sunshine
[Re-sending this for on-list completeness. It was sent off-list earlier when I was using an email client capable only of HTML messages.] On Mon, May 25, 2015 at 1:31 PM, Sébastien Guimmara wrote: > On 05/21/2015 08:01 PM, Eric Sunshine wrote: >> On Thu, May 21, 2015 at 1:39 PM, Sébastien Guimmara

Re: Mark trailing whitespace error in del lines of diff

2015-05-26 Thread Christian Brabandt
Hi Junio! On Di, 26 Mai 2015, Junio C Hamano wrote: > No need to apologize, but appreciating would not hurt ;-) Right. Thanks. Best, Christian -- Trägt der Bauer rote Socken, will er seinen Bullen schocken. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a mess

Re: Implementation of git rebase --status

2015-05-26 Thread Guillaume Pages
Junio C Hamano writes: >Guillaume Pages writes: >> Do you think it could be useful or do you have any suggestion? >All of your examples say things like: >> You are in the middle of a rebase session. >> The line that paused this session is: >but what if there is no such "line"? >IOW,

Re: [PATCH] submodule documentation: Reorder introductory paragraphs

2015-05-26 Thread Stefan Beller
On Mon, May 25, 2015 at 3:00 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> DESCRIPTION >> --- >> +This command will inspect, update and manage submodules. >> >> +Submodules allow you to keep another Git repository in a subdirectory >> +of your repository. The other repository h

Re: Mark trailing whitespace error in del lines of diff

2015-05-26 Thread Junio C Hamano
Christian Brabandt writes: >> And here is the second one. > > Wow, great and so fast! I really apologize it. No need to apologize, but appreciating would not hurt ;-) Thanks for an interesting idea. I spotted a buglet in 1/2 so I'll queue a fixed version on 'pu' when I push today's intergratio

Re: Mark trailing whitespace error in del lines of diff

2015-05-26 Thread Christian Brabandt
Hi Junio! On Di, 26 Mai 2015, Junio C Hamano wrote: > Junio C Hamano writes: > > > I'll send out two patch series to do the painting part (I didn't > > want to touch "--check", as its utility is even more dubious > > compared to painting, at least to me). > > And here is the second one. Wow,

Re: [PATCH v3 00/56] Convert parts of refs.c to struct object_id

2015-05-26 Thread Stefan Beller
On Mon, May 25, 2015 at 12:40 PM, brian m. carlson wrote: > On Mon, May 25, 2015 at 12:34:59PM -0700, Junio C Hamano wrote: >> [PATCH 01/56] was authored by you but has Michael's sign-off, which >> looked somewhat odd to me, though. > > Yes, it does. He picked it up from me, and signed off, and I

Re: Mark trailing whitespace error in del lines of diff

2015-05-26 Thread Junio C Hamano
Junio C Hamano writes: > I'll send out two patch series to do the painting part (I didn't > want to touch "--check", as its utility is even more dubious > compared to painting, at least to me). And here is the second one. -- >8 -- Subject: [PATCH 2/2] diff.c: --ws-check-deleted option Traditio

Re: Mark trailing whitespace error in del lines of diff

2015-05-26 Thread Junio C Hamano
Christian Brabandt writes: >> But as I said in the other message, I think that the approach this >> patch takes goes in a wrong direction. Instead of adding a single >> "check and highlight this and only kind of breakage on preimage" >> option as a new kind to existing "what kind of use of white

Re: Mark trailing whitespace error in del lines of diff

2015-05-26 Thread Junio C Hamano
Christian Brabandt writes: > It was the one I am interesting in and also the one that I usually try > to avoid ;) > > (In fact, I thought if the other options would be needed, one could add > additional suboptions for core.whitespace as well,... That road leads to madness. Why should we add 2

Re: Query on git submodules

2015-05-26 Thread Heiko Voigt
Hi, On Fri, May 22, 2015 at 01:46:24PM +, Frawley, Sarah wrote: > I am a design automation engineer supporting 200+ designers who use > git for hardware design.  We also use the submodule feature where we > can have quite complex hierarchy's with 10+ layers. What does this 10+ layers mean? Ne

Re: Mark trailing whitespace error in del lines of diff

2015-05-26 Thread Christian Brabandt
Hi Junio! On Mo, 25 Mai 2015, Junio C Hamano wrote: > Christian Brabandt , Christian Brabandt > writes: > > > As far as I can see, this does not break any tests and also the > > behaviour of git-diff --check does not change. > > Even if this change introduced a bug that changed the behaviour

Re: Mark trailing whitespace error in del lines of diff

2015-05-26 Thread Christian Brabandt
Hi Junio! On Mo, 25 Mai 2015, Junio C Hamano wrote: > "brian m. carlson" writes: > > > I like this idea. > > I don't. > > > My use case is determining whether a patch to a pristine-tar > > repository introduced trailing whitespace (which is not okay) or > > just left it there (which is okay).

Re: [PATCH] git-new-workdir: add windows compatibility

2015-05-26 Thread Karsten Blees
Am 26.05.2015 um 06:03 schrieb Junio C Hamano: > Daniel Smith writes: > >> When running on Windows in MinGW, creating symbolic links via ln always >> failed. >> >> Using mklink instead of ln is the recommended method of creating links on >> Windows: >> http://stackoverflow.com/questions/18641864/

Re: Implementation of git rebase --status

2015-05-26 Thread Junio C Hamano
Guillaume Pages writes: > Do you think it could be usefull or do you have any suggestion? All of your examples say things like: > You are in the middle of a rebase session. > The line that paused this session is: but what if there is no such "line"? IOW, what does the user see when

Re: [PATCH v2 1/2] for-each-ref: re-structure code for moving to 'ref-filter'

2015-05-26 Thread Matthieu Moy
Junio C Hamano writes: > Yuck; I can see what you are doing but can you imitate what the more > experienced people (e.g. peff, mhagger) do when restructuring > existing code and do things in smaller increments? Seconded. Some reasons/guide to split: * Split trivial and non-trivial stuff. I can

Re: Re: [PATCH v3 0/4] submodule config lookup API

2015-05-26 Thread Heiko Voigt
On Thu, May 21, 2015 at 11:40:44AM -0700, Junio C Hamano wrote: > Heiko Voigt writes: > > > This is finally the next iteration of the submodule config api. The last > > iteration can be found here: > > > > http://article.gmane.org/gmane.comp.version-control.git/252601 > > > > This iteration fixes

Re: Re: [PATCH v3 0/4] submodule config lookup API

2015-05-26 Thread Heiko Voigt
On Thu, May 21, 2015 at 08:50:11PM +0200, René Scharfe wrote: > Am 21.05.2015 um 19:06 schrieb Heiko Voigt: > >diff --git a/submodule-config.h b/submodule-config.h > >index 9061e4e..58afc83 100644 > >--- a/submodule-config.h > >+++ b/submodule-config.h > >@@ -24,6 +24,6 @@ const struct submodule *s

Re: Pushing and pulling the result of `git replace` and objects/info/alternates

2015-05-26 Thread Christian Couder
On Tue, May 26, 2015 at 4:10 PM, Stephen Kelly wrote: > On Tue, May 26, 2015 at 12:39 PM, Christian Couder > wrote: > >>> 1) How would Alice push the content to a remote host so that Bob would >>> get that automatically? >> >> I am not sure what you want exactly, but let me try to answer anyway.

Re: git clone --depth: shallow clone problems

2015-05-26 Thread Junio C Hamano
Duy Nguyen writes: > --unshallow:: > - If the source repository is complete, convert a shallow > - repository to a complete one, removing all the limitations > + If the source repository is complete, convert all shallow > + refs to complete ones, removing all the limitations Def

Implementation of git rebase --status

2015-05-26 Thread Guillaume Pages
Hi, I would like to implement a new command git rebase --status to inform the user about the current rebase session. Here is a sample of what I think it could look like in case of merge conflict: git rebase --status You are in the middle of a rebase session. The line that paused this sessio

Re: [PATCH] git-new-workdir: add windows compatibility

2015-05-26 Thread Johannes Schindelin
Hi, On 2015-05-26 06:03, Junio C Hamano wrote: > Daniel Smith writes: > >> When running on Windows in MinGW, creating symbolic links via ln always >> failed. >> >> Using mklink instead of ln is the recommended method of creating links on >> Windows: >> http://stackoverflow.com/questions/18641864

LED WALL MOUNT

2015-05-26 Thread t...@a.81510.net
Dear friend, Hello and Good day! Hope everything goes well . Rebecca here from Jiaweihao , LED/LCD TV brackets, Wall Mounts manufacturer in China for years. Here to introduce our Newest Design table bracket, details as below: a) VESA: 75x75,100x100mm b) Capacity of loading: 10kg c) Table clamp

Re: Pushing and pulling the result of `git replace` and objects/info/alternates

2015-05-26 Thread Stephen Kelly
On Tue, May 26, 2015 at 12:39 PM, Christian Couder wrote: > First it looks like you sent the email to me only, so I am replying to you > only. > If this was a mistake, feel free to post this email to the Git mailing list. Thanks, sorry for the mis-post. >> 1) How would Alice push the content to

Re: [PATCH] git-new-workdir: add windows compatibility

2015-05-26 Thread Paul Smith
On Tue, 2015-05-26 at 11:53 +0200, Johannes Schindelin wrote: > The biggest problem with `mklink` is that it is only supported on > Windows Vista and later, while I really like to keep Windows XP > support in Git for Windows. No, the biggest problem with mklink is that you have to have administrat

Re: recovering from "unordered stage entries in index" error

2015-05-26 Thread Duy Nguyen
On Tue, May 26, 2015 at 8:28 PM, McHenry, Matt wrote: >> see these commands, or something else. Could you try again with >> GIT_TRACE=/absolute/path/to/some/where instead of GIT_TRACE=2 and post >> the content of /abso../some/where? > > It looks the same as far as I can see: > > $ GIT_TRAC

RE: recovering from "unordered stage entries in index" error

2015-05-26 Thread McHenry, Matt
> see these commands, or something else. Could you try again with > GIT_TRACE=/absolute/path/to/some/where instead of GIT_TRACE=2 and post > the content of /abso../some/where? It looks the same as far as I can see: $ GIT_TRACE=/tmp/git-trace git svn fetch fatal: unordered stage entries in

Re: [PATCH] git-new-workdir: add windows compatibility

2015-05-26 Thread Johannes Schindelin
Hi Paul, On 2015-05-26 14:20, Paul Smith wrote: > On Tue, 2015-05-26 at 11:53 +0200, Johannes Schindelin wrote: >> The biggest problem with `mklink` is that it is only supported on >> Windows Vista and later, while I really like to keep Windows XP >> support in Git for Windows. > > No, the bigges

Re: git clone --depth: shallow clone problems

2015-05-26 Thread Duy Nguyen
On Thu, Apr 23, 2015 at 04:53:04PM +0200, Michal Pomorski wrote: > tl: skip to the second paragraph > > So here is what I just experienced: > We had an emergency error in an application at work and as the > responsible developer was unavailable, I was asked to check it out and > look into it. > We

Re: [PATCH v2 1/2] for-each-ref: re-structure code for moving to 'ref-filter'

2015-05-26 Thread Karthik Nayak
Also I think Matthieu already commented that "filter" was out of place for that struct. I still think your ref_list is better called ref_array, but that is a minor point. Use of "foo_list" in our codebase is predominantly (because we use "commit_list" very often in the core part of the system)