[PATCH v3] blame: add support for --[no-]progress option

* created struct progress_info in builtin/blame.c this struct holds the information used to display progress so that only one additional parameter is passed to found_guilty_entry(). * --[no-]progress option is also inherited by git-annotate. Signed-off-by: Edmundo Carmona Antoranz

Re: [PATCH v3] blame: add support for --[no-]progress option

On Sun, Nov 22, 2015 at 11:12 PM, Edmundo Carmona Antoranz wrote: > +struct progress_info { > + struct progress *progress; > + int blamed_lines; > +}; > + This is valid, right? Adding 2 more parameters to found_guilty_entry() sounded like an overkill so I joined

Re: [PATCH v2] blame: add support for --[no-]progress option

Edmundo Carmona Antoranz writes: > Will also affect annotate Is that a good thing? In any case, make it understandable without the title line (i.e. make it a full sentence, ending with a full stop). > + if (progress) { > +

Re: [PATCH v2] blame: add support for --[no-]progress option

Nice to see you back, Junio! On Sun, Nov 22, 2015 at 8:08 PM, Junio C Hamano wrote: > Edmundo Carmona Antoranz writes: > >> Will also affect annotate > > Is that a good thing? In any case, make it understandable without > the title line (i.e. make it a

Re: [PATCH v1] blame: add support for --[no-]progress option

I think I found where to calculate the number of blamed lines without having to do it from scratch every cycle. It's where the list of sb->ent is getting its nodes pointed around here: for (;;) { struct blame_entry *next = ent->next; found_guilty_entry(ent); if (next) {

Re: [PATCH v3] ls-files: Add eol diagnostics

On 21.11.2015 08:36, Torsten Bögershausen wrote: > git ls-files --eol gives an output like this: > > i/text-no-eol w/text-no-eol attr/text=auto t/t5100/empty I'm sorry if this has been discussed before, but hav you considered to use a header line and omit the prefixed from the columns

[PATCH v2] blame: add support for --[no-]progress option

Will also affect annotate Signed-off-by: Edmundo Carmona Antoranz --- Documentation/blame-options.txt | 7 +++ Documentation/git-blame.txt | 9 - builtin/blame.c | 25 +++-- 3 files changed, 38 insertions(+), 3

Re: [PATCH v1] blame: add support for --[no-]progress option

On Sat, Nov 21, 2015 at 11:27 PM, Edmundo Carmona Antoranz wrote: > -static void assign_blame(struct scoreboard *sb, int opt) > +static void assign_blame(struct scoreboard *sb, int opt, int show_progress) > > Would it be better to include show_progress as a binary flag in opt

Re: [RFC] OS X El Capitan + Xcode ships without SSL header?!

> On 21 Nov 2015, at 18:58, Lars Schneider wrote: > > I installed OpenSSL with brew, added the include path and it works. > > Can anyone confirm? That is correct. Xcode’s copy of OpenSSL has been deprecated since 10.7 and was removed for 10.11 in Xcode 7:

Re: [PATCH v2] blame: add support for --[no-]progress option

Am 22.11.2015 um 17:02 schrieb Edmundo Carmona Antoranz: Will also affect annotate Signed-off-by: Edmundo Carmona Antoranz --- Documentation/blame-options.txt | 7 +++ Documentation/git-blame.txt | 9 - builtin/blame.c | 25

Re: [PATCH v2] blame: add support for --[no-]progress option

Hey, Johannes! An oversight! git-annotate.txt took me to blame-options.txt and I didn't notice it's also pointed to from git-blame.txt. Let's wait for some comments about the coding (or blessings) so that I can send another patch. Thanks! On Sun, Nov 22, 2015 at 1:58 PM, Johannes Sixt

Re: What's cooking in git.git (Nov 2015, #03; Fri, 20)

> > * kn/for-each-branch-remainder (2015-10-02) 9 commits > - branch: implement '--format' option > - branch: use ref-filter printing APIs > - ref-filter: make %(upstream:track) prints "[gone]" for invalid upstreams > - ref-filter: introduce format_ref_array_item() > - ref-filter: adopt