Re: [ANNOUNCE] Git for Windows 2.14.2(3)

> On 16 Oct 2017, at 20:59, Steve Hoelzer wrote: > > Johannes, > > On Mon, Oct 16, 2017 at 5:57 AM, Johannes Schindelin > wrote: >> Hi Steve, >> >> On Sun, 15 Oct 2017, Johannes Schindelin wrote: >> >>> On Fri, 13 Oct 2017, Steve Hoelzer

Re: [PATCH] check-ref-format: require a repository for --branch

Junio C Hamano writes: >> I don't think there is any need to prepare it upon my 4d03f955, >> though. I'd think it could simply replace it. > > Yeah, it ended up that way, it seems. Still it needs a bit of doc > updates to balance the description. So here is what I have now

Re: [PATCH] check-ref-format: require a repository for --branch

Hi, Junio C Hamano wrote: > Things like @{-1} would not make any sense when the command is run > outside a repository, and the documentation is quite clear that it > is the primary reason why we added "--branch" option to the command, > i.e. > > With the `--branch` option, it expands the

Re: [PATCH] check-ref-format: require a repository for --branch

On Tue, Oct 17, 2017 at 11:40:17AM +0900, Junio C Hamano wrote: > Kevin Daudt writes: > > >> + setup_git_directory_gently(); > >> + > >> + if (!nongit) > >> + malformed = (strbuf_check_branch_ref(, arg) || > >> + !skip_prefix(sb.buf,

Re: [PATCH 2/1] mention git stash push first in the man page

On Thu, Oct 05, 2017 at 09:10:29PM +0100, Thomas Gummerer wrote: > Because 'stash push' and 'stash save' are so closely related they share one > section in the man page. Currently 'stash save' comes first, as that > was the command that people were historically using. However this makes > the

Re: [RFC] deprecate git stash save? (was: Re: [PATCH 2/3] http-push: fix construction of hex value from path)

On Thu, Oct 05, 2017 at 09:00:49PM +0100, Thomas Gummerer wrote: > Since you were asking :) With the introduction of 'git stash push', > my hope was always that we could eventually get rid of 'git stash > save' and only keep one interface around. > > As there still many references to it around

Re: [PATCH 0/4] pre-merge hook

Michael J Gruber writes: > This series revives an old suggestion of mine to make merge honor > pre-commit hook or a separate pre-merge hook This seems to have become an abandoned loose end, so I'll drop the topic from my tree for now; revival of the discussion is _not_

Re: [PATCH] patch reply

Thais Diniz writes: > +Just to clarify I did not see Marius patch. > +Did see Marius' comment saying he would look it in the leftoverbits list, > +but since i didn't see any patch i thought i could work on it and did so > based on Stephan's comment > +(which i

Re: [PATCH][Outreachy] New git config variable to specify string that will be automatically passed as --push-option

Just to clarify I did not see Marius patch. Did see Marius' comment saying he would look it in the leftoverbits list, but since i didn't see any patch i thought i could work on it and did so based on Stephan's comment (which i suppose Mario also did and that is why the code resulted to be

[PATCH] fetch doc: src side of refspec could be full SHA-1

Since a9d34933 ("Merge branch 'fm/fetch-raw-sha1'", 2015-06-01) we allow to fetch by an object name when the other side accepts such a request, but we never updated the documentation to match. Signed-off-by: Junio C Hamano --- Documentation/pull-fetch-param.txt | 6 -- 1

[PATCH] patch reply

From: Thais Diniz Braz --- emailReply | 4 1 file changed, 4 insertions(+) create mode 100644 emailReply diff --git a/emailReply b/emailReply new file mode 100644 index 0..2d591b55b --- /dev/null +++ b/emailReply @@ -0,0 +1,4 @@ +Just to clarify I did

Re: [PATCH] check-ref-format: require a repository for --branch

Jeff King writes: > On Tue, Oct 17, 2017 at 10:22:31AM +0900, Junio C Hamano wrote: > >> > I like the state this puts us in, but there's one catch: we're >> > completely changing the meaning of "check-ref-format --branch", aren't >> > we? >> > >> > It is going from "this is how

Re: [PATCH v2] column: show auto columns when pager is active

Kevin Daudt writes: > When columns are set to automatic for git tag and the output is > paginated by git, the output is a single column instead of multiple > columns. > > Standard behaviour in git is to honor auto values when the pager is > active, which happens for example with

Re: [PATCH] doc: list filter-branch subdirectory-filter first

David Glasser writes: > From: David Glasser > > The docs claim that filters are applied in the listed order, so > subdirectory-filter should come first. > --- > Documentation/git-filter-branch.txt | 10 +- > 1 file changed, 5 insertions(+),

Re: Consider escaping special characters like 'less' does

On Tue, Oct 17, 2017 at 10:13:34AM +0900, Junio C Hamano wrote: > Jeff King writes: > > > Alternatively, I suppose we could just always escape in > > add--interactive. I'm trying to think of a case where somebody would > > really want their diffFilter to see the raw bytes (or

Re: [PATCH] check-ref-format: require a repository for --branch

On Tue, Oct 17, 2017 at 10:22:31AM +0900, Junio C Hamano wrote: > > I like the state this puts us in, but there's one catch: we're > > completely changing the meaning of "check-ref-format --branch", aren't > > we? > > > > It is going from "this is how you resolve @{-1}" to "this is how you > >

Re: [PATCH] check-ref-format: require a repository for --branch

Kevin Daudt writes: >> +setup_git_directory_gently(); >> + >> +if (!nongit) >> +malformed = (strbuf_check_branch_ref(, arg) || >> + !skip_prefix(sb.buf, "refs/heads/", )); >> +else >> +malformed =

[L10N] Kickoff of translation for Git 2.15.0 round 2

Hi, Git v2.15.0-rc1 released with a typo fix from commit dfab1eac23 ("i18n: add a missing space in message", Sun Oct 8 14:18:39 2017 +0200). This time there are 2 updated messages need to be translated since last update. Let's start new round of translation for Git 2.15.0. You can get it from

Re: [PATCH v4 0/3] implement fetching of moved submodules

Heiko Voigt writes: > The previous RFC iteration can be found here: > > https://public-inbox.org/git/20171006222544.GA26642@sandbox/ > > This should now be in a state ready for review for inclusion. > > The main difference from last iteration is that we now also support >

Re: What's cooking in git.git (Oct 2017, #03; Mon, 16)

On Mon, Oct 16, 2017 at 03:54:56PM +0900, Junio C Hamano wrote: > * bc/hash-algo (2017-10-04) 6 commits > - fixup! hash-algo: integrate hash algorithm support with repo setup > - hash-algo: switch empty tree and blob lookups to use hash abstraction > - hash-algo: integrate hash algorithm

Re: [PATCH] check-ref-format: require a repository for --branch

On Mon, Oct 16, 2017 at 07:45:46PM +0900, Junio C Hamano wrote: > Junio C Hamano writes: > > [..] > > diff --git a/builtin/check-ref-format.c b/builtin/check-ref-format.c > index 1e5f9835f0..4e62852089 100644 > --- a/builtin/check-ref-format.c > +++

Re: [PATCH] check-ref-format: require a repository for --branch

Jeff King writes: > On Mon, Oct 16, 2017 at 07:45:46PM +0900, Junio C Hamano wrote: > >> > So I think the right endgame in the longer term is: >> > ... >> >> Here is to illustrate what I mean in a patch form. It resurrects >> the gentle setup, and uses a purely textual format

Re: [PATCH v3 00/25] object_id part 10

"brian m. carlson" writes: > On Mon, Oct 16, 2017 at 11:15:34AM +0900, Junio C Hamano wrote: >> With a hope that this might help other reviewers, here is the >> interdiff between "the previous one merged with v2.15-rc1" and "this >> round applied on v2.15-rc1

Re: Consider escaping special characters like 'less' does

Jeff King writes: > Alternatively, I suppose we could just always escape in > add--interactive. I'm trying to think of a case where somebody would > really want their diffFilter to see the raw bytes (or vice versa, to > show raw bytes produced by their filter), but I'm having

Re: [PATCH 1/2] color: downgrade "always" to "auto" only for on-disk configuration

Jeff King writes: > On Sat, Oct 14, 2017 at 12:01:46PM +0900, Junio C Hamano wrote: > >> > That takes us back to the pre-regression state. The ancient bug from >> > 4c7f1819 still exists, but that would be OK for v2.15. We'd probably >> > want to bump the -rc cycle a bit to give

Re: [PATCH v3 00/25] object_id part 10

On Mon, Oct 16, 2017 at 11:49:13PM +, brian m. carlson wrote: > On Mon, Oct 16, 2017 at 11:15:34AM +0900, Junio C Hamano wrote: > > With a hope that this might help other reviewers, here is the > > interdiff between "the previous one merged with v2.15-rc1" and "this > > round applied on

Re: [PATCH v3 00/25] object_id part 10

On Mon, Oct 16, 2017 at 11:15:34AM +0900, Junio C Hamano wrote: > With a hope that this might help other reviewers, here is the > interdiff between "the previous one merged with v2.15-rc1" and "this > round applied on v2.15-rc1 directly". > > The changes all looked sensible to me. Thanks. Is

Adding a target prefix to git filter-branch --subdirectory-filter

git filter-branch --subdirectory-filter is really useful and easy to use. It's a commonly used step as part of moving a directory from one repo to another. It lets you move a subdirectory to the root of the repo. I've found that, when moving directories between repos, I often want to do a task

[PATCH] doc: list filter-branch subdirectory-filter first

From: David Glasser The docs claim that filters are applied in the listed order, so subdirectory-filter should come first. --- Documentation/git-filter-branch.txt | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH/RFC] git-post: the opposite of git-cherry-pick

> This is worth discussing, though not my preference. The picture to "pick > cherries" has become quite common, and now that we use it for the name of > the command, "cherry-pick", the direction of flow is quite obvious and > strongly implied: from somewhere else to me (and not to somebody else).

Re: [PATCH] check-ref-format: require a repository for --branch

Jeff King wrote: > On Mon, Oct 16, 2017 at 07:45:46PM +0900, Junio C Hamano wrote: >> Here is to illustrate what I mean in a patch form. It resurrects >> the gentle setup, and uses a purely textual format check when we are >> outside the repository, while bypassing the @{magic} interpolation >>

Re: Consider escaping special characters like 'less' does

On Tue, Oct 17, 2017 at 12:47:01AM +0200, Andreas Schwab wrote: > On Okt 16 2017, Jeff King wrote: > > > I can't help but feel this is the tip of a larger iceberg, though. E.g., > > what about characters outside of the terminal's correct encoding? Or > > broken UTF-8 characters?

Re: Minor man page weirdness?

On Mon, Oct 16, 2017 at 07:16:49AM -0700, Lars Schneider wrote: > Hi, > > I just noticed that a space between "-f" and "git" is missing in `man > git-branch`. > The space is present in "Documentation/git-branch.txt", though. I am using > `man` > version 1.6c on macOS. > > -f, --force >

Re: Consider escaping special characters like 'less' does

On Okt 16 2017, Jeff King wrote: > I can't help but feel this is the tip of a larger iceberg, though. E.g., > what about characters outside of the terminal's correct encoding? Or > broken UTF-8 characters? Or correctly encoded UTF-8 characters that look confusing? Or blobs with

Re: [PATCH] check-ref-format: require a repository for --branch

On Mon, Oct 16, 2017 at 07:45:46PM +0900, Junio C Hamano wrote: > > So I think the right endgame in the longer term is: > > ... > > Here is to illustrate what I mean in a patch form. It resurrects > the gentle setup, and uses a purely textual format check when we are > outside the repository,

Re: [PATCH] check-ref-format: require a repository for --branch

On Mon, Oct 16, 2017 at 03:44:08PM +0900, Junio C Hamano wrote: > I threw this topic in stalled category, hoping that one or the other > opinion eventually turns out to be more prevalent, but it didn't > seem to have happened X-<. I think it's sufficiently obscure that nobody really cares. I

Re: Consider escaping special characters like 'less' does

On Sun, Oct 15, 2017 at 11:37:04PM +0200, Joris Valette wrote: > 2017-10-15 22:06 GMT+02:00 Jeff King : > > Git's diff generation will never do such escaping by default, because it > > means creating a patch that cannot be applied to get back the original > > content. > > Indeed

Re: [PATCH 1/2] color: downgrade "always" to "auto" only for on-disk configuration

On Sat, Oct 14, 2017 at 12:01:46PM +0900, Junio C Hamano wrote: > > That takes us back to the pre-regression state. The ancient bug from > > 4c7f1819 still exists, but that would be OK for v2.15. We'd probably > > want to bump the -rc cycle a bit to give more confidence that (2) caught > >

Re: [PATCH] diff: alias -q to --quiet

On Sat, Oct 14, 2017 at 11:37:28AM +0900, Junio C Hamano wrote: > Jeff King writes: > > > So there are two separate questions/tasks: > > > > 1. Should we remove the special handling of "-q" leftover from this > > deprecation? I think the answer is yes. > > > > 2. Should

Re: [PATCH 3/3] branch: forbid refs/heads/HEAD

On Sat, Oct 14, 2017 at 11:20:11AM +0900, Junio C Hamano wrote: > Junio C Hamano writes: > > >> Should we test that: > >> > >> git update-ref refs/heads/HEAD HEAD^ > >> > >> continues to work? > > > > Perhaps. Also we may want to make sure that "git branch -D HEAD" > >

Re: [PATCH v4 03/11] protocol: introduce protocol extension mechanisms

On Mon, Oct 16, 2017 at 10:55:24AM -0700, Brandon Williams wrote: > Create protocol.{c,h} and provide functions which future servers and > clients can use to determine which protocol to use or is being used. > > Also introduce the 'GIT_PROTOCOL' environment variable which will be > used to

Re: [ANNOUNCE] Git for Windows 2.14.2(3)

Johannes, On Mon, Oct 16, 2017 at 5:57 AM, Johannes Schindelin wrote: > Hi Steve, > > On Sun, 15 Oct 2017, Johannes Schindelin wrote: > >> On Fri, 13 Oct 2017, Steve Hoelzer wrote: >> >> > On Thu, Oct 12, 2017 at 5:53 PM, Johannes Schindelin >> >

[PATCH v2] column: show auto columns when pager is active

When columns are set to automatic for git tag and the output is paginated by git, the output is a single column instead of multiple columns. Standard behaviour in git is to honor auto values when the pager is active, which happens for example with commands like git log showing colors when being

Re: slight addition to t.gummerer's proposed "git stash" patch

On 10/11, Robert P. J. Day wrote: > On Wed, 11 Oct 2017, Thomas Gummerer wrote: > > > On 10/11, Robert P. J. Day wrote: > > > > > > was perusing thomas gummerer's proposed "git stash" patch here: > > > > > > https://www.spinics.net/lists/git/msg313993.html > > > > > > and i'd make one more

Minor man page weirdness?

Hi, I just noticed that a space between "-f" and "git" is missing in `man git-branch`. The space is present in "Documentation/git-branch.txt", though. I am using `man` version 1.6c on macOS. -f, --force Reset to if exists already. Without -fgit branch refuses to change

Re: [RFC] deprecate git stash save?

On 10/12, Junio C Hamano wrote: > Junio C Hamano writes: > > > Thomas Gummerer writes: > > > >> git stash push is the newer interface for creating a stash. While we > >> are still keeping git stash save around for the time being, it's better > >> to

[PATCH v4 11/11] Documentation: document Extra Parameters

From: Jonathan Tan Document the server support for Extra Parameters, additional information that the client can send in its first message to the server during a Git client-server interaction. Signed-off-by: Jonathan Tan Signed-off-by: Brandon

[PATCH v4 10/11] ssh: introduce a 'simple' ssh variant

When using the 'ssh' transport, the '-o' option is used to specify an environment variable which should be set on the remote end. This allows git to send additional information when contacting the server, requesting the use of a different protocol version via the 'GIT_PROTOCOL' environment

[PATCH v4 00/11] protocol transition

Changes in v4: * Added more tests for the new handeling of ssh variants. * Removed the 'default' case in upload_pack and receive_pack and instead ensured that all enum values were accounted for. This way when a new protocol version is introduced the compiler will throw an error if the new

[PATCH v4 08/11] http: tell server that the client understands v1

Tell a server that protocol v1 can be used by sending the http header 'Git-Protocol' with 'version=1' indicating this. Also teach the apache http server to pass through the 'Git-Protocol' header as an environment variable 'GIT_PROTOCOL'. Signed-off-by: Brandon Williams ---

[PATCH v4 01/11] connect: in ref advertisement, shallows are last

From: Jonathan Tan Currently, get_remote_heads() parses the ref advertisement in one loop, allowing refs and shallow lines to intersperse, despite this not being allowed by the specification. Refactor get_remote_heads() to use two loops instead, enforcing that refs come

[PATCH v4 06/11] connect: teach client to recognize v1 server response

Teach a client to recognize that a server understands protocol v1 by looking at the first pkt-line the server sends in response. This is done by looking for the response "version 1" send by upload-pack or receive-pack. Signed-off-by: Brandon Williams --- connect.c | 30

[PATCH v4 02/11] pkt-line: add packet_write function

Add a function which can be used to write the contents of an arbitrary buffer. This makes it easy to build up data in a buffer before writing the packet instead of formatting the entire contents of the packet using 'packet_write_fmt()'. Signed-off-by: Brandon Williams ---

[PATCH v4 04/11] daemon: recognize hidden request arguments

A normal request to git-daemon is structured as "command path/to/repo\0host=..\0" and due to a bug introduced in 49ba83fb6 (Add virtualization support to git-daemon, 2006-09-19) we aren't able to place any extra arguments (separated by NULs) besides the host otherwise the parsing of those

[PATCH v4 05/11] upload-pack, receive-pack: introduce protocol version 1

Teach upload-pack and receive-pack to understand and respond using protocol version 1, if requested. Protocol version 1 is simply the original and current protocol (what I'm calling version 0) with the addition of a single packet line, which precedes the ref advertisement, indicating the protocol

[PATCH v4 07/11] connect: tell server that the client understands v1

Teach the connection logic to tell a serve that it understands protocol v1. This is done in 2 different ways for the builtin transports, both of which ultimately set 'GIT_PROTOCOL' to 'version=1' on the server. 1. git:// A normal request to git-daemon is structured as "command

[PATCH v4 09/11] i5700: add interop test for protocol transition

Signed-off-by: Brandon Williams --- t/interop/i5700-protocol-transition.sh | 68 ++ 1 file changed, 68 insertions(+) create mode 100755 t/interop/i5700-protocol-transition.sh diff --git a/t/interop/i5700-protocol-transition.sh

[PATCH v4 03/11] protocol: introduce protocol extension mechanisms

Create protocol.{c,h} and provide functions which future servers and clients can use to determine which protocol to use or is being used. Also introduce the 'GIT_PROTOCOL' environment variable which will be used to communicate a colon separated list of keys with optional values to a server.

Re: [PATCH v1 1/1] Introduce git add --renormalize .

tbo...@web.de writes: > From: Torsten Bögershausen > > Make it safer to normalize the line endings in a repository: > Files that had been commited with CRLF will be commited with LF. > (Unless core.autorclf and .gitattributes specify that Git > should not do line ending

Re: [PATCH v3 10/10] ssh: introduce a 'simple' ssh variant

On 10/03, Jonathan Nieder wrote: > Hi, > > Brandon Williams wrote: > > > When using the 'ssh' transport, the '-o' option is used to specify an > > environment variable which should be set on the remote end. This allows > > git to send additional information when contacting the server, > >

Re: Does Git build things during 'make install"?

Am 16.10.2017 um 10:23 schrieb Junio C Hamano: > Johannes Sixt writes: > >> Yes, running "sudo make install" is a nightmare. sudo clears the path, >> and the git command is not found by the make invoked with root >> permissions. This changes the version string that gets compiled

[PATCH v1 1/1] Introduce git add --renormalize .

From: Torsten Bögershausen Make it safer to normalize the line endings in a repository: Files that had been commited with CRLF will be commited with LF. (Unless core.autorclf and .gitattributes specify that Git should not do line ending conversions) The old way to normalize a

Greetings in the name of God, Business proposal in God we trust

Greetings in the name of God Dear Friend Greetings in the name of God,please let this not sound strange to you for my only surviving lawyer who would have done this died early this year.I prayed and got your email id from your country guestbook. I am Mrs Suran Yoda from London,I am 72 years

[PATCH v4 2/3] implement fetching of moved submodules

We store the changed submodules paths to calculate which submodule needs fetching. This does not work for moved submodules since their paths do not stay the same in case of a moved submodules. In case of new submodules we do not have a path in the current checkout, since they just appeared in this

[PATCH v4 3/3] submodule: simplify decision tree whether to or not to fetch

To make extending this logic later easier. Signed-off-by: Heiko Voigt --- submodule.c | 74 ++--- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/submodule.c b/submodule.c index 71d1773e2e..82d206eb65

[PATCH v4 1/3] fetch: add test to make sure we stay backwards compatible

The current implementation of submodules supports on-demand fetch if there is no .gitmodules entry for a submodule. Let's add a test to document this behavior. Signed-off-by: Heiko Voigt --- t/t5526-fetch-submodules.sh | 42 +- 1 file

[PATCH v4 0/3] implement fetching of moved submodules

The previous RFC iteration can be found here: https://public-inbox.org/git/20171006222544.GA26642@sandbox/ This should now be in a state ready for review for inclusion. The main difference from last iteration is that we now also support unconfigured gitlinks for push and fetch for backwards

Re: [PATCH v2] sequencer.c: fix and unify error messages in rearrange_squash()

"Philip Oakley" writes: > Hi, 'Truncate' is real English, but it is not that common in normal usage. > > My dictionary suggests that it means 'cut off at the tip' such as a > truncated cone. However the thesaurus is far more relaxed about the > common idioms that truncate

Re: [PATCH v2] sequencer.c: fix and unify error messages in rearrange_squash()

From: "Johannes Schindelin" On Mon, 16 Oct 2017, Junio C Hamano wrote: Ralf Thielow writes: > When the write opertion fails, we write that we could > not read. Change the error message to match the operation > and remove the full stop at

Re: [PATCH v2 2/3] for-each-ref: let upstream/push optionally remote ref name

Hi Junio, On Mon, 16 Oct 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> >> -Also respects `:remotename` to state the name of the *remote* instead > >> >> of > >> >> -the ref. > >> >> +Also respects `:remotename` to state the name of the *remote*

Re: [PATCH v2] sequencer.c: fix and unify error messages in rearrange_squash()

Hi Junio, On Mon, 16 Oct 2017, Junio C Hamano wrote: > Ralf Thielow writes: > > > When the write opertion fails, we write that we could > > not read. Change the error message to match the operation > > and remove the full stop at the end. > > > > When ftruncate() fails,

Re: [ANNOUNCE] Git for Windows 2.14.2(3)

Hi Steve, On Sun, 15 Oct 2017, Johannes Schindelin wrote: > On Fri, 13 Oct 2017, Steve Hoelzer wrote: > > > On Thu, Oct 12, 2017 at 5:53 PM, Johannes Schindelin > > wrote: > > > > > > It is my pleasure to announce that Git for Windows 2.14.2(3) is > > > available

Re: [PATCH] check-ref-format: require a repository for --branch

Junio C Hamano writes: > Having said that, there may still be a use case where a Porcelain > script wants a way to see if a $name it has is appropriate as a > branch name before it has a repository (e.g. a wrapper to "git > clone" that wants to verify the name it is going to

Re: Does Git build things during 'make install"?

Johannes Sixt writes: > Yes, running "sudo make install" is a nightmare. sudo clears the path, > and the git command is not found by the make invoked with root > permissions. This changes the version string that gets compiled into > the executable, which finally triggers a

DEAR FRIEND.

Dear Friend, I am Mr.Nawfal Nagi the head of file department of Bank of Africa(B.O.A) here in Burkina Faso / Ouagadougou. In my department we discover an abandoned sum of (US$18 million US Dollars) in an account that belongs to one of our foreign customer who died along with his family in plane

What's cooking in git.git (Oct 2017, #03; Mon, 16)

Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The ones marked with '.' do not appear in any of the integration branches, but I am still holding onto them. 2.15-rc1 has been tagged, but

Re: [PATCH] check-ref-format: require a repository for --branch

Jeff King writes: > On Mon, Jul 17, 2017 at 10:27:09AM -0700, Jonathan Nieder wrote: >> ... >> I don't think it's right. Today I can do >> >> $ cd /tmp >> $ git check-ref-format --branch master >> master >> >> You might wonder why I'd ever do such a thing. But