Re: future of the mediawiki extension?

"Junio C Hamano" wrote: > I think the plan was to make code drop from time to time at major > release points of git-multimail, but I do not think we've seen many > updates recently. I realize I didn't answer this point. The reason you didn't see any update recently is just

Re: [PATCH v4 2/7] remote-mediawiki: allow fetching namespaces with spaces

On Mon, Nov 06, 2017 at 04:19:48PM -0500, Antoine Beaupré wrote: > From: Ingo Ruhnke > > we still want to use spaces as separators in the config, but we should > allow the user to specify namespaces with spaces, so we use underscore > for this. > > Reviewed-by: Antoine

[PATCH v2 2/2] diff: --ignore-cr-at-eol

A new option --ignore-cr-at-eol tells the diff machinery to treat a carriage-return at the end of a (complete) line as if it does not exist. This would make it easier to review a change whose only effect is to turn line endings from CRLF to LF or the other way around. Signed-off-by: Junio C

[PATCH v2 1/2] xdiff: reassign xpparm_t.flags bits

We have packed the bits too tightly in such a way that it is not easy to add a new type of whitespace ignoring option, a new type of LCS algorithm, or a new type of post-cleanup heuristics. Reorder bits a bit to give room for these three classes of options to grow. Also make use of

[PATCH v2 0/2] Teach "diff" to ignore only CR at EOL

This time with doc updates and tests. The previous one is at https://public-inbox.org/git/xmqqshe7j0af@gitster.mtv.corp.google.com A change that is supposed to only change the end-of-line convention between LF <-> CRLF and nothing else can be verified with "diff -b" or "diff

Re: [PATCH v2 2/8] t0021/rot13-filter: refactor packet reading functions

On Tue, Nov 7, 2017 at 2:15 AM, Junio C Hamano wrote: > Christian Couder writes: > >> +sub packet_required_key_val_read { >> + my ( $key ) = @_; >> + my ( $res, $buf ) = packet_txt_read(); >> + unless ( $res == -1 or ( $buf =~ s/^$key=//

Re: [PATCH v2 1/1] Introduce git add --renormalize .

tbo...@web.de writes: > From: Torsten Bögershausen > > Make it safer to normalize the line endings in a repository: > Files that had been commited with CRLF will be commited with LF. > ... > Helped-By: Junio C Hamano > Signed-off-by: Torsten Bögershausen

[PATCH/RFC] Replace Free Software Foundation address in license notices

The mailing address for the FSF has changed over the years. Rather than updating the address across all files, refer readers to gnu.org, as the GNU GPL documentation now suggests for license notices. The mailing address is retained in the full license files (COPYING and LGPL-2.1). The old

Re: [PATCH v1 6/8] sequencer: simplify adding Signed-off-by: trailer

Phillip Wood writes: > diff --git a/sequencer.c b/sequencer.c > index > ae24405c23d021ed7916e5e2d9df6de27f867a2e..3e4c3bbb265db58df22cfcb5a321fb74d822327e > 100644 > --- a/sequencer.c > +++ b/sequencer.c > @@ -477,9 +477,6 @@ static int do_recursive_merge(struct

Re: [PATCH v1 5/8] sequencer: don't die in print_commit_summary()

Phillip Wood writes: > From: Phillip Wood > > Return an error rather than dying so that the sequencer can exit > cleanly once it starts committing without forking 'git commit' > > Signed-off-by: Phillip Wood >

Re: [PATCH v1 4/8] commit: move print_commit_summary() to libgit

Phillip Wood writes: > From: Phillip Wood > > Move print_commit_summary() from builtin/commit.c to sequencer.c so it > can be shared with other commands. The function is modified by > changing the last argument to a flag so callers can

Re: [PATCH v1 3/8] commit: move post-rewrite code to libgit

Phillip Wood writes: > From: Phillip Wood > > Move run_rewrite_hook() from bulitin/commit.c to sequencer.c so it can > be shared with other commands and add a new function > commit_post_rewrite() based on the code in builtin/commit.c that >

Re: [PATCH v1 2/8] Add a function to update HEAD after creating a commit

Phillip Wood writes: > @@ -1735,25 +1733,10 @@ int cmd_commit(int argc, const char **argv, const > char *prefix) > strbuf_release(_ident); > free_commit_extra_headers(extra); > > - nl = strchr(sb.buf, '\n'); > - if (nl) > -

Re: [PATCH 1/3] checkout: describe_detached_head: remove 3dots after committish

Thanks for all the feedback provided! I'd like to summarise what consensus we have reached so far and then propose a way forward: * we'll use the term "ellipsis (pl. ellipses)" for what's been referred to as "3dots", "n-dots", "many dots" and so forth * we would like to use

Re: future of the mediawiki extension?

On 2017-11-07 09:44:03, Junio C Hamano wrote: > Antoine Beaupré writes: > >> On 2017-10-31 10:37:29, Junio C Hamano wrote: There's also a hybrid solution used by git-multimail: have a copy of the code in git.git, but do the development separately. I'm not sure it'd

sb/submodule-recursive-checkout-detach-head

Stefan Beller writes: >> * sb/submodule-recursive-checkout-detach-head (2017-07-28) 2 commits >> (merged to 'next' on 2017-10-26 at 30994b4c76) >> + Documentation/checkout: clarify submodule HEADs to be detached >> + recursive submodules: detach HEAD from new state >> >>

Re: [PATCH] Tests: document test_submodule_{,forced_}switch()

Jonathan Tan writes: > Factor out the commonalities from test_submodule_switch() and > test_submodule_forced_switch() in lib-submodule-update.sh, and document > their usage. > > This also makes explicit (through the KNOWN_FAILURE_FORCED_SWITCH_TESTS > variable) the fact

Re: [PATCH v1 8/8] sequencer: try to commit without forking 'git commit'

Hi Phillip, On Mon, 6 Nov 2017, Phillip Wood wrote: > From: Phillip Wood > > If the commit message does not need to be edited then create the > commit without forking 'git commit'. Taking the best time of ten runs > with a warm cache this reduces the time taken to

Re: [PATCH v2 7/8] t0021/rot13-filter: add capability functions

Christian Couder writes: > t/t0021/rot13-filter.pl | 58 > ++--- > 1 file changed, 45 insertions(+), 13 deletions(-) Makes sense.

Re: [PATCH v2 6/8] t0021/rot13-filter: refactor checking final lf

Christian Couder writes: > As checking for a lf character at the end of a buffer > will be useful in another function, let's refactor this > functionality into a small remove_final_lf_or_die() > helper function. > > Signed-off-by: Christian Couder

Re: [PATCH v2 2/8] t0021/rot13-filter: refactor packet reading functions

Christian Couder writes: > +sub packet_required_key_val_read { > + my ( $key ) = @_; > + my ( $res, $buf ) = packet_txt_read(); > + unless ( $res == -1 or ( $buf =~ s/^$key=// and $buf ne '' ) ) { > + die "bad $key: '$buf'"; > + } > +

Re: [PATCH v1 7/8] sequencer: load commit related config

Hi Phillip, On Mon, 6 Nov 2017, Phillip Wood wrote: > From: Phillip Wood > > Load default values for message cleanup and gpg signing of commits in > preparation for committing without forking 'git commit'. Nicely explained. > diff --git a/builtin/rebase--helper.c

Re: [PATCH v2 1/8] t0021/rot13-filter: fix list comparison

Christian Couder writes: > +sub packet_compare_lists { > + my ($expect, @result) = @_; > + my $ix; > + if (scalar @$expect != scalar @result) { > + return undef; > + } > + for ($ix = 0; $ix < $#result; $ix++) { > + if

Re: [PATCH 1/3] checkout: describe_detached_head: remove 3dots after committish

Ann T Ropea writes: > Lest we confuse the meticulous observer, we ought to retire the 3dots in > the circumstances described above. Yes, as I said in my response to 3/3, I think it is a good goal to avoid n-dots used as a "here we truncated something longer" sign, which was a

Re: [PATCH v1 6/8] sequencer: simplify adding Signed-off-by: trailer

Hi Phillip, On Mon, 6 Nov 2017, Phillip Wood wrote: > From: Phillip Wood > > Add the Signed-off-by: trailer in one place rather than adding it to > the message when doing a recursive merge and specifying '--signoff' > when running 'git commit'. I would find this

Re: future of the mediawiki extension?

Antoine Beaupré writes: > On 2017-10-31 10:37:29, Junio C Hamano wrote: >>> There's also a hybrid solution used by git-multimail: have a copy of the >>> code in git.git, but do the development separately. I'm not sure it'd be >>> a good idea for Git-Mediawiki, but I'm

Re: [PATCH v1 1/8] commit: move empty message checks to libgit

Hi Phillip, On Mon, 6 Nov 2017, Phillip Wood wrote: > From: Phillip Wood > > Move the functions that check for empty messages from bulitin/commit.c > to sequencer.c so they can be shared with other commands. The > functions are refactored to take an explicit cleanup

Business Proposal.

Dear Friend, I am interested in establishing and operating a very viable business as a means of investment abroad. I do not know too well on how this is done in your country, So I will need you to help me in this regard. My preference is any good profit yielding business and I would appreciate

Re: [PATCH 1/3] checkout: describe_detached_head: remove 3dots after committish

From: "Junio C Hamano" Ann T Ropea writes: This could be confusing not only for novices; in either case, no range should be insinuated by describe_detached_head. We actually do not insinuate any range in these output. These dots denote "truncated at

Re: [PATCH v1 2/2] log: add option to choose which refs to decorate

Jacob Keller writes: > On November 3, 2017 8:49:15 PM PDT, Junio C Hamano wrote: >>Rafael Ascensão writes: >> >>Why should this be a special case that burdens users to remember one >>more rule? Wouldn't users find

[PATCH] Tests: document test_submodule_{,forced_}switch()

Factor out the commonalities from test_submodule_switch() and test_submodule_forced_switch() in lib-submodule-update.sh, and document their usage. This also makes explicit (through the KNOWN_FAILURE_FORCED_SWITCH_TESTS variable) the fact that, currently, all functionality tested using

Re: [PATCH 6/7] builtin/describe.c: describe a blob

From: "Junio C Hamano" Sent: Sunday, November 05, 2017 6:28 AM "Philip Oakley" writes: Is this not also an alternative case, relative to the user, for the scenario where the user has an oid/sha1 value but does not know what it is, and would like to

Re: [PATCH] wt-status: actually ignore submodules when requested

On 11/06, Stefan Beller wrote: > On Mon, Nov 6, 2017 at 2:08 PM, Brandon Williams wrote: > > Since ff6f1f564 (submodule-config: lazy-load a repository's .gitmodules > > file, 2017-08-03) rebase interactive fails if there are any submodules > > with unstaged changes which have

Re: [PATCH] wt-status: actually ignore submodules when requested

On Mon, Nov 6, 2017 at 2:08 PM, Brandon Williams wrote: > Since ff6f1f564 (submodule-config: lazy-load a repository's .gitmodules > file, 2017-08-03) rebase interactive fails if there are any submodules > with unstaged changes which have been configured with a value for >

[PATCH] wt-status: actually ignore submodules when requested

Since ff6f1f564 (submodule-config: lazy-load a repository's .gitmodules file, 2017-08-03) rebase interactive fails if there are any submodules with unstaged changes which have been configured with a value for 'submodule..ignore' in the repository's config. This is due to how configured values of

[PATCH v4 0/7] remote-mediawiki: namespace support

Hopefully, the final series. This includes only one more fix, from Thomas, to remove an extra loop. This should, alas, be ready to merge.

[PATCH v4 2/7] remote-mediawiki: allow fetching namespaces with spaces

From: Ingo Ruhnke we still want to use spaces as separators in the config, but we should allow the user to specify namespaces with spaces, so we use underscore for this. Reviewed-by: Antoine Beaupré Signed-off-by: Antoine Beaupré ---

[PATCH v4 7/7] remote-mediawiki: show progress while fetching namespaces

Without this, the fetch process seems hanged while we fetch page listings across the namespaces. Obviously, it should be possible to silence this with -q, but that's an issue already present everywhere in the code and should be fixed separately:

[PATCH v4 3/7] remote-mediawiki: show known namespace choices on failure

If we fail to find a requested namespace, we should tell the user which ones we know about, since those were already fetched. This allows users to fetch all namespaces by specifying a dummy namespace, failing, then copying the list of namespaces in the config. Eventually, we should have a flag

[PATCH v4 4/7] remote-mediawiki: skip virtual namespaces

Virtual namespaces do not correspond to pages in the database and are automatically generated by MediaWiki. It makes little sense, therefore, to fetch pages from those namespaces and the MW API doesn't support listing those pages. According to the documentation, those virtual namespaces are

[PATCH v4 6/7] remote-mediawiki: process namespaces in order

Ideally, we'd process them in numeric order since that is more logical, but we can't do that yet since this is where we find the numeric identifiers in the first place. Lexicographic order is a good compromise. Signed-off-by: Antoine Beaupré ---

[PATCH v4 5/7] remote-mediawiki: support fetching from (Main) namespace

When we specify a list of namespaces to fetch from, by default the MW API will not fetch from the default namespace, refered to as "(Main)" in the documentation: https://www.mediawiki.org/wiki/Manual:Namespace#Built-in_namespaces I haven't found a way to address that "(Main)" namespace when

[PATCH v4 1/7] remote-mediawiki: add namespace support

From: Kevin This introduces a new remote.origin.namespaces argument that is a space-separated list of namespaces. The list of pages extract is then taken from all the specified namespaces. Reviewed-by: Antoine Beaupré Signed-off-by: Antoine Beaupré

Re: Bug report: git reset --hard does not fix submodule worktree

On Fri, Nov 3, 2017 at 5:46 PM, Billy O'Neal (VC LIBS) wrote: > Hello, Git folks. I managed to accidentally break the our test lab by > attempting to git mv a directory with a submodule inside. It seems like if a > reset does an undo on a mv, the workfold entry should be

Re: Regression[2.14.3->2.15]: Interactive rebase fails if submodule is modified

On Mon, Nov 6, 2017 at 8:37 PM, Brandon Williams wrote: > After reading your bug report and the fact that you weren't able to > reproduce it outside of your project I think i figured out what is > happening. Before ff6f1f564c the gitmodules file wasn't being loaded > unless a

RE ::: Good Morning

Your email was successfully selected in the on-going Qatar Foundation donation, Contact to redeem, Thanks. --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Re: [PATCH v1 2/2] log: add option to choose which refs to decorate

On November 3, 2017 8:49:15 PM PDT, Junio C Hamano wrote: >Rafael Ascensão writes: > >Why should this be a special case that burdens users to remember one >more rule? Wouldn't users find "--decorate-refs=refs/tags" useful >and it woulld be shorter and

Re: [PATCH 1/9] extension.partialclone: introduce partial clone extension

On Mon, 6 Nov 2017 12:32:45 -0500 Jeff Hostetler wrote: > >> Yes, that is a point I wanted to ask about. I renamed the > >> extensions.partialclone that you created and then I moved your > >> remote..blob-max-bytes setting to be in extensions too. > >> Moving it to

did you receive the email i send to you

Re: Regression[2.14.3->2.15]: Interactive rebase fails if submodule is modified

On 11/05, Orgad Shaneh wrote: > On Sat, Nov 4, 2017 at 8:04 PM, Orgad Shaneh wrote: > > On Fri, Nov 3, 2017 at 6:20 PM, Johannes Schindelin > > wrote: > >> Hi Orgad, > >> > >> On Fri, 3 Nov 2017, Johannes Schindelin wrote: > >> > >>> On Thu, 2 Nov

Re: [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list

On Mon, 6 Nov 2017 12:51:52 -0500 Jeff Hostetler wrote: > Jonathan and I were talking off-list about the performance > effects of inspecting the pathnames to identify the ".git*" > special files. I added it in my first draft back in the spring, > thinking that even if you

Re: [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list

On 11/2/2017 1:50 PM, Jeff Hostetler wrote: From: Jeff Hostetler Create traverse_commit_list_filtered() and add filtering interface to allow certain objects to be omitted from the traversal. ... diff --git a/list-objects-filter.c b/list-objects-filter.c new file mode

Re: benefits of "/" in branch names other than the obvious?

On Sun, Nov 5, 2017 at 9:36 PM, Robert P. J. Day wrote: > > another picky question ... are there any other benefits of > supporting slashes in branch names other than the obvious ones i know > about? > > 1) visually, let's you *imagine* a branch hierarchy, and > 2) allows

Re: [PATCH 1/9] extension.partialclone: introduce partial clone extension

On 11/3/2017 2:39 PM, Jonathan Tan wrote: On Fri, 3 Nov 2017 09:57:18 -0400 Jeff Hostetler wrote: On 11/2/2017 6:24 PM, Jonathan Tan wrote: On Thu, 2 Nov 2017 20:20:44 + Jeff Hostetler wrote: From: Jeff Hostetler

Re: Improved error handling (Was: [PATCH 1/2] sequencer: factor out rewrite_file())

On Sat, Nov 04, 2017 at 10:07:00PM -0400, Jeff King wrote: > Yes, I think what you've written here (and below) is quite close to the > error_context patches I linked elsewhere in the thread. In other > words, I think it's a sane approach. In contrast to error_context I'd like to keep all exiting

Re: git grep -P fatal: pcre_exec failed with error code -8

On Mon, Nov 06 2017, Jeff King jotted: > On Mon, Nov 06, 2017 at 12:50:45PM +0100, Ævar Arnfjörð Bjarmason wrote: > >> Some replies to the thread in general, didn't want to spread this out >> into different replies. >> >> * Yes this sucks. >> >> * Just emitting a warning without an appropriate

Re: git grep -P fatal: pcre_exec failed with error code -8

On Mon, Nov 06, 2017 at 12:50:45PM +0100, Ævar Arnfjörð Bjarmason wrote: > Some replies to the thread in general, didn't want to spread this out > into different replies. > > * Yes this sucks. > > * Just emitting a warning without an appropriate exit code would suck >more, would break

Re: git grep -P fatal: pcre_exec failed with error code -8

On Mon, Nov 06 2017, Jeff King jotted: > On Sun, Nov 05, 2017 at 10:41:17AM +0100, Дилян Палаузов wrote: > >> I understand that the PCRE's stack can get exhausted for some files, but in >> such cases, git grep shall proceed with the other files, and print at the >> end/stderr for which files the

[PATCH v1 1/8] commit: move empty message checks to libgit

From: Phillip Wood Move the functions that check for empty messages from bulitin/commit.c to sequencer.c so they can be shared with other commands. The functions are refactored to take an explicit cleanup mode and template filename passed by the caller.

[PATCH v1 2/8] Add a function to update HEAD after creating a commit

From: Phillip Wood Add update_head() based on the code that updates HEAD after committing in builtin/commit.c that can be called by 'git commit' and other commands. Signed-off-by: Phillip Wood --- builtin/commit.c | 19

[PATCH v1 4/8] commit: move print_commit_summary() to libgit

From: Phillip Wood Move print_commit_summary() from builtin/commit.c to sequencer.c so it can be shared with other commands. The function is modified by changing the last argument to a flag so callers can specify whether they want to show the author date in addition

[PATCH v1 8/8] sequencer: try to commit without forking 'git commit'

From: Phillip Wood If the commit message does not need to be edited then create the commit without forking 'git commit'. Taking the best time of ten runs with a warm cache this reduces the time taken to cherry-pick 10 commits by 27% (from 282ms to 204ms), and the time

[PATCH v1 5/8] sequencer: don't die in print_commit_summary()

From: Phillip Wood Return an error rather than dying so that the sequencer can exit cleanly once it starts committing without forking 'git commit' Signed-off-by: Phillip Wood --- builtin/commit.c | 3 ++- sequencer.c | 17

[PATCH v1 6/8] sequencer: simplify adding Signed-off-by: trailer

From: Phillip Wood Add the Signed-off-by: trailer in one place rather than adding it to the message when doing a recursive merge and specifying '--signoff' when running 'git commit'. This means that if there are conflicts when merging with a strategy other than

[PATCH v1 7/8] sequencer: load commit related config

From: Phillip Wood Load default values for message cleanup and gpg signing of commits in preparation for committing without forking 'git commit'. Signed-off-by: Phillip Wood --- builtin/rebase--helper.c | 13 -

[PATCH v1 3/8] commit: move post-rewrite code to libgit

From: Phillip Wood Move run_rewrite_hook() from bulitin/commit.c to sequencer.c so it can be shared with other commands and add a new function commit_post_rewrite() based on the code in builtin/commit.c that encapsulates rewriting notes and running the post-rewrite

[PATCH v1 0/8] sequencer: dont't fork git commit

From: Phillip Wood Changes since the last version - reworked the second patch based on Junio's feedback so it no longer sets GIT_REFLOG_ACTION - reworded commit messages - print_commit_summary() no longer dies but returns an error so the sequencer can exit

Re: [PATCH v2 1/2] builtin/merge-base: UNLEAK commit lists

On Sun, Nov 05, 2017 at 09:26:30PM +0100, Martin Ågren wrote: > In several functions, we iterate through a commit list by assigning > `result = result->next`. As a consequence, we lose the original pointer > and eventually leak the list. > > These are immediate helpers to `cmd_merge_base()`

Re: [PATCH/DONOTAPPLY 0/4] first steps towards pager.foo.{command,enable}

On Sun, Nov 05, 2017 at 12:58:18PM +0100, Martin Ågren wrote: > On 4 November 2017 at 10:28, Jeff King wrote: > > - the pager. config is mis-designed, because our config keys > >cannot represent all possible command names (e.g., case folding and > >illegal characters).

Re: git grep -P fatal: pcre_exec failed with error code -8

On Sun, Nov 05, 2017 at 10:41:17AM +0100, Дилян Палаузов wrote: > I understand that the PCRE's stack can get exhausted for some files, but in > such cases, git grep shall proceed with the other files, and print at the > end/stderr for which files the pattern was not applied. Such behaviour >

Re: [PATCH] credential-libsecret: unlock locked secrets

On Fri, Nov 3, 2017 at 10:44 PM, Dennis Kaarsemaker wrote: > Credentials exposed by the secret service DBUS interface may be locked. > Setting the SECRET_SEARCH_UNLOCK flag will make the secret service > unlock these secrets, possibly prompting the user for credentials to

What's cooking in git.git (Nov 2017, #02; Mon, 6)

Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The ones marked with '.' do not appear in any of the integration branches, but I am still holding onto them. Early batches for the next cycle