Re: Cloned repository has file changes -> bug?

2018-01-27 Thread Torsten Bögershausen
On Sat, Jan 27, 2018 at 08:59:50PM +0100, Ævar Arnfjörð Bjarmason wrote: > > On Sat, Jan 27 2018, Filip Jorissen jotted: > > > I think our git repository is bugged. The reason why I say this is the > > following. When cloning the repository, the newly cloned repository > > immediately has file

Re: Creating sparse checkout in a new linked git worktree

2018-01-27 Thread Eric Sunshine
On Wed, Jan 24, 2018 at 11:11 AM, Jessie Hernandez wrote: > I am trying to get a sparse checkout in a linked worktree but cannot get > it working. I have tried the following > > * git worktree add /some/new/path/new-branch --no-checkout > * git config core.sparseCheckout

Re: [PATCH v2] daemon: add --send-log-to=(stderr|syslog|none)

2018-01-27 Thread Eric Sunshine
On Sat, Jan 27, 2018 at 1:31 PM, Lucas Werkmeister wrote: > This makes it possible to use --inetd while still logging to standard > error. --syslog is retained as an alias for --send-log-to=syslog. A mode > to disable logging explicitly is also provided. > > The

[PATCH v2 0/1] setup: recognise extensions.objectFormat

2018-01-27 Thread Patryk Obara
Compared to v1: Implemented code suggestions from Duy Nguyễn (string for translation and strbuf instead of char array). I also added an annotation in repository-version.txt, clarifying, that this option is useful only for development purpose for now. Patryk Obara (1): setup: recognise

[PATCH v2 1/1] setup: recognise extensions.objectFormat

2018-01-27 Thread Patryk Obara
This extension selects which hashing algorithm from vtable should be used for reading and writing objects in the object store. At the moment supports only single value (sha-1). In case value of objectFormat is an unknown hashing algorithm, Git command will fail with following message: fatal:

[PATCH v4 09/12] sha1_file: convert write_sha1_file to object_id

2018-01-27 Thread Patryk Obara
Convert the definition and declaration of write_sha1_file to struct object_id and adjust usage of this function. This commit also converts static function write_sha1_file_prepare, as it is closely related. Rename these functions to write_object_file and write_object_file_prepare respectively.

[PATCH v4 02/12] dir: convert struct sha1_stat to use object_id

2018-01-27 Thread Patryk Obara
Convert the declaration of struct sha1_stat. Adjust all usages of this struct and replace hash{clr,cmp,cpy} with oid{clr,cmp,cpy} wherever possible. Rename it to struct oid_stat. Rename static function load_sha1_stat to load_oid_stat. Remove macro EMPTY_BLOB_SHA1_BIN, as it's no longer used.

[PATCH v4 04/12] cache: clear whole hash buffer with oidclr

2018-01-27 Thread Patryk Obara
As long as GIT_SHA1_RAWSZ is equal to GIT_MAX_RAWSZ there's no problem, but when new hashing algorithm will be in place this memset will clear only 20-byte prefix of hash buffer. Alternatively, hashclr implementation could be adjusted, but this function is almost removed from codebase already.

[PATCH v4 11/12] sha1_file: convert write_loose_object to object_id

2018-01-27 Thread Patryk Obara
Convert the definition and declaration of static write_loose_object function to struct object_id. Signed-off-by: Patryk Obara --- sha1_file.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/sha1_file.c b/sha1_file.c

[PATCH v4 10/12] sha1_file: convert force_object_loose to object_id

2018-01-27 Thread Patryk Obara
Convert the definition and declaration of force_object_loose to struct object_id and adjust usage of this function. Signed-off-by: Patryk Obara --- builtin/pack-objects.c | 2 +- cache.h| 3 ++- sha1_file.c| 10 +- 3 files changed, 8

[PATCH v4 07/12] notes: convert combine_notes_* to object_id

2018-01-27 Thread Patryk Obara
Convert the definition and declarations of combine_notes_* functions to struct object_id and adjust usage of these functions. Signed-off-by: Patryk Obara --- notes.c | 46 +++--- notes.h | 25 +++-- 2 files

[PATCH v4 06/12] commit: convert commit_tree* to object_id

2018-01-27 Thread Patryk Obara
Convert the definitions and declarations of commit_tree and commit_tree_extended to use struct object_id and adjust all usages of these functions. Signed-off-by: Patryk Obara --- builtin/am.c | 4 ++-- builtin/commit-tree.c | 4 ++-- builtin/commit.c | 5

[PATCH v4 00/12] A bunch of object_id conversions

2018-01-27 Thread Patryk Obara
Thank you, everyone, for review and thanks, Junio for queueing two first patches - I removed them from v4, as there were no more comments to them anyway. Compared to v3: Patch 2 (formerly 4) - renamed all parameter names sha1_stat to oid_stat - renamed static function load sha1_stat to

[PATCH v4 03/12] sha1_file: convert hash_sha1_file to object_id

2018-01-27 Thread Patryk Obara
Convert the declaration and definition of hash_sha1_file to use struct object_id and adjust all function calls. Rename this function to hash_object_file. Signed-off-by: Patryk Obara --- apply.c | 4 ++-- builtin/index-pack.c | 5 ++---

[PATCH v4 12/12] sha1_file: rename hash_sha1_file_literally

2018-01-27 Thread Patryk Obara
This function was already converted to use struct object_id earlier. Signed-off-by: Patryk Obara --- builtin/hash-object.c | 3 ++- cache.h | 4 +++- sha1_file.c | 5 +++-- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git

[PATCH v4 05/12] match-trees: convert splice_tree to object_id

2018-01-27 Thread Patryk Obara
Convert the definition of static recursive splice_tree function to use struct object_id and adjust single caller. Signed-off-by: Patryk Obara --- match-trees.c | 46 ++ 1 file changed, 22 insertions(+), 24 deletions(-) diff

[PATCH v4 01/12] sha1_file: convert pretend_sha1_file to object_id

2018-01-27 Thread Patryk Obara
Convert the declaration and definition of pretend_sha1_file to use struct object_id and adjust all usages of this function. Rename it to pretend_object_file. Signed-off-by: Patryk Obara --- Documentation/technical/api-object-access.txt | 2 +- blame.c

[PATCH v4 08/12] notes: convert write_notes_tree to object_id

2018-01-27 Thread Patryk Obara
Convert the definition and declaration of write_notes_tree to struct object_id and adjust usage of this function. Additionally, improve style of small part of this function, as old formatting made it hard to understand at glance what this part of code is doing. Signed-off-by: Patryk Obara

git send-email sets date

2018-01-27 Thread Michal Suchánek
Hello, git send-email sets the message date to author date. This is wrong because the message will most likely not get delivered when the author date differs from current time. It might give slightly better results with commit date instead of author date but can't is just skip that header and

Re: Cloned repository has file changes -> bug?

2018-01-27 Thread Ævar Arnfjörð Bjarmason
On Sat, Jan 27 2018, Filip Jorissen jotted: > I think our git repository is bugged. The reason why I say this is the > following. When cloning the repository, the newly cloned repository > immediately has file changes[...]. If you run this: git ls-files | tr '[:upper:]' '[:lower:]' | sort

Cloned repository has file changes -> bug?

2018-01-27 Thread Filip Jorissen
Dear all, I think our git repository is bugged. The reason why I say this is the following. When cloning the repository, the newly cloned repository immediately has file changes. Steps to reproduce and illustration is at the end of this email. Git checkout does not work to remove the file

Re: Some rough edges of core.fsmonitor

2018-01-27 Thread Ævar Arnfjörð Bjarmason
On Sat, Jan 27 2018, Duy Nguyen jotted: > On Sat, Jan 27, 2018 at 07:39:27PM +0700, Duy Nguyen wrote: >> On Sat, Jan 27, 2018 at 6:43 PM, Ævar Arnfjörð Bjarmason >> wrote: >> > a) no fsmonitor >> > >> > $ time GIT_TRACE_PERFORMANCE=1 ~/g/git/git-status >> >

[PATCH v2] daemon: add --send-log-to=(stderr|syslog|none)

2018-01-27 Thread Lucas Werkmeister
This makes it possible to use --inetd while still logging to standard error. --syslog is retained as an alias for --send-log-to=syslog. A mode to disable logging explicitly is also provided. The combination of --inetd with --send-log-to=stderr is useful, for instance, when running `git daemon` as

lucky winner

2018-01-27 Thread Mr Johnson Paul
Wow!!! Congratulation It is a great pleasure to inform you that you emerge winner to the sum of 1,850,000.00 Euro For more inquiries contact: Mr Johnson Paul trough his Email address:johnsonop...@gmail.com Yours faithfully, Online Coordinator's

Re: [PATCH v2 0/2] wrap format-patch diffstats around 72 columns

2018-01-27 Thread Jeff King
On Thu, Jan 25, 2018 at 06:59:25PM +0700, Nguyễn Thái Ngọc Duy wrote: > Like v1, these changes keep diffstat generated by format-patch in 72 > columns. This constant is already used in the code, so it's a bit > better than my random "70 or 75" value. > > Granted these hard coded values (both 80

Re: [PATCH v2 2/2] format-patch: reduce patch diffstat width to 72

2018-01-27 Thread Jeff King
On Thu, Jan 25, 2018 at 06:59:27PM +0700, Nguyễn Thái Ngọc Duy wrote: > diff --git a/t/t4052-stat-output.sh b/t/t4052-stat-output.sh > index 9f563db20a..1e62333b46 100755 > --- a/t/t4052-stat-output.sh > +++ b/t/t4052-stat-output.sh > @@ -60,7 +60,7 @@ do > test_cmp expect actual >

Re: [ANNOUNCE] Git Merge Contributor's Summit Mar 7, 2018, Barcelona

2018-01-27 Thread Lars Schneider
Hi Peff, I would like to register to the contributor summit :-) --- As I am writing you, I thought I could ask you a question: "git verify-pack" tells me the "size-in-packfile" which is kind of the "real" size of a file in a Git repo. Are you aware of a way to get this number via the GitHub

Re: Some rough edges of core.fsmonitor

2018-01-27 Thread Duy Nguyen
On Sat, Jan 27, 2018 at 07:39:27PM +0700, Duy Nguyen wrote: > On Sat, Jan 27, 2018 at 6:43 PM, Ævar Arnfjörð Bjarmason > wrote: > > a) no fsmonitor > > > > $ time GIT_TRACE_PERFORMANCE=1 ~/g/git/git-status > > 12:32:44.947651 read-cache.c:1890 performance:

Re: Feature request: Improve diff algorithm

2018-01-27 Thread KES
One yet more: @@ -43,22 +44,25 @@ sub tariff_title { 1; __DATA__ -@@ control/tariff.css -* { -margin: 0; -padding: 0; -border: 0; --webkit-box-sizing: border-box; -box-sizing: border-box; } -html { -background-color: #121212; -color: white; -font-family:

Re: Some rough edges of core.fsmonitor

2018-01-27 Thread Duy Nguyen
On Sat, Jan 27, 2018 at 6:43 PM, Ævar Arnfjörð Bjarmason wrote: > a) no fsmonitor > > $ time GIT_TRACE_PERFORMANCE=1 ~/g/git/git-status > 12:32:44.947651 read-cache.c:1890 performance: 0.053153609 s: read > cache .git/index > 12:32:44.967943

[PATCH v2] trace: measure where the time is spent in the index-heavy operations

2018-01-27 Thread Nguyễn Thái Ngọc Duy
All the known heavy code blocks are measured (except object database access). This should help identify if an optimization is effective or not. An unoptimized git-status would give something like below: 0.001791141 s: read cache ... 0.004011363 s: preload index 0.000516161 s: refresh

Re: [PATCH v3 1/3] read-cache: fix reading the shared index for other repos

2018-01-27 Thread Thomas Gummerer
On 01/21, Junio C Hamano wrote: > Thomas Gummerer writes: > > > On 01/19, Junio C Hamano wrote: > >> Thomas Gummerer writes: > >> > >> > read_cache_from() defaults to using the gitdir of the_repository. As it > >> > is mostly a convenience macro,

Re: [PATCH] trace: measure where the time is spent in the index-heavy operations

2018-01-27 Thread Thomas Gummerer
On 01/27, Nguyễn Thái Ngọc Duy wrote: > All the known heavy code blocks are measured (except object database > access). This should help identify if an optimization is effective or > not. An unoptimized git-status would give something like below (92% of > time is accounted). > > Signed-off-by:

Re: Some rough edges of core.fsmonitor

2018-01-27 Thread Ævar Arnfjörð Bjarmason
On Sat, Jan 27 2018, Duy Nguyen jotted: > On Sat, Jan 27, 2018 at 7:28 AM, Ævar Arnfjörð Bjarmason > wrote: >> 3) A lot of time spend reading the index (or something..) > > I'm resending a patch from my old index-helper series. It should > measure all big time consuming blocks

Re: [PATCH 0/2] Add "git rebase --show-patch"

2018-01-27 Thread Ævar Arnfjörð Bjarmason
On Fri, Jan 26 2018, Nguyễn Thái Ngọc Duy jotted: > When a conflict happens during a rebase, you often need to look at the > original patch to see what the changes are. This requires opening your > favourite pager with some random path inside $GIT_DIR. > > This series makes that experience a bit

Hello Dear Friend,

2018-01-27 Thread ATIKOLA AWA
Hello Dear Friend, Greetings and how are you doing? I want to know if you are kind to be my partner in claiming the fund of $13.6 MillionUSD left by a late client. If you're interested please Revert for more details. You can visit the web for more details.