Re: [PATCH 1/1] commit-graph: define GIT_TEST_COMMIT_GRAPH

2018-10-08 Thread Junio C Hamano
Derrick Stolee writes: > I see these failures, too, but I believe they are due to > ds/commit-graph-with-grafts not being merged to 'next' yet. The > purpose of that branch is to fix these test breaks. The environment > variable got merged a lot faster. A separate "ping" would have helped me.

Re: How to handle patch series conflicts

2018-10-08 Thread Junio C Hamano
Stephen & Linda Smith writes: > Junio - I've been working this but would like your opinion on 7500, 7501 and > now 7510. > > I note that the the commit tests have intermixed functionality. An example > is > signoff tests that are in the three tests I mentioned. > > I've been tempted

Re: [PATCH 1/1] rebase -i: introduce the 'break' command

2018-10-08 Thread Junio C Hamano
Junio C Hamano writes: >> There is one crucial difference: the exit code. > > OK, and it was good that you explicitly said "with exit code 0" in > the log message. Together with the idea to update the doc I floated > earlier, this probably is worth documenting, too. Heh, I am becoming sloppy

Re: git log -S or -G

2018-10-08 Thread Junio C Hamano
Jeff King writes: > I think that is the best we could do for "-S", though, which is > inherently about counting hits. > > For "-G", we are literally grepping the diff. It does not seem > unreasonable to add the ability to grep only "-" or "+" lines, and the > interface for that should be pretty

Re: [BUG] A part of an edge from an octopus merge gets colored, even with --color=never

2018-10-08 Thread Jeff King
On Wed, Oct 03, 2018 at 06:32:06PM -0400, Noam Postavsky wrote: > > which is admittedly pretty horrible, too, but at least resembles a > > graph. I dunno. > > Yeah, but it's lossy, so it doesn't seem usable for the test. Maybe > doubling up some characters? > > ** left > R| **B-B-M-M.

Re: [PATCH 1/1] rebase -i: introduce the 'break' command

2018-10-08 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Junio, > > On Fri, 5 Oct 2018, Junio C Hamano wrote: > >> "Johannes Schindelin via GitGitGadget" >> writes: >> >> > From: Johannes Schindelin >> > >> > The 'edit' command can be used to cherry-pick a commit and then >> > immediately drop out of the interactive

Re: git log -S or -G

2018-10-08 Thread Jacob Keller
On Mon, Oct 8, 2018 at 8:22 PM Jeff King wrote: > > On Tue, Oct 09, 2018 at 08:09:32AM +0900, Junio C Hamano wrote: > > > Julia Lawall writes: > > > > >> Doing the same for -S is much harder at the machinery level, as it > > >> performs its thing without internally running "diff" twice, but just

Re: [PATCH v6 09/10] submodule: support reading .gitmodules when it's not in the working tree

2018-10-08 Thread Junio C Hamano
Junio C Hamano writes: > Antonio Ospite writes: > >> Finally, add t7416-submodule-sparse-gitmodules.sh to verify that reading >> from .gitmodules succeeds and that writing to it fails when the file is >> not checked out. >> ... >> t/t7416-submodule-sparse-gitmodules.sh | 78

Re: [PATCH v6 09/10] submodule: support reading .gitmodules when it's not in the working tree

2018-10-08 Thread Junio C Hamano
Antonio Ospite writes: > Finally, add t7416-submodule-sparse-gitmodules.sh to verify that reading > from .gitmodules succeeds and that writing to it fails when the file is > not checked out. > ... > t/t7416-submodule-sparse-gitmodules.sh | 78 ++ This now triggers

Re: git log -S or -G

2018-10-08 Thread Jeff King
On Tue, Oct 09, 2018 at 08:09:32AM +0900, Junio C Hamano wrote: > Julia Lawall writes: > > >> Doing the same for -S is much harder at the machinery level, as it > >> performs its thing without internally running "diff" twice, but just > >> counts the number of occurrences of 'foo'---that is

Re: [PATCH v3] coccicheck: process every source file at once

2018-10-08 Thread Jeff King
On Fri, Oct 05, 2018 at 09:54:13PM +0200, SZEDER Gábor wrote: > Runtimes tend to fluctuate quite a bit more on Travis CI compared to > my machine, but not this much, and it seems to be consistent so far. > > After scripting/querying the Travis CI API a bit, I found that from > the last 100

Re: [PATCH v3] coccicheck: process every source file at once

2018-10-08 Thread Jeff King
On Sat, Oct 06, 2018 at 10:42:57AM +0200, René Scharfe wrote: > > That's OK, too, assuming people would actually want to use it. I'm also > > OK shipping this (with the "make -j" fix you suggested) and seeing if > > anybody actually complains. I assume there are only a handful of people > >

Re: [PATCH v5 0/4] Filter alternate references

2018-10-08 Thread Jeff King
On Mon, Oct 08, 2018 at 11:09:20AM -0700, Taylor Blau wrote: > Attached is (what I anticipate to be) the final re-roll of my series to > introduce 'core.alternateRefsCommand' and 'core.alternateRefsPrefixes' > in order to limit the ".have" advertisement when pushing over protocol > v1 to a

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-08 Thread Jeff King
On Mon, Oct 08, 2018 at 02:29:47PM -0400, Derrick Stolee wrote: > > > > But I'm afraid it will take a while until I get around to turn it into > > > > something presentable... > > > Do you have the code pushed somewhere public where one could take a look? > > > I > > > Do you have the code

Re: [PATCH][Outreachy] remove all the inclusions of git-compat-util.h in header files

2018-10-08 Thread Ananya Krishna Maram
On Mon, 8 Oct 2018 at 22:43, Derrick Stolee wrote: > > On 10/8/2018 1:05 PM, Ananya Krishna Maram wrote: > > Hi All, > Hello, Ananya! Welcome. > > > I was searching through #leftovers and found this. > >

Re: What's so special about objects/17/ ?

2018-10-08 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Depending on how we're counting there's at least two. I thought you were asking "why the special sentinel is not 0{40}?" You counted the number of reasons why 0{40} is used to stand in for a real value, but that was the number I didn't find interesting in the

Re: What's so special about objects/17/ ?

2018-10-08 Thread Junio C Hamano
Stefan Beller writes: > On Sun, Oct 7, 2018 at 1:07 PM Junio C Hamano wrote: >> >> Junio C Hamano writes: > >> > ... >> > by general public and I do not have to explain the choice to the >> > general public ;-) >> >> One thing that is more important than "why not 00 but 17?" to answer >> is

Re: [PATCH] builtin/grep.c: remote superflous submodule code

2018-10-08 Thread Stefan Beller
> Well, submodule-config.c has its implementation and another caller, > which technically is outside submodule.c ;-) i.e. there is a typo in my commit message. I meant to say submodule-config.c > repo_read_gitmodules > has two more callers in unpack-trees.c these days, so perhaps we can > do

Re: [PATCH 14/14] rerere: convert to use the_hash_algo

2018-10-08 Thread Stefan Beller
On Mon, Oct 8, 2018 at 2:57 PM brian m. carlson wrote: > > Since this data is stored in the .git directory, it makes sense for us > to use the same hash algorithm for it as for everything else. Convert > the remaining uses of SHA-1 to use the_hash_algo. Use GIT_MAX_RAWSZ for > allocations.

Re: [PATCH 13/14] submodule: make zero-oid comparison hash function agnostic

2018-10-08 Thread Stefan Beller
On Mon, Oct 8, 2018 at 2:57 PM brian m. carlson wrote: > > With SHA-256, the length of the all-zeros object ID is longer. Add a > function to git-submodule.sh to check if a full hex object ID is the > all-zeros value, and use it to check the output we're parsing from git > diff-files or

Re: git log -S or -G

2018-10-08 Thread Junio C Hamano
Julia Lawall writes: >> Doing the same for -S is much harder at the machinery level, as it >> performs its thing without internally running "diff" twice, but just >> counts the number of occurrences of 'foo'---that is sufficient for >> its intended use, and more efficient. > > There is still the

Re: [PATCH 02/14] builtin/repack: replace hard-coded constant

2018-10-08 Thread Eric Sunshine
On Mon, Oct 8, 2018 at 6:27 PM Stefan Beller wrote: > On Mon, Oct 8, 2018 at 2:57 PM brian m. carlson > wrote: > > - if (line.len != 40) > > - die("repack: Expecting 40 character sha1 lines only > > from pack-objects."); > > + if (line.len !=

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-08 Thread Junio C Hamano
SZEDER Gábor writes: > There is certainly potential there. With a (very) rough PoC > experiment, a 8MB bloom filter, and a carefully choosen path I can > achieve a nice, almost 25x speedup: > > $ time git rev-list --count HEAD -- t/valgrind/valgrind.sh > 6 > > real0m1.563s > user

Re: [PATCH 06/14] packfile: express constants in terms of the_hash_algo

2018-10-08 Thread Stefan Beller
On Mon, Oct 8, 2018 at 2:57 PM brian m. carlson wrote: > > Replace uses of GIT_SHA1_RAWSZ with references to the_hash_algo to avoid > dependence on a particular hash length. Unlike the previous patches, this is dealing directly with packfiles, which (I would think) carry their own hash function

Re: [PATCH 05/14] pack-revindex: express constants in terms of the_hash_algo

2018-10-08 Thread Stefan Beller
> - /* This knows the pack format -- the 20-byte trailer > + /* This knows the pack format -- the hash trailer > * follows immediately after the last object data. While at it, fix the comment style? With or without the nit addressed, this patch (and patches 1 and 4) are

Re: [PATCH 03/14] builtin/mktree: remove hard-coded constant

2018-10-08 Thread Stefan Beller
On Mon, Oct 8, 2018 at 2:57 PM brian m. carlson wrote: > > Instead of using a hard-coded constant for the size of a hex object ID, > switch to use the computed pointer from parse_oid_hex that points after > the parsed object ID. > > Signed-off-by: brian m. carlson > --- > builtin/mktree.c | 2

Re: [PATCH 02/14] builtin/repack: replace hard-coded constant

2018-10-08 Thread Stefan Beller
On Mon, Oct 8, 2018 at 2:57 PM brian m. carlson wrote: > > Signed-off-by: brian m. carlson > --- > builtin/repack.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/builtin/repack.c b/builtin/repack.c > index c6a7943d5c..e77859062d 100644 > --- a/builtin/repack.c >

Re: [PATCH v3 0/2] EditorConfig file

2018-10-08 Thread Taylor Blau
On Mon, Oct 08, 2018 at 10:03:51PM +, brian m. carlson wrote: > This series introduces an EditorConfig file to help developers using any > editor set their editor's settings in conformance with the Git Project's > settings. This is helpful for developers who work on different projects > with

Re: [PATCH v6 09/10] submodule: support reading .gitmodules when it's not in the working tree

2018-10-08 Thread Stefan Beller
> +test_expect_success 'not writing gitmodules config file when it is not > checked out' ' > +test_must_fail git -C super submodule--helper config > submodule.submodule.url newurl This only checks the exit code, do we also want to check for test_path_is_missing .gitmodules ? >

[PATCH v3 0/2] EditorConfig file

2018-10-08 Thread brian m. carlson
This series introduces an EditorConfig file to help developers using any editor set their editor's settings in conformance with the Git Project's settings. This is helpful for developers who work on different projects with different indentation standards to keep their work in sync. Changes since

[PATCH v3 1/2] editorconfig: provide editor settings for Git developers

2018-10-08 Thread brian m. carlson
Contributors to Git use a variety of editors, each with their own configuration files. Because C lacks the defined norms on how to indent and style code that other languages, such as Ruby and Rust, have, it's possible for various contributors, especially new ones, to have configured their editor

[PATCH v3 2/2] editorconfig: indicate settings should be kept in sync

2018-10-08 Thread brian m. carlson
Now that we have two places where we set code formatting settings, .editorconfig and .clang-format, it's possible that they could fall out of sync. This is relatively unlikely, since we're not likely to change the tab width or our preference for tabs, but just in case, add comments to both files

[PATCH 11/14] apply: replace hard-coded constants

2018-10-08 Thread brian m. carlson
Replace several 40-based constants with references to GIT_MAX_HEXSZ or the_hash_algo, as appropriate. Signed-off-by: brian m. carlson --- apply.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/apply.c b/apply.c index e485fbc6bc..792ecea36a 100644 ---

[PATCH 07/14] refs/packed-backend: express constants using the_hash_algo

2018-10-08 Thread brian m. carlson
Switch uses of GIT_SHA1_HEXSZ to use the_hash_algo so that they are appropriate for the any given hash length. Signed-off-by: brian m. carlson --- refs/packed-backend.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/refs/packed-backend.c

[PATCH 05/14] pack-revindex: express constants in terms of the_hash_algo

2018-10-08 Thread brian m. carlson
Express the various constants used in terms of the_hash_algo. Signed-off-by: brian m. carlson --- pack-revindex.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pack-revindex.c b/pack-revindex.c index bb521cf7fb..3756ec71a8 100644 --- a/pack-revindex.c +++

[PATCH 12/14] apply: rename new_sha1_prefix and old_sha1_prefix

2018-10-08 Thread brian m. carlson
Rename these structure members to "new_oid_prefix" and "old_oid_prefix". Signed-off-by: brian m. carlson --- apply.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/apply.c b/apply.c index 792ecea36a..b9eb02ec12 100644 --- a/apply.c

[PATCH 13/14] submodule: make zero-oid comparison hash function agnostic

2018-10-08 Thread brian m. carlson
With SHA-256, the length of the all-zeros object ID is longer. Add a function to git-submodule.sh to check if a full hex object ID is the all-zeros value, and use it to check the output we're parsing from git diff-files or diff-index. Signed-off-by: brian m. carlson --- git-submodule.sh | 7

[PATCH 14/14] rerere: convert to use the_hash_algo

2018-10-08 Thread brian m. carlson
Since this data is stored in the .git directory, it makes sense for us to use the same hash algorithm for it as for everything else. Convert the remaining uses of SHA-1 to use the_hash_algo. Use GIT_MAX_RAWSZ for allocations. Rename various struct members, local variables, and a function to be

[PATCH 10/14] tag: express constant in terms of the_hash_algo

2018-10-08 Thread brian m. carlson
Signed-off-by: brian m. carlson --- tag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tag.c b/tag.c index 1db663d716..7445b8f6ea 100644 --- a/tag.c +++ b/tag.c @@ -144,7 +144,7 @@ int parse_tag_buffer(struct repository *r, struct tag *item, const void *data, u

[PATCH 09/14] transport: use parse_oid_hex instead of a constant

2018-10-08 Thread brian m. carlson
Use parse_oid_hex to compute a pointer instead of using GIT_SHA1_HEXSZ. This simplifies the code and makes it independent of the hash length. Signed-off-by: brian m. carlson --- transport.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/transport.c b/transport.c

[PATCH 01/14] pack-bitmap-write: use GIT_MAX_RAWSZ for allocation

2018-10-08 Thread brian m. carlson
Signed-off-by: brian m. carlson --- pack-bitmap-write.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pack-bitmap-write.c b/pack-bitmap-write.c index fc82f37a02..6f0c78d6aa 100644 --- a/pack-bitmap-write.c +++ b/pack-bitmap-write.c @@ -37,7 +37,7 @@ struct bitmap_writer {

[PATCH 04/14] builtin/fetch-pack: remove constants with parse_oid_hex

2018-10-08 Thread brian m. carlson
Instead of using GIT_SHA1_HEXSZ, use parse_oid_hex to compute a pointer and use that in comparisons. This is both simpler to read and works independent of the hash length. Update references to SHA-1 in the same function to refer to object IDs instead. Signed-off-by: brian m. carlson ---

[PATCH 08/14] upload-pack: express constants in terms of the_hash_algo

2018-10-08 Thread brian m. carlson
Convert all uses of the GIT_SHA1_HEXSZ to use the_hash_algo so that they are appropriate for any given hash length. Signed-off-by: brian m. carlson --- upload-pack.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/upload-pack.c b/upload-pack.c index

[PATCH 06/14] packfile: express constants in terms of the_hash_algo

2018-10-08 Thread brian m. carlson
Replace uses of GIT_SHA1_RAWSZ with references to the_hash_algo to avoid dependence on a particular hash length. Signed-off-by: brian m. carlson --- packfile.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packfile.c b/packfile.c index 841b36182f..17f993b5bf 100644

[PATCH 00/14] Hash function transition part 15

2018-10-08 Thread brian m. carlson
This is the fifteenth series in the ongoing hash function transition. This series includes several conversions to use the_hash_algo, combined with some use of parse_oid_hex and GIT_MAX_RAWSZ. None of the transformations here are especially surprising. brian m. carlson (14): pack-bitmap-write:

[PATCH 03/14] builtin/mktree: remove hard-coded constant

2018-10-08 Thread brian m. carlson
Instead of using a hard-coded constant for the size of a hex object ID, switch to use the computed pointer from parse_oid_hex that points after the parsed object ID. Signed-off-by: brian m. carlson --- builtin/mktree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 02/14] builtin/repack: replace hard-coded constant

2018-10-08 Thread brian m. carlson
Signed-off-by: brian m. carlson --- builtin/repack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/repack.c b/builtin/repack.c index c6a7943d5c..e77859062d 100644 --- a/builtin/repack.c +++ b/builtin/repack.c @@ -407,8 +407,8 @@ int cmd_repack(int argc, const

Re: [PATCH v2 1/2] editorconfig: provide editor settings for Git developers

2018-10-08 Thread brian m. carlson
On Mon, Oct 08, 2018 at 10:53:52PM +0200, Ævar Arnfjörð Bjarmason wrote: > > It looks like we can add at least "pm" and "pl" to that pattern: Sure. I didn't think we had any of those, but you've just proven me wrong. I'll send a v3 shortly. -- brian m. carlson: Houston, Texas, US OpenPGP:

[PATCH] unpack-trees: allow missing CE_SKIP_WORKTREE objs

2018-10-08 Thread Jonathan Tan
Whenever a sparse checkout occurs, the existence of all blobs in the index is verified, whether or not they are included or excluded by the .git/info/sparse-checkout specification. This degrades performance, significantly in the case of a partial clone, because a lazy fetch occurs whenever the

Re: [PATCH v2 1/2] editorconfig: provide editor settings for Git developers

2018-10-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Oct 08 2018, brian m. carlson wrote: > Contributors to Git use a variety of editors, each with their own > configuration files. Because C lacks the defined norms on how to indent > and style code that other languages, such as Ruby and Rust, have, it's > possible for various

[PATCH v2 0/2] EditorConfig file

2018-10-08 Thread brian m. carlson
This series introduces an EditorConfig file to help developers using any editor set their editor's settings in conformance with the Git Project's settings. This is helpful for developers who work on different projects with different indentation standards to keep their work in sync. Changes since

[PATCH v2 1/2] editorconfig: provide editor settings for Git developers

2018-10-08 Thread brian m. carlson
Contributors to Git use a variety of editors, each with their own configuration files. Because C lacks the defined norms on how to indent and style code that other languages, such as Ruby and Rust, have, it's possible for various contributors, especially new ones, to have configured their editor

[PATCH v2 2/2] editorconfig: indicate settings should be kept in sync

2018-10-08 Thread brian m. carlson
Now that we have two places where we set code formatting settings, .editorconfig and .clang-format, it's possible that they could fall out of sync. This is relatively unlikely, since we're not likely to change the tab width or our preference for tabs, but just in case, add comments to both files

Re: What's so special about objects/17/ ?

2018-10-08 Thread Stefan Beller
On Sun, Oct 7, 2018 at 1:07 PM Junio C Hamano wrote: > > Junio C Hamano writes: > > ... > > by general public and I do not have to explain the choice to the > > general public ;-) > > One thing that is more important than "why not 00 but 17?" to answer > is why a hardcoded number rather than a

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-08 Thread Derrick Stolee
On 10/8/2018 2:10 PM, SZEDER Gábor wrote: On Mon, Oct 08, 2018 at 12:57:34PM -0400, Derrick Stolee wrote: Nice! These numbers make sense to me, in terms of how many TREESAME queries we actually need to perform for such a query. Yeah... because you didn't notice that I deliberately cheated :)

Re: t3404.6 breaks on master under GIT_FSMONITOR_TEST

2018-10-08 Thread Ben Peart
On 10/8/2018 10:19 AM, Ævar Arnfjörð Bjarmason wrote: On Thu, Sep 06 2018, Ævar Arnfjörð Bjarmason wrote: On Thu, Feb 01 2018, Ævar Arnfjörð Bjarmason wrote: The GIT_FSMONITOR_TEST variable allows you to roundtrip the fsmonitor codpath in the whole test suite. On both Debian & CentOS

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-08 Thread SZEDER Gábor
On Mon, Oct 08, 2018 at 12:57:34PM -0400, Derrick Stolee wrote: > On 10/8/2018 12:41 PM, SZEDER Gábor wrote: > >On Wed, Oct 03, 2018 at 03:18:05PM -0400, Jeff King wrote: > >>I'm still excited about the prospect of a bloom filter for paths which > >>each commit touches. I think that's the next big

[PATCH v5 0/4] Filter alternate references

2018-10-08 Thread Taylor Blau
Hi, Attached is (what I anticipate to be) the final re-roll of my series to introduce 'core.alternateRefsCommand' and 'core.alternateRefsPrefixes' in order to limit the ".have" advertisement when pushing over protocol v1 to a repository with configured alternates. Not much has changed from last

[PATCH v5 4/4] transport.c: introduce core.alternateRefsPrefixes

2018-10-08 Thread Taylor Blau
The recently-introduced "core.alternateRefsCommand" allows callers to specify with high flexibility the tips that they wish to advertise from alternates. This flexibility comes at the cost of some inconvenience when the caller only wishes to limit the advertisement to one or more prefixes. For

[PATCH v5 2/4] transport.c: extract 'fill_alternate_refs_command'

2018-10-08 Thread Taylor Blau
To list alternate references, 'read_alternate_refs' creates a child process running 'git for-each-ref' in the alternate's Git directory. Prepare to run other commands besides 'git for-each-ref' by introducing and moving the relevant code from 'read_alternate_refs' to

[PATCH v5 3/4] transport.c: introduce core.alternateRefsCommand

2018-10-08 Thread Taylor Blau
When in a repository containing one or more alternates, Git would sometimes like to list references from those alternates. For example, 'git receive-pack' lists the "tips" pointed to by references in those alternates as special ".have" references. Listing ".have" references is designed to make

[PATCH v5 1/4] transport: drop refnames from for_each_alternate_ref

2018-10-08 Thread Taylor Blau
From: Jeff King None of the current callers use the refname parameter we pass to their callbacks. In theory somebody _could_ do so, but it's actually quite weird if you think about it: it's a ref in somebody else's repository. So the name has no meaning locally, and in fact there may be

I want you to Distribute my funds to less priviledge if interested reply now

2018-10-08 Thread Shill Sheila Johnson

Re: [PATCH v11 8/8] list-objects-filter: implement filter tree:0

2018-10-08 Thread Matthew DeVore
On Sat, Oct 6, 2018 at 5:10 PM Junio C Hamano wrote: > > As output made inside test_expect_{succcess,failure} are discarded > by default and shown while debugging tests, there is no strong > reason to use "grep -q" in our tests. I saw a few instances of > "grep -q" added in this series including

Re: [PATCH][Outreachy] remove all the inclusions of git-compat-util.h in header files

2018-10-08 Thread Derrick Stolee
On 10/8/2018 1:05 PM, Ananya Krishna Maram wrote: Hi All, Hello, Ananya! Welcome. I was searching through #leftovers and found this. https://public-inbox.org/git/cabpp-bgvvxcbzx44er6to-pusfen_6gnyj1u5cuon9deaa4...@mail.gmail.com/ This patch address the task discussed in the above link. The

[PATCH][Outreachy] remove all the inclusions of git-compat-util.h in header files

2018-10-08 Thread Ananya Krishna Maram
Hi All, I was searching through #leftovers and found this. https://public-inbox.org/git/cabpp-bgvvxcbzx44er6to-pusfen_6gnyj1u5cuon9deaa4...@mail.gmail.com/ This patch address the task discussed in the above link. From: Ananya Krishan Maram skip the #include of git-compat-util.h since all .c

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-08 Thread Derrick Stolee
On 10/8/2018 12:41 PM, SZEDER Gábor wrote: On Wed, Oct 03, 2018 at 03:18:05PM -0400, Jeff King wrote: I'm still excited about the prospect of a bloom filter for paths which each commit touches. I think that's the next big frontier in getting things like "git log -- path" to a reasonable

Re: We should add a "git gc --auto" after "git clone" due to commit graph

2018-10-08 Thread SZEDER Gábor
On Wed, Oct 03, 2018 at 03:18:05PM -0400, Jeff King wrote: > I'm still excited about the prospect of a bloom filter for paths which > each commit touches. I think that's the next big frontier in getting > things like "git log -- path" to a reasonable run-time. There is certainly potential there.

Loan

2018-10-08 Thread Lawrence corporate loan
-- Are you a Business Owner or a Financial Consultant looking for a Business loan or are you looking for a Personal loan. Our interest rates are affordable, ranging from 3% to 4.5% interest rate per annual depends on the loan type. If interested, please contact us today here on email:

Re: [PATCH v2 0/5] Fix the racy split index problem

2018-10-08 Thread SZEDER Gábor
On Mon, Oct 08, 2018 at 04:54:51PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> Thanks. I had ~400 runs of the tests I ran before and they were all > >> OK. Now trying also with t1701 (which I hadn't noticed was a new > >> test...). > > > > Ran that overnight with the same conditions as before.

Re:Business proposition for you

2018-10-08 Thread Melvin Greg
Hello, Business proposition for you. I have a client from Syrian who will like to invest with your company. My client is willing to invest $4 Million. Can I have your company website to show to my client your company so that they will check and decide if they will invest there funds with

[PATCH 1/3] midx: fix broken free() in close_midx()

2018-10-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee When closing a multi-pack-index, we intend to close each pack-file and free the struct packed_git that represents it. However, this line was previously freeing the array of pointers, not the pointer itself. This leads to a double-free issue. Signed-off-by: Derrick Stolee

[PATCH 0/3] Add GIT_TEST_MULTI_PACK_INDEX environment variable

2018-10-08 Thread Derrick Stolee via GitGitGadget
To increase coverage of the multi-pack-index feature, add a GIT_TEST_MULTI_PACK_INDEX environment variable similar to other GIT_TEST_* variables. After creating the environment variable and running the test suite with it enabled, I found a few bugs in the multi-pack-index implementation. These

[PATCH 3/3] multi-pack-index: define GIT_TEST_MULTI_PACK_INDEX

2018-10-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The multi-pack-index feature is tested in isolation by t5319-multi-pack-index.sh, but there are many more interesting scenarios in the test suite surrounding pack-file data shapes and interactions. Since the multi-pack-index is an optional data structure, it does not make

[PATCH 2/3] midx: close multi-pack-index on repack

2018-10-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee When repacking, we may remove pack-files. This invalidates the multi-pack-index (if it exists). Previously, we removed the multi-pack-index file before removing any pack-file. In some cases, the repack command may load the multi-pack-index into memory. This may lead to later

Re: [PATCH 1/1] commit-graph: define GIT_TEST_COMMIT_GRAPH

2018-10-08 Thread Derrick Stolee
On 10/8/2018 10:58 AM, Ævar Arnfjörð Bjarmason wrote: On Mon, Oct 08 2018, Derrick Stolee wrote: On 10/8/2018 9:43 AM, Ævar Arnfjörð Bjarmason wrote: On Tue, Aug 28 2018, Derrick Stolee via GitGitGadget wrote: From: Derrick Stolee The commit-graph feature is tested in isolation by

Re: [PATCH 1/1] commit-graph: define GIT_TEST_COMMIT_GRAPH

2018-10-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Oct 08 2018, Derrick Stolee wrote: > On 10/8/2018 9:43 AM, Ævar Arnfjörð Bjarmason wrote: >> On Tue, Aug 28 2018, Derrick Stolee via GitGitGadget wrote: >> >>> From: Derrick Stolee >>> >>> The commit-graph feature is tested in isolation by >>> t5318-commit-graph.sh and

Re: [PATCH v2 0/5] Fix the racy split index problem

2018-10-08 Thread Ævar Arnfjörð Bjarmason
On Fri, Sep 28 2018, Ævar Arnfjörð Bjarmason wrote: > On Thu, Sep 27 2018, Ævar Arnfjörð Bjarmason wrote: > >> On Thu, Sep 27 2018, SZEDER Gábor wrote: >> >>> On Thu, Sep 27, 2018 at 03:53:24PM +0200, Ævar Arnfjörð Bjarmason wrote: On Thu, Sep 27 2018, SZEDER Gábor wrote: >

[PATCH v4 1/1] contrib: add coverage-diff script

2018-10-08 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee We have coverage targets in our Makefile for using gcov to display line coverage based on our test suite. The way I like to do it is to run: make coverage-test make coverage-report This leaves the repo in a state where every X.c file that was covered has an

[PATCH v4 0/1] contrib: Add script to show uncovered "new" lines

2018-10-08 Thread Derrick Stolee via GitGitGadget
We have coverage targets in our Makefile for using gcov to display line coverage based on our test suite. The way I like to do it is to run: make coverage-test make coverage-report This leaves the repo in a state where every X.c file that was covered has an X.c.gcov file containing the coverage

Re: [PATCH 1/1] commit-graph: define GIT_TEST_COMMIT_GRAPH

2018-10-08 Thread Derrick Stolee
On 10/8/2018 9:43 AM, Ævar Arnfjörð Bjarmason wrote: On Tue, Aug 28 2018, Derrick Stolee via GitGitGadget wrote: From: Derrick Stolee The commit-graph feature is tested in isolation by t5318-commit-graph.sh and t6600-test-reach.sh, but there are many more interesting scenarios involving

Re: t3404.6 breaks on master under GIT_FSMONITOR_TEST

2018-10-08 Thread Ævar Arnfjörð Bjarmason
On Thu, Sep 06 2018, Ævar Arnfjörð Bjarmason wrote: > On Thu, Feb 01 2018, Ævar Arnfjörð Bjarmason wrote: > >> The GIT_FSMONITOR_TEST variable allows you to roundtrip the fsmonitor >> codpath in the whole test suite. On both Debian & CentOS this breaks for >> me: >> >> (cd t &&

RE:

2018-10-08 Thread Inderpreet Saini
unsubscribe git

Re: [PATCH 1/1] commit-graph: define GIT_TEST_COMMIT_GRAPH

2018-10-08 Thread Ævar Arnfjörð Bjarmason
On Tue, Aug 28 2018, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee > > The commit-graph feature is tested in isolation by > t5318-commit-graph.sh and t6600-test-reach.sh, but there are many > more interesting scenarios involving commit walks. Many of these > scenarios are

Re: [PATCH v4 4/4] rebase --skip: clean up commit message after a failed fixup/squash

2018-10-08 Thread Phillip Wood
Hi Johannes On 02/10/2018 14:50, Johannes Schindelin wrote: Hi Phillip, [sorry, I just got to this mail now] Don't worry, I'm impressed you remembered it, I'd completely forgotten about it. On Sun, 6 May 2018, Phillip Wood wrote: On 27/04/18 21:48, Johannes Schindelin wrote: During

[no subject]

2018-10-08 Thread Netravnen
unsubscribe git

Translation to Portuguese

2018-10-08 Thread Thiago Saife
Hello Git Team. I would like to help to continue the books' translation to Brazilian Portuguese and I don't know how to proceed. Thanks in advance for your help. Regards, -- Thiago Saife (11) 97236-8742

Re: [PATCH v6 08/10] submodule: add a helper to check if it is safe to write to .gitmodules

2018-10-08 Thread Antonio Ospite
On Sun, 07 Oct 2018 08:44:20 +0900 Junio C Hamano wrote: > Stefan Beller writes: > > >> static int module_config(int argc, const char **argv, const char *prefix) > >> { > >> + enum { > >> + CHECK_WRITEABLE = 1 > >> + } command = 0; > > > > Can we have the default

Re: What's so special about objects/17/ ?

2018-10-08 Thread Ævar Arnfjörð Bjarmason
On Sun, Oct 07 2018, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> 1. We still have this check of objects/17/ in builtin/gc.c today. Why >>objects/17/ and not e.g. objects/00/ to go with other 000* magic such >>as the SHA-1?d