Re: email as a bona fide git transport

2019-10-19 Thread Vegard Nossum
On 10/20/19 5:17 AM, Willy Tarreau wrote: On Fri, Oct 18, 2019 at 03:14:56PM -0400, Theodore Y. Ts'o wrote: On Fri, Oct 18, 2019 at 06:50:51PM +0200, Vegard Nossum wrote: The problem I ran into with putting the metadata at the end was detecting where the diff ends. A comment in 'git apply' su

Re: email as a bona fide git transport

2019-10-19 Thread Laurent Pinchart
On Thu, Oct 17, 2019 at 06:30:29PM -0700, Greg KH wrote: > On Thu, Oct 17, 2019 at 04:45:32PM -0400, Konstantin Ryabitsev wrote: > > On Thu, Oct 17, 2019 at 01:43:43PM -0700, Greg KH wrote: > >>> I wonder if it'd be also possible to then embed gpg signatures over > >>> send-mail payloads so as they

Re: email as a bona fide git transport

2019-10-19 Thread Willy Tarreau
On Fri, Oct 18, 2019 at 03:14:56PM -0400, Theodore Y. Ts'o wrote: > On Fri, Oct 18, 2019 at 06:50:51PM +0200, Vegard Nossum wrote: > > The problem I ran into with putting the metadata at the end was > > detecting where the diff ends. A comment in 'git apply' suggested that > > detecting the differe

Re: [PATCH v4] Doc: Bundle file usage

2019-10-19 Thread Jeff King
On Fri, Oct 18, 2019 at 09:30:52PM +0100, Philip Oakley wrote: > +`git clone` can use any bundle created without negative refspecs > +(e.g., `new`, but not `old..new`). > +If you want to match `git clone --mirror`, which would clone other > +refs such as `refs/remotes/*`, use `--all`. > +If you wa

Re: [BUG]: Testsuite failures on big-endian targets

2019-10-19 Thread Todd Zullinger
Hello, [+cc: Ævar] John Paul Adrian Glaubitz wrote: > The testsuite is failing again on s390x and all other big-endian targets in > Debian. For a full build log on s390x see [1]. > > Adrian > >> [1] >> https://buildd.debian.org/status/fetch.php?pkg=git&arch=s390x&ver=1%3A2.24.0%7Erc0-1&stamp=1

Re: [PATCH] test-progress: fix test failures on big-endian systems

2019-10-19 Thread Todd Zullinger
Hi, John Paul Adrian Glaubitz wrote: > Hi Gábor! > > On 10/20/19 1:37 AM, SZEDER Gábor wrote: >> On Sat, Oct 19, 2019 at 11:38:40PM +0200, John Paul Adrian Glaubitz wrote: >>> The testsuite is failing again on s390x and all other big-endian targets in >>> Debian. For a full build log on s390x see

Re: [PATCH] test-progress: fix test failures on big-endian systems

2019-10-19 Thread John Paul Adrian Glaubitz
Hi Gábor! On 10/20/19 1:37 AM, SZEDER Gábor wrote: > On Sat, Oct 19, 2019 at 11:38:40PM +0200, John Paul Adrian Glaubitz wrote: >> The testsuite is failing again on s390x and all other big-endian targets in >> Debian. For a full build log on s390x see [1]. > > Gah, my progress display fixes strik

[PATCH] test-progress: fix test failures on big-endian systems

2019-10-19 Thread SZEDER Gábor
On Sat, Oct 19, 2019 at 11:38:40PM +0200, John Paul Adrian Glaubitz wrote: > The testsuite is failing again on s390x and all other big-endian targets in > Debian. For a full build log on s390x see [1]. Gah, my progress display fixes strike again... I think the patch below should fix it, but I cou

Re: [PATCH v2 9/9] pack-objects: improve partial packfile reuse

2019-10-19 Thread Jeff King
On Sat, Oct 19, 2019 at 09:20:11PM +0200, Christian Couder wrote: > > > +static void write_reused_pack_one(size_t pos, struct hashfile *out, > > > + struct pack_window **w_curs) > > > +{ > > > + off_t offset, next, cur; > > > + enum object_type type; > > > +

Re: [PATCH v2 5/9] pack-bitmap: introduce bitmap_walk_contains()

2019-10-19 Thread Jeff King
On Sat, Oct 19, 2019 at 04:25:19PM +0100, Philip Oakley wrote: > > +int bitmap_walk_contains(struct bitmap_index *bitmap_git, > > +struct bitmap *bitmap, const struct object_id *oid) > > +{ > > + int idx; > Excuse my ignorance here... > > For the case on Windows (int/long 32

Re: [BUG]: Testsuite failures on big-endian targets

2019-10-19 Thread John Paul Adrian Glaubitz
Hi! On 7/31/19 9:17 AM, Todd Zullinger wrote: >> Build logs are: >> >>> https://buildd.debian.org/status/fetch.php?pkg=git&arch=s390x&ver=1%3A2.23.0%7Erc0-1&stamp=1564449102&raw=0 >>> https://buildd.debian.org/status/fetch.php?pkg=git&arch=s390x&ver=1%3A2.23.0%7Erc0%2Bnext.20190729-1&stamp=1564449

Re: [PATCH v2 5/9] pack-bitmap: introduce bitmap_walk_contains()

2019-10-19 Thread Philip Oakley
Hi Christian, On 19/10/2019 19:55, Christian Couder wrote: Hi Philip, On Sat, Oct 19, 2019 at 5:25 PM Philip Oakley wrote: Hi Christian, can I check one thing? Yeah, sure! Thanks for taking a look at my patches! On 19/10/2019 11:35, Christian Couder wrote: +int bitmap_walk_contains(struct

Re: [PATCH v2 9/9] pack-objects: improve partial packfile reuse

2019-10-19 Thread Christian Couder
Hi Philip, On Sat, Oct 19, 2019 at 5:30 PM Philip Oakley wrote: > On 19/10/2019 11:35, Christian Couder wrote: > > +static void write_reused_pack_one(size_t pos, struct hashfile *out, > > + struct pack_window **w_curs) > > +{ > > + off_t offset, next, cur; > >

Re: [PATCH v2 5/9] pack-bitmap: introduce bitmap_walk_contains()

2019-10-19 Thread Christian Couder
Hi Philip, On Sat, Oct 19, 2019 at 5:25 PM Philip Oakley wrote: > > Hi Christian, > can I check one thing? Yeah, sure! Thanks for taking a look at my patches! > On 19/10/2019 11:35, Christian Couder wrote: > > +int bitmap_walk_contains(struct bitmap_index *bitmap_git, > > +

Re: [PATCH v2 9/9] pack-objects: improve partial packfile reuse

2019-10-19 Thread Philip Oakley
Hi Christian, a couple of mem_size questions? On 19/10/2019 11:35, Christian Couder wrote: From: Jeff King Let's store the chunks of the packfile that we reuse in a dynamic array of `struct reused_chunk`, and let's use a reuse_packfile_bitmap to speed up reusing parts of packfiles. The dynam

Re: [PATCH v2 5/9] pack-bitmap: introduce bitmap_walk_contains()

2019-10-19 Thread Philip Oakley
Hi Christian, can I check one thing? On 19/10/2019 11:35, Christian Couder wrote: From: Jeff King We will use this helper function in a following commit to tell us if an object is packed. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- pack-bitmap.c | 12 pack-b

Re: [PATCH v1] config/branch: state that .merge is the remote ref

2019-10-19 Thread Philip Oakley
Hi Junio, On 19/10/2019 00:11, Junio C Hamano wrote: Philip Oakley writes: branch..merge::     Defines, for the local branch , the upstream branch ref     _on the remote_ (as given by branch..remote).     The upstream ref may be different from the local branch ref. optionally s/different f

Re: [PATCH v2 01/15] t7408: replace `test_must_fail test_path_is_file`

2019-10-19 Thread Johannes Sixt
Am 19.10.19 um 00:04 schrieb Denton Liu: > diff --git a/t/t7408-submodule-reference.sh b/t/t7408-submodule-reference.sh > index 34ac28c056..9e62d43cac 100755 > --- a/t/t7408-submodule-reference.sh > +++ b/t/t7408-submodule-reference.sh > @@ -123,7 +123,7 @@ test_expect_success 'missing submodule al

[PATCH v2 8/9] builtin/pack-objects: introduce obj_is_packed()

2019-10-19 Thread Christian Couder
From: Jeff King Let's refactor the way we check if an object is packed by introducing obj_is_packed(). This function is now a simple wrapper around packlist_find(), but it will evolve in a following commit. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- builtin/pack-objects.c |

[PATCH v2 7/9] pack-objects: introduce pack.allowPackReuse

2019-10-19 Thread Christian Couder
From: Jeff King Let's make it possible to configure if we want pack reuse or not. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- Documentation/config/pack.txt | 4 builtin/pack-objects.c| 8 +++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/Doc

[PATCH v2 1/9] builtin/pack-objects: report reused packfile objects

2019-10-19 Thread Christian Couder
From: Jeff King To see when packfile reuse kicks in or not, it is useful to show reused packfile objects statistics in the output of upload-pack. Helped-by: James Ramsay Signed-off-by: Jeff King Signed-off-by: Christian Couder --- builtin/pack-objects.c | 6 -- 1 file changed, 4 insertio

[PATCH v2 9/9] pack-objects: improve partial packfile reuse

2019-10-19 Thread Christian Couder
From: Jeff King Let's store the chunks of the packfile that we reuse in a dynamic array of `struct reused_chunk`, and let's use a reuse_packfile_bitmap to speed up reusing parts of packfiles. The dynamic array of `struct reused_chunk` is useful because we need to know not just the number of zero

[PATCH v2 3/9] ewah/bitmap: introduce bitmap_word_alloc()

2019-10-19 Thread Christian Couder
From: Jeff King In a following commit we will need to allocate a variable number of bitmap words, instead of always 32, so let's add bitmap_word_alloc() for this purpose. We will also always access at least one word for each bitmap, so we want to make sure that at least one is always allocated.

[PATCH v2 4/9] pack-bitmap: don't rely on bitmap_git->reuse_objects

2019-10-19 Thread Christian Couder
From: Jeff King We will no longer compute bitmap_git->reuse_objects in a following commit, so we cannot rely on it anymore to terminate the loop early; we have to iterate to the end. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- pack-bitmap.c | 18 +++--- 1 file cha

[PATCH v2 5/9] pack-bitmap: introduce bitmap_walk_contains()

2019-10-19 Thread Christian Couder
From: Jeff King We will use this helper function in a following commit to tell us if an object is packed. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- pack-bitmap.c | 12 pack-bitmap.h | 3 +++ 2 files changed, 15 insertions(+) diff --git a/pack-bitmap.c b/pack-

[PATCH v2 6/9] csum-file: introduce hashfile_total()

2019-10-19 Thread Christian Couder
From: Jeff King We will need this helper function in a following commit to give us total number of bytes fed to the hashfile so far. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- csum-file.h | 9 + 1 file changed, 9 insertions(+) diff --git a/csum-file.h b/csum-file.h

[PATCH v2 2/9] packfile: expose get_delta_base()

2019-10-19 Thread Christian Couder
From: Jeff King In a following commit get_delta_base() will be used outside packfile.c, so let's make it non static and declare it in packfile.h. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- packfile.c | 10 +- packfile.h | 3 +++ 2 files changed, 8 insertions(+), 5 d

[PATCH v2 0/9] Rewrite packfile reuse code

2019-10-19 Thread Christian Couder
This patch series is rewriting the code that tries to reuse existing packfiles. The code in this patch series was written by GitHub, and Peff nicely provided it in the following discussion: https://public-inbox.org/git/3e56b0fd-ebe8-4057-a93a-16ebb09fb...@jramsay.com.au/ The first version of thi

Git for Windows v2.24.0-rc0 delayed a bit

2019-10-19 Thread Johannes Schindelin
Hi all, I tried pretty hard yesterday to get a preview of Git for Windows out, based on v2.24.0-rc0, but I need a bit more time. The PR at https://github.com/git-for-windows/git/pull/2360 shows where I am going, and I started the automation based on it, but it failed (and I could not monkey patch