[PATCH v4 14/22] sha1_file: make check_and_freshen_file() non static

2017-02-27 Thread Christian Couder
This function will be used in a commit soon, so let's make it available globally. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- cache.h | 3 +++ sha1_file.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/cache.h b/cache.h index 955e80913e..6b25

[PATCH v4 12/22] t1700: add tests for splitIndex.maxPercentChange

2017-02-27 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t1700-split-index.sh | 72 ++ 1 file changed, 72 insertions(+) diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh index df19b812fd..21f43903f8 100755 --- a/t/t1700

[PATCH v4 11/22] read-cache: regenerate shared index if necessary

2017-02-27 Thread Christian Couder
g tests are assuming that the shared index is regenerated only when `git update-index --split-index` is used. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- read-cache.c | 32 t/t1700-split-index.sh | 1 + 2 files changed, 33 insert

[PATCH v4 00/22] Add configuration options for split-index

2017-02-27 Thread Christian Couder
12086-1-chrisc...@tuxfamily.org/ v2: https://public-inbox.org/git/20161217145547.11748-1-chrisc...@tuxfamily.org/ v3: https://public-inbox.org/git/2016122610.17150-1-chrisc...@tuxfamily.org/ Christian Couder (22): config: mark an error message up for translation t1700: change here docu

[PATCH v4 02/22] t1700: change here document style

2017-02-27 Thread Christian Couder
This improves test indentation by getting rid of the outdated here document style. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t1700-split-index.sh | 170 - 1 file changed, 85 insertions(+), 85 deletions(-) diff --git a/t

[PATCH v4 10/22] config: add git_config_get_max_percent_split_change()

2017-02-27 Thread Christian Couder
This new function will be used in a following commit to get the value of the "splitIndex.maxPercentChange" config variable. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- cache.h | 1 + config.c | 15 +++ 2 files changed, 16 insertions(+) diff -

[PATCH v4 06/22] update-index: warn in case of split-index incoherency

2017-02-27 Thread Christian Couder
ill happen and why. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/update-index.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/builtin/update-index.c b/builtin/update-index.c index 24fdadfa4b..d74d72cc7f 100644 --- a/builtin/update-index

[PATCH v4 05/22] read-cache: add and then use tweak_split_index()

2017-02-27 Thread Christian Couder
This will make us use the split-index feature or not depending on the value of the "core.splitIndex" config variable. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- read-cache.c | 17 + 1 file changed, 17 insertions(+) diff --git a/read-cache.

[PATCH v4 08/22] Documentation/config: add information for core.splitIndex

2017-02-27 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Documentation/config.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index 015346c417..61a863adeb 100644 --- a/Documentation/config.txt +++ b/Documentation/conf

[PATCH v4 07/22] t1700: add tests for core.splitIndex

2017-02-27 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t1700-split-index.sh | 37 + 1 file changed, 37 insertions(+) diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh index cb68b8dc1e..1659986d8d 100755 --- a/t/t1700-split-index.sh +

[PATCH v4 09/22] Documentation/git-update-index: talk about core.splitIndex config var

2017-02-27 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Documentation/git-update-index.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt index 7386c93162..e091b2a409 100644 --- a/Documentation/git-

[PATCH v4 04/22] split-index: add {add,remove}_split_index() functions

2017-02-27 Thread Christian Couder
Also use the functions in cmd_update_index() in builtin/update-index.c. These functions will be used in a following commit to tweak our use of the split-index feature depending on the setting of a configuration variable. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- b

[PATCH v4 01/22] config: mark an error message up for translation

2017-02-27 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config.c b/config.c index c6b874a7bf..2ac1aa19b0 100644 --- a/config.c +++ b/config.c @@ -1728,8 +1728,8 @@ int git_config_get_untracked_cach

[PATCH v4 03/22] config: add git_config_get_split_index()

2017-02-27 Thread Christian Couder
This new function will be used in a following commit to know if we want to use the split index feature or not. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- cache.h | 1 + config.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/cache.h b/cache.h

[ANNOUNCE] Git Rev News edition 24

2017-02-23 Thread Christian Couder
Hi everyone, The 24th edition of Git Rev News is now published: https://git.github.io/rev_news/2017/02/22/edition-24/ Thanks a lot to all the contributors and helpers! Enjoy, Christian, Thomas, Jakub and Markus.

Draft of Git Rev News edition 24

2017-02-19 Thread Christian Couder
Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-24.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub

Re: Git bisect does not find commit introducing the bug

2017-02-19 Thread Christian Couder
On Sun, Feb 19, 2017 at 12:32 PM, Alex Hoffman wrote: >> At the end of the git-bisect man page (in the SEE ALSO section) there >> is a link to >> https://github.com/git/git/blob/master/Documentation/git-bisect-lk2009.txt >> which has a lot of details about how bisect works. > >

Re: Git bisect does not find commit introducing the bug

2017-02-18 Thread Christian Couder
On Sat, Feb 18, 2017 at 7:36 PM, Alex Hoffman wrote: >> But this is not how Git works. Git computes graph differences, i.e., it >> subtracts from the commits reachable from v.bad those that are reachable >> from v.good. This leaves more than just those on some path from v.good to >>

Re: [PATCH] show-branch: fix crash with long ref name

2017-02-16 Thread Christian Couder
On Wed, Feb 15, 2017 at 10:40 PM, Jeff King <p...@peff.net> wrote: > On Tue, Feb 14, 2017 at 10:29:46PM +0100, Christian Couder wrote: > >> > I notice Christian's patch added a few tests. I don't know if we'd want >> > to squash them in (I didn't mean to override his

Re: [git-for-windows] Re: Continuous Testing of Git on Windows

2017-02-14 Thread Christian Couder
On Tue, Feb 14, 2017 at 10:08 PM, Junio C Hamano wrote: > Johannes Schindelin writes: > >> On Mon, 13 Feb 2017, Junio C Hamano wrote: >> >>> Johannes Schindelin writes: >>> >>> > That is why I taught the Git for Windows

Re: [PATCH] show-branch: fix crash with long ref name

2017-02-14 Thread Christian Couder
On Tue, Feb 14, 2017 at 8:55 PM, Jeff King wrote: > On Tue, Feb 14, 2017 at 11:35:48AM -0800, Junio C Hamano wrote: > >> Jeff King writes: >> >> > This fixes the problem, but I think we can simplify it quite a bit by >> > using resolve_refdup(). Here's the patch

[PATCH] show-branch: fix crash with long ref name

2017-02-14 Thread Christian Couder
characters then the crash could appear again. Reported by: Maxim Kuvyrkov <maxim.kuvyr...@linaro.org> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/show-branch.c | 14 +++--- t/t3204-show-branch-refname.sh | 19 +++ 2 files changed, 2

Re: [BUG] Memory corruption crash with "git bisect start"

2017-02-14 Thread Christian Couder
On Tue, Feb 14, 2017 at 12:56 PM, Maxim Kuvyrkov wrote: > I'm seeing the following memory corruption crash on a script-constructed repo > when starting git bisect. I'm seeing this crash both with system git of > Ubuntu Xenial and with freshly-compiled git master from

Re: [RFH] Request for Git Merge 2017 impressions for Git Rev News

2017-02-13 Thread Christian Couder
Hi, On Sat, Feb 11, 2017 at 5:33 PM, Jakub Narębski wrote: > Hello, > > Git Rev News #24 is planned to be released on February 15. It is meant > to cover what happened during the month of January 2017 (and earely > February 2017) and the Git Merge 2017 conference that happened

Re: Git status performance on PS (command prompt)

2017-02-12 Thread Christian Couder
On Sun, Feb 12, 2017 at 5:46 PM, brian m. carlson wrote: > On Sun, Feb 12, 2017 at 04:53:47PM +0100, Mark Gaiser wrote: [...] >> I did a bit of profiling in git to figure out where this slowdown comes from. >> Callgrind tells me that "read_directory_recursive"

Re: Non-zero exit code without error

2017-02-11 Thread Christian Couder
On Wed, Feb 8, 2017 at 11:26 AM, Serdar Sahin wrote: > Hi Christian, > > > We are using a private repo (Github Enterprise). Maybe you could try 'git fast-export --anonymize ...' on it. > Let me give you the > details you requested. > > > On Git Server: git version

Re: GSoC 2017: application open, deadline = February 9, 2017

2017-02-09 Thread Christian Couder
On Thu, Feb 9, 2017 at 1:22 PM, Matthieu Moy wrote: > Matthieu Moy writes: > >> I created a Git organization and invited you + Peff as admins. Great thanks! I accepted the invite. > I'll >> start cut-and-pasting to show my good faith

Re: GSoC 2017: application open, deadline = February 9, 2017

2017-02-09 Thread Christian Couder
On Thu, Feb 9, 2017 at 11:28 AM, Siddharth Kannan wrote: > On 9 February 2017 at 15:45, Matthieu Moy > wrote: >> >> A non-quoted but yet important part of my initial email was: >> >> | So, as much as possible, I'd like to avoid being

Re: GSoC 2017: application open, deadline = February 9, 2017

2017-02-09 Thread Christian Couder
On Thu, Feb 9, 2017 at 11:15 AM, Matthieu Moy <matthieu@grenoble-inp.fr> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> On Wed, Feb 8, 2017 at 3:54 PM, Matthieu Moy >> <matthieu@grenoble-inp.fr> wrote: >>> Jeff King <p...

Re: GSoC 2017: application open, deadline = February 9, 2017

2017-02-09 Thread Christian Couder
On Wed, Feb 8, 2017 at 3:54 PM, Matthieu Moy wrote: > Jeff King writes: > >> On Mon, Jan 23, 2017 at 04:02:02PM +0100, Matthieu Moy wrote: >> >>> * We need to write the application, i.e. essentially polish and update >>> the text here:

Re: Non-zero exit code without error

2017-02-08 Thread Christian Couder
Hi, On Tue, Feb 7, 2017 at 12:27 PM, Serdar Sahin wrote: > Hi, > > When we execute the following lines, the exit code is 1, but it is > unclear what is the reason of this exit code. Do you have any idea? > > git clone --mirror --depth 50 --no-single-branch >

Re: Git clonebundles

2017-02-05 Thread Christian Couder
On Sat, Feb 4, 2017 at 6:39 PM, Shawn Pearce wrote: > On Mon, Jan 30, 2017 at 11:00 PM, Stefan Saasen wrote: >> >> Bitbucket recently added support for Mercurial’s clonebundle extension >>

Re: [RFC] Add support for downloading blobs on demand

2017-02-05 Thread Christian Couder
(Sorry for the late reply and thanks to Dscho for pointing me to this thread.) On Tue, Jan 17, 2017 at 10:50 PM, Ben Peart wrote: >> From: Jeff King [mailto:p...@peff.net] >> On Fri, Jan 13, 2017 at 10:52:53AM -0500, Ben Peart wrote: >> >> > Clone and fetch will pass a

Re: [ANNOUNCE] Git Merge Contributor Summit topic planning

2017-02-01 Thread Christian Couder
On Tue, Jan 31, 2017 at 1:59 AM, Jeff King wrote: > On Tue, Jan 31, 2017 at 01:48:05AM +0100, Jeff King wrote: > >> The list of topics is totally open. If you're coming and have something >> you'd like to present or discuss, then propose it here. If you're _not_ >> coming, you may

Re: [PATCH v3 14/21] read-cache: touch shared index files when used

2017-01-31 Thread Christian Couder
On Wed, Jan 25, 2017 at 9:52 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> Well, when we cannot freshen a loose file (with >> freshen_loose_object()), we don't warn or die, we just write the loose >

Re: [RFC] Proof of concept: Support multiple authors

2017-01-30 Thread Christian Couder
Hi, On Sun, Jan 29, 2017 at 7:06 PM, Cornelius Schumacher wrote: > This patch is a proof of concept implementation of support for > multiple authors. It adds an optional `authors` header to commits > which is set when there are authors configured in the git config. I am just

Re: Intermittent failure of t1700-split-index.sh

2017-01-26 Thread Christian Couder
On Fri, Jan 27, 2017 at 4:58 AM, Jeff King wrote: > On Fri, Jan 27, 2017 at 02:45:15AM +, Ramsay Jones wrote: > >> I can't devote any time to looking at this further tonight >> (it's 2-45am here, I'm off to bed!). Can you reproduce the >> problem, or is it just me? :) > > I can

[ANNOUNCE] Git Rev News edition 23

2017-01-25 Thread Christian Couder
Hi everyone, The 23rd edition of Git Rev News is now published: https://git.github.io/rev_news/2017/01/25/edition-23/ Thanks a lot to all the contributors and helpers! Enjoy, Christian, Thomas, Jakub and Markus.

Re: [PATCH v3 14/21] read-cache: touch shared index files when used

2017-01-25 Thread Christian Couder
On Mon, Jan 23, 2017 at 7:53 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> Also in general the split-index mode is useful when you often write >> new indexes, and in this case shared index files that are u

Re: GSoC 2017: application open, deadline = February 9, 2017

2017-01-24 Thread Christian Couder
On Tue, Jan 24, 2017 at 12:28 PM, Johannes Schindelin wrote: > Hi Matthieu, > > On Mon, 23 Jan 2017, Matthieu Moy wrote: > >> * Who's willing to mentor? > > As in the years before, I am willing to mentor. I am also willing to mentor. Thanks!

Re: [PATCH v3 14/21] read-cache: touch shared index files when used

2017-01-23 Thread Christian Couder
t; >>>> On Sun, Jan 8, 2017 at 4:46 AM, Junio C Hamano <gits...@pobox.com> wrote: >>>>> Christian Couder <christian.cou...@gmail.com> writes: >>>>> >>>>>> So what should we do if freshen_file() returns 0 which means that the >>

Re: [PATCH v3 08/21] Documentation/git-update-index: talk about core.splitIndex config var

2017-01-23 Thread Christian Couder
On Mon, Jan 9, 2017 at 12:18 PM, Duy Nguyen <pclo...@gmail.com> wrote: > On Sun, Jan 8, 2017 at 4:38 AM, Junio C Hamano <gits...@pobox.com> wrote: >> Christian Couder <christian.cou...@gmail.com> writes: >> >>> It feels strange that when I do t

Re: [RFC] what content should go in https://git-scm.com/doc/ext

2017-01-22 Thread Christian Couder
On Sat, Jan 21, 2017 at 2:55 PM, Jeff King wrote: > I'm wondering if anybody has opinions on: > > https://github.com/git/git-scm.com/pull/924 > > (and I suspect most people in this community do not read pull requests > there, hence this post). Yeah, thanks for posting it here.

Draft of Git Rev News edition 23

2017-01-21 Thread Christian Couder
Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-23.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub

Re: [PATCH] Documentation/bisect: improve on (bad|new) and (good|bad)

2017-01-15 Thread Christian Couder
On Fri, Jan 13, 2017 at 8:14 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> The following part of the description: >> >> git bisect (bad|new) [] >> git bisect (good|old) [...] >> &

[PATCH] Documentation/bisect: improve on (bad|new) and (good|bad)

2017-01-13 Thread Christian Couder
.]" should hint that there is a good reason for the way it is. But we can further clarify and complete the description by adding "" and "" to the "bad|new" and "good|old" alternatives. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Documentation/git

Re: Bug report: Documentation error in git-bisect man description

2017-01-12 Thread Christian Couder
On Fri, Jan 13, 2017 at 12:42 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Manuel Ullmann writes: >> >> Hmmm, I tend to agree, modulo a minor fix. >> >> If the description were in a context inside a paragraph like this: >>

Re: [PATCH v3 21/21] Documentation/git-update-index: explain splitIndex.*

2017-01-02 Thread Christian Couder
On Tue, Dec 27, 2016 at 8:13 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> --split-index:: >> --no-split-index:: >> - Enable or disable split index mode. If enabled, the index is >>

Re: [PATCH v3 20/21] Documentation/config: add splitIndex.sharedIndexExpire

2017-01-02 Thread Christian Couder
On Tue, Dec 27, 2016 at 8:11 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> >> --- >> Documentation/config.txt | 11 +++ >&

Re: [PATCH v3 14/21] read-cache: touch shared index files when used

2017-01-02 Thread Christian Couder
On Tue, Dec 27, 2016 at 8:10 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> +/* >> + * Signal that the shared index is used by updating its mtime. >> + * >> + * This way, shared index

Re: [PATCH v3 12/21] Documentation/config: add splitIndex.maxPercentChange

2017-01-02 Thread Christian Couder
On Tue, Dec 27, 2016 at 8:09 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> >> --- >> Documentation/config.txt | 13 + >&

Re: [PATCH v3 10/21] read-cache: regenerate shared index if necessary

2017-01-02 Thread Christian Couder
On Tue, Dec 27, 2016 at 8:08 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> + case 0: >> + return 1; /* 0% means always write a new shared index */ >> + case 100: >> +

Re: [PATCH v3 08/21] Documentation/git-update-index: talk about core.splitIndex config var

2017-01-02 Thread Christian Couder
On Tue, Dec 27, 2016 at 8:07 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> >> --- >> Documentation/git-update-index.txt | 6 ++ >

Re: [PATCH v3 06/21] t1700: add tests for core.splitIndex

2017-01-02 Thread Christian Couder
On Tue, Dec 27, 2016 at 8:04 PM, Junio C Hamano <gits...@pobox.com> wrote: > Christian Couder <christian.cou...@gmail.com> writes: > >> +test_expect_success 'set core.splitIndex config variable to true' ' >> + git config core.splitIndex true && >>

Re: [PATCH v2 00/21] Add configuration options for split-index

2016-12-26 Thread Christian Couder
On Mon, Dec 19, 2016 at 1:02 PM, Duy Nguyen <pclo...@gmail.com> wrote: > On Sat, Dec 17, 2016 at 03:55:26PM +0100, Christian Couder wrote: >> Goal >> >> >> We want to make it possible to use the split-index feature >> automatically by just settin

Re: [PATCH v3 00/21] Add configuration options for split-index

2016-12-26 Thread Christian Couder
On Mon, Dec 26, 2016 at 11:22 AM, Christian Couder <christian.cou...@gmail.com> wrote: > > Highlevel view of the patches in the series > ~~~ > > Except for patch 1/21, there are 3 big steps, one for each new > configura

[PATCH v3 16/21] read-cache: unlink old sharedindex files

2016-12-26 Thread Christian Couder
ecently used shared index file will not be deleted. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- read-cache.c | 64 +++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/read-cache.c b/read-cache.c index 9fba

[PATCH v3 13/21] sha1_file: make check_and_freshen_file() non static

2016-12-26 Thread Christian Couder
This function will be used in a commit soon, so let's make it available globally. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- cache.h | 3 +++ sha1_file.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/cache.h b/cache.h index e15b421b6f..f442

[PATCH v3 06/21] t1700: add tests for core.splitIndex

2016-12-26 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t1700-split-index.sh | 37 + 1 file changed, 37 insertions(+) diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh index 292a0720fc..db8c39f446 100755 --- a/t/t1700-split-index.sh +

[PATCH v3 07/21] Documentation/config: add information for core.splitIndex

2016-12-26 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Documentation/config.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index d51182a060..221c5982c0 100644 --- a/Documentation/config.txt +++ b/Documentation/conf

[PATCH v3 18/21] read-cache: refactor read_index_from()

2016-12-26 Thread Christian Couder
It looks better and is simpler to review when we don't compute the same things many times in the function. It will also help make the following commit simpler. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- read-cache.c | 14 -- 1 file changed, 8 insertions

[PATCH v3 08/21] Documentation/git-update-index: talk about core.splitIndex config var

2016-12-26 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Documentation/git-update-index.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt index 7386c93162..e091b2a409 100644 --- a/Documentation/git-

[PATCH v3 20/21] Documentation/config: add splitIndex.sharedIndexExpire

2016-12-26 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Documentation/config.txt | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index e0f5a77980..24e771d22e 100644 --- a/Documentation/config.txt +++ b/Documen

[PATCH v3 05/21] update-index: warn in case of split-index incoherency

2016-12-26 Thread Christian Couder
ill happen and why. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/update-index.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/builtin/update-index.c b/builtin/update-index.c index 24fdadfa4b..d74d72cc7f 100644 --- a/builtin/update-index

[PATCH v3 03/21] split-index: add {add,remove}_split_index() functions

2016-12-26 Thread Christian Couder
Also use the functions in cmd_update_index() in builtin/update-index.c. These functions will be used in a following commit to tweak our use of the split-index feature depending on the setting of a configuration variable. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- b

[PATCH v3 15/21] config: add git_config_get_expiry() from gc.c

2016-12-26 Thread Christian Couder
This function will be used in a following commit to get the expiration time of the shared index files from the config, and it is generic enough to be put in "config.c". Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/gc.c | 15 ++- c

[PATCH v3 09/21] config: add git_config_get_max_percent_split_change()

2016-12-26 Thread Christian Couder
This new function will be used in a following commit to get the value of the "splitIndex.maxPercentChange" config variable. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- cache.h | 1 + config.c | 15 +++ 2 files changed, 16 insertions(+) diff -

[PATCH v3 11/21] t1700: add tests for splitIndex.maxPercentChange

2016-12-26 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t1700-split-index.sh | 72 ++ 1 file changed, 72 insertions(+) diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh index 507a1dd1ad..f03addf654 100755 --- a/t/t1700

[PATCH v3 14/21] read-cache: touch shared index files when used

2016-12-26 Thread Christian Couder
. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- read-cache.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/read-cache.c b/read-cache.c index a1aaec5135..9fbad2044b 100644 --- a/read-cache.c +++ b/read-cache.c @@ -1682,6 +1682,19 @@ int do_read_index(

[PATCH v3 21/21] Documentation/git-update-index: explain splitIndex.*

2016-12-26 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Documentation/config.txt | 6 +++--- Documentation/git-update-index.txt | 37 + 2 files changed, 32 insertions(+), 11 deletions(-) diff --git a/Documentation/config.txt b/Documen

[PATCH v3 17/21] t1700: test shared index file expiration

2016-12-26 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t1700-split-index.sh | 44 1 file changed, 44 insertions(+) diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh index f03addf654..f448fc13cd 100755 --- a/t/t1700-split-in

[PATCH v3 10/21] read-cache: regenerate shared index if necessary

2016-12-26 Thread Christian Couder
g tests are assuming that the shared index is regenerated only when `git update-index --split-index` is used. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- read-cache.c | 32 t/t1700-split-index.sh | 1 + 2 files changed, 33 insert

[PATCH v3 04/21] read-cache: add and then use tweak_split_index()

2016-12-26 Thread Christian Couder
This will make us use the split-index feature or not depending on the value of the "core.splitIndex" config variable. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- read-cache.c | 17 + 1 file changed, 17 insertions(+) diff --git a/read-cache.

[PATCH v3 19/21] read-cache: use freshen_shared_index() in read_index_from()

2016-12-26 Thread Christian Couder
one. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- read-cache.c | 1 + t/t1700-split-index.sh | 14 +++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/read-cache.c b/read-cache.c index 98ef1323d6..bf0ac1ce61 100644 --- a/read-cache.c +++

[PATCH v3 12/21] Documentation/config: add splitIndex.maxPercentChange

2016-12-26 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Documentation/config.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index 221c5982c0..e0f5a77980 100644 --- a/Documentation/config.txt +++ b/Documen

[PATCH v3 01/21] config: mark an error message up for translation

2016-12-26 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config.c b/config.c index 83fdecb1bc..2eaf8ad77a 100644 --- a/config.c +++ b/config.c @@ -1701,8 +1701,8 @@ int git_config_get_untracked_cach

[PATCH v3 00/21] Add configuration options for split-index

2016-12-26 Thread Christian Couder
https://public-inbox.org/git/20161023092648.12086-1-chrisc...@tuxfamily.org/ v2: https://public-inbox.org/git/20161217145547.11748-1-chrisc...@tuxfamily.org/ Christian Couder (21): config: mark an error message up for translation config: add git_config_get_split_index() split-index: add {a

[PATCH v3 02/21] config: add git_config_get_split_index()

2016-12-26 Thread Christian Couder
This new function will be used in a following commit to know if we want to use the split index feature or not. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- cache.h | 1 + config.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/cache.h b/cache.h

Re: [PATCH v2 16/21] read-cache: unlink old sharedindex files

2016-12-26 Thread Christian Couder
On Mon, Dec 19, 2016 at 12:58 PM, Duy Nguyen <pclo...@gmail.com> wrote: > On Sat, Dec 17, 2016 at 03:55:42PM +0100, Christian Couder wrote: >> +static int clean_shared_index_files(const char *current_hex) >> +{ >> + struct dirent *de; >> +

Re: [PATCH v2 10/21] read-cache: regenerate shared index if necessary

2016-12-26 Thread Christian Couder
On Mon, Dec 19, 2016 at 12:48 PM, Duy Nguyen <pclo...@gmail.com> wrote: > On Sat, Dec 17, 2016 at 03:55:36PM +0100, Christian Couder wrote: >> +static const int default_max_percent_split_change = 20; >> + >> +static int too_many_not_shared_entries(struct index_state *i

Re: [PATCH v2 04/21] read-cache: add and then use tweak_split_index()

2016-12-26 Thread Christian Couder
On Mon, Dec 19, 2016 at 12:18 PM, Duy Nguyen <pclo...@gmail.com> wrote: > On Sat, Dec 17, 2016 at 03:55:30PM +0100, Christian Couder wrote: >> +static void tweak_split_index(struct index_state *istate) >> +{ >> + switch (git_config_get_split_index()) { >> +

Re: [PATCH v2 02/21] config: add git_config_get_split_index()

2016-12-26 Thread Christian Couder
On Mon, Dec 19, 2016 at 12:14 PM, Duy Nguyen <pclo...@gmail.com> wrote: > On Sat, Dec 17, 2016 at 03:55:28PM +0100, Christian Couder wrote: >> diff --git a/config.c b/config.c >> index 2eaf8ad77a..c1343bbb3e 100644 >> --- a/config.c >> +++ b/confi

Re: [PATCH v2 00/21] Add configuration options for split-index

2016-12-17 Thread Christian Couder
> The previous versions were: > > RFC: https://github.com/chriscool/git/commits/config-split-index7 > v1: https://github.com/chriscool/git/commits/config-split-index72 The diff since v1 is: diff --git a/Documentation/config.txt b/Documentation/config.txt index 8fbef25cb1..52a3cac4ff 100644

[PATCH v2 19/21] read-cache: use freshen_shared_index() in read_index_from()

2016-12-17 Thread Christian Couder
one. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- read-cache.c | 1 + t/t1700-split-index.sh | 14 +++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/read-cache.c b/read-cache.c index 96e097e341..35377f0a3e 100644 --- a/read-cache.c +++

[PATCH v2 10/21] read-cache: regenerate shared index if necessary

2016-12-17 Thread Christian Couder
g tests are assuming that the shared index is regenerated only when `git update-index --split-index` is used. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- read-cache.c | 32 t/t1700-split-index.sh | 1 + 2 files changed, 33 insert

[PATCH v2 11/21] t1700: add tests for splitIndex.maxPercentChange

2016-12-17 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t1700-split-index.sh | 72 ++ 1 file changed, 72 insertions(+) diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh index 507a1dd1ad..f03addf654 100755 --- a/t/t1700

[PATCH v2 18/21] read-cache: refactor read_index_from()

2016-12-17 Thread Christian Couder
It looks better and is simpler to review when we don't compute the same things many times in the function. It will also help make the following commit simpler. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- read-cache.c | 14 -- 1 file changed, 8 insertions

[PATCH v2 04/21] read-cache: add and then use tweak_split_index()

2016-12-17 Thread Christian Couder
This will make us use the split-index feature or not depending on the value of the "core.splitIndex" config variable. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- read-cache.c | 17 + 1 file changed, 17 insertions(+) diff --git a/read-cache.

[PATCH v2 14/21] read-cache: touch shared index files when used

2016-12-17 Thread Christian Couder
. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- read-cache.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/read-cache.c b/read-cache.c index 280b01bd6c..42688261f7 100644 --- a/read-cache.c +++ b/read-cache.c @@ -1685,6 +1685,19 @@ int do_read_index(

[PATCH v2 15/21] config: add git_config_get_expiry() from gc.c

2016-12-17 Thread Christian Couder
This function will be used in a following commit to get the expiration time of the shared index files from the config, and it is generic enough to be put in "config.c". Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/gc.c | 15 ++- c

[PATCH v2 21/21] Documentation/git-update-index: explain splitIndex.*

2016-12-17 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Documentation/config.txt | 6 +++--- Documentation/git-update-index.txt | 37 + 2 files changed, 32 insertions(+), 11 deletions(-) diff --git a/Documentation/config.txt b/Documen

[PATCH v2 07/21] Documentation/config: add information for core.splitIndex

2016-12-17 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Documentation/config.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index a0ab66aae7..dc44d8a417 100644 --- a/Documentation/config.txt +++ b/Documentation/conf

[PATCH v2 16/21] read-cache: unlink old sharedindex files

2016-12-17 Thread Christian Couder
ecently used shared index file will not be deleted. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- read-cache.c | 63 +++- 1 file changed, 62 insertions(+), 1 deletion(-) diff --git a/read-cache.c b/read-cache.c index 4268

[PATCH v2 20/21] Documentation/config: add splitIndex.sharedIndexExpire

2016-12-17 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- Documentation/config.txt | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index 08f638c65c..8fbef25cb1 100644 --- a/Documentation/config.txt +++ b/Documen

[PATCH v2 03/21] split-index: add {add,remove}_split_index() functions

2016-12-17 Thread Christian Couder
Also use the functions in cmd_update_index() in builtin/update-index.c. These functions will be used in a following commit to tweak our use of the split-index feature depending on the setting of a configuration variable. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- b

[PATCH v2 13/21] sha1_file: make check_and_freshen_file() non static

2016-12-17 Thread Christian Couder
This function will be used in a commit soon, so let's make it available globally. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- cache.h | 3 +++ sha1_file.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/cache.h b/cache.h index e15b421b6f..f442

[PATCH v2 17/21] t1700: test shared index file expiration

2016-12-17 Thread Christian Couder
Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- t/t1700-split-index.sh | 44 1 file changed, 44 insertions(+) diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh index f03addf654..f448fc13cd 100755 --- a/t/t1700-split-in

[PATCH v2 05/21] update-index: warn in case of split-index incoherency

2016-12-17 Thread Christian Couder
ill happen and why. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- builtin/update-index.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/builtin/update-index.c b/builtin/update-index.c index b75ea037dd..dc1fd0d44d 100644 --- a/builtin/update-index

[PATCH v2 00/21] Add configuration options for split-index

2016-12-17 Thread Christian Couder
ated patch series and discussions were: RFC: https://public-inbox.org/git/20160711172254.13439-1-chrisc...@tuxfamily.org/ v1: https://public-inbox.org/git/20161023092648.12086-1-chrisc...@tuxfamily.org/ Christian Couder (21): config: mark an error message up for translation

[PATCH v2 02/21] config: add git_config_get_split_index()

2016-12-17 Thread Christian Couder
This new function will be used in a following commit to know if we want to use the split index feature or not. Signed-off-by: Christian Couder <chrisc...@tuxfamily.org> --- cache.h | 1 + config.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/cache.h b/cache.h

<    5   6   7   8   9   10   11   12   13   14   >