Re: [PATCH] format-patch: clear UNINTERESTING flag before prepare_bases

2018-06-04 Thread Eduardo Habkost
e commits, > thus `git format-patch --base Z..C` won't be able to > generate > the list of prerequisite patch ids. Clear UNINTERESTING flag with > clear_object_flags solves this issue. > > Reported-by: Eduardo Habkost > Signed-off-by: Xiaolong Ye Thanks! The fix wor

format-patch: no 'prerequisite-patch-id' info when specifying commit range

2018-05-29 Thread Eduardo Habkost
Hi, I'm trying to use git-format-patch --base to generate the list of prerequisite patches for a series, but the behavior of git doesn't seem to match the documentation: When using a commit count (e.g.: "-2"), git-format-patch generates the prerequisite-patch-id lines as expected. But when

Re: [PATCH] am: add am.signoff add config variable

2016-12-29 Thread Eduardo Habkost
On Thu, Dec 29, 2016 at 01:42:13PM -0800, Junio C Hamano wrote: > Eric Wong <e...@80x24.org> writes: > > > Eduardo Habkost <ehabk...@redhat.com> wrote: > >> git-am has options to enable --message-id and --3way by default, > >> but no option to enab

Re: [PATCH v3] am: add am.signoff add config variable

2016-12-29 Thread Eduardo Habkost
On Thu, Dec 29, 2016 at 08:58:36AM +0100, Andreas Schwab wrote: > On Dez 28 2016, Eduardo Habkost <ehabk...@redhat.com> wrote: > > > @@ -32,10 +32,12 @@ OPTIONS > > If you supply directories, they will be treated as Maildirs. > > > > -s:: > > ---si

Re: [PATCH] am: add am.signoff add config variable

2016-12-29 Thread Eduardo Habkost
On Thu, Dec 29, 2016 at 08:47:01AM +, Eric Wong wrote: > Eduardo Habkost <ehabk...@redhat.com> wrote: > > git-am has options to enable --message-id and --3way by default, > > but no option to enable --signoff by default. Add a "am.signoff" > > config opt

Re: [PATCH v2] am: add am.signoff add config variable

2016-12-29 Thread Eduardo Habkost
On Thu, Dec 29, 2016 at 01:29:33PM +0530, Pranit Bauva wrote: > Hey Eduardo, > > On Thu, Dec 29, 2016 at 12:49 AM, Eduardo Habkost <ehabk...@redhat.com> wrote: > >> test_expect_success '--no-signoff overrides am.signoff' ' > >> rm -fr .git/rebase-apply &am

[PATCH v3] am: add am.signoff add config variable

2016-12-28 Thread Eduardo Habkost
git-am has options to enable --message-id and --3way by default, but no option to enable --signoff by default. Add a "am.signoff" config option. Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> --- Changes v1 -> v2: * Added documentation to Documentation/git-am.txt

Re: [PATCH v2] am: add am.signoff add config variable

2016-12-28 Thread Eduardo Habkost
On Wed, Dec 28, 2016 at 05:11:42PM -0200, Eduardo Habkost wrote: > On Wed, Dec 28, 2016 at 10:51:28AM -0800, Stefan Beller wrote: > > On Wed, Dec 28, 2016 at 10:35 AM, Eduardo Habkost <ehabk...@redhat.com> > > wrote: [...] > > > + test $(git cat-file com

Re: [PATCH v2] am: add am.signoff add config variable

2016-12-28 Thread Eduardo Habkost
On Wed, Dec 28, 2016 at 08:07:54PM +0100, Andreas Schwab wrote: > On Dez 28 2016, Eduardo Habkost <ehabk...@redhat.com> wrote: > > > diff --git a/Documentation/git-am.txt b/Documentation/git-am.txt > > index 12879e402..f22f10d40 100644 > > --- a/Documentation/git-

Re: [PATCH v2] am: add am.signoff add config variable

2016-12-28 Thread Eduardo Habkost
On Wed, Dec 28, 2016 at 10:51:28AM -0800, Stefan Beller wrote: > On Wed, Dec 28, 2016 at 10:35 AM, Eduardo Habkost <ehabk...@redhat.com> wrote: > > git-am has options to enable --message-id and --3way by default, > > but no option to enable --signoff by default. Add a &q

[PATCH v2] am: add am.signoff add config variable

2016-12-28 Thread Eduardo Habkost
git-am has options to enable --message-id and --3way by default, but no option to enable --signoff by default. Add a "am.signoff" config option. Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> --- Changes v1 -> v2: * Added documentation to Documentation/git-am.txt

Re: [PATCH] am: add am.signoff add config variable

2016-12-28 Thread Eduardo Habkost
On Wed, Dec 28, 2016 at 09:45:24AM -0800, Stefan Beller wrote: > On Wed, Dec 28, 2016 at 9:40 AM, Eduardo Habkost <ehabk...@redhat.com> wrote: > > git-am has options to enable --message-id and --3way by default, > > but no option to enable --signoff by default. Add a "am.

[PATCH] am: add am.signoff add config variable

2016-12-28 Thread Eduardo Habkost
git-am has options to enable --message-id and --3way by default, but no option to enable --signoff by default. Add a "am.signoff" config option. Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> --- builtin/am.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin/am.