Re: [RFC/PATCH] perl: bump the required Perl version to 5.10.0 from 5.8.0

Jonathan Nieder wrote: > Ævar Arnfjörð Bjarmason wrote: >> This is similar to Jeff King's jk/drop-ancient-curl series in that >> we're dropping perl releases that are rarely tested anymore, however >> unlike those patches git still works on e.g. 5.8.8 (I couldn't bu

Re: [RFC/PATCH] perl: bump the required Perl version to 5.10.0 from 5.8.0

That said, I don't have a strong opinion there. Reviewed-by: Jonathan Nieder <jrnie...@gmail.com>

Re: [PATCH] diffcore: add a filter to find a specific blob

Stefan Beller wrote: > On Thu, Dec 14, 2017 at 6:18 PM, Junio C Hamano wrote: >> I think it would make it a better companion to --pickaxe but we need >> to align its behaviour a little bit so that it plays better with the >> "--pickaxe-all" option, and also needs to hide mode

Re: [RFC PATCH v2] http: support CURLPROXY_HTTPS

Wei Shuyu wrote: > Git has been taught to support an https:// used for http.proxy when > using recent versions of libcurl. nit: commit messages use the imperative mood, as though commanding the code base to do something: Support https:// for http.proxy when using recent versions of

Re: [PATCH v2 3/5] status: add --[no-]ahead-behind to porcelain V2 output

Hi, Jeff Hostetler wrote: > --- a/builtin/commit.c > +++ b/builtin/commit.c > @@ -141,6 +141,7 @@ static int sequencer_in_use; > static int use_editor = 1, include_status = 1; > static int show_ignored_in_status, have_option_m; > static struct strbuf message = STRBUF_INIT; > +static int

Re: [PATCH v2 2/5] stat_tracking_info: return +1 when branches are not equal

Jeff Hostetler wrote: > --- a/ref-filter.c > +++ b/ref-filter.c > @@ -1239,7 +1239,7 @@ static void fill_remote_ref_details(struct used_atom > *atom, const char *refname, > *s = show_ref(>u.remote_ref.refname, refname); > else if (atom->u.remote_ref.option == RR_TRACK) { >

Re: [PATCH v2 1/5] core.aheadbehind: add new config setting

Hi, Jeff Hostetler wrote: > Created core.aheadbehind config setting and core_ahead_behind > global variable. This value defaults to true. > > This value will be used in the next few commits as the default value > for the --ahead-behind parameter. > > Signed-off-by: Jeff Hostetler

Re: [PATCH 5/5] submodule: submodule_move_head omits old argument in forced case

Stefan Beller wrote: > On Tue, Dec 19, 2017 at 2:44 PM, Jonathan Nieder <jrnie...@gmail.com> wrote: >> checkout -f >> I think I would expect this not to touch a submodule that >> hasn't changed, since that would be consistent with its >>

Re: [PATCH 5/5] submodule: submodule_move_head omits old argument in forced case

Hi, Stefan Beller wrote: > On Tue, Dec 19, 2017 at 2:44 PM, Jonathan Nieder <jrnie...@gmail.com> wrote: >> checkout -f >> I think I would expect this not to touch a submodule that >> hasn't changed, since that would be consistent with its &

Re: [PATCH 5/5] submodule: submodule_move_head omits old argument in forced case

Hi, I had trouble understanding what this fixes, so I'll try nitpicking a bit as a sideways way to address that. Stefan Beller wrote: > With the previous patch applied (fix of the same() function), This tripped me up a bit. Usually commits assume that all previous patches have already been

Re: [PATCH 3/5] t/lib-submodule-update.sh: add new test for submodule internal change

Hi, Stefan Beller wrote: > The test is marked as a failure as the fix comes in a later patch. > > Signed-off-by: Stefan Beller > --- > t/lib-submodule-update.sh | 11 +++ > 1 file changed, 11 insertions(+) I think I'd find this easier to undrestand if it were

Re: [PATCH] http: support CURLPROXY_HTTPS

Junio C Hamano wrote: > Jonathan Nieder <jrnie...@gmail.com> writes: >> Wei Shuyu wrote: >>> diff --git a/http.c b/http.c >>> index 215bebef1..32d33261c 100644 >>> --- a/http.c >>> +++ b/http.c >>> @@ -865,6 +865,11 @@ static CURL

Re: [PATCH] http: support CURLPROXY_HTTPS

Hi, Wei Shuyu wrote: > HTTP proxy over SSL is supported by curl since 7.52.0. > This is very useful for networks with protocol whitelist. > > Signed-off-by: Wei Shuyu > --- > http.c | 5 + > 1 file changed, 5 insertions(+) Thanks for writing this. Can you give an example

Re: [PATCH v3] imap-send: URI encode server folder

har <doron.be...@gmail.com> > Signed-off-by: Nicolas Morey-Chaisemartin <nmoreychaisemar...@suse.com> > Signed-off-by: Kaartic Sivaraam <kaartic.sivar...@gmail.com> > --- > imap-send.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) Thanks! Reviewed-by:

Re: feature-request: git "cp" like there is git mv.

Hi Simon, Simon Doodkin wrote: > please develop a new feature, git "cp" like there is git mv tomovefile1 > tofile2 > (to save space). > > there is a solution in https://stackoverflow.com/a/44036771/466363 > however, it is not single easy command. This sounds like a reasonable thing to add.

Re: [PATCH] diffcore: add a filter to find a specific blob

Hi, Stefan Beller wrote: > On Thu, Dec 14, 2017 at 1:22 PM, Jonathan Nieder <jrnie...@gmail.com> wrote: >> - what about mode changes? If the file became executable but the >> blob content didn't change, does that commit match? > > ./git log --find-object=$(git rev-

Re: What's cooking in git.git (Dec 2017, #03; Wed, 13)

Junio C Hamano wrote: > Jonathan Nieder <jrnie...@gmail.com> writes: >>> * sb/diff-blobfind (2017-12-12) 1 commit >>> (merged to 'next' on 2017-12-13 at 9a27a20c5f) >>> + diffcore: add a filter to find a specific blob >>> >>> "git di

Re: [PATCH] diffcore: add a filter to find a specific blob

Hi, Stefan Beller wrote: > Junio hinted at a different approach of solving this problem, which this > patch implements. Teach the diff machinery another flag for restricting > the information to what is shown. For example: > > $ ./git log --oneline --find-object=v2.0.0:Makefile > b2feb64309

Re: What's cooking in git.git (Dec 2017, #03; Wed, 13)

Hi, Junio C Hamano wrote: > * sb/diff-blobfind (2017-12-12) 1 commit > (merged to 'next' on 2017-12-13 at 9a27a20c5f) > + diffcore: add a filter to find a specific blob > > "git diff" family of commands learned --blobfind= that > allows you to limit the output only to a change that involves

Re: Q: rational for $XDG_CONFIG_HOME/git/config to be "non global" or just a bug?

Hi, Yaroslav Halchenko wrote: > Example to show that TFM outlines precedence and --global correctly: > > $> grep xdg .gitconfig .config/git/config > .gitconfig:xdg-and-user = user > .config/git/config: xdg = xdg > .config/git/config: xdg-and-user = xdg > $> git config user.xdg ; git config

Re: [PATCH 2/2] version --build-options: report commit, too, if possible

Hi, Johannes Schindelin wrote: > In particular when local tags are used (or tags that are pushed to some > fork) to build Git, it is very hard to figure out from which particular > revision a particular Git executable was built. Hm, can you say more about how this comes up in practice? I

Re: [PATCH 1/2] git version --build-options: report the build platform, too

Hi, Johannes Schindelin wrote: > From: Adric Norris > > When asking for bug reports to include the output of `git version > --build-options`, the idea is that we get a better idea of the > environment where said bug occurs. In this context, it is useful to >

Re: How hard would it be to implement sparse fetching/pulling?

Hi, Jeff Hostetler wrote: > On 12/2/2017 1:24 PM, Philip Oakley wrote: >> From: "Jeff Hostetler" >> Sent: Friday, December 01, 2017 5:23 PM >>> Discussing this feature in the context of the defense industry >>> makes me a little nervous.  (I used to be in that area.) >>

Re: [PATCH v1 1/2] t/README: remove mention of adding copyright notices

Hi, Thomas Gummerer wrote: > We generally no longer include copyright notices in new test scripts. > However t/README still mentions it as something to include at the top of > every new script. Where can I read more about this change? Was it a deliberate change or something that simply

Re: [PATCH v1 2/2] t/README: document test_cmp_rev

, 5 insertions(+) Reviewed-by: Jonathan Nieder <jrnie...@gmail.com> I admit I usually go straight to t/test-lib-functions.sh when I want to find an appropriate helper. I think this kind of introductory documentation in t/README is still useful, though. Thanks, Jonathan

Re: [PATCH] git-gui: allow Ctrl+T to toggle multiple paths (Re: [BUG] git gui can't commit multiple files)

Jonathan Nieder wrote: > From: Johannes Schindelin <johannes.schinde...@gmx.de> > Subject: git-gui: allow Ctrl+T to toggle multiple paths > > In the Unstaged Changes panel, selecting multiple lines (using > shift+click) and pressing ctrl+t to stage them causes one file t

[PATCH] git-gui: allow Ctrl+T to toggle multiple paths (Re: [BUG] git gui can't commit multiple files)

leshed out commit message] Reported-by: Timon <timo...@gmail.com> Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> Signed-off-by: Jonathan Nieder <j...@google.com> --- Hi Timon, Timon wrote: >>> On Sun, Dec 04, 2016 at 05:36:46PM +0100, Timon wrote: >&g

Re: [PATCH v2 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test

Todd Zullinger wrote: > Reviewed-by: Jonathan Nieder <jrnie...@gmail.com> > Signed-off-by: Todd Zullinger <t...@pobox.com> > --- > t/lib-git-svn.sh | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) This and the previous one are indeed still Reviewed

Re: How hard would it be to implement sparse fetching/pulling?

Jeff Hostetler wrote: > On 11/30/2017 6:43 PM, Philip Oakley wrote: >> The 'companies' problem is that it tends to force a client-server, always-on >> on-line mentality. I'm also wanting the original DVCS off-line capability to >> still be available, with _user_ control, in a generic sense, of

Re: How hard would it be to implement sparse fetching/pulling?

Hi, Jeff Hostetler wrote: > On 11/30/2017 3:03 PM, Jonathan Nieder wrote: >> One piece of missing functionality that looks intereseting to me: that >> series batches fetches of the missing blobs involved in a "git >> checkout" command: >> >> https://p

Re: [PATCH 1/2] t/lib-git-svn: whitespace cleanup

Todd Zullinger wrote: > Jonathan Nieder wrote: >> nit: it would have been a tiny bit easier to review if the commit >> message mentioned that this is only changing the indentation from an >> inconsistent space/tab mixture to tabs and isn't making any other >> changes. &

Re: [PATCH 0/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test

Todd Zullinger wrote: > These tests are not run by default nor are they enabled in travis-ci. I > don't know how much testing they get in user or other packager builds. > > I've been slowly increasing the test suite usage in fedora builds. I > ran into this while testing locally with parallel

Re: [PATCH 1/2] t/lib-git-svn: whitespace cleanup

Todd Zullinger wrote: > Subject: t/lib-git-svn: whitespace cleanup > > Signed-off-by: Todd Zullinger <t...@pobox.com> > --- > t/lib-git-svn.sh | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) Reviewed-by: Jonathan Nieder <jrnie

Re: [PATCH 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test

Hi, Todd Zullinger wrote: > Previously, setting SVNSERVE_PORT enabled several tests which require a > local svnserve daemon to be run (in t9113 & t9126). The tests share the > setup of the local svnserve via `start_svnserve()`. The function uses > the svnserve option `--listen-once` which

Re: How hard would it be to implement sparse fetching/pulling?

Hi Vitaly, Vitaly Arbuzov wrote: > I think it would be great if we high level agree on desired user > experience, so let me put a few possible use cases here. I think one thing this thread is pointing to is a lack of overview documentation about how the 'partial clone' series currently works.

Re: [PATCH] Makefile: replace perl/Makefile.PL with simple make rules

Ævar Arnfjörð Bjarmason wrote: > On Thu, Nov 30 2017, Jonathan Nieder jotted: >> Ævar Arnfjörð Bjarmason wrote: >>> * We don't build the Git(3) Git::I18N(3) etc. man pages from the >>>embedded perldoc. I suspect nobody really cares, these are mostly >>>

Re: How hard would it be to implement sparse fetching/pulling?

Hi Vitaly, Vitaly Arbuzov wrote: > Found some details here: https://github.com/jeffhostetler/git/pull/3 > > Looking at commits I see that you've done a lot of work already, > including packing, filtering, fetching, cloning etc. > What are some areas that aren't complete yet? Do you need any help

Re: [PATCH] Makefile: replace perl/Makefile.PL with simple make rules

Hi, Ævar Arnfjörð Bjarmason wrote: > Replace the perl/Makefile.PL and the fallback perl/Makefile used under > NO_PERL_MAKEMAKER=NoThanks with a much simpler implementation heavily > inspired by how the i18n infrastructure's build process works[1]. Yay! This looks exciting. One quick comment:

Re: imap-send with gmail: curl_easy_perform() failed: URL using bad/illegal format or missing URL

(+cc: Nicolas) Hi, Doron Behar wrote: > I'm trying to send a patch with the command `git imap-send`, I used the > examples in the manual page as the main reference for my configuration: > > ``` > [imap] > folder = "[Gmail]/Drafts" > host = imaps://imap.gmail.com > user =

Re: [PATCH] hashmap: adjust documentation to reflect reality

e style > here and there. > > Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> > --- > hashmap.h | 60 +--- > 1 file changed, 29 insertions(+), 31 deletions(-) Yay, thanks for this. Reviewed-by: Jonatha

Re: [PATCH on en/rename-progress v2] diffcore-rename: make diff-tree -l0 mean -l

ffcore-rename.c | 2 ++ > t/t4001-diff-rename.sh | 15 +++ > 2 files changed, 17 insertions(+) Reviewed-by: Jonathan Nieder <jrnie...@gmail.com> Thanks again. > diff --git a/diffcore-rename.c b/diffcore-rename.c > index 9ca0eaec7..245e999fe 100644

Re: [PATCH on en/rename-progress] diffcore-rename: make diff-tree -l0 mean -l

amp of renameLimit", > 2017-11-13) rather than b520abf ("sequencer: warn when internal merge > may be suboptimal due to renameLimit", 2017-11-14). > > Other than that minor issue, patch and test looks good to me. Thanks, both. Looking at that patch, the fix is obviously correct. With Elijah's commit message tweak, Reviewed-by: Jonathan Nieder <jrnie...@gmail.com>

Re: git status always modifies index?

Hi, Jeff King wrote: > On Sun, Nov 26, 2017 at 06:35:56PM +0900, Junio C Hamano wrote: >> Having a large picture option like "--read-only" instead of ending >> up with dozens of "we implemented a knob to tweak only this little >> piece, and here is an option to trigger it" would help users in

Re: git status always modifies index?

Hi, Johannes Schindelin wrote: > On Mon, 27 Nov 2017, Jeff King wrote: >> [...] IMHO it argues for GfW trying to land patches upstream first, and >> then having them trickle in as you merge upstream releases. > > You know that I tried that, and you know why I do not do that anymore: it > simply

[ANNOUNCE] Bug tracker for Git

Hi, As discussed at [1], I've occasionally wanted to have a place to keep track of bugs I'm working on in Git. Some kind people on the Chromium project helped me set an issue tracker up, so now we have one. https://crbug.com/git Feel free to file bugs, feature requests, and leftover bits

Re: [PATCH 0/3] Introduce BUG_ON(cond, msg) MACRO

Jeff King wrote: > On Wed, Nov 22, 2017 at 03:45:32PM -0800, Jonathan Nieder wrote: >> It lets you build with NDEBUG. > > But why do you want to build with NDEBUG if nothing uses assert()? ;) No idea, but some distros (not Debian) have done it before and I don't want to be burne

Re: [PATCH 1/3] Documentation/CodingGuidelines: explain why assert is bad

Stefan Beller wrote: > On Wed, Nov 22, 2017 at 2:59 PM, Jonathan Nieder <jrnie...@gmail.com> wrote: >> In a certain ideal world, the preference would be reversed: you'd want >> to use assert() wherever you can and require the compiler to check >> that all assert()s are

Re: [PATCH 0/3] Introduce BUG_ON(cond, msg) MACRO

Jeff King wrote: > Yes. I'd be fine having a single-argument BUG_ON() like that. But then, > I'm not sure what it's buying us over assert(). It lets you build with NDEBUG. It also goes through our own die() handler, which means that e.g. the error message gets propagated over remote transports.

Re: [PATCH 0/3] Introduce BUG_ON(cond, msg) MACRO

Hi, Jeff King wrote: > On Wed, Nov 22, 2017 at 02:38:24PM -0800, Stefan Beller wrote: >> On reviewing [1] I wondered why there are so many asserts and wondered >> if these asserts could have been prevented by a better functionality around >> bug reporting in our code. >> >> Introduce a BUG_ON

Re: [PATCH 2/3] git-compat: introduce BUG_ON(condition, fmt, ...) macro

Hi, Stefan Beller wrote: > --- a/git-compat-util.h > +++ b/git-compat-util.h > @@ -1092,9 +1092,13 @@ static inline int regexec_buf(const regex_t *preg, > const char *buf, size_t size, > __attribute__((format (printf, 3, 4))) NORETURN > void BUG_fl(const char *file, int line, const char *fmt,

Re: [PATCH 1/3] Documentation/CodingGuidelines: explain why assert is bad

Hi, Stefan Beller wrote: > --- a/Documentation/CodingGuidelines > +++ b/Documentation/CodingGuidelines > @@ -386,6 +386,9 @@ For C programs: > - Use Git's gettext wrappers to make the user interface > translatable. See "Marking strings for translation" in po/README. > > + - Prefer the

Re: git status always modifies index?

Jeff King wrote: > On Wed, Nov 22, 2017 at 12:27:20PM -0800, Jonathan Nieder wrote: >> That said, I wonder if this use case is an illustration that a name >> like --no-lock-index (as was used in Git for Windows when this feature >> first appeared) or --no-refresh-on-di

Re: git status always modifies index?

Hi, Nathan Neulinger wrote[1]: > I just got an answer to my stackoverflow question on this, > apparently it's already implemented: > > https://stackoverflow.com/questions/47436939/how-to-run-git-status-without-modifying-git-index-such-as-in-a-prompt-command > > There is a "--no-optional-locks"

Re: [PATCH 1/2] test-lib: add LIBPCRE1 & LIBPCRE2 prerequisites

Hi, Ævar Arnfjörð Bjarmason wrote: > Add LIBPCRE1 and LIBPCRE2 prerequisites which are true when git is > compiled with USE_LIBPCRE1=YesPlease or USE_LIBPCRE2=YesPlease, > respectively. > > The syntax of PCRE1 and PCRE2 isn't the same in all cases (see > pcresyntax(3) and pcre2syntax(3)). If

Re: [PATCH v5 5/6] rev-list: add list-objects filtering support

Hi, Jeff Hostetler wrote: > Teach rev-list to use the filtering provided by the > traverse_commit_list_filtered() interface to omit > unwanted objects from the result. > > Object filtering is only allowed when one of the "--objects*" > options are used. micronit: the line widths seem to be

Re: [PATCH][l10n-fr] list translated to prune in command

Hi, Louis Bettens wrote: > "$ git worktree" when in a french locale shows an incorrect usage > summary. This comes down to this trivial issue in the i18n. Good catch. This comes from v2.7.0-rc3~4^2~7^2~2^2 (l10n: fr v2.7.0 round 1 (2477t), 2015-12-18). For next time, you can send these three

Re: [PATCH 1/2] Git/Packet.pm: rename packet_required_key_val_read()

Junio C Hamano wrote: > Jonathan Nieder <jrnie...@gmail.com> writes: >> Junio C Hamano wrote: >>> Jonathan Nieder <jrnie...@gmail.com> writes: >>>> This comment doesn't tell me how to use the function. How do I detect >>>> whether i

Re: [PATCH 1/3] Documentation: allow overriding timestamps of generated asciidoc

Anders Kaseorg wrote: > On Tue, 21 Nov 2017, Jonathan Nieder wrote: >> http://asciidoc.org/CHANGELOG.html is stale but asciidoc still seems >> to be getting changes at https://github.com/asciidoc/asciidoc. I >> wonder how difficult it would be to add any required SOURCE_

Re: [PATCH 1/2] Git/Packet.pm: rename packet_required_key_val_read()

Junio C Hamano wrote: > Jonathan Nieder <jrnie...@gmail.com> writes: >> Christian Couder wrote: >>> +# Read a text line and check that it is in the form "key=value" >>> +sub packet_key_val_read { >> >> This comment doesn't tell

Re: Draft of Git Rev News edition 33

Hi, Christian Couder wrote: > On Tue, Nov 21, 2017 at 2:10 AM, Jonathan Nieder <jrnie...@gmail.com> wrote: >> That said, I believe that the gitattributes(5) manpage does an okay >> job of covering this and that that thread came to a clear conclusion: >> >>

Re: [PATCH 1/3] Documentation: allow overriding timestamps of generated asciidoc

Hi, brian m. carlson wrote: > On Tue, Nov 21, 2017 at 03:34:32PM -0800, Jonathan Nieder wrote: >> --- a/Documentation/Makefile >> +++ b/Documentation/Makefile >> @@ -410,6 +410,7 @@ $(patsubst %.txt,%.texi,$(MAN_TXT)): %.texi : %.xml >> howto-index.txt: howto-inde

[PATCH 3/3] generate-cmdlist: avoid non-deterministic output

instead. Signed-off-by: Jonathan Nieder <jrnie...@gmail.com> --- That's the end of the series. Thanks for reading. generate-cmdlist.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/generate-cmdlist.sh b/generate-cmdlist.sh index ab0d1b0c06..eeea4b67ea 100755 --- a/ge

[PATCH 2/3] git-gui: sort entries in optimized tclIndex

iously fixed in gitgui-0.21.0~14 (git-gui: sort entries in tclIndex, 2015-01-26). Signed-off-by: Anders Kaseorg <ande...@mit.edu> Signed-off-by: Jonathan Nieder <jrnie...@gmail.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefil

[PATCH 1/3] Documentation: allow overriding timestamps of generated asciidoc

ckages of open source projects were built from the source they were claimed to have been built from. https://reproducible-builds.org/ has more details. Signed-off-by: Anders Kaseorg <ande...@mit.edu> Signed-off-by: Jonathan Nieder <jrnie...@gmail.com> --- Perhaps this should e.g. be

[PATCH 0/3] Improving build reproducibility

ntries in optimized tclIndex Jonathan Nieder (1): generate-cmdlist: avoid non-deterministic output Documentation/Makefile | 7 +-- Documentation/technical/api-index.sh | 5 + generate-cmdlist.sh | 2 +- git-gui/Makefile | 2 +- 4 files chang

Re: stash: learn to parse -m/--message like commit does

Hi, Phil Hord wrote: > `git stash push -m foo` uses "foo" as the message for the stash. But > `git stash push -m"foo"` does not parse successfully. Similarly > `git stash push --message="My stash message"` also fails. Nothing > in the documentation suggests this syntax should work, "git help

Re: doc: prefer 'stash push' over 'stash save'

insertions(+), 2 deletions(-) Reviewed-by: Jonathan Nieder <jrnie...@gmail.com> Thanks.

Re: [PATCH] recursive submodules: detach HEAD from new state

Hi, Stefan Beller wrote: > On Tue, Nov 21, 2017 at 2:34 PM, Jonathan Nieder <jrnie...@gmail.com> wrote: >> Stefan, do you know what thread I should look at to find the current >> state of this patch? I've had it applied locally for a long time. > > It was "Unde

Re: [PATCH] recursive submodules: detach HEAD from new state

Stefan Beller wrote: >> Junio C Hamano writes: >>> Also, while I do agree with you that the problem exists, it is >>> unclear why this patch is a solution and not a hack that sweeps a >>> problem under the rug. >>> >>> It is unclear why this "silently detach HEAD without

Re: some apparent inaccuracies in "man git-worktree"

Hi, Robert P. J. Day wrote: > On Tue, 14 Nov 2017, Eric Sunshine wrote: >> On Tue, Nov 14, 2017 at 3:43 AM, Robert P. J. Day >> wrote: >>> from "man git-worktree", there seem to be some inaccuracies in the >>> SYNOPSIS regarding the "add" subcommand: >>> >>> git

Re: [PATCH 2/2] Git/Packet.pm: use 'if' instead of 'unless'

Hi, Christian Couder wrote: > The code is more understandable with 'if' instead of 'unless'. > > Signed-off-by: Christian Couder > --- > perl/Git/Packet.pm | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) I'm agnostic about that. In some ways

Re: [PATCH] notes: correct 'git notes prune' options to '[-n] [-v]'

Robert P. J. Day wrote: > Currently, 'git notes prune' in man page and usage message > incorrectly lists options as '[-n | -v]', rather than '[-n] [-v]'. > > Signed-off-by: Robert P. J. Day <rpj...@crashcourse.ca> > --- Reviewed-by: Jonathan Nieder <jrnie...@gmail.co

Re: [PATCH 1/2] Git/Packet.pm: rename packet_required_key_val_read()

Hi, Christian Couder wrote: > The function calls itself "required", but it does not die when it > sees an unexpected EOF. > Let's rename it to "packet_key_val_read()". > > Signed-off-by: Christian Couder > --- nit: please wrap lines to a consistent width, to make the

Re: [PATCH] notes: fix erroneous "git notes prune [-n | -v]" message

Robert P. J. Day wrote: > so it should simply be corrected to: > > git notes prune [-n] [-v] > > sound about right? Sounds good to me. Thanks for finding these confusing docs, by the way. Jonathan

Re: [PATCH] notes: fix erroneous "git notes prune [-n | -v]" message

Hi, Robert P. J. Day wrote: > It seems clear that the man page SYNPOSIS and the usage message > referring to: > > git notes prune [-n | -v] > > is incorrect, as "-n" (dry run) and "-v" (verbose) are not > alternatives, so fix both places to refer to: > > git notes prune [-n] [-v | -q] > > to

Re: pedantry: is there a standard for what should be in the SYNOPSIS?

Hi, Robert P. J. Day wrote: > following up on an earlier question of mine, is there a standard for > what options should be listed in either the SYNOPSIS or the > DESCRIPTION sections of a man page? i ask since i'm seeing some > definite inconsistency. No standard. Seems worth starting a

Re: [PATCH 6/8] ssh: 'auto' variant to select between 'ssh' and 'simple'

Junio C Hamano wrote: > Jonathan Nieder <jrnie...@gmail.com> writes: >> Android's "repo" tool is a tool for managing a large codebase >> consisting of multiple smaller repositories, similar to Git's >> submodule feature. Starting with Git 94b8ae5a (ssh: intr

[PATCH 1/8 v2] ssh test: make copy_ssh_wrapper_as clean up after itself

ten with '>uplink' had the wrong filename and failed. Reported-by: Johannes Schindelin <johannes.schinde...@gmx.de> Signed-off-by: Jonathan Nieder <jrnie...@gmail.com> Acked-by: Brandon Williams <bmw...@google.com> --- Jonathan Nieder wrote: > Thanks to Dscho for tracking thi

Re: [PATCH] list-objects-filter-options: fix up some sparse warnings

Hi, Ramsay Jones wrote: > If you need to re-roll your 'jh/object-filtering' branch, could you > please squash this (or something like it) into the relevant patch > (commit bf0aedcbe1, "list-objects: filter objects in traverse_commit_list", > 16-11-2017). Micronit: can these messages use the ISO

Re: Draft of Git Rev News edition 33

Hi, Yubin Ruan wrote: > 2017-11-20 16:33 GMT+08:00 Christian Couder : >> A draft of a new Git Rev News edition is available here: >> >> >> https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-33.md >> >> Everyone is welcome to contribute in any

[PATCH v4 4/8] connect: split ssh command line options into separate function

The git_connect function is growing long. Split the portion that discovers an ssh command and options it accepts before the service name and path to a separate function to make it easier to read. No functional change intended. Signed-off-by: Jonathan Nieder <jrnie...@gmail.com> Re

Re: [PATCH 4/8] connect: split ssh command line options into separate function

Hi, Brandon Williams wrote: > On 11/20, Jonathan Nieder wrote: [long stream of quoted context snipped; please cut down the quoted text to what you are replying to in the future] >> @@ -972,16 +1031,13 @@ struct child_process *git_connect(int fd[2], const >> char *url, >&

Re: [PATCH 3/8] connect: split git:// setup into a separate function

Brandon Williams wrote: > On 11/20, Jonathan Nieder wrote: >> +/* These underlying connection commands die() if they >> + * cannot connect. >> + */ > > I know this is really just code motion but maybe we can fix the style of > the comment here? How

[PATCH 8/8] ssh: 'simple' variant does not support --port

to OpenSSH would also support -G and would not require such an update.) Reported-by: William Yan <w...@google.com> Signed-off-by: Jonathan Nieder <jrnie...@gmail.com> Acked-by: Stefan Beller <sbel...@google.com> --- As before. That's the end of the series. Thanks for re

[PATCH 6/8] ssh: 'auto' variant to select between 'ssh' and 'simple'

5944c56b068bac0a77c049/lib/dpl/provider.rb#L215 Reported-by: William Yan <w...@google.com> Improved-by: Jonathan Tan <jonathanta...@google.com> Signed-off-by: Jonathan Nieder <jrnie...@gmail.com> --- Added two notes to the commit message: - describing the real-world testing this

[PATCH 7/8] ssh: 'simple' variant does not support -4/-6

If the user passes -4/--ipv4 or -6/--ipv6 to "git fetch" or "git push" and the ssh command configured with GIT_SSH does not support such a setting, error out instead of ignoring the option and continuing. Signed-off-by: Jonathan Nieder <jrnie...@gmail.com> Ack

[PATCH 5/8] connect: split ssh option computation to its own function

This puts the determination of options to pass to each ssh variant (see ssh.variant in git-config(1)) in one place. A follow-up patch will use this in an initial dry run to detect which variant to use when the ssh command is ambiguous. No functional change intended yet. Signed-off-by: Jonathan

[PATCH 4/8] connect: split ssh command line options into separate function

The git_connect function is growing long. Split the portion that discovers an ssh command and options it accepts before the service name and path to a separate function to make it easier to read. No functional change intended. Signed-off-by: Jonathan Nieder <jrnie...@gmail.com> Re

[PATCH 2/8] connect: move no_fork fallback to git_tcp_connect

ano <gits...@pobox.com> Signed-off-by: Jonathan Nieder <jrnie...@gmail.com> --- connect.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/connect.c b/connect.c index 7fbd396b35..aa994d1518 100644 --- a/connect.c +++ b/conne

[PATCH 3/8] connect: split git:// setup into a separate function

The git_connect function is growing long. Split the PROTO_GIT-specific portion to a separate function to make it easier to read. No functional change intended. Signed-off-by: Jonathan Nieder <jrnie...@gmail.com> Reviewed-by: Stefan Beller <sbel...@google.com> --- As before. con

[PATCH 1/8] ssh test: make copy_ssh_wrapper_as clean up after itself

ten with '>uplink' had the wrong filename and failed. Reported-by: Johannes Schindelin <johannes.schinde...@gmx.de> Signed-off-by: Jonathan Nieder <jrnie...@gmail.com> --- Thanks to Dscho for tracking this subtle issue down. t/t5601-clone.sh | 28

[PATCH v3 0/8] Coping with unrecognized ssh wrapper scripts in GIT_SSH

from [3] Thanks for the helpful reviews, and sorry to take so long to get this out. Thoughts of all kinds welcome, as always. Sincerely, Jonathan Nieder (8): ssh test: make copy_ssh_wrapper_as clean up after itself connect: move no_fork fallback to git_tcp_connect connect: split git:// setup

Re: [PATCH] contrib/git-jump: allow to configure the grep command

s(+) Thanks for making it clearer. Reviewed-by: Jonathan Nieder <jrnie...@gmail.com> > diff --git a/contrib/git-jump/README b/contrib/git-jump/README > index 225e3f0954..4257cef2e6 100644 > --- a/contrib/git-jump/README > +++ b/contrib/git-jump/README > @@ -92,3 +92,10 @@ how

Re: [PATCH] Makefile: check that tcl/tk is installed

Hi, Christian Couder wrote: > By default running `make install` in the root directory of the > project will set TCLTK_PATH to `wish` and then go into the "git-gui" > and "gitk-git" sub-directories to build and install these 2 > sub-projects. > > When Tcl/Tk is not installed, the above will

Re: is there a rationale for some sample hooks but not others?

Hi Robert, Robert P. J. Day wrote: > given that a newly-initialized repo contains samples for some hooks > but not others, is there a simple rationale for why those particular > sample hooks are provided, and not the rest? I assume this is in the context of reviewing the Pro Git book. Thanks

Re: [PATCH 1/5] connect: split git:// setup into a separate function

Hi, On Oct 24, 2017, Junio C Hamano wrote: > Jonathan Nieder <jrnie...@gmail.com> writes: >> +static struct child_process *git_connect_git(int fd[2], char *hostandport, >> + const char *p

Re: [PATCH] fix typos in 2.15.0 release notes

Hi, Jean Carlo Machado wrote: > --- > Documentation/RelNotes/2.15.0.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Thanks! Can we have your sign-off? (See Documentation/SubmittingPatches section 5 "Certify your work" for what this means.) Sincerely, Jonathan

Re: [PATCH 0/3] mingw: introduce a way to avoid std handle inheritance

Hi, Johannes Schindelin wrote: > On Mon, 30 Oct 2017, Jonathan Nieder wrote: >> Can this rationale go in the commit messages? > > I thought I had done exactly that in 1/3... Okay, I'll be more specific. This cover letter includes some information about the rationale

Re: [PATCH 00/13] WIP Partial clone part 1: object filtering

Hi, Jonathan Tan wrote: > As for how this patch set (excluding the partialclone patch) interacts > with my fsck series, they are relatively independent, as far as I can > tell. I'll rebase my fsck, gc, and lazy object fetch patches (but not > the fetch and clone parts, which we plan to instead

Re: [PATCH 0/3] mingw: introduce a way to avoid std handle inheritance

Hi, Johannes Schindelin wrote: > Particularly when calling Git from applications, such as Visual Studio, > it is important that stdin/stdout/stderr are closed properly. However, > when spawning processes on Windows, those handles must be marked as > inheritable if we want to use them, but that

<    1   2   3   4   5   6   7   8   9   10   >