idmap.
Signed-off-by: Jonathan Tan
---
Some replies to v1 [1] [2] seem to indicate that simpler non-duplicated
code should be preferred over optimizing away the storage of the 4-byte
hash code, and I have no objection to that, so I have updated this code
to be a thin wrapper over hashmap with
On Wed, 27 Sep 2017 18:46:30 +0200
Christian Couder wrote:
> I am ok to split the patch series, but I am not sure that 01/40 to
> 09/40 is the right range for the first patch series.
> I would say that 01/40 to 07/40 is better as it can be seen as a
> separate refactoring.
I mentioned 09/40 beca
On Tue, 26 Sep 2017 17:26:33 +0200
Michael Haggerty wrote:
> Maybe naming has been discussed at length before, and I am jumping into
> a long-settled topic. And admittedly this is bikeshedding.
>
> But I find these names obscure, even as a developer. And terms like this
> will undoubtedly bleed
ranteed to be in to_pack.
[1] For the purposes of pack_objects, a blob is a Git special file if it
appears in a to-be-packed tree with a filename beginning with
".git".
Signed-off-by: Jonathan Tan
---
builtin/pack-objects.c | 56 +---
Teach fsck to not treat missing promisor objects indirectly pointed to
by refs as an error when extensions.partialclone is set.
Signed-off-by: Jonathan Tan
---
builtin/fsck.c | 11 +++
t/t0410-partial-clone.sh | 23 +++
2 files changed, 34 insertions
ow any object type to be "want"-ed.
Signed-off-by: Jonathan Tan
---
Makefile | 1 +
builtin/fetch-pack.c | 8
builtin/index-pack.c | 16 +---
fetch-object.c | 23 +++
fetch-object.h | 6 ++
fetch-pack.c
ased on
the contents of the local repo alone, whereas for status=delayed, it is
the filter process that tells us what needs to be checked in the end.
Signed-off-by: Jonathan Tan
---
fetch-object.c | 27 +++
fetch-object.h | 5 +
t
Teach fetch-pack and upload-pack to support excluding large blobs
through a blob-max-bytes parameter.
Signed-off-by: Jonathan Tan
---
Documentation/technical/pack-protocol.txt | 9
Documentation/technical/protocol-capabilities.txt | 7 ++
builtin/fetch-pack.c
and
did not mention parsing the unparsed commit, so I prefer to preserve the
existing behavior.
Signed-off-by: Jonathan Tan
---
fetch-pack.c | 4
1 file changed, 4 insertions(+)
diff --git a/fetch-pack.c b/fetch-pack.c
index 19b8e9322..8e6f54547 100644
--- a/fetch-pack.c
+++ b/fetch-pack.c
@
Teach clone to support excluding large blobs through a blob-max-bytes
parameter.
Signed-off-by: Jonathan Tan
---
builtin/clone.c | 23 +--
t/t5601-clone.sh | 49 +
2 files changed, 70 insertions(+), 2 deletions(-)
diff --git
usion occurs.)
If bitmaps are to be used, we would not know if a blob corresponded to a
file whose name starts with ".git". For this reason, when invoked with
--blob-max-bytes, pack-objects will not use bitmaps.
Signed-off-by: Jonathan Tan
---
Documentation/git-pack-objects.txt
)
- builtin/prune-packed - check if object to be pruned is packed (if
not, don't prune it)
- revision - used to exclude packed objects if requested by user
- diff - just for optimization
Signed-off-by: Jonathan Tan
---
builtin/cat-file.c | 2 ++
builtin/fetch-pack.c | 2 ++
bu
Teach gc to stop traversal at promisor objects, and to leave promisor
packfiles alone. This has the effect of only repacking non-promisor
packfiles, and preserves the distinction between promisor packfiles and
non-promisor packfiles.
Signed-off-by: Jonathan Tan
---
builtin/gc.c | 3
Teach fetch to support excluding large blobs through a blob-max-bytes
parameter. This is only allowed for the remote configured in
extensions.partialclone.
Signed-off-by: Jonathan Tan
---
builtin/fetch.c | 22 --
connected.c | 1 +
remote-curl.c | 7
Teach fsck to not treat missing promisor objects provided on the CLI as
an error when extensions.partialclone is set.
Signed-off-by: Jonathan Tan
---
builtin/fsck.c | 2 ++
t/t0410-partial-clone.sh | 13 +
2 files changed, 15 insertions(+)
diff --git a/builtin/fsck.c b
Teach clone to configure blobmaxbytes in any repos that it generates
when the --blob-max-bytes parameter is set. Also teach fetch to use this
parameter.
Signed-off-by: Jonathan Tan
---
builtin/clone.c | 1 +
builtin/fetch.c | 4
remote.c | 2 ++
remote.h
In a subsequent commit, index-pack will be taught to write ".promisor"
files which are similar to the ".keep" files it knows how to write.
Refactor the writing of ".keep" files, so that the implementation of
writing ".promisor" files becomes easier.
Signed-
in process_blob() and
process_tree() do not need to be changed because those happen only when
there is a conflict between the expected type and the existing object.
If the object doesn't exist, an object will be synthesized, which is
fine.)
Signed-off-by: Jonathan Tan
---
builtin/rev-l
Teach fsck to not treat refs referring to missing promisor objects as an
error when extensions.partialclone is set.
For the purposes of warning about no default refs, such refs are still
treated as legitimate refs.
Signed-off-by: Jonathan Tan
---
builtin/fsck.c | 8
t/t0410
Separate out the calculation of remotes to be fetched from and the
actual fetching. This will allow us to include an additional step before
the actual fetching in a subsequent commit.
Signed-off-by: Jonathan Tan
---
builtin/fetch.c | 14 --
1 file changed, 8 insertions(+), 6
commits, fsck will be taught about other cases.
Signed-off-by: Jonathan Tan
---
Documentation/technical/repository-version.txt | 12
builtin/fsck.c | 2 +-
cache.h| 5 +-
environment.c
vertisement. All packfiles
downloaded in this way are annotated with ".promisor".
Fetching with `git fetch`
-
The fetch-pack/upload-pack protocol has also been extended to support omission
of blobs above a certain size. The client only allows this when fetching f
On Thu, 28 Sep 2017 10:33:39 -0400
Jeff Hostetler wrote:
> Maybe. What I have here now is the result of adding these arguments to
> rev-list and pack-objects (in the current patch series), and also to
> fetch-pack, fetch, clone, upload-pack, index-pack, and the transport and
> protocol code (in
On Thu, 28 Sep 2017 16:05:57 -0400
Jeff King wrote:
> When I saw that you were implementing "oidset" in terms of "oidmap", I
> was all ready to be crabby about this extra memory. But then I saw that
> the implementation tries hard not to waste any memory. :)
>
> All of which is to say I gave thi
On Fri, 15 Sep 2017 13:43:43 -0700
Jonathan Tan wrote:
> For those interested in partial clones and/or missing objects in repos,
> I've updated my original partialclone patches to not require an explicit
> list of promises. Fetch/clone still only permits exclusion of bl
On Wed, 27 Sep 2017 17:41:37 -0700
Brandon Williams wrote:
> On 09/27, Jonathan Tan wrote:
> > This is similar to using the hashmap in hashmap.c, but with an
> > easier-to-use API. In particular, custom entry comparisons no longer
> > need to be written, and lookup
On Thu, 28 Sep 2017 12:13:00 +0900
Junio C Hamano wrote:
> Jonathan Tan writes:
>
> > This is similar to using the hashmap in hashmap.c, but with an
> > easier-to-use API. In particular, custom entry comparisons no longer
> > need to be written, and lookups can be don
On Wed, 27 Sep 2017 13:09:42 -0400
Jeff Hostetler wrote:
> On 9/26/2017 6:39 PM, Jonathan Tan wrote:
> > On Fri, 22 Sep 2017 20:30:11 +
> > Jeff Hostetler wrote:
> >
> >> Makefile| 1
This is similar to using the hashmap in hashmap.c, but with an
easier-to-use API. In particular, custom entry comparisons no longer
need to be written, and lookups can be done without constructing a
temporary entry structure.
oidset has been updated to use oidmap.
Signed-off-by: Jonathan Tan
On Wed, 27 Sep 2017 15:09:43 -0400
Jeff Hostetler wrote:
> By adding it to the set of provisionally omitted objects, we
> have the option to capture a little extra information with it
> and refer to that the next time we see the object in the traversal.
> For example, in the sparse-checkout case,
On Wed, 27 Sep 2017 13:04:42 -0400
Jeff Hostetler wrote:
> The sparse filter is looking at pathnames and using the same rules
> as sparse-checkout to decide which to *include* in the result. This
> is essentially backwards from the other filters which are looking for
> reasons to *exclude* a blo
On Fri, 22 Sep 2017 20:30:13 +
Jeff Hostetler wrote:
> + if (filter_options.relax) {
Add some documentation about how this differs from ignore_missing_links
in struct rev_info.
On Fri, 22 Sep 2017 20:30:11 +
Jeff Hostetler wrote:
> Makefile| 1 +
> object-filter.c | 269
>
> object-filter.h | 173
> 3 files changed, 443 insertions(+)
> create mode 100644 object
On Fri, 22 Sep 2017 20:26:22 +
Jeff Hostetler wrote:
> From: Jeff Hostetler
>
> Create traverse_commit_list_filtered() and add filtering
You mention _filtered() here, but this patch contains _worker().
> list-objects.h | 30 ++
> 2 files changed, 80 insertions(+),
On Fri, 22 Sep 2017 20:26:21 +
Jeff Hostetler wrote:
> From: Jeff Hostetler
>
> Create subclass of oidset where each entry has a
> field to store the length of the object's content
> and an optional pathname.
>
> This will be used in a future commit to build a
> manifest of omitted objects
other lines.
Signed-off-by: Jonathan Tan
---
Changes in v5:
- print warning when encountering capabilities on other lines instead
of ignoring them (also updated commit message)
- explicitly disallow refs of name "capabilities^{}" (except when it is
the only ref)
---
conne
On Tue, 26 Sep 2017 10:25:16 -0400
Jeff Hostetler wrote:
> >> Perhaps you could augment the OID lookup to remember where the object
> >> was found (essentially a .promisor bit set). Then you wouldn't need
> >> to touch them all.
> >
> > Sorry - I don't understand this. Are you saying that missi
On Fri, 22 Sep 2017 20:26:19 +
Jeff Hostetler wrote:
> This draft contains filters to:
> () omit all blobs
> () omit blobs larger than some size
> () omit blobs using a sparse-checkout specification
>
> In addition to specifying the filter criteria, the rev-list command
> was updated to incl
On Fri, 22 Sep 2017 17:32:00 -0400
Jeff Hostetler wrote:
> I guess I'm afraid that the first call to is_promised() is going
> cause a very long pause as it loads up a very large hash of objects.
Yes, the first call will cause a long pause. (I think fsck and gc can
tolerate this, but a better sol
On Fri, 22 Sep 2017 17:19:50 -0400
Jeff Hostetler wrote:
> > In your specific example, how would rev-list know, on the client, to
> > include (or exclude) a large blob in its output if it does not have it,
> > and thus does not know its size?
> >
>
> The client doesn't have the size. It just kn
On Fri, 22 Sep 2017 17:02:11 -0400
Jeff Hostetler wrote:
> > I was struggling a bit with the terminology, true.
> >
> > Right now I'm thinking of:
> > - promisor remote (as you defined)
> > - promisor packfile (as you defined)
> > - promisor object is an object known to belong to the promi
On Fri, 22 Sep 2017 14:01:04 -0700
Brandon Williams wrote:
> > +static void process_capabilities(int len)
> > +{
> > + int nul_location = strlen(packet_buffer);
>
> It may make more sense to not rely on accessing a global buffer here
> directly and instead pass in the buff you're working on, m
easier to teach get_remote_heads() to interpret other
lines in the ref advertisement, which will be done in a subsequent
patch.
As part of this change, this patch interprets capabilities only on the
first line in the ref advertisement, ignoring all others.
Signed-off-by: Jonathan Tan
---
I&#x
easier to teach get_remote_heads() to interpret other
lines in the ref advertisement, which will be done in a subsequent
patch.
Signed-off-by: Jonathan Tan
---
I sent the wrong version of this patch :-(
This should be the correct one. A bit less clean because I introduced a
3rd state, however
easier to teach get_remote_heads() to interpret other
lines in the ref advertisement, which will be done in a subsequent
patch.
Signed-off-by: Jonathan Tan
---
In some in-office discussion, I was informed that my original patch
relaxed the ordering of ".keep" lines. Here is an update.
On Thu, 21 Sep 2017 14:00:40 -0400
Jeff Hostetler wrote:
> (part 3)
>
> Additional overall comments on:
> https://github.com/jonathantanmy/git/commits/partialclone2
>
> {} WRT the code in is_promised() [1]
>
> [1]
> https://github.com/jonathantanmy/git/commit/7a9c2d9b6e2fce293817b595dee29a7eed
On Thu, 21 Sep 2017 13:59:43 -0400
Jeff Hostetler wrote:
> (part 2)
>
> Additional overall comments on:
> https://github.com/jonathantanmy/git/commits/partialclone2
>
> {} I think it would help to split the blob-max-bytes filtering and the
> promisor/promised concepts and discuss them indep
On Thu, 21 Sep 2017 13:57:30 -0400
Jeff Hostetler wrote:
> There's a lot in this patch series. I'm still studying it, but here
> are some notes and questions. I'll start with direct responses to
> the RFC here and follow up in a second email with specific questions
> and comments to keep this f
easier to teach get_remote_heads() to interpret other
lines in the ref advertisement, which will be done in a subsequent
patch.
Signed-off-by: Jonathan Tan
---
It seems that some people are concerned about looseness in interpreting
the ref advertisement, so here is a patch to tighten it instead
On Wed, 20 Sep 2017 17:24:43 -0700
Jonathan Tan wrote:
> On Wed, 13 Sep 2017 14:54:43 -0700
> Brandon Williams wrote:
>
> > A normal request to git-daemon is structured as
> > "command path/to/repo\0host=..\0" and due to a bug in an old version of
> > g
On Wed, 13 Sep 2017 14:54:43 -0700
Brandon Williams wrote:
> A normal request to git-daemon is structured as
> "command path/to/repo\0host=..\0" and due to a bug in an old version of
> git-daemon 73bb33a94 (daemon: Strictly parse the "extra arg" part of the
> command, 2009-06-04) we aren't able t
ting test in t9350-fast-export is also fixed in this patch. The
existing line "C file6 file7" copies the wrong version of file6, but it
has coincidentally worked because file7 was subsequently overridden.
Reported-by: Juraj Oršulić
Signed-off-by: Jonathan Tan
---
I tested this with
y its definitions to not leave these semicolons.
Signed-off-by: Jonathan Tan
---
OK, here is the same patch with an updated commit message.
---
git-compat-util.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index 003e444c4..9bc15b
ore, modify its definitions to cause a compile-time error if
invoked without the trailing semicolon.
Signed-off-by: Jonathan Tan
---
Sure, here is the patch.
---
git-compat-util.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index 003
Thanks - this does look like a good thing to have. Sorry for the late
comments.
The following comments are assuming that we're going to standardize on
UNLEAK(var); (with the semicolon).
On Fri, 8 Sep 2017 02:38:41 -0400
Jeff King wrote:
> +#ifdef SUPPRESS_ANNOTATED_LEAKS
> +extern void unleak_m
I wonder if it's better to get a change like this (PATCH v6 09/40 and
any of the previous patches that this depends on) in and then build on
it rather than to review the whole patch set at a time. This would
reduce ripple effects (of needing to change later patches in a patch set
multiple times un
On Fri, 15 Sep 2017 13:24:50 +0200
Christian Couder wrote:
> > There are still some nuances. For example, if an external ODB provides
> > both a tree and a blob that the tree references, do we fetch the tree in
> > order to call "have" on all its blobs, or do we trust the ODB that if it
> > has t
For those interested in partial clones and/or missing objects in repos,
I've updated my original partialclone patches to not require an explicit
list of promises. Fetch/clone still only permits exclusion of blobs, but
the infrastructure is there for a local repo to support missing trees
and commits
On Thu, 14 Sep 2017 10:39:35 +0200
Christian Couder wrote:
> From the following email:
>
> https://public-inbox.org/git/20170804145113.5ceaf...@twelve2.svl.corp.google.com/
>
> it looks like his work is fundamentally about changing the rules of
> connectivity checks. Objects are split between "
This empty file was inadvertently introduced in commit 4f39cd8 ("pack:
move pack name-related functions", 2017-08-23). Remove this file.
Signed-off-by: Jonathan Tan
---
outgoing/packfile.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 outgoing/packfile.h
di
This new binary was introduced in commit 3921a0b ("perf: add test for
writing the index", 2017-08-21), but a .gitignore entry was not added
for it. Add that entry.
Signed-off-by: Jonathan Tan
---
t/helper/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/t/helper/.git
On Fri, 25 Aug 2017 08:14:08 +0200
Christian Couder wrote:
> As Git is used by more and more by people having different needs, I
> think it is not realistic to expect that we can optimize its object
> storage for all these different needs. So a better strategy is to just
> let them store objects
ned-off-by: Jonathan Tan
---
Thanks. I've reverted the NAME change and used some of your suggestion
for the --max-pack-size documentation.
---
Documentation/git-pack-objects.txt | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/Documentation/git-pack
The documentation for pack-objects describes that it creates "a packed
archive of objects", which is confusing because it may create multiple
packs if --max-pack-size is set. Update the documentation to clarify
this.
Signed-off-by: Jonathan Tan
---
It took me quite some time before
On Sat, 19 Aug 2017 23:40:33 -0700
Junio C Hamano wrote:
> Junio C Hamano writes:
>
> > I have to say that this was a painful topic to integrate.
> >
> > As you may know, the mk/use-size-t-in-zlib topic is being retracted
> > and getting rerolled as a larger size_t series, most of which still
>
On Fri, 11 Aug 2017 15:41:28 -0400
Ben Peart wrote:
> Nice to see the pack file functions being refactored out. I looked at
> the end result and it looked good to me.
Thanks.
> Do you have the energy to do a similar refactoring for the remaining
> public functions residing in sha1_file.c? P
On Fri, 18 Aug 2017 10:18:37 -0400
Ben Peart wrote:
> > But if there was a good way to refer to the "anti-projection" in a
> > virtualized system (that is, the "real" thing or "object" behind the
> > "virtual" thing or "image"), then maybe the "virtualized" language is
> > the best. (And I would
alloc_packed_git() in packfile.c is duplicated from sha1_file.c. In a
subsequent commit, alloc_packed_git() will be removed from sha1_file.c.
Signed-off-by: Jonathan Tan
---
builtin/count-objects.c | 1 +
builtin/fsck.c | 1 +
builtin/pack-objects.c | 1 +
cache.h
Signed-off-by: Jonathan Tan
---
cache.h | 1 -
packfile.c | 9 +
packfile.h | 1 +
sha1_file.c | 9 -
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/cache.h b/cache.h
index a27018210..0313b0b8d 100644
--- a/cache.h
+++ b/cache.h
@@ -1645,7 +1645,6
Signed-off-by: Jonathan Tan
---
cache.h | 1 -
connected.c | 1 +
packfile.c | 53 +
packfile.h | 1 +
sha1_file.c | 61 -
5 files changed, 55 insertions(+), 62 deletions
This function needs to be global as it is used by sha1_file.c and will
be used by packfile.c.
Signed-off-by: Jonathan Tan
---
packfile.c | 53 +
packfile.h | 2 ++
sha1_file.c | 53 -
3
Signed-off-by: Jonathan Tan
---
cache.h | 1 -
packfile.c | 11 ++-
packfile.h | 2 ++
sha1_file.c | 9 -
4 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/cache.h b/cache.h
index 3625509f9..c4d8bee52 100644
--- a/cache.h
+++ b/cache.h
@@ -1619,7 +1619,6
Signed-off-by: Jonathan Tan
---
cache.h | 1 -
packfile.c | 25 +
packfile.h | 2 ++
sha1_file.c | 25 -
4 files changed, 27 insertions(+), 26 deletions(-)
diff --git a/cache.h b/cache.h
index 63765d481..75cc0c497 100644
--- a/cache.h
Signed-off-by: Jonathan Tan
---
builtin/gc.c | 1 +
bulk-checkin.c | 1 +
cache.h| 15
connected.c| 2 +-
fetch-pack.c | 1 +
http-backend.c | 1 +
packfile.c | 217 +
packfile.h | 16 -
path.c
The function unuse_one_window() needs to be temporarily made global. Its
scope will be restored to static in a subsequent commit.
Signed-off-by: Jonathan Tan
---
git-compat-util.h | 2 --
packfile.c| 49 +
packfile.h| 4
Signed-off-by: Jonathan Tan
---
cache.h | 8 ---
packfile.c | 76 -
packfile.h | 9 ++--
sha1_file.c | 73 --
4 files changed, 82 insertions(+), 84 deletions
Signed-off-by: Jonathan Tan
---
cache.h | 2 --
packfile.c | 24
packfile.h | 2 ++
sha1_file.c | 24
4 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/cache.h b/cache.h
index aa2b4d390..a0497d469 100644
--- a/cache.h
+++ b
Signed-off-by: Jonathan Tan
---
cache.h | 3 ---
http-push.c | 1 +
http-walker.c | 1 +
packfile.c| 13 +
packfile.h| 3 +++
sha1_file.c | 13 -
6 files changed, 18 insertions(+), 16 deletions(-)
diff --git a/cache.h b/cache.h
index 9297d078a
Signed-off-by: Jonathan Tan
---
builtin/prune-packed.c | 1 +
cache.h| 2 --
diff.c | 1 +
packfile.c | 6 ++
packfile.h | 2 ++
revision.c | 1 +
sha1_file.c| 6 --
7 files changed, 11 insertions(+), 8
Signed-off-by: Jonathan Tan
---
cache.h | 1 -
packfile.c | 26 ++
packfile.h | 1 +
sha1_file.c | 26 --
4 files changed, 27 insertions(+), 27 deletions(-)
diff --git a/cache.h b/cache.h
index 87f65aeea..7adbc587d 100644
--- a/cache.h
: Jonathan Tan
---
cache.h | 7 -
packfile.c | 661 ++
packfile.h | 10 +
sha1_file.c | 677 ++--
4 files changed, 685 insertions(+), 670 deletions(-)
diff --git a/cache.h b
Signed-off-by: Jonathan Tan
---
cache.h | 2 --
packfile.c | 8
packfile.h | 2 ++
sha1_file.c | 8
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/cache.h b/cache.h
index 286891df4..dcbe37a3f 100644
--- a/cache.h
+++ b/cache.h
@@ -1233,8 +1233,6
Signed-off-by: Jonathan Tan
---
cache.h | 16
packfile.c | 33 +
packfile.h | 16
sha1_file.c | 33 -
4 files changed, 49 insertions(+), 49 deletions(-)
diff --git a/cache.h b/cache.h
index
Signed-off-by: Jonathan Tan
---
cache.h | 1 -
packfile.c | 40
packfile.h | 1 +
sha1_file.c | 39 ---
4 files changed, 41 insertions(+), 40 deletions(-)
diff --git a/cache.h b/cache.h
index 75cc0c497
Signed-off-by: Jonathan Tan
---
cache.h | 14 --
packfile.c | 31 +++
packfile.h | 16 +++-
sha1_file.c | 31 ---
4 files changed, 46 insertions(+), 46 deletions(-)
diff --git a/cache.h b/cache.h
index
Signed-off-by: Jonathan Tan
---
builtin/cat-file.c | 1 +
cache.h| 7 +--
packfile.c | 40
packfile.h | 11 +++
reachable.c| 1 +
sha1_file.c| 40
6 files
sha1_file.c declares some static variables that store packfile-related
state. Move them to packfile.c.
They are temporarily made global, but subsequent commits will restore
their scope back to static.
Signed-off-by: Jonathan Tan
---
packfile.c | 14 ++
packfile.h | 9
The function close_pack_fd() needs to be temporarily made global. Its
scope will be restored to static in a subsequent commit.
Signed-off-by: Jonathan Tan
---
builtin/am.c | 1 +
builtin/clone.c| 1 +
builtin/fetch.c| 1 +
builtin/merge.c| 1 +
builtin
The function open_packed_git() needs to be temporarily made global. Its
scope will be restored to static in a subsequent commit.
Signed-off-by: Jonathan Tan
---
cache.h | 1 -
packfile.c | 303 ++--
packfile.h | 14
corresponding header packfile.h.
In this commit, the pack name-related functions are moved. Subsequent
commits will move the other functions.
Signed-off-by: Jonathan Tan
---
Makefile | 1 +
builtin/index-pack.c | 1 +
builtin/pack-redundant.c | 1 +
cache.h | 23
ce", there are much fewer zebra stripes
The merge base commit can be accessed online [1], if you need it.
[1] https://github.com/jonathantanmy/git/commits/packmigrate
Jonathan Tan (23):
pack: move pack name-related functions
pack: move static state variables
pack: move pac
On Thu, 17 Aug 2017 23:34:33 +0200
Lars Schneider wrote:
>
> > On 17 Aug 2017, at 23:01, Junio C Hamano wrote:
> >
> > Christian Couder writes:
> >
> >> ... but I think we should then emphasize more in our test
> >> scripts (maybe by giving a good example) and perhaps also in the doc
> >> th
Thanks for your comments. I'll reply to both your e-mails in this one
e-mail.
> This illustrates another place we need to resolve the
> naming/vocabulary. We should at least be consistent to make it easier
> to discuss/explain. We obviously went with "virtual" when building
> GVFS but I'm OK wit
On Fri, 11 Aug 2017 14:34:27 -0700
Junio C Hamano wrote:
> Ben Peart writes:
>
> > On 8/9/2017 1:16 PM, Jonathan Tan wrote:
> >
> >> Ah, I forgot to mention this in the cover letter. I thought that one
> >> header was sufficient to cover all pack-related
On Wed, 16 Aug 2017 13:32:23 -0700
Junio C Hamano wrote:
> Jonathan Tan writes:
>
> > Also, let me know if there's a better way to send out these patches for
> > review. Some of the code here has been reviewed before, for example.
> >
> > [1]
> > http
h as those
solely consisting of one or a few closing braces), as was the intention
of the adjacent-moved-line heuristic.
This requires a change in some tests in that some of their lines are no
longer considered to be part of a block, because they are too short.
Signed-off-by: Jo
Currently, MIN_BLOCK_LENGTH is only checked when diff encounters a line
that does not belong to the current block. In particular, this means
that MIN_BLOCK_LENGTH is not checked after all lines are encountered.
Perform that check.
Signed-off-by: Jonathan Tan
---
diff.c | 29
No code in diff.c sets DIFF_SYMBOL_MOVED_LINE except in
mark_color_as_moved(), so it is redundant to clear it for the current
line. Therefore, clear it only for previous lines.
This makes a refactoring in a subsequent patch easier.
Signed-off-by: Jonathan Tan
---
diff.c | 2 +-
1 file changed
it's clearer if the parent function provides that
information, since it already tracks that. In addition, we avoid corner
cases such as what happens if the block is at the start of the diff
output (we must ensure that we don't read off the beginning edge, for
example).
Jonathan Tan
fsck about the new state of affairs. In this commit, teach fsck
that promises referenced from the reflog are not an error case; in
future commits, fsck will be taught about other cases.
Signed-off-by: Jonathan Tan
---
Documentation/technical/repository-version.txt | 8 +++
builtin/fsck.
801 - 900 of 1357 matches
Mail list logo
