On Fri, May 24, 2019 at 12:14 PM Orgad Shaneh wrote:
>
> Hi,
>
> git fetch in my repository *when nothing new is received* takes 2.5x
> the time when comparing 2.20 against 2.21 (on Windows it's 4x).
>
> I have 5 initialized submodules in this working directory.
>
&
Hi,
git fetch in my repository *when nothing new is received* takes 2.5x
the time when comparing 2.20 against 2.21 (on Windows it's 4x).
I have 5 initialized submodules in this working directory.
I reported this issue on git-for-windows github:
https://github.com/git-for-windows/git/issues/2199
On Sat, Dec 29, 2018 at 12:34 AM Junio C Hamano wrote:
>
> org...@gmail.com writes:
>
> > Subject: Re: [PATCH 1/2] t5403: Refactor
>
> Hmph. "Refactor" alone leaves readers wondering "refactor what?",
> "refactor for what?" and "refactor how?". Given that the overfall
> goal this change seeks se
On Sat, Dec 29, 2018 at 12:53 AM Junio C Hamano wrote:
>
> org...@gmail.com writes:
>
> > From: Orgad Shaneh
>
> > Re: [PATCH 2/2] Rebase: Run post-checkout hook on checkout
>
> There is no explanation here?
>
> Is this a regression fix (i.e. scripted versio
Hi Johannes,
On Fri, Dec 21, 2018 at 6:12 PM Johannes Schindelin
wrote:
>
> Hi Orgad,
>
> On Thu, 20 Dec 2018, org...@gmail.com wrote:
>
> > From: Orgad Shaneh
> >
> > Signed-off-by: Orgad Shaneh
>
> Feel free to steal the PR description I added to
Hi Johannes,
Thanks for reviewing this.
On Fri, Dec 21, 2018 at 6:06 PM Johannes Schindelin
wrote:
>
> Hi Orgad,
>
> On Thu, 20 Dec 2018, org...@gmail.com wrote:
>
> > diff --git a/t/t5403-post-checkout-hook.sh b/t/t5403-post-checkout-hook.sh
> > index fc898c9eac..7e941537f9 100755
> > --- a/t/t
On Thu, Dec 20, 2018 at 5:18 PM Jeff King wrote:
>
> On Thu, Dec 20, 2018 at 10:37:21AM +0200, Orgad Shaneh wrote:
>
> > I played around with t5403-post-checkout-hook, and noticed that its
> > state is not exactly what I'd expect it to be.
> >
> > The test s
Hi,
I played around with t5403-post-checkout-hook, and noticed that its
state is not exactly what I'd expect it to be.
The test setup is:
echo Data for commit0. >a &&
echo Data for commit0. >b &&
git update-index --add a &&
git update-index --add b &&
tree0=$(git write-tree) &&
commit0=$(echo set
Hi,
The new built-in rebase feature is much faster than before. Thanks for that :)
One problem we found in it is that doesn't seem to execute post-checkout hook.
Please fix it.
Thanks,
- Orgad
Hi,
I found 2 bugs in grep, using Git for Windows 2.19.1 (but noticed
these several versions ago):
1. git grep --recursive on a worktree (without rev) always matches
against the submodule's HEAD, not its worktree, as it should.
2. When core.autocrlf (or eol=crlf) is used, and a file in the
worktr
On Tue, Jun 12, 2018 at 11:51 AM Edward Thomson
wrote:
>
> On Tue, Jun 12, 2018 at 09:13:54AM +0300, Orgad Shaneh wrote:
> > Some of my colleagues use an ancient version of Source Insight, which also
> > locks files for write.
>
> If that application is locking files for
On Mon, May 28, 2018 at 3:56 PM Johannes Schindelin <
johannes.schinde...@gmx.de> wrote:
> Hi Orgad,
> On Sun, 27 May 2018, Orgad Shaneh wrote:
> > exec argument is a command, not a commit.
> >
> > Signed-off-by: Orgad Shaneh
> > ---
> > git-rebase--
exec argument is a command, not a commit.
Signed-off-by: Orgad Shaneh
---
git-rebase--interactive.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index cbf44f8648..85a72b933e 100644
--- a/git-rebase--interactive.sh
Hi,
If I cherry-pick a commit that added a line, then merge another commit
which removes this line, the line remains in the file instead of being
removed.
The following script demonstrates the bug.
file should be equivalent on both branches
git init
seq 1 20 > file
git add file
git commit -m 'I
On Mon, Nov 6, 2017 at 8:37 PM, Brandon Williams wrote:
> After reading your bug report and the fact that you weren't able to
> reproduce it outside of your project I think i figured out what is
> happening. Before ff6f1f564c the gitmodules file wasn't being loaded
> unless a codepath explicitly
On Sat, Nov 4, 2017 at 8:04 PM, Orgad Shaneh wrote:
> On Fri, Nov 3, 2017 at 6:20 PM, Johannes Schindelin
> wrote:
>> Hi Orgad,
>>
>> On Fri, 3 Nov 2017, Johannes Schindelin wrote:
>>
>>> On Thu, 2 Nov 2017, Orgad Shaneh wrote:
>>>
>>>
On Fri, Nov 3, 2017 at 6:20 PM, Johannes Schindelin
wrote:
> Hi Orgad,
>
> On Fri, 3 Nov 2017, Johannes Schindelin wrote:
>
>> On Thu, 2 Nov 2017, Orgad Shaneh wrote:
>>
>> > I can't reproduce this with a minimal example, but it happens in my
>> &
On Thu, Nov 2, 2017 at 8:34 PM, Stefan Beller wrote:
> On Thu, Nov 2, 2017 at 1:30 AM, Orgad Shaneh wrote:
>> I can't reproduce this with a minimal example, but it happens in my project.
>>
>> What I tried to do for reproducing is:
>> rm -rf super sub
>> mkd
I can't reproduce this with a minimal example, but it happens in my project.
What I tried to do for reproducing is:
rm -rf super sub
mkdir sub; cd sub; git init
git commit --allow-empty -m 'Initial commit'
mkdir ../super; cd ../super
git init
git submodule add ../sub
touch foo; git add foo sub
git
Hi,
There was an issue with lightweight tags that was supposed to be fixed
in Git 2.14 (by branch jc/name-rev-lw-tag).
I also proposed a patch[1], but that was too late, after the other fix
was already in master.
Anyway, I still have the same issue with git 2.14.2.windows.3.
My repository has b
Hi,
git version 2.15.0.rc0 (from debian sid package)
There is an infinite loop when colormoved is used with --ignore-space-change:
git init
seq 20 > test
git add test
sed -i 's/9/42/' test
git -c diff.colormoved diff --ignore-space-change -- test
- Orgad
On Mon, Jul 24, 2017 at 7:13 PM, Jonathan Tan wrote:
> On Sun, 23 Jul 2017 09:41:50 +0300
> Orgad Shaneh wrote:
>
>> Hi,
>>
>> Jonathan Tan proposed a design and a patch series for requesting a
>> specific ref on fetch 4 months ago[1].
>>
>> I
Hi,
Jonathan Tan proposed a design and a patch series for requesting a
specific ref on fetch 4 months ago[1].
Is there any progress with this?
- Orgad
[1]
https://public-inbox.org/git/ffd92ad9-39fe-c76b-178d-6e3d6a425...@google.com/
Hi,
When git grep --color=always is used, and the output is redirected to
a file or a pipe, results inside submodules are not colored. Results
in the supermodule are colored correctly.
- Orgad
On Mon, Jun 26, 2017 at 12:54 AM, Junio C Hamano wrote:
> Orgad Shaneh writes:
>
>> What I'd like to have is a way to tell the first tag per branch (or
>> per merge) that the commit appeared on.
>
>> I think that this can be done by filtering out tags that are con
Hi,
git describe --tags gives me the first tag that includes this commit.
git tag --contains shows all the tags that contain the commit.
git branch -a --contains shows the branches that include this commit.
What I'd like to have is a way to tell the first tag per branch (or
per merge) that t
Commit 7550424804 (name-rev: include taggerdate in considering the best
name) introduced a bug in name-rev.
If a repository has both annotated and non-annotated tags, annotated
tag will always win, even if it was created decades after the commit.
Consider a repository that always used non-annotat
Hi,
When a not-ignored file inside an ignore directory is added along with
other files, a false alarm is shown:
git init
echo /d/ > .gitignore
mkdir d
touch d/file foo
git add -f d/file foo
git add d/file
# fine
git add d/file foo
# The following paths are ignored by one of your .gitignore files:
Hi,
I've noticed a strange behavior with submodule/content conflict. My
current Git version is 2.12.2, but the problem exists since I
remember.
Branch A has a submodule.
In branch B which diverged from A, I replaced the submodule with its contents.
Now, every time I merge A into B, and A had cha
On Tue, Sep 27, 2016 at 7:31 PM, Junio C Hamano wrote:
> Orgad Shaneh writes:
>
>> On Tue, Sep 27, 2016 at 12:34 AM, Junio C Hamano wrote:
>>> Orgad Shaneh writes:
>>>
>> I actually see that there is a problem with it:
>> https://github.com/git-fo
On Tue, Sep 27, 2016 at 12:34 AM, Junio C Hamano wrote:
> Orgad Shaneh writes:
>
>> On Sun, Jul 10, 2016 at 7:36 AM, Orgad Shaneh wrote:
>>
>>> On Wed, May 18, 2016 at 9:12 AM, Orgad Shaneh wrote:
>>>> ping?
>>>>
>>> It's been
4.5 months and counting... :(
- Orgad
On Sun, Jul 10, 2016 at 7:36 AM, Orgad Shaneh wrote:
> It's been over 2 months. Can anyone please review and merge it?
>
> Thanks.
> - Orgad
>
> On Wed, May 18, 2016 at 9:12 AM, Orgad Shaneh wrote:
>> ping?
>>
>>
Hi again,
On Tue, Jul 26, 2016 at 5:54 PM, Johannes Schindelin
wrote:
>
> Hi Orgad,
>
> On Tue, 26 Jul 2016, Orgad Shaneh wrote:
>
> > On Tue, Jul 26, 2016 at 4:02 PM, Johannes Schindelin
> > wrote:
> > >
> > > On Tue, 26 Jul 2016, Orgad Shaneh wrote
Hi,
On Tue, Jul 26, 2016 at 4:02 PM, Johannes Schindelin
wrote:
> Hi Orgad,
>
> On Tue, 26 Jul 2016, Orgad Shaneh wrote:
>
>> From: Orgad Shaneh
>
> Again, this is unnecessary if you already send the mail from the same
> address.
>
>> commit-msg is needed t
Hi and thanks for your reply.
On Tue, Jul 26, 2016 at 3:55 PM, Johannes Schindelin
wrote:
> Hi Orgad
>
> On Tue, 26 Jul 2016, Orgad Shaneh wrote:
>
>> From: Orgad Shaneh
>
> This is unnecessary, as it matches your email address.
>
>> include also commit-msg
From: Orgad Shaneh
include also commit-msg hook.
Signed-off-by: Orgad Shaneh
---
builtin/commit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/commit.c b/builtin/commit.c
index 163dbca..2725712 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -1616,7
From: Orgad Shaneh
commit-msg is needed to either validate the commit message or edit it.
Gerrit for instance uses this hook to append its Change-Id footer.
This is relevant to merge commit just like any other commit.
Signed-off-by: Orgad Shaneh
---
Documentation/git-merge.txt | 6
It's been over 2 months. Can anyone please review and merge it?
Thanks.
- Orgad
On Wed, May 18, 2016 at 9:12 AM, Orgad Shaneh wrote:
> ping?
>
> On Thu, May 5, 2016 at 8:22 PM, Junio C Hamano wrote:
>> Pat, we haven't heard from you for a long time. Are you still
&g
sage, and
>> setting the appropriate environment variables required for preserving
>> them.
>>
>> Reported long ago in the mailing list[1].
>>
>> [1] http://article.gmane.org/gmane.comp.version-control.git/243921
>>
>> Signed-off-by: Orgad Shaneh
>>
mailing list[1].
[1] http://article.gmane.org/gmane.comp.version-control.git/243921
Signed-off-by: Orgad Shaneh
---
git-gui/lib/commit.tcl | 19 +++
1 file changed, 19 insertions(+)
diff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl
index 864b687..60edf99 100644
--- a
Add the verbose flag to add and update which displays the
progress of the actual submodule checkout when given. This
is useful for checkouts that take a long time, as the user
can then see the progress.
Signed-off-by: Orgad Shaneh
---
Documentation/git-submodule.txt | 7 +--
git
On Wed, Mar 12, 2014 at 6:15 PM, Jens Lehmann wrote:
>
> Am 12.03.2014 14:42, schrieb Orgad Shaneh:
> > From: Orgad Shaneh
>
> You don't need the line above when you are the sender ;-)
>
> > Executes checkout without -q
>
> That's a bit terse. What
From: Orgad Shaneh
Executes checkout without -q
Signed-off-by: Orgad Shaneh
---
Documentation/git-submodule.txt | 7 +--
git-submodule.sh| 24 +++-
t/t7406-submodule-update.sh | 9 +
3 files changed, 33 insertions(+), 7 deletions(-)
diff
Executes checkout without -q
---
git-submodule.sh | 24 +++-
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index a33f68d..5c4e057 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -5,11 +5,11 @@
# Copyright (c) 2007 La
Hi,
Amending a commit using git gui resets its author, unlike plain "git
commit --amend".
- Orgad
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 4, 2013 at 3:42 PM, Antoine Pelisse wrote:
>>> Your problem is that your hook script is not checking $2 so it is
>>> overwriting the message even when you do not want to do so.
>>
>> No, it isn't. Not by git-gui at least. Check /tmp/hook.log with the
>> hook I provided...
>
> So what y
On Thu, Jul 4, 2013 at 2:19 PM, John Keeping wrote:
> On Thu, Jul 04, 2013 at 01:59:10PM +0300, Orgad Shaneh wrote:
>> On Thu, Jul 4, 2013 at 1:34 PM, John Keeping wrote:
>> > On Thu, Jul 04, 2013 at 12:47:28PM +0300, Orgad Shaneh wrote:
>> >> Hi,
>> >>
On Thu, Jul 4, 2013 at 1:34 PM, John Keeping wrote:
> On Thu, Jul 04, 2013 at 12:47:28PM +0300, Orgad Shaneh wrote:
>> Hi,
>>
>> If a prepare-commit-msg hook is used, git gui executes it for "New Commit".
>>
>> If the "New Commit" is selec
On Thu, Jul 4, 2013 at 1:01 PM, Fredrik Gustafsson wrote:
> On Thu, Jul 04, 2013 at 12:47:28PM +0300, Orgad Shaneh wrote:
>> If a prepare-commit-msg hook is used, git gui executes it for "New Commit".
>>
>> If the "New Commit" is selected, and then immedi
Hi,
If a prepare-commit-msg hook is used, git gui executes it for "New Commit".
If the "New Commit" is selected, and then immediately "Amend" (before
the hook returns), when the hook returns the message is replaced with
the one produced by the hook.
- Orgad
--
To unsubscribe from this list: send
Running "git rev-parse --show-toplevel" doesn't print anything when it
is run inside .git dir (on all levels)
- Orgad
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-inf
On Wed, Apr 10, 2013 at 11:00 PM, Jens Lehmann wrote:
>
> Am 10.04.2013 20:24, schrieb Orgad Shaneh:
> > Executes checkout without -q
>
> Nice, looks like you picked the proposal I made last September:
> http://permalink.gmane.org/gmane.comp.version-control.git/204747
T
rmally given to checkout so the user sees progress output
from the checkout command.
Signed-off-by: Orgad Shaneh
---
Documentation/git-submodule.txt | 10 --
git-submodule.sh| 24 +++-
2 files changed, 27 insertions(+), 7 deletions(-)
diff --git a/Do
Executes checkout without -q
---
git-submodule.sh | 24 +++-
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 79bfaac..f7964ad 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -5,11 +5,11 @@
# Copyright (c) 2007
If a file's case is changed on rename (Foo -> foo), rebase
fails on Windows because the file already exists.
The change is safe, because if working directory is not clean
rebase fails before checking out.
---
git-rebase.sh |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git
On Sun, Feb 17, 2013 at 10:37 AM, Orgad Shaneh wrote:
> $ git stash save foo:bar
> HEAD is now at 9f88dce Foo
> $ git stash pop foo:bar
> fatal: Invalid object name 'foo'.
> $ git rev-parse foo:bar
> foo:bar
> fatal: Invalid object name 'foo'.
$1 becomes undef by internal regex, since it has no capture groups.
Match against accpetable control characters using index() instead of a regex.
Signed-off-by: Orgad Shaneh
---
gitweb/gitweb.perl |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gitweb/gitweb.perl b
Use of uninitialized value in substitution iterator at gitweb.cgi line 1560
Signed-off-by: Orgad Shaneh
---
gitweb/gitweb.perl |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 0f207f2..862b9cd 100755
--- a/gitweb/gitweb.perl
On Thu, Aug 30, 2012 at 3:34 PM, Orgad and Raizel Shaneh
wrote:
>
> On Thu, Aug 30, 2012 at 4:22 PM, Nguyen Thai Ngoc Duy
> wrote:
> > On Thu, Aug 30, 2012 at 8:12 PM, Orgad and Raizel Shaneh
> > wrote:
> >>> Could be path normalization. What does "git rev-parse --git-dir" say?
> >>> Try to run
On Mon, Sep 24, 2012 at 9:56 PM, Jens Lehmann wrote:
> Am 24.09.2012 21:16, schrieb Orgad Shaneh:
>> On Mon, Sep 24, 2012 at 9:06 PM, Junio C Hamano wrote:
>>> Orgad Shaneh writes:
>>>
>>>> That is not correct. git-config is ignored as well for commit.
>
On Mon, Sep 24, 2012 at 9:30 PM, Orgad Shaneh wrote:
> In order to read diff options for a submodule, its path must be configured
> ---
> git-submodule.sh |2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 3e2045e..f97bb
In order to read diff options for a submodule, its path must be configured
Signed-off-by: Orgad Shaneh
---
git-submodule.sh |2 ++
1 file changed, 2 insertions(+)
diff --git a/git-submodule.sh b/git-submodule.sh
index 3e2045e..af9c003 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
In order to read diff options for a submodule, its path must be configured
---
git-submodule.sh |2 ++
1 file changed, 2 insertions(+)
diff --git a/git-submodule.sh b/git-submodule.sh
index 3e2045e..f97bb62 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -359,6 +359,7 @@ Use -f if you
On Mon, Sep 24, 2012 at 9:06 PM, Junio C Hamano wrote:
> Orgad Shaneh writes:
>
>> That is not correct. git-config is ignored as well for commit.
>
> What do you mean? As far as I can tell, if you have
>
> [submodule "var"]
> path = var
>
ide those found in
> > .gitmodules. And of course you are right, while the change to the
> > code is sane the commit message still needs some work.
>
> Here is what I tentatively queued on 'pu' (not pushed out yet).
>
> -- >8 --
> From: Orgad Shaneh
&
As reported on the mailing list[1], ignore submodule config is not
respected on commit.
[1]
http://git.661346.n2.nabble.com/submodule-ignore-is-not-respected-on-commit-td7539238.html
Signed-off-by: Orgad Shaneh
---
builtin/commit.c |1 +
1 file changed, 1 insertion(+)
diff --git a
SMB shared are accessed using //server/share/directory...
notation.
normalize_path_copy used to leave only a single slash, which
invalidated the path.
Fix suggested by Nguyen Thai Ngoc Duy
Signed-off-by: Orgad Shaneh
---
path.c |6 ++
1 file changed, 6 insertions(+)
diff --git a
Signed-off-by: Orgad Shaneh
---
git-submodule.sh | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index aac575e..dd57abb 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -266,6 +266,11 @@ cmd_add()
repo
68 matches
Mail list logo
