The string-list API has STRING_LIST_INIT_* macros to be used
to define variables with initializers, but lacks functions
to initialize an uninitialized piece of memory to be used as
a string-list at the run-time.
Introduce `string_list_init()` function for that.
Signed-off-by: Tanay Abhra tanay
the `config_set` API.
Signed-off-by: Matthieu Moy matthieu@imag.fr
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
Documentation/technical/api-config.txt | 137 +
cache.h| 30
config.c | 263
Expose the `config_set` C API as a set of simple commands in order to
facilitate testing. Add tests for the `config_set` API as well as for
`git_config_get_*()` family for the usual config files.
Signed-off-by: Matthieu Moy matthieu@imag.fr
Signed-off-by: Tanay Abhra tanay...@gmail.com
On 7/17/2014 3:31 PM, Matthieu Moy wrote:
Tanay Abhra tanay...@gmail.com writes:
I have a question about renaming git_config() to git_config_raw().
I was working on a patch and I am getting stuck here.
It fails in t1001, t1020 t4018. The reason for the last test failure
is unknown right
the `config_set` API.
Signed-off-by: Matthieu Moy matthieu@imag.fr
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
Documentation/technical/api-config.txt | 137 +
cache.h| 30
config.c | 264
Expose the `config_set` C API as a set of simple commands in order to
facilitate testing. Add tests for the `config_set` API as well as for
`git_config_get_*()` family for the usual config files.
Signed-off-by: Matthieu Moy matthieu@imag.fr
Signed-off-by: Tanay Abhra tanay...@gmail.com
the `config_set` API.
Signed-off-by: Matthieu Moy matthieu@imag.fr
Signed-off-by: Tanay Abhra tanay...@gmail.com
Documentation/technical/api-config.txt | 137 +
cache.h| 30
config.c | 264
Expose the `config_set` C API as a set of simple commands in order to
facilitate testing. Add tests for the `config_set` API as well as for
`git_config_get_*()` family for the usual config files.
Signed-off-by: Matthieu Moy matthieu@imag.fr
Signed-off-by: Tanay Abhra tanay...@gmail.com
On 7/16/2014 9:36 PM, Matthieu Moy wrote:
Tanay Abhra tanay...@gmail.com writes:
implemented as a thin wrapper around the `config_set` API.
Signed-off-by: Matthieu Moy matthieu@imag.fr
Signed-off-by: Tanay Abhra tanay...@gmail.com
Documentation/technical/api-config.txt | 137
the
return value.
I think if the file is unreadable. we must continue running as no harm has been
done yet, worse is parsing a file with wrong syntax which can cause reading
wrong config values. So the decision to die on syntax error sounds alright
to me.
Cheers,
Tanay Abhra.
--
To unsubscribe from
Junio C Hamano gitster at pobox.com writes:
Tanay Abhra tanayabh at gmail.com writes:
diff --git a/test-config.c b/test-config.c
new file mode 100644
index 000..dc313c2
--- /dev/null
+++ b/test-config.c
at at -0,0 +1,125 at at
+
+
+int main(int argc, char **argv
://article.gmane.org/gmane.comp.version-control.git/252942/
[9] http://thread.gmane.org/gmane.comp.version-control.git/252959/
[10] http://article.gmane.org/gmane.comp.version-control.git/253113
[11] http://thread.gmane.org/gmane.comp.version-control.git/253248
Tanay Abhra (2):
config set
test-config
Expose the `config_set` C API as a set of simple commands in order to
facilitate testing. Add tests for the `config_set` API as well as for
`git_config_get_*()` family for the usual config files.
Signed-off-by: Matthieu Moy matthieu@imag.fr
Signed-off-by: Tanay Abhra tanay...@gmail.com
the `config_set` API.
Signed-off-by: Matthieu Moy matthieu@imag.fr
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
Documentation/technical/api-config.txt | 135
cache.h| 31
config.c | 276
On 7/15/2014 9:16 PM, Junio C Hamano wrote:
Tanay Abhra tanay...@gmail.com writes:
diff --git a/config.c b/config.c
index ba882a1..89e2d67 100644
--- a/config.c
+++ b/config.c
...
+const struct string_list *git_configset_get_value_multi(struct config_set
*cs, const char *key
this?
check_config get_value_multi case.baz sam bat hask
Noted and corrected.
I suspect the same applies to most if not all uses of test-config
in the remainder of this patch.
I cant use it for configset_get_value_* as it may have variable number
of files as arguments. :)
Thanks,
Tanay
/gmane.comp.version-control.git/252959/
[10] http://article.gmane.org/gmane.comp.version-control.git/253113
Tanay Abhra (2):
config set
test-config
.gitignore | 1 +
Documentation/technical/api-config.txt | 134 +++
Makefile
Expose the `config_set` C API as a set of simple commands in order to
facilitate testing. Add tests for the `config_set` API as well as for
`git_config_get_*()` family for the usual config files.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
.gitignore| 1 +
Makefile
the `config_set` API.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
Documentation/technical/api-config.txt | 134 +++
cache.h| 31
config.c | 296 +
3 files changed, 461 insertions
=14042811521r=1w=2
[8] http://article.gmane.org/gmane.comp.version-control.git/252942/
[9] http://thread.gmane.org/gmane.comp.version-control.git/252959/
Tanay Abhra (2):
config-hash.c
test-config
.gitignore | 1 +
Documentation/technical/api-config.txt | 134
Expose the `config_set` C API as a set of simple commands in order to
facilitate testing. Add tests for the `config_set` API as well as for
`git_config_get_*()` family for the usual config files.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
.gitignore| 1 +
Makefile
the `config_set` API.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
Documentation/technical/api-config.txt | 134 +++
Makefile | 1 +
cache.h| 34
config-hash.c | 295
On 7/7/2014 10:34 PM, Matthieu Moy wrote:
Tanay Abhra tanay...@gmail.com writes:
diff --git a/t/t1308-config-hash.sh b/t/t1308-config-hash.sh
new file mode 100755
index 000..ad99f8b
--- /dev/null
+++ b/t/t1308-config-hash.sh
+test_expect_success 'setup default config' '
+cat
On 7/9/2014 5:42 PM, Matthieu Moy wrote:
Tanay Abhra tanay...@gmail.com writes:
diff --git a/Documentation/technical/api-config.txt
b/Documentation/technical/api-config.txt
index 230b3a0..65a6717 100644
--- a/Documentation/technical/api-config.txt
+++ b/Documentation/technical/api
On 7/9/2014 5:43 PM, Matthieu Moy wrote:
Tanay Abhra tanay...@gmail.com writes:
+test_expect_success 'find value with misspelled key' '
+test_must_fail check my.fOo Bar.hi Value not found for \my.fOo
Bar.hi\
+'
Sorry, this is still not right. You're checking that either test
On 7/9/2014 7:49 PM, Matthieu Moy wrote:
Tanay Abhra tanay...@gmail.com writes:
My opinion on this:
* It's low priority. I think the order of priority should be (high to
low)
1) Finish and get the current series into pu (we're almost there, it's
not time to back off
the `config_set` API.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
Documentation/technical/api-config.txt | 134 +++
Makefile | 1 +
cache.h| 34
config-hash.c | 295
/251073/focus=251369
[5] http://thread.gmane.org/gmane.comp.version-control.git/251704/
[6] http://thread.gmane.org/gmane.comp.version-control.git/252329/
[7] http://marc.info/?t=14042811521r=1w=2
[8] http://article.gmane.org/gmane.comp.version-control.git/252942/
Tanay Abhra (2):
config
Expose the `config_set` C API as a set of simple commands in order to
facilitate testing. Add tests for the `config_set` API as well as for
`git_config_get_*()` family for the usual config files.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
.gitignore | 1 +
Makefile
Expose the `config_set` C API as a set of simple commands in order to
facilitate testing. Add tests for the `config_set` API as well as for
`git_config_get_*()` family for the usual config files.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
.gitignore | 1 +
Makefile
://marc.info/?t=14042811521r=1w=2
Tanay Abhra (2):
config-hash.c
test-config
.gitignore | 1 +
Documentation/technical/api-config.txt | 134 +++
Makefile | 2 +
cache.h| 34
around the `config_set` API.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
Documentation/technical/api-config.txt | 134 +++
Makefile | 1 +
cache.h| 34
config-hash.c | 297
On 7/4/2014 2:47 PM, Matthieu Moy wrote:
Tanay Abhra tanay...@gmail.com writes:
Hi,
I have cooked up a single hashmap implementation. What are your
thoughts about it?
I had a quick look, and it looks good to me. I'll make a more detailed
review when you send the next series.
One
On 7/2/2014 10:30 PM, Junio C Hamano wrote:
Tanay Abhra tanay...@gmail.com writes:
diff --git a/Documentation/technical/api-config.txt
b/Documentation/technical/api-config.txt
index 230b3a0..2c02fee 100644
--- a/Documentation/technical/api-config.txt
+++ b/Documentation/technical/api
or the multi hashmap one.
Cheers,
Tanay Abhra.
-- 8 --
diff --git a/Makefile b/Makefile
index 07ea105..d503f78 100644
--- a/Makefile
+++ b/Makefile
@@ -777,6 +777,7 @@ LIB_OBJS += commit.o
LIB_OBJS += compat/obstack.o
LIB_OBJS += compat/terminal.o
LIB_OBJS += config.o
+LIB_OBJS += config-hash.o
://thread.gmane.org/gmane.comp.version-control.git/251704/
[6] http://thread.gmane.org/gmane.comp.version-control.git/252329/
Tanay Abhra (2):
config-hash.c
test-config
.gitignore | 1 +
Documentation/technical/api-config.txt | 144
Makefile
query functions that are
implemented as a thin wrapper around the `config_set` API.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
Documentation/technical/api-config.txt | 144
Makefile | 1 +
cache.h| 41
config
Expose the `config_set` C API as a set of simple commands in order to
facilitate testing. Add tests for the `config_set` API as well as for
`git_config_get_*()` family for the usual config files.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
.gitignore | 1 +
Makefile
On 7/2/2014 2:44 PM, Matthieu Moy wrote:
Tanay Abhra tanay...@gmail.com writes:
Add a `config_set` construct that points to an ordered set of config files
specified by the user, each of which represents what was read and cached
in core as hashmaps. Add two external functions
On 7/2/2014 2:59 PM, Matthieu Moy wrote:
Tanay Abhra tanay...@gmail.com writes:
+test_expect_success 'clear default config' '
+rm -f .git/config
+'
+
+cat .git/config EOF
t/README says:
- Put all code inside test_expect_success and other assertions.
Even code
On 6/30/2014 7:04 PM, Karsten Blees wrote:
Am 29.06.2014 13:01, schrieb Eric Sunshine:
On Thu, Jun 26, 2014 at 4:19 AM, Tanay Abhra tanay...@gmail.com wrote:
On 6/25/2014 1:24 PM, Eric Sunshine wrote:
On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra tanay...@gmail.com wrote:
Use
On 6/30/2014 9:26 PM, Karsten Blees wrote:
Am 30.06.2014 16:39, schrieb Tanay Abhra:
On 6/30/2014 7:04 PM, Karsten Blees wrote:
Am 29.06.2014 13:01, schrieb Eric Sunshine:
On Thu, Jun 26, 2014 at 4:19 AM, Tanay Abhra tanay...@gmail.com wrote:
On 6/25/2014 1:24 PM, Eric Sunshine wrote
in config.c would become redundant. Is it really necessary to write new
helper functions for the non-callback code, instead of reusing the older ones?
[1]: http://marc.info/?t=14035185021r=1w=2
Cheers,
Tanay Abhra.
Documentation/technical/api-config.txt | 26 +
cache.h
On 6/25/2014 10:15 AM, Eric Sunshine wrote:
On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra tanay...@gmail.com wrote:
diff --git a/branch.c b/branch.c
index 660097b..c9a2a0d 100644
--- a/branch.c
+++ b/branch.c
@@ -140,33 +140,25 @@ static int setup_tracking(const char *new_ref, const
char
On 6/25/2014 12:39 PM, Eric Sunshine wrote:
On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra tanay...@gmail.com wrote:
Use git_config_get_string instead of git_config to take advantage of
the config hash-table api which provides a cleaner control flow.
You may want to mention as a side-note
On 6/25/2014 1:24 PM, Eric Sunshine wrote:
On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra tanay...@gmail.com wrote:
Use git_config_get_string instead of git_config to take advantage of
the config hash-table api which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay
On 6/25/2014 1:36 PM, Eric Sunshine wrote:
On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra tanay...@gmail.com wrote:
Use git_config_get_string instead of git_config to take advantage of
the config hash-table api which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay
On 6/25/2014 7:42 AM, Eric Sunshine wrote:
On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra tanay...@gmail.com wrote:
Use git_config_get_string instead of git_config to take advantage of
the config hash-table api which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay
On 6/25/2014 9:29 AM, Eric Sunshine wrote:
On Mon, Jun 23, 2014 at 6:41 AM, Tanay Abhra tanay...@gmail.com wrote:
Use git_config_get_string instead of git_config to take advantage of
the config hash-table api which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay
Hi,
I thought about adding a test*.sh file after sending the series.
No worries, I will rectify it in the next patch.
Also, I have read all your comments.
Thanks for the review.
Cheers,
Tanay Abhra.
On 6/25/2014 4:49 PM, Eric Sunshine wrote:
On Mon, Jun 23, 2014 at 6:11 AM, Tanay Abhra tanay
or commit sha1. What else can
I add to my implementation, please suggest.
Thanks,
Tanay Abhra
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 6/23/2014 5:25 PM, Matthieu Moy wrote:
Tanay Abhra tanay...@gmail.com writes:
+/* for NULL values, 'util' for each `string_list_item` is flagged as 1 */
It's a void *, so just saying that it is flagged as 1 does not say how
it's encoded. How about ... is an 'int *' pointing to the value 1
On 6/24/2014 4:44 AM, Junio C Hamano wrote:
Tanay Abhra tanay...@gmail.com writes:
+static int hashmap_initialized;
+ ...
+static struct hashmap *get_config_cache(void)
+{
+ static struct hashmap config_cache;
+ if (!hashmap_initialized) {
+ config_cache_init
-control.git/251704/
Tanay Abhra (3):
string-list: Add string_list initializer helper functions
config: Add hashtable for config parsing retrieval
test-config
.gitignore | 1 +
Documentation/technical/api-config.txt | 26 ++
Makefile
O(1) lookups once the hash table is constructed.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
Documentation/technical/api-config.txt | 26 ++
cache.h| 2 +
config.c | 144 +
3 files changed
Add different usage examples for 'git_config_get_string' and
`git_config_get_string_multi`. They will serve as documentation
on how to query for config values in a non-callback manner.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
.gitignore| 1 +
Makefile | 1 +
test-config.c
The string-list API has STRING_LIST_INIT_* macros to be used
to define variables with initialisers, but lacks functions
to initialise an uninitialised piece of memory to be used as
a string-list at the run-time.
Introduce string_list_init_{dup,nodup}() functions for that.
Signed-off-by: Tanay
Use git_config_get_string instead of git_config to take advantage of
the config hash-table api which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
pager.c | 44 +++-
1 file changed, 15 insertions(+), 29 deletions
Use git_config_get_string instead of git_config to take advantage of
the config hash-table api which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
notes.c | 20 ++--
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/notes.c b
Use git_config_get_string instead of git_config to take advantage of
the config hash-table api which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
notes-utils.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff
Use git_config_get_string instead of git_config to take advantage of
the config hash-table api which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
imap-send.c | 68 ++---
1 file changed, 29 insertions
Use git_config_get_string instead of git_config to take advantage of
the config hash-table api which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
branch.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/branch.c
Use git_config_get_string instead of git_config to take advantage of
the config hash-table api which provides a cleaner control flow.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
alias.c | 28 ++--
1 file changed, 10 insertions(+), 18 deletions(-)
diff --git
On 06/23/2014 05:36 AM, Torsten Bögershausen wrote:
If we look at the definition below:
struct string_list {
struct string_list_item *items;
unsigned int nr, alloc;
unsigned int strdup_strings:1;
compare_strings_fn cmp; /* NULL uses strcmp() */
I think a simple
On 06/23/2014 07:57 AM, Ramsay Jones wrote:
On 23/06/14 11:11, Tanay Abhra wrote:
diff --git a/config.c b/config.c
index a1aef1c..6200f36 100644
--- a/config.c
+++ b/config.c
@@ -9,6 +9,8 @@
#include exec_cmd.h
#include strbuf.h
#include quote.h
+#include hashmap.h
+#include string
On 6/24/2014 4:08 AM, Jonathan Nieder wrote:
Tanay Abhra wrote:
alias.c | 28 ++--
1 file changed, 10 insertions(+), 18 deletions(-)
What commit are these patches against? Are they a continuation
of the git config cache special querying api series?
My fault, I
Hi,
I was about to send a patch like this series today, I am attaching it below.
-- 8 --
Subject: [PATCH] imap-send: use skip_prefix instead of using magic numbers
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
imap-send.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff
, ))
+ config_error_nonbool(alias_key);
What do you think about this approach?
Thanks for the suggestion, I was pulling my hair out due this bug for last two
days.
Cheers,
Tanay Abhra.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord
On 06/16/2014 03:59 PM, Junio C Hamano wrote:
Tanay Abhra tanay...@gmail.com writes:
When a compound construct like a string_list within another
struct is used, the default initializer macros are useless.
For such cases add helper functions for string_list
initialization for both DUP
.nabble.com/RFC-PATCH-0-2-Git-config-cache-amp-special-querying-api-utilizing-the-cache-td7611691.html
[3]
https://drive.google.com/file/d/0B4suZ-aHqDcnSUZJRXVTTnZUN1E/edit?usp=sharing
[4] http://thread.gmane.org/gmane.comp.version-control.git/251073/focus=251369
Cheers,
Tanay Abhra.
Tanay Abhra (2
When a compound construct like a string_list within another
struct is used, the default initializer macros are useless.
For such cases add helper functions for string_list
initialization for both DUP and NODUP modes.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
string-list.c | 18
.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
Documentation/technical/api-config.txt | 17 +
cache.h| 2 +
config.c | 123 +
3 files changed, 142 insertions(+)
diff --git a/Documentation
://thread.gmane.org/gmane.comp.version-control.git/251704
Cheers,
Tanay Abhra.
branch.c | 25 +
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/branch.c b/branch.c
index 660097b..257b1bf 100644
--- a/branch.c
+++ b/branch.c
@@ -140,33 +140,26 @@ static int
Original implementation uses a callback based approach which has some
deficiencies like a convoluted control flow and redundant variables.
Use git_config_get_string instead of git_config to take advantage of
the config hash-table.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
**DOUBT
On 06/16/2014 10:11 AM, Matthieu Moy wrote:
Tanay Abhra tanay...@gmail.com writes:
Add a hash table to cache all key-value pairs read from config files
(repo specific .git/config, user wide ~/.gitconfig and the global
/etc/gitconfig). Add two external functions `git_config_get_string
On 06/16/2014 10:29 AM, Matthieu Moy wrote:
Subject: Re: [PATCH/RFC] branch.c: Replace `git_config` with
`git_config_get_string`
Here and elsewhere: usually, no capital after :.
Noted.
Tanay Abhra tanay...@gmail.com writes:
Original implementation uses a callback based approach which
On 06/16/2014 05:49 AM, Philip Oakley wrote:
Pass a configuration parameter to the command. The value
- given will override values from configuration files.
+ given will override single valued variables from configuration
+ files, and append to multivar variables. Previous
Hi,
Thanks for the review, Eric. I have replied to your comments below,
I will try to reply early and more promptly now.
On 06/10/2014 04:27 AM, Eric Sunshine wrote:
---
diff --git a/Documentation/technical/api-config.txt
b/Documentation/technical/api-config.txt
index 230b3a0..5b6e376
On 06/10/2014 04:45 AM, Eric Sunshine wrote:
One additional comment...
On Mon, Jun 9, 2014 at 8:49 AM, Tanay Abhra tanay...@gmail.com wrote:
+static int config_cache_set_value(const char *key, const char *value)
+{
+ struct hashmap *config_cache;
+ struct config_cache_entry *e
/file/d/0B4suZ-aHqDcnSUZJRXVTTnZUN1E/edit?usp=sharing
Cheers,
Tanay Abhra.
Tanay Abhra (1):
config: Add hashtable for config parsing retrival
Documentation/technical/api-config.txt | 18 +
cache.h| 2 +
config.c | 122
.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
Documentation/technical/api-config.txt | 18 +
cache.h| 2 +
config.c | 122 +
3 files changed, 142 insertions(+)
diff --git a/Documentation
On 06/02/2014 12:37 PM, Matthieu Moy wrote:
Tanay Abhra tanay...@gmail.com writes:
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
Documentation/technical/api-config.txt | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
Even though the reason
l = { NULL, 0, 0, 1 };
and the last member that is not mentioned (i.e. 'cmp') is
initialized to NULL.
While there is nothing wrong in this construct, spelling out
all the values where the macros are defined will serve also
as a documentation, so let's do so.
Signed-off-by: Tanay Abhra tanay
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
Documentation/technical/api-config.txt | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/Documentation/technical/api-config.txt
b/Documentation/technical/api-config.txt
index 230b3a0..df08385
=sharing
Cheers,
Tanay Abhra.
Tanay Abhra (2):
config: Add hashtable for config parsing retrieval
config: Add new query functions to the api docs
Documentation/technical/api-config.txt | 18 +
cache.h| 2 +
config.c | 118
Add explanations for `git_config_get_string_multi` and `git_config_get_string`
which utilize the config hash table for querying in a non-callback manner for
a specific variable.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
Documentation/technical/api-config.txt | 18 ++
1
.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
cache.h | 2 ++
config.c | 118 +++
2 files changed, 120 insertions(+)
diff --git a/cache.h b/cache.h
index 107ac61..2038150 100644
--- a/cache.h
+++ b/cache.h
@@ -1271,6 +1271,8
rid of the variable int num_values by simply writing
result = values-items[values-nr-1].string;
Noted.
Cheers,
Tanay Abhra.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
added only the file
from each variable value pair comes in an upcoming series.
What else should I add or implement ;is my approach right?
[1]
https://drive.google.com/file/d/0B4suZ-aHqDcnSUZJRXVTTnZUN1E/edit?usp=sharing
Cheers,
Tanay Abhra.
Tanay Abhra (2):
config: Add cache for config
manner from the
cache.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
cache.h | 2 ++
config.c | 105 +++
2 files changed, 107 insertions(+)
diff --git a/cache.h b/cache.h
index 107ac61..2038150 100644
--- a/cache.h
+++ b/cache.h
Add explanations for `git_config_get_string_multi` and `git_config_get_string`
which utilize the config cache for querying in an non callback manner for a
specific variable.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
Documentation/technical/api-config.txt | 19 +++
1 file
, try try.github.com/ for
an interactive tutorial.
Cheers,
Tanay Abhra.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
this option.
links:-
[1]http://thread.gmane.org/gmane.comp.version-control.git/219505
[2]http://thread.gmane.org/gmane.comp.version-control.git/208113
--
Cheers,
Tanay Abhra
this,
[PATCH v2] fsck_commit.c: Replace memcmp() by skip_prefix()
Cheers,
Tanay Abhra.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
help
me , I just want the starting function and will trace the function calls
after that.
Regards,
Tanay Abhra.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[2]http://thread.gmane.org/gmane.comp.version-control.git/208113
---
Thanks,
Tanay Abhra.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info
In record_author_date() parse_gpg_output() ,using skip_prefix() instead of
starts_with() is a more suitable abstraction.
Helped-by: Max Horn m...@quendi.de
Helped-by: Junio C Hamano gits...@pobox.com
Helped-by: Michael Haggerty mhag...@alum.mit.edu
Signed-off-by: Tanay Abhra tanay...@gmail.com
() advantages are not so important
in the context.So the replace may not be so advantageous ,I may be wrong in
this case.
Cheers,
Tanay Abhra.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
at 0x80f8b40: file help.c, line 396.
Cheers,
Tanay Abhra.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Helped-by: Junio C Hamano gits...@pobox.com
Helped-by: Michael Haggerty mhag...@alum.mit.edu
Signed-off-by: Tanay Abhra tanay...@gmail.com
Signed-off-by: Junio C Hamano gits...@pobox.com
---
Patch V4 Identation improved, removed useless comment. [1]
Thanks to Junio C Hamano and Max
201 - 300 of 304 matches
Mail list logo
