Bump code to the top for usage in further patches.
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
ref-filter.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c
index 38f38d4..c3a8372 100644
---
Introduce optional prefixes "width=" and "position=" for the align atom
so that the atom can be used as "%(align:width=,position=)".
Add Documentation and tests for the same.
Helped-by: Eric Sunshine <sunsh...@sunshineco.com>
Signed-off-by:
without including the terminator.
Helped-by: Eric Sunshine <sunsh...@sunshineco.com>
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
strbuf.c | 14 +-
strbuf.h | 25 -
2 files changed, 25 insertions(+), 14 deletions(-)
diff --git a/strbuf.
Introduce color_atom_parser() which will parse a "color" atom and
store its color in the "used_atom" structure for further usage in
populate_value().
Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com>
Helped-by: Eric Sunshine <sunsh...@sunshineco.com>
Signe
for their comments on the previous
version. And everyone else who helped review the previous patch series.
Karthik Nayak (12):
strbuf: introduce strbuf_split_str_omit_term()
ref-filter: use strbuf_split_str_omit_term()
ref-filter: bump 'used_atom' and related code to the top
ref-filter: introduce
On Sun, Feb 7, 2016 at 7:17 PM, Andreas Schwab <sch...@linux-m68k.org> wrote:
> Karthik Nayak <karthik@gmail.com> writes:
>
>> + if ((( arg && len == arg - sp) ||
>> +(!arg && len == ep - sp )) &&
On Sun, Feb 7, 2016 at 12:03 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Sat, Feb 6, 2016 at 10:15 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> On Sun, Jan 31, 2016 at 11:12 PM, Karthik Nayak <karthik@gmail.com>
>> wrote:
>>> @@ -
On Sun, Feb 7, 2016 at 1:13 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Sat, Feb 6, 2016 at 10:20 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> On Fri, Feb 5, 2016 at 3:55 AM, Eric Sunshine <sunsh...@sunshineco.com>
>> wrote:
>>> On Su
On Sun, Feb 7, 2016 at 12:33 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Sat, Feb 6, 2016 at 9:36 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> On Thu, Feb 4, 2016 at 3:49 AM, Eric Sunshine <sunsh...@sunshineco.com>
>> wrote:
>>> On Su
On Fri, Feb 5, 2016 at 5:35 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Sun, Jan 31, 2016 at 11:12:54PM +0530, Karthik Nayak wrote:
>> Introduce remote_ref_atom_parser() which will parse the '%(upstream)'
>> and '%(push)' atoms and store information into the 'us
On Fri, Feb 5, 2016 at 3:55 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Sun, Jan 31, 2016 at 12:42 PM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce color_atom_parser() which will parse a "color" atom and
>> store its color in the &q
On Fri, Feb 5, 2016 at 5:18 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Sun, Jan 31, 2016 at 12:42 PM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce align_atom_parser() which will parse an 'align' atom and
>> store the required alignment position
On Fri, Feb 5, 2016 at 5:30 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Sun, Jan 31, 2016 at 12:42 PM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce optional prefixes "width=" and "position=" for the align atom
>> so that t
rst.
> Aside from the two proposed fixes, a fix patterned after the original
> code which patch 5/12 replaced would be even easier to understand.
> That is, something like this:
>
> arg = memchr(...);
> if (!arg)
> arg = ep;
> if (len == arg - sp && !me
On Fri, Feb 5, 2016 at 5:52 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Sun, Jan 31, 2016 at 12:42 PM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce contents_atom_parser() which will parse the '%(contents)'
>> atom and store information into the
On Sun, Jan 31, 2016 at 11:12 PM, Karthik Nayak <karthik@gmail.com> wrote:
> @@ -138,10 +140,9 @@ int parse_ref_filter_atom(const char *atom, const char
> *ep)
> * shouldn't be used for checking against the valid_atom
>
On Thu, Feb 4, 2016 at 3:49 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Sun, Jan 31, 2016 at 12:42 PM, Karthik Nayak <karthik@gmail.com> wrote:
>> Parsing atoms is done in populate_value(), this is repetitive and
>> hence expensive. Introduce a parsing
On Tue, Feb 2, 2016 at 3:52 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Karthik Nayak <karthik@gmail.com> writes:
>
>> Bump code to the top for usage in further patches.
>> ---
>
> Sign-off?
Shall reply with patch, missed th
Bump code to the top for usage in further patches.
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
ref-filter.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c
index 38f38d4..c3a8372 100644
---
esource Karthik
> accidentally included in the commit (which has been stripped from
> this re-send).
>
Thanks a lot, wondering how that happened.
> On Sun, Jan 31, 2016 at 11:12:54PM +0530, Karthik Nayak wrote:
>> Introduce remote_ref_atom_parser() which will parse the '%(upstream)'
On Tue, Feb 2, 2016 at 6:07 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Mon, Feb 1, 2016 at 5:25 PM, Junio C Hamano <gits...@pobox.com> wrote:
>> Karthik Nayak <karthik@gmail.com> writes:
>>
>>> This series cleans up populate_value() in
of test (t6302).
Karthik Nayak (12):
strbuf: introduce strbuf_split_str_omit_term()
ref-filter: use strbuf_split_str_omit_term()
ref-filter: bump 'used_atom' and related code to the top
ref-filter: introduce struct used_atom
ref-filter: introduce parsing functions for each valid atom
ref
without including the terminator.
Helped-by: Eric Sunshine <sunsh...@sunshineco.com>
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
strbuf.c | 14 +-
strbuf.h | 25 -
2 files changed, 25 insertions(+), 14 deletions(-)
diff --git a/strbuf.
Introduce optional prefixes "width=" and "position=" for the align atom
so that the atom can be used as "%(align:width=,position=)".
Add Documentation and tests for the same.
Helped-by: Eric Sunshine <sunsh...@sunshineco.com>
Signed-off-by:
Introduce the 'used_atom' structure to replace the existing
implementation of 'used_atom' (which is a list of atoms). This helps
us parse atoms beforehand and store required details into the
'used_atom' for future usage.
Helped-by: Eric Sunshine <sunsh...@sunshineco.com>
Signed-off-by: K
-by: Eric Sunshine <sunsh...@sunshineco.com>
Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
ref-filter.c | 91 ++--
1 file changed, 40 insertions(+), 51 deletions(-)
Introduce color_atom_parser() which will parse a "color" atom and
store its color in the "used_atom" structure for further usage in
populate_value().
Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com>
Helped-by: Eric Sunshine <sunsh...@sunshineco.com>
Signe
>From populate_value() extract parse_align_position() which given a
string would give us the alignment position. This is a preparatory
patch as to introduce prefixes for the %(align) atom and avoid
redundancy in the code.
Helped-by: Eric Sunshine <sunsh...@sunshineco.com>
Signed-off-by
;
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
ref-filter.c | 35 ---
1 file changed, 24 insertions(+), 11 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c
index b2043a0..d48e2a3 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -43,6 +43,
.
Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com>
Helped-by: Eric Sunshine <sunsh...@sunshineco.com>
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
ref-filter.c | 77 ++--
1 file changed, 49 insertions(+), 28
ed-off-by: Karthik Nayak <karthik@gmail.com>
---
ref-filter.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c
index 3736dc3..92b4419 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -36,6 +36,7 @@ static int need_color_reset_at_
Bump code to the top for usage in further patches.
---
ref-filter.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c
index 38f38d4..c3a8372 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -16,6 +16,21 @@
typedef
Use the newly introduced strbuf_split_str_omit_term() rather than
using strbuf_split_str() and manually removing the ',' terminator.
Helped-by: Eric Sunshine <sunsh...@sunshineco.com>
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
ref-filter.c | 9 +
1 file changed,
On Tue, Jan 26, 2016 at 5:58 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Tue, Jan 5, 2016 at 3:03 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce remote_ref_atom_parser() which will parse the '%(upstream)'
>> and '%(push)' atoms and store info
On Tue, Jan 26, 2016 at 3:19 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Tue, Jan 5, 2016 at 3:03 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> From align_atom_parser() form parse_align_position() which given a
>> string would give us the alignment posi
On Tue, Jan 26, 2016 at 4:28 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Tue, Jan 5, 2016 at 3:03 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce optional prefixes "width=" and "position=" for the align atom
>> so that t
uot;align:$option" "
>> git for-each-ref --format='...$option...' >actual &&
>> ...
>> "
>> done
>> }
>
> but make it more like this:
>
> for option in ...
> do
>
On Tue, Jan 26, 2016 at 10:46 AM, Christian Couder
<christian.cou...@gmail.com> wrote:
> On Tue, Jan 5, 2016 at 9:03 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce optional prefixes "width=" and "position=" for the align atom
>>
me to decide what strip= should do in the error case.
>
> Unfortunately, this means kn/ref-filter-atom-parsing topic from you
> that were parked on 'pu' must be ejected for now, as any change in
> this area overlaps with it, and the atom parsing code would need to
> be updated to l
about a scenario wherein we have
refs/branches/abc/foo
refs/branches/xyz
should --format="%(refname:strip=3)" give us
foo
xyz (here stripping till 2 '/', which is the maximum)
or
foo
refs/branches/xyz (no stripping done at all)
I prefer the former, cause that would allow us t
On Fri, Jan 22, 2016 at 12:34 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Tuesday, January 5, 2016, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce the 'used_atom' structure to replace the existing
>> implementation of 'used_atom' (which is a list
On Fri, Jan 22, 2016 at 1:17 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Jan 6, 2016 at 2:27 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> On Wed, Jan 6, 2016 at 12:54 AM, Junio C Hamano <gits...@pobox.com> wrote:
>>> Karthik
On Wed, Jan 6, 2016 at 2:42 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Karthik Nayak <karthik@gmail.com> writes:
>
>> In align_atom_parser() the 'width' variable is an int, which requires
>> an explicit type conversion when used in strtoul_ui(). He
On Wed, Jan 6, 2016 at 2:36 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Karthik Nayak <karthik@gmail.com> writes:
>
>> @@ -90,7 +105,7 @@ static struct {
>> { "symref" },
>> { "flag" },
>> { "HEAD" }
On Wed, Jan 6, 2016 at 2:52 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Karthik Nayak <karthik@gmail.com> writes:
>
>> Introduce contents_atom_parser() which will parse the '%(contents)'
>> atom and store information into the 'used_atom' structure based
On Wed, Jan 6, 2016 at 3:01 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Karthik Nayak <karthik@gmail.com> writes:
>
>> @@ -467,15 +482,17 @@ static void *get_obj(const unsigned char *sha1, struct
>> object **obj, unsigned lo
>> }
>>
>> st
<sunsh...@sunshineco.com>
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
ref-filter.c | 107 ---
1 file changed, 66 insertions(+), 41 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c
index df0b114..32b4674 100644
--- a/
;
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
ref-filter.c | 39 ---
1 file changed, 28 insertions(+), 11 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c
index 9e61530..57b4280 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -43,6 +43,
ect' and 'body' in contents_atom_parser() and although Eric
suggested I use strcmp() instead, this would not work as we need to
check for derefernced 'subject' and 'body' atoms.
[0]: http://article.gmane.org/gmane.comp.version-control.git/282701
Karthik Nayak (15):
strbuf: introd
Introduce color_atom_parser() which will parse a "color" atom and
store its color in the "used_atom" structure for further usage in
populate_value().
Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com>
Helped-by: Eric Sunshine <sunsh...@sunshineco.com>
Signe
Introduce optional prefixes "width=" and "position=" for the align atom
so that the atom can be used as "%(align:width=,position=)".
Add Documetation and tests for the same.
Helped-by: Eric Sunshine <sunsh...@sunshineco.com>
Signed-off-by: Karthik Nayak <ka
;
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
ref-filter.c | 74 +---
1 file changed, 46 insertions(+), 28 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c
index 32b4674..9e61530 100644
--- a/ref-filter.c
+++ b/ref-filter
>From align_atom_parser() form parse_align_position() which given a
string would give us the alignment position. This is a preparatory
patch as to introduce prefixes for the %(align) atom and avoid
redundancy in the code.
Helped-by: Eric Sunshine <sunsh...@sunshineco.com>
Signed-off-by
without including the terminator.
Helped-by: Eric Sunshine <sunsh...@sunshineco.com>
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
strbuf.c | 7 ---
strbuf.h | 25 -
2 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/strbuf.c b/st
ed-off-by: Karthik Nayak <karthik@gmail.com>
---
ref-filter.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ref-filter.c b/ref-filter.c
index 75ebd03..efa247a 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -36,6 +36,7 @@ static int need_color_reset_at_eol;
static struct {
m>
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
ref-filter.c | 83 +---
1 file changed, 46 insertions(+), 37 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c
index 9708d67..fa081a8 100644
--- a/ref-filter.c
+++ b/ref
On Wed, Jan 6, 2016 at 12:54 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Karthik Nayak <karthik@gmail.com> writes:
>
>> The current implementation of 'strbuf_split_buf()' includes the
>> terminator at the end of each strbuf post splitting. Add an
On Wed, Jan 6, 2016 at 2:19 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Karthik Nayak <karthik@gmail.com> writes:
>
>> Introduce color_atom_parser() which will parse a "color" atom and
>> store its color in the "used_atom" structure for
On Thu, Dec 17, 2015 at 2:29 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Dec 16, 2015 at 10:29 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> ref-filter: introduce prefixes for the align atom
>
> The prefixes are actually for the ar
On Fri, Dec 25, 2015 at 11:39 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Fri, Dec 25, 2015 at 8:44 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> On Fri, Dec 18, 2015 at 11:54 AM, Eric Sunshine <sunsh...@sunshineco.com>
>> wrote:
>>>
On Fri, Dec 18, 2015 at 11:54 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Dec 16, 2015 at 10:30 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce objectname_atom_parser() which will parse the
>> '%(objectname)' atom and store info
On Thu, Dec 17, 2015 at 3:09 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Dec 16, 2015 at 10:30 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce contents_atom_parser() which will parse the '%(contents)'
>> atom and store information into the
On Thu, Dec 17, 2015 at 2:52 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Dec 16, 2015 at 10:30 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce remote_ref_atom_parser() which will parse the '%(upstream)'
>> and '%(push)' atoms and store info
On Thu, Dec 17, 2015 at 3:24 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Dec 16, 2015 at 10:29 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce align_atom_parser() which will parse an "align" atom and
>> store the required alignmen
On Fri, Dec 18, 2015 at 11:20 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Dec 16, 2015 at 10:29 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce align_atom_parser() which will parse an "align" atom and
>> store the
On Thu, Dec 17, 2015 at 2:27 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Dec 16, 2015 at 10:29 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce the 'used_array' structure which would replace the existing
>> implementation of 'used_ar
On Thu, Dec 17, 2015 at 2:41 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Dec 16, 2015 at 10:29 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> In upcoming patches we make calls to match_atom_name() with the '*'
>> deref specifier still attached to
On Thu, Dec 17, 2015 at 2:51 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Dec 16, 2015 at 10:29 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce color_atom_parser() which will parse a "color" atom and
>> store its color in the &
On Thu, Dec 17, 2015 at 2:05 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Dec 16, 2015 at 10:29 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> strbuf: introduce strbuf_split_str_without_term()
>
> s/without/omit/
>
>> The current implementat
On Mon, Dec 14, 2015 at 3:25 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Sun, Dec 13, 2015 at 4:31 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> On Sun, Dec 13, 2015 at 11:10 AM, Eric Sunshine <sunsh...@sunshineco.com>
>> wrote:
>>>
et rid of repetitive checks performed.
(http://article.gmane.org/gmane.comp.version-control.git/282320).
Karthik Nayak (11):
strbuf: introduce strbuf_split_str_without_term()
ref-filter: use strbuf_split_str_omit_term()
ref-filter: introduce struct used_atom
ref-fitler: bump match_atom() n
Bump match_atom() to the top for usage in further patches.
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
ref-filter.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c
index 043a02a..f4a6414
. Using
this we can define special parsing functions for each of the atoms.
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
ref-filter.c | 63 +++-
1 file changed, 33 insertions(+), 30 deletions(-)
diff --git a/ref-filter.c
Use the newly introduced strbuf_split_str_omit_term() rather than
using strbuf_split_str() and manually removing the ',' terminator.
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
ref-filter.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/ref-filt
Introduce color_atom_parser() which will parse a "color" atom and
store its color in the "use_atom" structure for further usage in
'populate_value()'.
Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Karthik Nayak <karthik@gmai
In upcoming patches we make calls to match_atom_name() with the '*'
deref specifier still attached to the atom name. This causes
undesirable errors, hence, if present skip over the '*' deref
specifier in the atom name.
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
ref-filter
without including the terminator.
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
strbuf.c | 7 ---
strbuf.h | 25 -
2 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/strbuf.c b/strbuf.c
index b552a13..b62508e 100644
--- a/strbuf.c
Introduce optional prefixes "width=" and "position=" for the align atom
so that the atom can be used as "%(align:width=,position=)".
Add Documetation and tests for the same.
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
Documentation/git-for-ea
Introduce align_atom_parser() which will parse an "align" atom and
store the required alignment position and width in the "use_atom"
structure for further usage in 'populate_value()'.
Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Karthik Na
Introduce objectname_atom_parser() which will parse the
'%(objectname)' atom and store information into the 'used_atom'
structure based on the modifiers used along with the atom.
Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Karthik Nayak <karthik@gmail.com&
Introduce remote_ref_atom_parser() which will parse the '%(upstream)'
and '%(push)' atoms and store information into the 'used_atom'
structure based on the modifiers used along with the corresponding
atom.
Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Karthik Nayak &l
Introduce contents_atom_parser() which will parse the '%(contents)'
atom and store information into the 'used_atom' structure based on the
modifiers used along with the atom.
Helped-by: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Karthik Nayak <karthik@gmail.com&
On Sun, Dec 13, 2015 at 2:15 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Sun, Dec 13, 2015 at 3:32 AM, Karthik Nayak <karthik@gmail.com> wrote:
>>> On Sun, Dec 13, 2015 at 6:23 AM, Eric Sunshine <sunsh...@sunshineco.com>
>>> wrote:
>&g
On Sun, Dec 13, 2015 at 11:10 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Fri, Dec 11, 2015 at 5:49 PM, Junio C Hamano <gits...@pobox.com> wrote:
>> Karthik Nayak <karthik@gmail.com> writes:
>>> ref-filter: introduce a parsing function for each
On Sun, Dec 13, 2015 at 11:32 AM, Karthik Nayak <karthik@gmail.com> wrote:
> On Sun, Dec 13, 2015 at 6:23 AM, Eric Sunshine <sunsh...@sunshineco.com>
> wrote:
>> On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak <karthik@gmail.com> wrote:
>>> I
On Sun, Dec 13, 2015 at 11:35 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Thu, Dec 3, 2015 at 8:35 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> On Wed, Dec 2, 2015 at 4:57 AM, Eric Sunshine <sunsh...@sunshineco.com>
>> wrote:
>>> On W
On Sun, Dec 13, 2015 at 10:11 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Sat, Dec 12, 2015 at 10:10 PM, Eric Sunshine <sunsh...@sunshineco.com>
> wrote:
>> On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak <karthik@gmail.com> wrote:
>>> +voi
On Sun, Dec 13, 2015 at 8:40 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce contents_atom_parser() which will parse the '%(contents)'
>> atom and store information into the
On Sun, Dec 13, 2015 at 10:19 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Nov 25, 2015 at 8:44 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce objectname_atom_parser() which will parse the
>> '%(objectname)' atom and store info
On Sun, Dec 13, 2015 at 6:23 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce remote_ref_atom_parser() which will parse the '%(upstream)'
>> and '%(push)' atoms and store info
On Sat, Dec 12, 2015 at 3:48 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Karthik Nayak <karthik@gmail.com> writes:
>
>>> This problem will go away if you introduce the 'valid_atom' field in
>>> the patch which actually needs it (as suggested above) rath
On Sat, Dec 12, 2015 at 4:01 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Karthik Nayak <karthik@gmail.com> writes:
>
>>>> diff --git a/ref-filter.c b/ref-filter.c
>>>> @@ -892,14 +892,11 @@ static void populate_value(struct ref_array_item
>&
On Thu, Dec 3, 2015 at 2:53 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce align_atom_parser() which will parse 'align' atoms and store
>> the required width and position int
On Wed, Dec 2, 2015 at 4:57 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce color_atom_parser() which will parse a "color" atom and
>> store its color in the &
On Wed, Dec 2, 2015 at 1:34 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak <karthik@gmail.com> wrote:
>> The current implementation of 'strbuf_split_buf()' includes the
>> terminator at the end of each str
On Wed, Dec 2, 2015 at 4:41 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak <karthik@gmail.com> wrote:
>> Signed-off-by: Karthik Nayak <karthik@gmail.com>
>
> A bit of explanation about why this change is
could you please squash the relevant parts of this patch into
> yours.
>
> Thanks!
Thanks, will squash this into the next version.
Regards,
Karthik Nayak
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
M
On Thu, Nov 26, 2015 at 1:11 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Nov 25, 2015 at 7:10 AM, Karthik Nayak <karthik@gmail.com> wrote:
>> On Tue, Nov 24, 2015 at 5:14 AM, Eric Sunshine <sunsh...@sunshineco.com>
>> wrote:
>>> On W
On Tue, Nov 24, 2015 at 5:14 AM, Eric Sunshine <sunsh...@sunshineco.com> wrote:
> On Wed, Nov 11, 2015 at 2:44 PM, Karthik Nayak <karthik@gmail.com> wrote:
>> Introduce a parsing function for each atom in valid_atom. Using this
>> we can define special parsing func
On Wed, Nov 25, 2015 at 3:18 AM, Jeff King <p...@peff.net> wrote:
> On Thu, Nov 12, 2015 at 01:14:26AM +0530, Karthik Nayak wrote:
>
>> Karthik Nayak (10):
>> ref-filter: introduce a parsing function for each atom in valid_atom
>> ref-filter: introduce struct u
301 - 400 of 1407 matches
Mail list logo
