Re: [GSoC microproject] Add XDG support to the credential-store helper

2015-03-06 Thread Matthieu Moy
Paul Tan pyoka...@gmail.com writes: Hi Luis, On Fri, Mar 6, 2015 at 7:41 AM, Luis Ressel ara...@aixah.de wrote: Okay, I've had a look at Paul's patch for this. Sorry again for the dupe, I must've missed it before. I guess I'll attempt another microproject. However, I feel like my patch is

Re: [GSoC microproject] Add XDG support to the credential-store helper

2015-03-06 Thread Paul Tan
Hi, Reading my previous message again, I apologize if it sounded conflicting. Truth to be told, I see merits in both proposed behaviors, but it all depends on whether we want git-credentials-store to support an arbitrary number of config files (now or in the future) or just two. I'm not sitting

Re: [GSoC microproject] Add XDG support to the credential-store helper

2015-03-06 Thread Paul Tan
Hi Luis, On Fri, Mar 6, 2015 at 7:41 AM, Luis Ressel ara...@aixah.de wrote: Okay, I've had a look at Paul's patch for this. Sorry again for the dupe, I must've missed it before. I guess I'll attempt another microproject. However, I feel like my patch is really all that's neccessary; I don't

[GSoC microproject] Add XDG support to the credential-store helper

2015-03-05 Thread Luis Ressel
I'm contributing this patch in preparation for a GSoC15 application with the git project. In particular, I'm interested in the two bisect improvements listed on the Ideas page. Does anyone have other suggestions for potential improvements of git bisect that would be suitable for such a GSoC

Re: [GSoC microproject] Add XDG support to the credential-store helper

2015-03-05 Thread Junio C Hamano
Luis Ressel ara...@aixah.de writes: Oh, and should I add a testcase for the new functionality introduced by this patch? And if yes, what exactly should I test? Absolutely. Thinking things through to design what needs to be tested is part of the exercise ;-) You need to demonstrate that the

Re: [GSoC microproject] Add XDG support to the credential-store helper

2015-03-05 Thread Luis Ressel
Okay, I've had a look at Paul's patch for this. Sorry again for the dupe, I must've missed it before. I guess I'll attempt another microproject. However, I feel like my patch is really all that's neccessary; I don't think we should try to use both files if they exist -- I consider Paul's approach

Re: [GSoC microproject] Add XDG support to the credential-store helper

2015-03-05 Thread Christian Couder
Hi, On Thu, Mar 5, 2015 at 9:51 PM, Luis Ressel ara...@aixah.de wrote: I'm contributing this patch in preparation for a GSoC15 application with the git project. In particular, I'm interested in the two bisect improvements listed on the Ideas page. Does anyone have other suggestions for

Re: [GSoC microproject] Add XDG support to the credential-store helper

2015-03-05 Thread Luis Ressel
On Thu, 5 Mar 2015 23:38:19 +0100 Christian Couder christian.cou...@gmail.com wrote: Hi, Last year, on the ideas page: http://git.github.io/SoC-2014-Ideas.html we also had the following improvement: in some cases, git bisect may test too many merge bases, thus slowing down the