Re: [PATCH/RFC] push: anonymize URL in error output

2017-08-26 Thread Jeff King
On Fri, Aug 25, 2017 at 12:37:43PM -0700, Brandon Williams wrote: > > > My knee-jerk reaction is if it's worth writing after the dashes, it's > > > worth putting in the commit message. > > > > > > However, in the case I think it is OK as-is (the motivation of "we > > > already avoid leaking auth

Re: [PATCH/RFC] push: anonymize URL in error output

2017-08-25 Thread Brandon Williams
On 08/24, Ivan Vyshnevskyi wrote: > On 23/08/17 18:58, Jeff King wrote: > > On Wed, Aug 23, 2017 at 12:49:29PM +0300, Ivan Vyshnevskyi wrote: > > > >> Commits 47abd85 (fetch: Strip usernames from url's before storing them, > >> 2009-04-17) and later 882d49c (push: anonymize URL in status output,

Re: [PATCH/RFC] push: anonymize URL in error output

2017-08-24 Thread Ivan Vyshnevskyi
On 23/08/17 18:58, Jeff King wrote: > On Wed, Aug 23, 2017 at 12:49:29PM +0300, Ivan Vyshnevskyi wrote: > >> Commits 47abd85 (fetch: Strip usernames from url's before storing them, >> 2009-04-17) and later 882d49c (push: anonymize URL in status output, >> 2016-07-14) made fetch and push strip the

Re: [PATCH/RFC] push: anonymize URL in error output

2017-08-24 Thread Ivan Vyshnevskyi
On 23/08/17 13:57, Lars Schneider wrote: > >> On 23 Aug 2017, at 11:49, Ivan Vyshnevskyi wrote: >> >> Commits 47abd85 (fetch: Strip usernames from url's before storing them, >> 2009-04-17) and later 882d49c (push: anonymize URL in status output, >> 2016-07-14) made fetch and

Re: [PATCH/RFC] push: anonymize URL in error output

2017-08-23 Thread Jeff King
On Wed, Aug 23, 2017 at 12:49:29PM +0300, Ivan Vyshnevskyi wrote: > Commits 47abd85 (fetch: Strip usernames from url's before storing them, > 2009-04-17) and later 882d49c (push: anonymize URL in status output, > 2016-07-14) made fetch and push strip the authentication part of the > remote URLs

Re: [PATCH/RFC] push: anonymize URL in error output

2017-08-23 Thread Lars Schneider
> On 23 Aug 2017, at 11:49, Ivan Vyshnevskyi wrote: > > Commits 47abd85 (fetch: Strip usernames from url's before storing them, > 2009-04-17) and later 882d49c (push: anonymize URL in status output, > 2016-07-14) made fetch and push strip the authentication part of the >

[PATCH/RFC] push: anonymize URL in error output

2017-08-23 Thread Ivan Vyshnevskyi
Commits 47abd85 (fetch: Strip usernames from url's before storing them, 2009-04-17) and later 882d49c (push: anonymize URL in status output, 2016-07-14) made fetch and push strip the authentication part of the remote URLs when used in the merge-commit messages or status outputs. The URLs that are