Re: [PATCH] Add userdiff patterns for Ada

2012-09-16 Thread Junio C Hamano
Adrian Johnson ajohn...@redneon.com writes: Add Ada xfuncname and wordRegex patterns to the list of builtin patterns. Signed-off-by: Adrian Johnson ajohn...@redneon.com --- Interesting. I do not read Ada, but in this expect file,... diff --git a/t/t4034/ada/expect b/t/t4034/ada/expect

Re: [PATCH] Add userdiff patterns for Ada

2012-09-16 Thread Adrian Johnson
On 16/09/12 15:37, Junio C Hamano wrote: Adrian Johnson ajohn...@redneon.com writes: Add Ada xfuncname and wordRegex patterns to the list of builtin patterns. Signed-off-by: Adrian Johnson ajohn...@redneon.com --- Interesting. I do not read Ada, but in this expect file,... diff

Re: [PATCH] Add userdiff patterns for Ada

2012-09-16 Thread Junio C Hamano
Adrian Johnson ajohn...@redneon.com writes: I do not seem to find anything interesting after @@, which means that xfuncname is not tested at all even though the log message claims the patch adds some. I probably misunderstood how the tests work. I thought t4034 tested wordRegex while t4018

[PATCH] Add userdiff patterns for Ada

2012-09-15 Thread Adrian Johnson
Add Ada xfuncname and wordRegex patterns to the list of builtin patterns. Signed-off-by: Adrian Johnson ajohn...@redneon.com --- Documentation/gitattributes.txt | 2 ++ t/t4018-diff-funcname.sh| 2 +- t/t4034-diff-words.sh | 1 + t/t4034/ada/expect | 27