Re: [PATCH] contrib/completion: suppress stderror in bash

Hi, Quoting SZEDER Gábor sze...@ira.uka.de: Hi, Quoting Junio C Hamano gits...@pobox.com: SZEDER Gábor sze...@ira.uka.de writes: @@ -412,7 +412,7 @@ __git_refs_remotes () __git_remotes () { local i IFS=$'\n' d=$(__gitdir) - test -d $d/remotes ls -1 $d/remotes + test

Re: [PATCH] contrib/completion: suppress stderror in bash

SZEDER Gábor sze...@ira.uka.de writes: @@ -412,7 +412,7 @@ __git_refs_remotes () __git_remotes () { local i IFS=$'\n' d=$(__gitdir) - test -d $d/remotes ls -1 $d/remotes + test -d $d/remotes ls -1 $d/remotes 2/dev/null for i in $(git --git-dir=$d config --get-regexp

Re: [PATCH] contrib/completion: suppress stderror in bash

Hi, Quoting Junio C Hamano gits...@pobox.com: SZEDER Gábor sze...@ira.uka.de writes: @@ -412,7 +412,7 @@ __git_refs_remotes () __git_remotes () { local i IFS=$'\n' d=$(__gitdir) - test -d $d/remotes ls -1 $d/remotes + test -d $d/remotes ls -1 $d/remotes 2/dev/null

Re: [PATCH] contrib/completion: suppress stderror in bash

Hi, Quoting Junio C Hamano gits...@pobox.com: Matt Korostoff mkorost...@gmail.com writes: diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 2fece98..72251cc 100644 --- a/contrib/completion/git-completion.bash +++

Re: [PATCH] contrib/completion: suppress stderror in bash completion of git remotes

Here are some screen shots demonstrating the issue I'm describing here: before this patch: https://cloud.githubusercontent.com/assets/1197335/6108333/1f3b10fa-b040-11e4-9164-3c7769dae110.gif after this patch:

Re: [PATCH] contrib/completion: suppress stderror in bash completion of git remotes

Matt Korostoff mkorost...@gmail.com writes: In some system configurations there is a bug with the __git_remotes function. Specifically, there is a problem with line 415, `test -d $d/remotes ls -1 $d/remotes`. While `test -d` is meant to prevent listing the remotes directory if it does not

[PATCH] contrib/completion: suppress stderror in bash completion of git remotes

In some system configurations there is a bug with the __git_remotes function. Specifically, there is a problem with line 415, `test -d $d/remotes ls -1 $d/remotes`. While `test -d` is meant to prevent listing the remotes directory if it does not exist, in some system, `ls` will run regardless.

Re: [PATCH] contrib/completion: suppress stderror in bash completion of git remotes

Thank you for your detailed reply Junio. I'll try to address your concerns individually, but let me also offer a general thought that this is probably a good use case to handle even if the root cause is solvable outside of git. That is to say, I would think we'd still want git autocompletion