Re: [PATCH] doc: correct command formatting

Jonathan Nieder writes: > Separate from this example: yes, I think adopting Linux's Reviewed-by > convention would be a good thing. When I see a positive reply to a > patch, I often wonder whether an ack or a fuller reviewed-by is > intended, and Linux's way of formalizing

Re: [PATCH] doc: correct command formatting

Junio C Hamano wrote: > Jonathan Nieder writes: >> Andreas Heiduk wrote: >>> +1, Thanks for spotting. >> >> Thanks for looking it over. Can we add your Reviewed-by? (See [1] >> for what this means.) > > I would just do "Acked-by: Andreas" after seeing such an obvious >

Re: [PATCH] doc: correct command formatting

Jonathan Nieder writes: > Andreas Heiduk wrote: > >> +1, Thanks for spotting. > > Thanks for looking it over. Can we add your Reviewed-by? (See [1] > for what this means.) I would just do "Acked-by: Andreas" after seeing such an obvious admission of guilt & appreciation

Re: [PATCH] doc: correct command formatting

Am 28.09.2017 um 21:34 schrieb Jonathan Nieder: > Andreas Heiduk wrote: > >> +1, Thanks for spotting. > > Thanks for looking it over. Can we add your Reviewed-by? (See [1] > for what this means.) Well, I'd like to see the following occurrence of the same problem solved in that patch, too.

Re: [PATCH] doc: correct command formatting

Hi, Andreas Heiduk wrote: > +1, Thanks for spotting. Thanks for looking it over. Can we add your Reviewed-by? (See [1] for what this means.) > I did a quick > > grep -r " ` " > > which came up with with another relevant place: > > Documentation/git-format-patch.txt:

Re: [PATCH] doc: correct command formatting

Adam Dinwoodie wrote: > Leaving spaces around the `-delimeters for commands means asciidoc fails > to parse them as the start of a literal string. Remove an extraneous > space that is causing a literal to not be formatted as such. > > Signed-off-by: Adam Dinwoodie > --- >

Re: [PATCH] doc: correct command formatting

Am 28.09.2017 um 16:06 schrieb Adam Dinwoodie: > Leaving spaces around the `-delimeters for commands means asciidoc fails > to parse them as the start of a literal string. Remove an extraneous > space that is causing a literal to not be formatted as such. > > Signed-off-by: Adam Dinwoodie

[PATCH] doc: correct command formatting

Leaving spaces around the `-delimeters for commands means asciidoc fails to parse them as the start of a literal string. Remove an extraneous space that is causing a literal to not be formatted as such. Signed-off-by: Adam Dinwoodie --- Documentation/git.txt | 2 +- 1 file