Re: [PATCH] git-send-email.perl: Add sendmail aliases support

2015-05-21 Thread Allen Hubbe
On Thu, May 21, 2015 at 5:05 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Thu, May 21, 2015 at 4:48 PM, Allen Hubbe alle...@gmail.com wrote: My motivation for this patch was not really to support the sendmail aliases file directly. The commit message may therefore be misleading. So, I

Re: [PATCH] git-send-email.perl: Add sendmail aliases support

2015-05-21 Thread Junio C Hamano
Allen Hubbe alle...@gmail.com writes: Those are good points. Maybe I shouldn't even mention sendmail at all, not in the name of the format, and not in the commit message. What name would be a good name for this format? simple? And if you are going to define such a format, then I do not

Re: [PATCH] git-send-email.perl: Add sendmail aliases support

2015-05-21 Thread Eric Sunshine
On Thu, May 21, 2015 at 4:48 PM, Allen Hubbe alle...@gmail.com wrote: My motivation for this patch was not really to support the sendmail aliases file directly. The commit message may therefore be misleading. So, I could also rewrite the commit message to say something like, loosely based on

Re: [PATCH] git-send-email.perl: Add sendmail aliases support

2015-05-21 Thread Junio C Hamano
Allen Hubbe alle...@gmail.com writes: diff --git a/git-send-email.perl b/git-send-email.perl index e1e9b14..5f2ec0d 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -515,7 +515,12 @@ my %parse_alias = ( $aliases{$alias} = [ split_addrs($addr) ];

Re: [PATCH] git-send-email.perl: Add sendmail aliases support

2015-05-21 Thread Allen Hubbe
On Thu, May 21, 2015 at 4:19 PM, Junio C Hamano gits...@pobox.com wrote: Allen Hubbe alle...@gmail.com writes: diff --git a/git-send-email.perl b/git-send-email.perl index e1e9b14..5f2ec0d 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -515,7 +515,12 @@ my %parse_alias = (

Re: [PATCH] git-send-email.perl: Add sendmail aliases support

2015-05-21 Thread Junio C Hamano
Allen Hubbe alle...@gmail.com writes: The diff doesn't show enough context to include this comment: my %parse_alias = ( # multiline formats can be supported in the future ... I can't be sure the author's intent, but my interpretation is such. The parsers do not support multiline,

Re: [PATCH] git-send-email.perl: Add sendmail aliases support

2015-05-21 Thread Allen Hubbe
On Thu, May 21, 2015 at 5:38 PM, Junio C Hamano gits...@pobox.com wrote: Allen Hubbe alle...@gmail.com writes: Those are good points. Maybe I shouldn't even mention sendmail at all, not in the name of the format, and not in the commit message. What name would be a good name for this format?

[PATCH] git-send-email.perl: Add sendmail aliases support

2015-05-21 Thread Allen Hubbe
Support sendmail (and postfix) style email aliases in git-send-email. This is the format of /etc/mail/aliases, documented by `man 5 aliases`. The man page may be provided by sendmail or postfix on your system, or by another email service that uses the same configuration file. See also: