Re: [PATCH] make hg-to-git compatible with python2.x and 3.x

Junio C Hamano writes: > - map(lambda ..., collection) is not liked; use list comprehension. > ... > I am not sure about the change from map(lambda ...) to list > comprehension, though. Not that I have a preference for or against > (I am not a Python person), but I do not

Re: [PATCH] make hg-to-git compatible with python2.x and 3.x

Hervé Beraud writes: > Signed-off-by: Hervé Beraud > --- > contrib/hg-to-git/hg-to-git.py | 52 > +- > 1 file changed, 26 insertions(+), 26 deletions(-) I think you shrunk the scope of the change,

[PATCH] make hg-to-git compatible with python2.x and 3.x

Signed-off-by: Hervé Beraud --- contrib/hg-to-git/hg-to-git.py | 52 +- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/contrib/hg-to-git/hg-to-git.py b/contrib/hg-to-git/hg-to-git.py index

Re: [PATCH] make hg-to-git compatible with python2.x and 3.x

Hervé Beraud writes: > --- Thanks for posting, but this is way under-justified, even for something in contrib/ area. Are all changes in this patch necessary to "make it compatible with both Python 2 and 3", or are some parts do not contribute directly to the

[PATCH] make hg-to-git compatible with python2.x and 3.x

--- contrib/hg-to-git/hg-to-git.py | 140 - 1 file changed, 83 insertions(+), 57 deletions(-) diff --git a/contrib/hg-to-git/hg-to-git.py b/contrib/hg-to-git/hg-to-git.py index de3f81667ed97..9b0842c3883dc 100755 --- a/contrib/hg-to-git/hg-to-git.py +++