Re: [PATCH] remote-curl: Include curl_errorstr on SSL setup failures

2016-02-14 Thread Jeff King
On Sat, Feb 13, 2016 at 05:39:34PM -0800, Shawn Pearce wrote: > For curl error 35 (CURLE_SSL_CONNECT_ERROR) users need the > additional text stored in CURLOPT_ERRORBUFFER to debug why > the connection did not start. This is curl_errorstr inside > of http.c, so include that in the message if it is

Re: [PATCH] remote-curl: Include curl_errorstr on SSL setup failures

2016-02-14 Thread Shawn Pearce
On Sun, Feb 14, 2016 at 8:50 AM, Jeff King wrote: > On Sat, Feb 13, 2016 at 05:39:34PM -0800, Shawn Pearce wrote: > >> For curl error 35 (CURLE_SSL_CONNECT_ERROR) users need the >> additional text stored in CURLOPT_ERRORBUFFER to debug why >> the connection did not start. This is

[PATCH] remote-curl: Include curl_errorstr on SSL setup failures

2016-02-13 Thread Shawn Pearce
For curl error 35 (CURLE_SSL_CONNECT_ERROR) users need the additional text stored in CURLOPT_ERRORBUFFER to debug why the connection did not start. This is curl_errorstr inside of http.c, so include that in the message if it is non-empty. Sometimes HTTP response codes aren't yet available, such