Re: [PATCH] sha1_file: remove static strbuf from sha1_file_name()

On Tue, Jan 16, 2018 at 8:00 PM, Jeff Hostetler wrote: > > > On 1/16/2018 9:01 AM, Derrick Stolee wrote: >> >> On 1/16/2018 2:18 AM, Christian Couder wrote: >>> >>> Using a static buffer in sha1_file_name() is error prone >>> and the performance improvements it gives are

Re: [PATCH] sha1_file: remove static strbuf from sha1_file_name()

On 1/16/2018 9:01 AM, Derrick Stolee wrote: On 1/16/2018 2:18 AM, Christian Couder wrote: Using a static buffer in sha1_file_name() is error prone and the performance improvements it gives are not needed in most of the callers. So let's get rid of this static buffer and, if necessary or

Re: [PATCH] sha1_file: remove static strbuf from sha1_file_name()

On Tue, Jan 16, 2018 at 08:18:14AM +0100, Christian Couder wrote: > Using a static buffer in sha1_file_name() is error prone > and the performance improvements it gives are not needed > in most of the callers. > > So let's get rid of this static buffer and, if necessary > or helpful, let's use

Re: [PATCH] sha1_file: remove static strbuf from sha1_file_name()

On 1/16/2018 2:18 AM, Christian Couder wrote: Using a static buffer in sha1_file_name() is error prone and the performance improvements it gives are not needed in most of the callers. So let's get rid of this static buffer and, if necessary or helpful, let's use one in the caller. First: this

[PATCH] sha1_file: remove static strbuf from sha1_file_name()

Using a static buffer in sha1_file_name() is error prone and the performance improvements it gives are not needed in most of the callers. So let's get rid of this static buffer and, if necessary or helpful, let's use one in the caller. --- cache.h | 8 +++- http-walker.c | 6 --