Re: [PATCH 0/6] Compute and consume generation numbers

2018-04-23 Thread Derrick Stolee
On 4/21/2018 4:44 PM, Jakub Narebski wrote: Jakub Narebski writes: Derrick Stolee writes: On 4/11/2018 3:32 PM, Jakub Narebski wrote: What would you suggest as a good test that could imply performance? The Google Colab notebook linked to above includes a

Re: [PATCH 0/6] Compute and consume generation numbers

2018-04-21 Thread Jakub Narebski
Jakub Narebski writes: > Derrick Stolee writes: >> On 4/11/2018 3:32 PM, Jakub Narebski wrote: > >>> What would you suggest as a good test that could imply performance? The >>> Google Colab notebook linked to above includes a function to count >>> number of

Re: [PATCH 0/6] Compute and consume generation numbers

2018-04-14 Thread Jakub Narebski
Derrick Stolee writes: > On 4/11/2018 3:32 PM, Jakub Narebski wrote: >> What would you suggest as a good test that could imply performance? The >> Google Colab notebook linked to above includes a function to count >> number of commits (nodes / vertices in the commit graph)

Re: [PATCH 0/6] Compute and consume generation numbers

2018-04-11 Thread Derrick Stolee
On 4/11/2018 3:32 PM, Jakub Narebski wrote: What would you suggest as a good test that could imply performance? The Google Colab notebook linked to above includes a function to count number of commits (nodes / vertices in the commit graph) walked, currently in the worst case scenario. The two

Re: [PATCH 0/6] Compute and consume generation numbers

2018-04-11 Thread Jakub Narebski
Derrick Stolee writes: > On 4/7/2018 12:55 PM, Jakub Narebski wrote: >> Currently I am at the stage of reproducing results in FELINE paper: >> "Reachability Queries in Very Large Graphs: A Fast Refined Online Search >> Approach" by Renê R. Veloso, Loïc Cerf, Wagner Meira Jr and

Re: [PATCH 0/6] Compute and consume generation numbers

2018-04-07 Thread Derrick Stolee
On 4/7/2018 12:55 PM, Jakub Narebski wrote: Currently I am at the stage of reproducing results in FELINE paper: "Reachability Queries in Very Large Graphs: A Fast Refined Online Search Approach" by Renê R. Veloso, Loïc Cerf, Wagner Meira Jr and Mohammed J. Zaki (2014). This paper is available

Re: [PATCH 0/6] Compute and consume generation numbers

2018-04-07 Thread Jakub Narebski
Derrick Stolee writes: > On 4/3/2018 2:03 PM, Brandon Williams wrote: >> On 04/03, Derrick Stolee wrote: >>> This is the first of several "small" patches that follow the serialized >>> Git commit graph patch (ds/commit-graph). >>> >>> As described in

Re: [PATCH 0/6] Compute and consume generation numbers

2018-04-07 Thread Jakub Narebski
Hello, Derrick Stolee writes: > This is the first of several "small" patches that follow the serialized > Git commit graph patch (ds/commit-graph). > > As described in Documentation/technical/commit-graph.txt, the generation > number of a commit is one more than the

Re: [PATCH 0/6] Compute and consume generation numbers

2018-04-03 Thread Jeff King
On Tue, Apr 03, 2018 at 02:47:27PM -0400, Jeff King wrote: > On Tue, Apr 03, 2018 at 02:29:01PM -0400, Derrick Stolee wrote: > > > If we have generic "can X reach Y?" queries, then we can also use generation > > numbers there to great effect (by not walking commits Z with gen(Z) <= > > gen(Y)).

Re: [PATCH 0/6] Compute and consume generation numbers

2018-04-03 Thread Jeff King
On Tue, Apr 03, 2018 at 02:29:01PM -0400, Derrick Stolee wrote: > If we have generic "can X reach Y?" queries, then we can also use generation > numbers there to great effect (by not walking commits Z with gen(Z) <= > gen(Y)). Perhaps I should look at that "git branch --contains" thread for >

Re: [PATCH 0/6] Compute and consume generation numbers

2018-04-03 Thread Derrick Stolee
On 4/3/2018 2:03 PM, Brandon Williams wrote: On 04/03, Derrick Stolee wrote: This is the first of several "small" patches that follow the serialized Git commit graph patch (ds/commit-graph). As described in Documentation/technical/commit-graph.txt, the generation number of a commit is one more

Re: [PATCH 0/6] Compute and consume generation numbers

2018-04-03 Thread Brandon Williams
On 04/03, Derrick Stolee wrote: > This is the first of several "small" patches that follow the serialized > Git commit graph patch (ds/commit-graph). > > As described in Documentation/technical/commit-graph.txt, the generation > number of a commit is one more than the maximum generation number

Re: [PATCH 0/6] Compute and consume generation numbers

2018-04-03 Thread Derrick Stolee
On 4/3/2018 12:51 PM, Derrick Stolee wrote: This is the first of several "small" patches that follow the serialized Git commit graph patch (ds/commit-graph). As described in Documentation/technical/commit-graph.txt, the generation number of a commit is one more than the maximum generation

[PATCH 0/6] Compute and consume generation numbers

2018-04-03 Thread Derrick Stolee
This is the first of several "small" patches that follow the serialized Git commit graph patch (ds/commit-graph). As described in Documentation/technical/commit-graph.txt, the generation number of a commit is one more than the maximum generation number among its parents (trivially, a commit with