Re: [PATCH 01/13] delete_ref(): move declaration to refs.h

2015-06-13 Thread Michael Haggerty
On 06/09/2015 06:42 PM, Stefan Beller wrote: On Tue, Jun 9, 2015 at 3:10 AM, Michael Haggerty mhag...@alum.mit.edu wrote: In set notation, non-NULL = non-NULL and not NULL_SHA1 ∪ non-NULL and equal to NULL_SHA1 The latter two are *not* treated the same, so I don't see

Re: [PATCH 01/13] delete_ref(): move declaration to refs.h

2015-06-09 Thread Michael Haggerty
On 06/08/2015 06:43 PM, Stefan Beller wrote: On Mon, Jun 8, 2015 at 4:45 AM, Michael Haggerty mhag...@alum.mit.edu wrote: [...] +/* + * Delete the specified reference. If old_sha1 is non-NULL and not + * NULL_SHA1, then verify that the current value of the reference is + * old_sha1 before

Re: [PATCH 01/13] delete_ref(): move declaration to refs.h

2015-06-09 Thread Stefan Beller
On Tue, Jun 9, 2015 at 3:10 AM, Michael Haggerty mhag...@alum.mit.edu wrote: On 06/08/2015 06:43 PM, Stefan Beller wrote: On Mon, Jun 8, 2015 at 4:45 AM, Michael Haggerty mhag...@alum.mit.edu wrote: [...] +/* + * Delete the specified reference. If old_sha1 is non-NULL and not + *

Re: [PATCH 01/13] delete_ref(): move declaration to refs.h

2015-06-08 Thread Stefan Beller
On Mon, Jun 8, 2015 at 4:45 AM, Michael Haggerty mhag...@alum.mit.edu wrote: Also * Add a docstring * Rename the second parameter to old_sha1, to be consistent with the convention used elsewhere in the refs module Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- cache.h | 2 --

[PATCH 01/13] delete_ref(): move declaration to refs.h

2015-06-08 Thread Michael Haggerty
Also * Add a docstring * Rename the second parameter to old_sha1, to be consistent with the convention used elsewhere in the refs module Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- cache.h | 2 -- refs.c | 5 +++-- refs.h | 9 + 3 files changed, 12 insertions(+), 4