Re: [PATCH 02/14] format-patch: add --interdiff option to embed diff in cover letter

2018-07-23 Thread Junio C Hamano
Eric Sunshine writes: > On Mon, Jul 23, 2018 at 12:03 PM Duy Nguyen wrote: >> On Sun, Jul 22, 2018 at 11:57 AM Eric Sunshine >> wrote: >> > @@ -0,0 +1,17 @@ >> > +void show_interdiff(struct rev_info *rev) >> > +{ >> > + struct diff_options opts; >> > + >> > + memcpy(&opts, &rev->di

Re: [PATCH 02/14] format-patch: add --interdiff option to embed diff in cover letter

2018-07-23 Thread Eric Sunshine
On Mon, Jul 23, 2018 at 12:03 PM Duy Nguyen wrote: > On Sun, Jul 22, 2018 at 11:57 AM Eric Sunshine > wrote: > > @@ -0,0 +1,17 @@ > > +void show_interdiff(struct rev_info *rev) > > +{ > > + struct diff_options opts; > > + > > + memcpy(&opts, &rev->diffopt, sizeof(opts)); > > +

Re: [PATCH 02/14] format-patch: add --interdiff option to embed diff in cover letter

2018-07-23 Thread Duy Nguyen
On Sun, Jul 22, 2018 at 11:57 AM Eric Sunshine wrote: > diff --git a/interdiff.c b/interdiff.c > new file mode 100644 > index 00..d0fac10c7c > --- /dev/null > +++ b/interdiff.c > @@ -0,0 +1,17 @@ > +#include "cache.h" > +#include "commit.h" > +#include "revision.h" > +#include "interdiff.

Re: [PATCH 02/14] format-patch: add --interdiff option to embed diff in cover letter

2018-07-22 Thread Eric Sunshine
On Sun, Jul 22, 2018 at 5:57 AM Eric Sunshine wrote: > Add an --interdiff option to automate this process. The argument to > --interdiff specifies the tip of the previous attempt against which to > generate the interdiff. > > Signed-off-by: Eric Sunshine > --- > diff --git a/interdiff.c b/interdi

[PATCH 02/14] format-patch: add --interdiff option to embed diff in cover letter

2018-07-22 Thread Eric Sunshine
When submitting a revised version of a patch series, it can be helpful (to reviewers) to include a summary of changes since the previous attempt in the form of an interdiff, however, doing so involves manually copy/pasting the diff into the cover letter. Add an --interdiff option to automate this