Re: [PATCH 04/18] Offer a function to demote fsck errors to warnings

2014-12-23 Thread Johannes Schindelin
Hi Junio, On Tue, 23 Dec 2014, Junio C Hamano wrote: > On Tue, Dec 23, 2014 at 9:28 AM, Johannes Schindelin > wrote: > >> Johannes Schindelin writes: > >> > >> > And *still*, this is *just* a global table with defaults. I would *still* > >> > need to copy-on-write when the first customization o

Re: [PATCH 04/18] Offer a function to demote fsck errors to warnings

2014-12-23 Thread Junio C Hamano
On Tue, Dec 23, 2014 at 9:28 AM, Johannes Schindelin wrote: >> Johannes Schindelin writes: >> >> > And *still*, this is *just* a global table with defaults. I would *still* >> > need to copy-on-write when the first customization of the severity level >> > takes place because I cannot allow the gl

Re: [PATCH 04/18] Offer a function to demote fsck errors to warnings

2014-12-23 Thread Johannes Schindelin
Hi Junio, On Tue, 23 Dec 2014, Junio C Hamano wrote: > Johannes Schindelin writes: > > > And *still*, this is *just* a global table with defaults. I would *still* > > need to copy-on-write when the first customization of the severity level > > takes place because I cannot allow the global defau

Re: [PATCH 04/18] Offer a function to demote fsck errors to warnings

2014-12-23 Thread Junio C Hamano
Johannes Schindelin writes: > And *still*, this is *just* a global table with defaults. I would *still* > need to copy-on-write when the first customization of the severity level > takes place because I cannot allow the global defaults to be modified by > one caller (that would defeat the whole p

Re: [PATCH 04/18] Offer a function to demote fsck errors to warnings

2014-12-23 Thread Johannes Schindelin
Hi Junio, On Tue, 23 Dec 2014, Junio C Hamano wrote: > Johannes Schindelin writes: > > > However, if we had to change the lookup such that it uses an array > > always, we would have to introduce a function to initialize the > > struct, always, in particular we would have to find a place to call

Re: [PATCH 04/18] Offer a function to demote fsck errors to warnings

2014-12-23 Thread Junio C Hamano
Johannes Schindelin writes: > However, if we had to change the lookup such that it uses an array always, > we would have to introduce a function to initialize the struct, always, in > particular we would have to find a place to call that initialization > function in, say, builtin/fsck.c (actually

Re: [PATCH 04/18] Offer a function to demote fsck errors to warnings

2014-12-23 Thread Johannes Schindelin
Hi Junio, On Mon, 22 Dec 2014, Junio C Hamano wrote: > Johannes Schindelin writes: > > > For example, try to spot the error here: > > > > ... > > F(ALMOST_HAPPY, INFO) \ > > F(CANNOT_RECOVER, ERROR) \ > > F(COFFEE_IS_EMPTY, WARN) \ > > F(JUST_BEING_CHATTY, INFO) \ > > F(

Re: [PATCH 04/18] Offer a function to demote fsck errors to warnings

2014-12-22 Thread Junio C Hamano
Johannes Schindelin writes: > For example, try to spot the error here: > > ... > F(ALMOST_HAPPY, INFO) \ > F(CANNOT_RECOVER, ERROR) \ > F(COFFEE_IS_EMPTY, WARN) \ > F(JUST_BEING_CHATTY, INFO) \ > F(LIFE_IS_GOOD, INFO) \ > F(MISSING_SOMETHING_VITAL, FATAL_

Re: [PATCH 04/18] Offer a function to demote fsck errors to warnings

2014-12-22 Thread Johannes Schindelin
Hi Junio, On Mon, 22 Dec 2014, Junio C Hamano wrote: > Johannes Schindelin writes: > > > On Mon, 22 Dec 2014, Junio C Hamano wrote: > > > >> Johannes Schindelin writes: > >> > >> >> In other words, at some point wouldn't we be better off with > >> >> something like this > >> >> > >> >>

Re: [PATCH 04/18] Offer a function to demote fsck errors to warnings

2014-12-22 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Junio, > > On Mon, 22 Dec 2014, Junio C Hamano wrote: > >> Johannes Schindelin writes: >> >> >> In other words, at some point wouldn't we be better off with >> >> something like this >> >> >> >> struct { >> >> enum id; >> >> const ch

Re: [PATCH 04/18] Offer a function to demote fsck errors to warnings

2014-12-22 Thread Johannes Schindelin
Hi Junio, On Mon, 22 Dec 2014, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> In other words, at some point wouldn't we be better off with > >> something like this > >> > >>struct { > >>enum id; > >> const char *id_string; > >> enum e

Re: [PATCH 04/18] Offer a function to demote fsck errors to warnings

2014-12-22 Thread Junio C Hamano
Johannes Schindelin writes: >> In other words, at some point wouldn't we be better off with >> something like this >> >> struct { >> enum id; >> const char *id_string; >> enum error_level { FSCK_PASS, FSCK_WARN, FSCK_ERROR }; >> } possible_f

Re: [PATCH 04/18] Offer a function to demote fsck errors to warnings

2014-12-22 Thread Johannes Schindelin
Hi Junio, On Wed, 10 Dec 2014, Junio C Hamano wrote: > Johannes Schindelin writes: > > > There are legacy repositories out there whose older commits and tags > > have issues that prevent pushing them when 'receive.fsckObjects' is set. > > One real-life example is a commit object that has been h

Re: [PATCH 04/18] Offer a function to demote fsck errors to warnings

2014-12-10 Thread Junio C Hamano
Johannes Schindelin writes: > There are legacy repositories out there whose older commits and tags > have issues that prevent pushing them when 'receive.fsckObjects' is set. > One real-life example is a commit object that has been hand-crafted to > list two authors. > > Often, it is not possible

[PATCH 04/18] Offer a function to demote fsck errors to warnings

2014-12-08 Thread Johannes Schindelin
There are legacy repositories out there whose older commits and tags have issues that prevent pushing them when 'receive.fsckObjects' is set. One real-life example is a commit object that has been hand-crafted to list two authors. Often, it is not possible to fix those issues without disrupting th