Re: [PATCH 1/1] repository.h: add comment and clarify repo_set_gitdir

2018-03-26 Thread Stefan Beller
On Mon, Mar 26, 2018 at 2:04 PM Stefan Beller wrote: > On Fri, Mar 23, 2018 at 8:55 AM Nguyễn Thái Ngọc Duy wrote: > > > > The argument name "optional" may mislead the reader to think this > > option could be NULL. But it can't be. While at there,

Re: [PATCH 1/1] repository.h: add comment and clarify repo_set_gitdir

2018-03-26 Thread Stefan Beller
On Fri, Mar 23, 2018 at 8:55 AM Nguyễn Thái Ngọc Duy wrote: > The argument name "optional" may mislead the reader to think this > option could be NULL. But it can't be. While at there, document a bit > more about struct set_gitdir_args. > Signed-off-by: Nguyễn Thái Ngọc Duy

[PATCH 1/1] repository.h: add comment and clarify repo_set_gitdir

2018-03-23 Thread Nguyễn Thái Ngọc Duy
The argument name "optional" may mislead the reader to think this option could be NULL. But it can't be. While at there, document a bit more about struct set_gitdir_args. Signed-off-by: Nguyễn Thái Ngọc Duy --- repository.h | 6 +- 1 file changed, 5 insertions(+), 1