[PATCH 1/3] cherry-pick: add support to copy notes

2013-05-28 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- builtin/revert.c | 2 + sequencer.c | 136 -- sequencer.h | 2 + t/t3500-cherry.sh | 32 + 4 files changed, 169 insertions(+), 3 deletions(-) diff --git a/builtin/revert.c b/buil

Re: [PATCH 1/3] cherry-pick: add support to copy notes

2013-05-28 Thread Junio C Hamano
Felipe Contreras writes: > Signed-off-by: Felipe Contreras > --- > builtin/revert.c | 2 + > sequencer.c | 136 > -- > sequencer.h | 2 + > t/t3500-cherry.sh | 32 + > 4 files changed, 169 insertions(+), 3 deleti

Re: [PATCH 1/3] cherry-pick: add support to copy notes

2013-05-28 Thread Thomas Rast
Junio C Hamano writes: > Thomas Rast Cc'ed as he has been the primary force behind this line > of "notes" usability. Thanks for pointing this out to me. > Felipe Contreras writes: > >> Signed-off-by: Felipe Contreras >> --- >> builtin/revert.c | 2 + >> sequencer.c | 136 >> +++

Re: [PATCH 1/3] cherry-pick: add support to copy notes

2013-05-28 Thread Felipe Contreras
Junio C Hamano wrote: > Felipe Contreras writes: > > > Signed-off-by: Felipe Contreras > > --- > > builtin/revert.c | 2 + > > sequencer.c | 136 > > -- > > sequencer.h | 2 + > > t/t3500-cherry.sh | 32 + > > 4

Re: [PATCH 1/3] cherry-pick: add support to copy notes

2013-05-28 Thread Felipe Contreras
Thomas Rast wrote: > Junio C Hamano writes: > > > Thomas Rast Cc'ed as he has been the primary force behind this line > > of "notes" usability. > > Thanks for pointing this out to me. > > > Felipe Contreras writes: > > > >> Signed-off-by: Felipe Contreras > >> --- > >> builtin/revert.c |

Re: [PATCH 1/3] cherry-pick: add support to copy notes

2013-05-29 Thread Thomas Rast
Felipe Contreras writes: > Thomas Rast wrote: >> Junio C Hamano writes: >> >> > Thomas Rast Cc'ed as he has been the primary force behind this line >> > of "notes" usability. >> >> Thanks for pointing this out to me. >> >> > Felipe Contreras writes: >> > >> >> Signed-off-by: Felipe Contreras

Re: [PATCH 1/3] cherry-pick: add support to copy notes

2013-05-29 Thread Felipe Contreras
On Wed, May 29, 2013 at 3:09 AM, Thomas Rast wrote: > Felipe Contreras writes: >> Feel free to implement that. I'm just interested in 'git cherry-pick' being >> usable for 'git rebase' purposes. > > Which would have been obvious to all but the most casual readers, eh? My motivations are irrelev

Re: [PATCH 1/3] cherry-pick: add support to copy notes

2013-05-29 Thread Thomas Rast
Felipe Contreras writes: > On Wed, May 29, 2013 at 3:09 AM, Thomas Rast wrote: >> Felipe Contreras writes: > >>> Feel free to implement that. I'm just interested in 'git cherry-pick' being >>> usable for 'git rebase' purposes. >> >> Which would have been obvious to all but the most casual reade

Re: [PATCH 1/3] cherry-pick: add support to copy notes

2013-05-29 Thread Felipe Contreras
On Wed, May 29, 2013 at 3:40 AM, Thomas Rast wrote: > Felipe Contreras writes: > >> On Wed, May 29, 2013 at 3:09 AM, Thomas Rast wrote: >>> Felipe Contreras writes: >> Feel free to implement that. I'm just interested in 'git cherry-pick' being usable for 'git rebase' purposes. >>> >>>

Re: [PATCH 1/3] cherry-pick: add support to copy notes

2013-05-29 Thread Thomas Rast
Felipe Contreras writes: > On Wed, May 29, 2013 at 3:40 AM, Thomas Rast wrote: >> Felipe Contreras writes: >> >>> On Wed, May 29, 2013 at 3:09 AM, Thomas Rast wrote: Felipe Contreras writes: >>> > Feel free to implement that. I'm just interested in 'git cherry-pick' > being

Re: [PATCH 1/3] cherry-pick: add support to copy notes

2013-05-29 Thread Felipe Contreras
On Wed, May 29, 2013 at 6:34 AM, Thomas Rast wrote: > Felipe Contreras writes: > >> On Wed, May 29, 2013 at 3:40 AM, Thomas Rast wrote: >>> Felipe Contreras writes: >>> On Wed, May 29, 2013 at 3:09 AM, Thomas Rast wrote: > Felipe Contreras writes: >> Feel free to implement t

Re: [PATCH 1/3] cherry-pick: add support to copy notes

2013-05-29 Thread Ramkumar Ramachandra
Thomas Rast wrote: > So until this changes, my $0.02 is a blanket NAK and a refusal to spend > my time reviewing. Then don't review the damn thing. With Felipe, I have the following rule of thumb: make some concrete suggestions and forget about follow-ups. He's not going to accept any general gu

Re: [PATCH 1/3] cherry-pick: add support to copy notes

2013-05-29 Thread Felipe Contreras
On Wed, May 29, 2013 at 7:09 AM, Ramkumar Ramachandra wrote: > Thomas Rast wrote: >> So until this changes, my $0.02 is a blanket NAK and a refusal to spend >> my time reviewing. > > Then don't review the damn thing. With Felipe, I have the following > rule of thumb: make some concrete suggestion

Re: [PATCH 1/3] cherry-pick: add support to copy notes

2013-05-29 Thread Ramkumar Ramachandra
Felipe Contreras wrote: > What you are really complaining about is that I don't agree with > *every* single suggestion you make. And since you made them, they must > be sensible, and single I don't agree with you, I must not be > sensible, is that right? Oh, I have no problems: I reviewed git-rela

Re: [PATCH 1/3] cherry-pick: add support to copy notes

2013-05-29 Thread Felipe Contreras
On Wed, May 29, 2013 at 8:48 AM, Ramkumar Ramachandra wrote: > Felipe Contreras wrote: >> There's nothing wrong with me choosing how best to spend my time. Really. > > Ofcourse you are. You have arguably spent it very productively > solving a lot of user issues (especially remote-bzr). > > Perso