Re: [PATCH 1/3] name-hash: refactor polymorphic index_name_exists()

2013-09-13 Thread Eric Sunshine
On Fri, Sep 13, 2013 at 6:16 PM, Junio C Hamano wrote: > Eric Sunshine writes: > >> Given the above. How should I proceed? Do you still feel that it is >> advisable to keep an index_name_exists() around for compatibility >> reasons in case any new callers are introduced? Regardless of that >> ans

Re: [PATCH 1/3] name-hash: refactor polymorphic index_name_exists()

2013-09-13 Thread Junio C Hamano
Eric Sunshine writes: > Given the above. How should I proceed? Do you still feel that it is > advisable to keep an index_name_exists() around for compatibility > reasons in case any new callers are introduced? Regardless of that > answer, do you want index_name_exists() renamed to > index_file_ex

Re: [PATCH 1/3] name-hash: refactor polymorphic index_name_exists()

2013-09-13 Thread Eric Sunshine
On Fri, Sep 13, 2013 at 3:41 PM, Junio C Hamano wrote: > On Fri, Sep 13, 2013 at 12:29 PM, Eric Sunshine > wrote: >> On Fri, Sep 13, 2013 at 2:40 PM, Junio C Hamano wrote: >>> Eric Sunshine writes: >>> Since these two modes of operations are disjoint and have no code in common (one s

Re: [PATCH 1/3] name-hash: refactor polymorphic index_name_exists()

2013-09-13 Thread Eric Sunshine
On Fri, Sep 13, 2013 at 2:40 PM, Junio C Hamano wrote: > Eric Sunshine writes: > >> Depending upon the absence or presence of a trailing '/' on the incoming >> pathname, index_name_exists() checks either if a file is present in the >> index or if a directory is represented within the index. Each

Re: [PATCH 1/3] name-hash: refactor polymorphic index_name_exists()

2013-09-13 Thread Junio C Hamano
Eric Sunshine writes: > Depending upon the absence or presence of a trailing '/' on the incoming > pathname, index_name_exists() checks either if a file is present in the > index or if a directory is represented within the index. Each caller > explicitly chooses the mode of operation by adding o

[PATCH 1/3] name-hash: refactor polymorphic index_name_exists()

2013-09-13 Thread Eric Sunshine
Depending upon the absence or presence of a trailing '/' on the incoming pathname, index_name_exists() checks either if a file is present in the index or if a directory is represented within the index. Each caller explicitly chooses the mode of operation by adding or removing a trailing '/' before