Re: [msysGit] Re: [PATCH 10/12] MINGW: compat/poll/poll.c: undef NOGDI

2014-05-05 Thread Stepan Kasal
On Mon, May 05, 2014 at 02:32:11AM -0500, Felipe Contreras wrote: > Stepan Kasal wrote: > > +ifneq ($(uname_M),x86_64) > > + # MinGW-W64 < x.y headers do not provide MsgWaitForMultipleObjects with > > NOGDI > > MinGW-w64 != x86_64; it provides a i686 compiler as well. thanks for correcting me.

Re: [PATCH 10/12] MINGW: compat/poll/poll.c: undef NOGDI

2014-05-05 Thread Felipe Contreras
Stepan Kasal wrote: > diff --git a/config.mak.uname b/config.mak.uname > index 82b8dff..446dd41 100644 > --- a/config.mak.uname > +++ b/config.mak.uname > @@ -508,7 +508,11 @@ ifneq (,$(findstring MINGW,$(uname_S))) > NO_POSIX_GOODIES = UnfortunatelyYes > DEFAULT_HELP_FORMAT = html >

Re: [PATCH 10/12] MINGW: compat/poll/poll.c: undef NOGDI

2014-05-05 Thread Stepan Kasal
Hello, On Mon, May 05, 2014 at 12:55:52AM +0400, Marat Radchenko wrote: > On Sun, May 04, 2014 at 08:52:44PM +0200, Stepan Kasal wrote: > > is really a work around: it would be in effect only for MinGW-W64, > > and the comment would explain that this is a hack to work around the > > bug. > > Wo

Re: [PATCH 10/12] MINGW: compat/poll/poll.c: undef NOGDI

2014-05-04 Thread Marat Radchenko
On Sun, May 04, 2014 at 08:52:44PM +0200, Stepan Kasal wrote: > Thank you very much for this analysis. > It enables us to redirect you the third time: to report this as a > bug in MinGW-W64 ! ;-) I'll report this to MinGW-W64 soon, though even if/when they fix the issue on their side, I'd still l

Re: [PATCH 10/12] MINGW: compat/poll/poll.c: undef NOGDI

2014-05-04 Thread Felipe Contreras
Marat Radchenko wrote: > If one wants to dig deeper, I'd say the problem is in MinGW-W64 > headers because their behavior of hiding MsgWaitForMultipleObjects > doesn't match behavior of MSVC headers. I agree with that. Can you file a bug report? -- Felipe Contreras -- To unsubscribe from this li

Re: [PATCH 10/12] MINGW: compat/poll/poll.c: undef NOGDI

2014-05-04 Thread Stepan Kasal
Hello Marat, On Sat, May 03, 2014 at 11:00:51AM +0400, Marat Radchenko wrote: > On Wed, Apr 30, 2014 at 01:41:25PM +0200, Stepan Kasal wrote: > > On Tue, Apr 29, 2014 at 01:12:04PM +0400, Marat Radchenko wrote: > > > On MinGW-W64, MsgWaitForMultipleObjects is guarded with #ifndef NOGDI. > > > > >

Re: [PATCH 10/12] MINGW: compat/poll/poll.c: undef NOGDI

2014-05-03 Thread Marat Radchenko
On Wed, Apr 30, 2014 at 01:41:25PM +0200, Stepan Kasal wrote: > Hello, > > On Tue, Apr 29, 2014 at 01:12:04PM +0400, Marat Radchenko wrote: > > On MinGW-W64, MsgWaitForMultipleObjects is guarded with #ifndef NOGDI. > > > > Removal -DNOGDI=1 from config.mak.uname has an undesirable effect of > > b

Re: [PATCH 10/12] MINGW: compat/poll/poll.c: undef NOGDI

2014-04-30 Thread Stepan Kasal
Hello, On Tue, Apr 29, 2014 at 01:12:04PM +0400, Marat Radchenko wrote: > On MinGW-W64, MsgWaitForMultipleObjects is guarded with #ifndef NOGDI. > > Removal -DNOGDI=1 from config.mak.uname has an undesirable effect of > bringing in wingdi.h with weird #define ERROR 0 that conflicts with > interna

[PATCH 10/12] MINGW: compat/poll/poll.c: undef NOGDI

2014-04-29 Thread Marat Radchenko
On MinGW-W64, MsgWaitForMultipleObjects is guarded with #ifndef NOGDI. Removal -DNOGDI=1 from config.mak.uname has an undesirable effect of bringing in wingdi.h with weird #define ERROR 0 that conflicts with internal Git enums. So, just #undef NOGDI in compat/poll/poll.c. Signed-off-by: Marat Rad