Re: [PATCH 13/33] peel_ref(): fix return value for non-peelable, not-current reference

2013-04-16 Thread Michael Haggerty
On 04/15/2013 07:38 PM, Junio C Hamano wrote: Michael Haggerty mhag...@alum.mit.edu writes: The old version was inconsistent: when a reference was REF_KNOWS_PEELED but with a null peeled value, it returned non-zero for the current reference but zero for other references. Change the

Re: [PATCH 13/33] peel_ref(): fix return value for non-peelable, not-current reference

2013-04-15 Thread Junio C Hamano
Michael Haggerty mhag...@alum.mit.edu writes: The old version was inconsistent: when a reference was REF_KNOWS_PEELED but with a null peeled value, it returned non-zero for the current reference but zero for other references. Change the behavior for non-current references to match that of

[PATCH 13/33] peel_ref(): fix return value for non-peelable, not-current reference

2013-04-14 Thread Michael Haggerty
The old version was inconsistent: when a reference was REF_KNOWS_PEELED but with a null peeled value, it returned non-zero for the current reference but zero for other references. Change the behavior for non-current references to match that of current_ref, which is what callers expect. Document