Re: [PATCH 2/2] avoid using sha1_to_hex output as printf format

On Fri, Jul 08, 2016 at 10:09:28AM -0700, Junio C Hamano wrote: > Junio C Hamano writes: > > > As to the hunk to commit.c that was dropped in this round, the only > > caller of print_commit_list() is bisect.c, and it passes "%s\n" to > > format_cur and format_last, it seems,

Re: [PATCH 2/2] avoid using sha1_to_hex output as printf format

Junio C Hamano writes: > As to the hunk to commit.c that was dropped in this round, the only > caller of print_commit_list() is bisect.c, and it passes "%s\n" to > format_cur and format_last, it seems, so that suggests a more > obvious direction for cleaning things up, I would

Re: [PATCH 2/2] avoid using sha1_to_hex output as printf format

Jeff King writes: > On Fri, Jul 08, 2016 at 05:25:26AM -0400, Jeff King wrote: > >> diff --git a/commit.c b/commit.c >> index 3f4f371..9603379 100644 >> --- a/commit.c >> +++ b/commit.c >> @@ -1623,7 +1623,7 @@ void print_commit_list(struct commit_list *list, >> { >> for ( ;

Re: [PATCH 2/2] avoid using sha1_to_hex output as printf format

On Fri, Jul 08, 2016 at 05:25:26AM -0400, Jeff King wrote: > diff --git a/commit.c b/commit.c > index 3f4f371..9603379 100644 > --- a/commit.c > +++ b/commit.c > @@ -1623,7 +1623,7 @@ void print_commit_list(struct commit_list *list, > { > for ( ; list; list = list->next) { >

[PATCH 2/2] avoid using sha1_to_hex output as printf format

We know that it should not contain any percent-signs, but it's a good habit not to feed non-literals to printf formatters. Signed-off-by: Jeff King --- builtin/worktree.c | 2 +- commit.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git