Re: [PATCH 2/2] commit-template: add new line before status information

2017-06-29 Thread Kaartic Sivaraam
On Thu, 2017-06-29 at 11:17 -0700, Junio C Hamano wrote: > The rationale of this has changed in this final version, hasn't it, > especially with the removal of the "include/only warning" bit? > > We used to add a blank line to separate the "we are committing for > somebody else", which is an optio

Re: [PATCH 2/2] commit-template: add new line before status information

2017-06-29 Thread Junio C Hamano
Kaartic Sivaraam writes: > The commit template adds the optional parts without > a new line to distinguish them. This results in > difficulty in interpreting it's content, specifically > for inexperienced users. > > Add new lines to separate the distinct parts of the > template. The rationale of

Re: [PATCH 2/2] commit-template: add new line before status information

2017-06-29 Thread Junio C Hamano
Kaartic Sivaraam writes: > The commit template adds the optional parts without > a new line to distinguish them. This results in > difficulty in interpreting it's content, specifically > for inexperienced users. > > Add new lines to separate the distinct parts of the > template. > --- > I tried

[PATCH 2/2] commit-template: add new line before status information

2017-06-29 Thread Kaartic Sivaraam
The commit template adds the optional parts without a new line to distinguish them. This results in difficulty in interpreting it's content, specifically for inexperienced users. Add new lines to separate the distinct parts of the template. --- I tried writing tests to ensure that the new line is