On Mon, Sep 17, 2018 at 12:48:51PM -0700, Junio C Hamano wrote:
> Jonathan Nieder writes:
>
> > I'd rather that we revert this change altogether. I have nothing
> > against a convenient command to do this kind of non build related
> > cleanup, but it shouldn't be spelled as "make clean".
>
>
On Mon, Sep 17, 2018 at 4:43 PM Eric Sunshine wrote:
> I did consider this case and felt that it would be reasonable for it
> to error out and ignore the error if git was missing or if the
> directory was not a repository. And, I _thought_ I had prefixed the
> line with "-" to handle just such a
On Mon, Sep 17, 2018 at 3:36 PM Junio C Hamano wrote:
> Jonathan Nieder writes:
> >> +'$(SHELL_PATH_SQ)' ./doc-diff --clean
> >
> > This means I need a copy of git in order to run "make clean". That
> > was never required before. It makes bootstrapping difficult --- do we
> > really need
Junio C Hamano wrote:
> Jonathan Nieder writes:
>> I'd rather that we revert this change altogether. I have nothing
>> against a convenient command to do this kind of non build related
>> cleanup, but it shouldn't be spelled as "make clean".
>
> OK, let's do this for now as I wanted to merge
Jonathan Nieder writes:
> I'd rather that we revert this change altogether. I have nothing
> against a convenient command to do this kind of non build related
> cleanup, but it shouldn't be spelled as "make clean".
OK, let's do this for now as I wanted to merge the remainder to
'master' today.
Junio C Hamano wrote:
> Jonathan Nieder writes:
>> Eric Sunshine wrote:
>>> + '$(SHELL_PATH_SQ)' ./doc-diff --clean
>>
>> This means I need a copy of git in order to run "make clean". That
>> was never required before. It makes bootstrapping difficult --- do we
>> really need it?
>
> Gahh,
Jonathan Nieder writes:
>> +'$(SHELL_PATH_SQ)' ./doc-diff --clean
>
> This means I need a copy of git in order to run "make clean". That
> was never required before. It makes bootstrapping difficult --- do we
> really need it?
Gahh, you are absolutely right. Also "doc-diff --clean", if I
Hi,
Eric Sunshine wrote:
> doc-diff creates a temporary working tree (git-worktree) and generates a
> bunch of temporary files which it does not remove since they act as a
> cache to speed up subsequent runs. Although doc-diff's working tree and
> generated files are not strictly build products
On Fri, Aug 31, 2018 at 4:07 PM Jeff King wrote:
> On Fri, Aug 31, 2018 at 02:33:18AM -0400, Eric Sunshine wrote:
> > diff --git a/Documentation/Makefile b/Documentation/Makefile
> > @@ -332,6 +332,7 @@ clean:
> > $(RM) manpage-base-url.xsl
> > + '$(SHELL_PATH_SQ)' ./doc-diff --clean
>
On Fri, Aug 31, 2018 at 02:33:18AM -0400, Eric Sunshine wrote:
> doc-diff creates a temporary working tree (git-worktree) and generates a
> bunch of temporary files which it does not remove since they act as a
> cache to speed up subsequent runs. Although doc-diff's working tree and
> generated
doc-diff creates a temporary working tree (git-worktree) and generates a
bunch of temporary files which it does not remove since they act as a
cache to speed up subsequent runs. Although doc-diff's working tree and
generated files are not strictly build products of the Makefile (which,
itself,
11 matches
Mail list logo
