Re: [PATCH v1] blame: add support for --[no-]progress option

I think I found where to calculate the number of blamed lines without having to do it from scratch every cycle. It's where the list of sb->ent is getting its nodes pointed around here: for (;;) { struct blame_entry *next = ent->next; found_guilty_entry(ent); if (next) {

Re: [PATCH v1] blame: add support for --[no-]progress option

On Sat, Nov 21, 2015 at 11:27 PM, Edmundo Carmona Antoranz wrote: > -static void assign_blame(struct scoreboard *sb, int opt) > +static void assign_blame(struct scoreboard *sb, int opt, int show_progress) > > Would it be better to include show_progress as a binary flag in opt

[PATCH v1] blame: add support for --[no-]progress option

Will also affect annotate Signed-off-by: Edmundo Carmona Antoranz --- Documentation/blame-options.txt | 7 +++ Documentation/git-blame.txt | 9 - builtin/blame.c | 39 --- 3 files changed, 51

Re: [PATCH v1] blame: add support for --[no-]progress option

Hey, guys! Time for some more patch destruction. On Sat, Nov 21, 2015 at 11:11 PM, Edmundo Carmona Antoranz wrote: -static void assign_blame(struct scoreboard *sb, int opt) +static void assign_blame(struct scoreboard *sb, int opt, int show_progress) Would it be better to