Re: [PATCH v12 11/20] index-helper: use watchman to avoid refreshing index with lstat()

2016-06-25 Thread Duy Nguyen
On Thu, May 19, 2016 at 11:45 PM, David Turner wrote: > From: Nguyễn Thái Ngọc Duy +"poke ": The new format is "poke ". > + Like "poke", but replies with "OK". If the index has the > + watchman extension, index-helper queries watchman, then >

Re: [PATCH v12 11/20] index-helper: use watchman to avoid refreshing, index with lstat()

2016-06-23 Thread Duy Nguyen
On Thu, Jun 23, 2016 at 8:24 AM, David Turner wrote: > So I'll remove it and re-roll (with some other changes) Please hold it for a few days. I wanted to have another look at this series, but I've been busy. I should be able to really look at it this weekend. -- Duy -- To

Re: [PATCH v12 11/20] index-helper: use watchman to avoid refreshing, index with lstat()

2016-06-23 Thread David Turner
On 06/19/2016 01:07 AM, David Turner wrote: Duy Nguyen wrote: > On Fri, May 20, 2016 at 4:45 AM, David Turner wrote: > > diff --git a/read-cache.c b/read-cache.c > > index 1719f5a..8ec4be3 100644 > > --- a/read-cache.c > > +++ b/read-cache.c

Re: [PATCH v12 11/20] index-helper: use watchman to avoid refreshing, index with lstat()

2016-06-18 Thread David Turner
Duy Nguyen wrote: > On Fri, May 20, 2016 at 4:45 AM, David Turner wrote: > > diff --git a/read-cache.c b/read-cache.c > > index 1719f5a..8ec4be3 100644 > > --- a/read-cache.c > > +++ b/read-cache.c > > @@ -1235,7 +1235,7 @@ int

Re: [PATCH v12 11/20] index-helper: use watchman to avoid refreshing index with lstat()

2016-06-17 Thread David Turner
> > - if (really && cache_errno == EINVAL) { > > + if (really || cache_errno == EINVAL) { > > /* If we are doing --really-refresh that > > * means the index is not valid anymore. > >

Re: [PATCH v12 11/20] index-helper: use watchman to avoid refreshing index with lstat()

2016-06-17 Thread Duy Nguyen
On Fri, May 20, 2016 at 4:45 AM, David Turner wrote: > diff --git a/read-cache.c b/read-cache.c > index 1719f5a..8ec4be3 100644 > --- a/read-cache.c > +++ b/read-cache.c > @@ -1235,7 +1235,7 @@ int refresh_index(struct index_state *istate, unsigned > int flags, >

[PATCH v12 11/20] index-helper: use watchman to avoid refreshing index with lstat()

2016-05-19 Thread David Turner
From: Nguyễn Thái Ngọc Duy Watchman is hidden behind index-helper. Before git tries to read the index from shm, it notifies index-helper through the socket and waits for index-helper to prepare a file for sharing memory (with MAP_SHARED). index-helper then contacts watchman,