Re: [PATCH v16 1/6] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

2017-10-03 Thread Junio C Hamano
Ramsay Jones writes: > On 03/10/17 04:51, Junio C Hamano wrote: >> >> It seems that Pranit needs a bit more work to take known fixes from >> your efforts and we should wait for the series to be rerolled? > > This series is just the first few patches from the

Re: [PATCH v16 1/6] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

2017-10-03 Thread Ramsay Jones
On 03/10/17 04:51, Junio C Hamano wrote: > Ramsay Jones writes: > >> On 02/10/17 14:44, Pranit Bauva wrote: >> [snip] >>> ... >> Yes, I also meant to tidy that up by removing some, now >> redundant, initialisation later in that function. >> >> Note, that wasn't the

Re: [PATCH v16 1/6] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

2017-10-02 Thread Pranit Bauva
Hey Junio, On Tue, Oct 3, 2017 at 9:21 AM, Junio C Hamano wrote: > Ramsay Jones writes: > >> On 02/10/17 14:44, Pranit Bauva wrote: >> [snip] >>>... >> Yes, I also meant to tidy that up by removing some, now >> redundant, initialisation later in

Re: [PATCH v16 1/6] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

2017-10-02 Thread Junio C Hamano
Ramsay Jones writes: > On 02/10/17 14:44, Pranit Bauva wrote: > [snip] >>... > Yes, I also meant to tidy that up by removing some, now > redundant, initialisation later in that function. > > Note, that wasn't the only bug! (I have probably forgotten > some of them,

Re: [PATCH v16 1/6] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

2017-10-02 Thread Ramsay Jones
On 02/10/17 14:44, Pranit Bauva wrote: [snip] >> Look for []-ed comments in the commit messages for a note of >> the changes I made to your original patches, in patches #2, >> #4, #7-9, #11-12 and #14. >> >> The commits I added, which are just WIP, are as follows: >> >> $ git log --oneline

Re: [PATCH v16 1/6] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

2017-10-02 Thread Pranit Bauva
Hey Ramsay, On Sat, Sep 30, 2017 at 6:29 PM, Ramsay Jones wrote: > Hi Pranit, > > Just before Junio dropped your 'pb/bisect' branch from his > repository (and What's cooking), I fetched it locally with > the intention of finishing it off. (It would have been silly >

Re: [PATCH v16 1/6] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

2017-09-30 Thread Ramsay Jones
On 29/09/17 07:49, Pranit Bauva wrote: > `--next-all` is meant to be used as a subcommand to support multiple > "operation mode" though the current implementation does not contain any > other subcommand along side with `--next-all` but further commits will > include some more subcommands. > >

Re: [PATCH v16 1/6] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

2017-09-29 Thread Pranit Bauva
Hey Stephan, On Sat, Sep 30, 2017 at 12:24 AM, Stephan Beyer wrote: > > Hi Pranit, > > On 09/29/2017 08:49 AM, Pranit Bauva wrote: > > It has been a long time since this series appeared on the mailing list. > > The previous version v15[1] is now split into many parts and I am >

Re: [PATCH v16 1/6] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

2017-09-29 Thread Stephan Beyer
Hi Pranit, On 09/29/2017 08:49 AM, Pranit Bauva wrote: > It has been a long time since this series appeared on the mailing list. > The previous version v15[1] is now split into many parts and I am > sending the first part right now, will focus on getting this merged and > then send out the next

[PATCH v16 1/6] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

2017-09-29 Thread Pranit Bauva
`--next-all` is meant to be used as a subcommand to support multiple "operation mode" though the current implementation does not contain any other subcommand along side with `--next-all` but further commits will include some more subcommands. Helped-by: Johannes Schindelin