Re: [PATCH v2 01/23] Update messages in preparation for i18n

2018-07-21 Thread Duy Nguyen
On Thu, Jul 19, 2018 at 8:18 PM Junio C Hamano wrote: > > --- a/config.c > > +++ b/config.c > > @@ -461,7 +461,7 @@ int git_config_from_parameters(config_fn_t fn, void > > *data) > > envw = xstrdup(env); > > > > if (sq_dequote_to_argv(envw, , , ) < 0) { > > - ret =

Re: [PATCH v2 01/23] Update messages in preparation for i18n

2018-07-19 Thread Junio C Hamano
Junio C Hamano writes: >> @@ -622,7 +626,7 @@ int cmd_config(int argc, const char **argv, const char >> *prefix) >> * location; error out even if XDG_CONFIG_HOME >> * is set and points at a sane location. >> */ >> -

Re: [PATCH v2 01/23] Update messages in preparation for i18n

2018-07-19 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > static void check_argc(int argc, int min, int max) { > if (argc >= min && argc <= max) > return; > - error("wrong number of arguments"); > + if (min == max) > + error("wrong number of arguments, should be %d", min); > +

[PATCH v2 01/23] Update messages in preparation for i18n

2018-07-18 Thread Nguyễn Thái Ngọc Duy
Many messages will be marked for translation in the following commits. This commit updates some of them to be more consistent and reduce diff noise in those commits. Changes are - keep the first letter of die(), error() and warning() in lowercase - no full stop in die(), error() or warning() if

[PATCH v2 01/23] Update messages in preparation for i18n

2018-06-03 Thread Nguyễn Thái Ngọc Duy
Many messages will be marked for translation in the following commits. This commit updates some of them to be more consistent and reduce diff noise in those commits. Changes are - keep the first letter of die(), error() and warning() in lowercase - no full stop in die(), error() or warning() if